Commit Graph

305 Commits

Author SHA1 Message Date
Eric Kohl
ec2bfa2e11 [WINLOGON] Localize the shutdown timeout 2018-04-29 17:09:37 +02:00
Hermès Bélusca-Maïto
84e78e6a15
[MODE] Use more translated strings. CORE-12178 2018-04-29 16:57:11 +02:00
Bișoc George
6c16f12de5 [CALC][CLIPBRD][SOLITAIRE][SPIDER][NOTEPAD][REGEDIT][TASKMGR] Disable help menu/button 2018-04-29 15:24:11 +02:00
Hermès Bélusca-Maïto
cb20bf8c90
[WINLOGON] Usability enhancement for the RPC SystemShutdown functionality.
- Perform an immediate system shutdown if the timeout is zero, otherwise
  display the countdown shutdown dialog.
- Cleanup pShutdownParams->pszMessage as soon as the dialog goes away.
- It actually appears (tested on Windows 2000 and 2003) that sending
  WM_CLOSE messages from a user-mode app to the shutdown dialog really
  do nothing (and in particular does not cancel the shutdown!), so modify
  the code to take this fact into account.
2018-04-29 01:02:05 +02:00
Hermès Bélusca-Maïto
03c233bcd0
[CMD] Improve how the command prompt displays when one presses Ctrl-C/break after having pressed ENTER, or after a command has been run. 2018-04-29 00:57:16 +02:00
Hermès Bélusca-Maïto
a3b36f8d3e
[CMD] Don't reset bCtrlBreak too early.
This allows to break commands such as:

C:\ReactOS\system32> for %f in (*.*) do dir

as one would expect: stop the currently running 'dir' and the 'for'.
"bCtrlBreak" doesn't need to be volatile too.
2018-04-29 00:53:49 +02:00
Hermès Bélusca-Maïto
6dd27bd467
[CMD] Use CheckCtrlBreak(). 2018-04-29 00:50:40 +02:00
James Woodcock
8b72fce3e1
[CMD] Use _T() rather than L to initialise TCHARS. 2018-04-28 22:16:59 +02:00
James Woodcock
d7e71357dc
[CMD] Fix CTRL-C handling.
Using CTRL-C to cancel command line input would leave the prompt in
a state where the next command would be ignored.  For example:

dir<CTRL-C>
dir

would cause cmd.exe to ignore the second dir command.
2018-04-28 22:16:58 +02:00
James Woodcock
23de2099e0
[CMD] Don't pass CTRL-C to child processes.
CORE-11677

The standard Win32 Console Control Handler will give CTRL-C events to
processes spawned from cmd.exe. If cmd.exe calls GenerateConsolCtrlEvent()
then the child process will receive two CTRL-C events.
2018-04-28 22:16:50 +02:00
Stanislav Motylkov
955048e50a [MSPAINT] Fix crash on zoom out
- Check the denominator for zero for both zoomed width and height.
- Do not allow to move zoom slider above possible position.
- Move commonly used `zoomTo` function into new header file.

CORE-14539
2018-04-23 20:11:43 +02:00
Hermès Bélusca-Maïto
bc826532e3
[MODE] Use ConUtils functions for printing to screen. 2018-04-18 00:45:32 +02:00
Hermès Bélusca-Maïto
22bf169288
[MODE] Improve few points in the MODE command. Adapted from a patch by Katayama Hirofumi MZ. CORE-12894 2018-04-18 00:45:28 +02:00
Hermès Bélusca-Maïto
bf3589a280
[EVENTVWR] Additions for the Event Viewer.
CORE-11637, CORE-12269

- Implement support for remote connections to NT computers to view their
  event logs (and the event logs settings). For the moment the remote
  computer name specification is is only available via the command-line.
  Note that the paths to the event log files need also to be translated
  to network-share format.
- Implement loading and saving the settings of the event viewer.
- Implement showing/hiding the events description pane, the ListView
  grid, and whether or not to save the EventViewer settings.
- Handle hypertext link click handling for the RichEdit edit box of the
  events description dialog.
2018-04-17 23:17:48 +02:00
Hermès Bélusca-Maïto
0c32666852
[EVENTVWR] Code style only. 2018-04-17 23:17:44 +02:00
Eric Kohl
8eb64332e9 [NET] Implement the options in the NET CONFIG SERVER command 2018-04-15 15:32:31 +02:00
Bișoc George
b3ff4f5f95 [WINLOGON] Romanian translation update 2018-04-14 21:11:48 +02:00
Eric Kohl
8787eba8ca [NET] Add help text for the NET GROUP command and improve the NET LOCALGROUP help text 2018-04-14 18:56:08 +02:00
Pierre Schweitzer
fd87f0ad87
[SC] Don't leak service status info on success
CID 1434266
2018-04-14 15:40:26 +02:00
Eric Kohl
ff9c737acc [NET] Add help text for the NET LOCALGROUP command 2018-04-14 13:24:05 +02:00
Hermès Bélusca-Maïto
1551d2b136
[EVENTLOG] Register .evt file extension so that we can open event log files from the shell.
Take also the opportunity to fix a problematic "%1" in wordpad.exe command line.
2018-04-13 23:46:32 +02:00
Hermès Bélusca-Maïto
bb03da981c
[EVENTVWR] Additions to the Event Viewer.
- Don't hardcode a buffer length in ExpandEnvironmentStringsW() call.
- If no file name is associated to a log (ErrorLog->FileName == NULL),
  don't try to attempt looking at its file properties. This also allows
  avoiding a crash in the FindFirstFileW() call under certain conditions
  on Windows.
2018-04-13 01:02:20 +02:00
Hermès Bélusca-Maïto
1afc87ee57
[EVENTVWR] Add support for a command-line for the Event Log Viewer.
CORE-12269

- Add support for '/?' and '/l:' switches. The former displays usage
  information. The latter allows to specify an event log file to load.
  Also one can specify the computer name from which one wants to
  retrieve events for display (work in progress).
- In EnumEventsThread(), move around the code that updates the
  application title and status bar, so that the selected event log name
  and loading status is always displayed first, while loading itself is
  in progress.
2018-04-12 02:45:37 +02:00
Hermès Bélusca-Maïto
eb2934df0e
[EVENTVWR] Enhancements to the event log viewer.
- Initialize hwndMainWindow as it can be used before it is properly
  initialized with an existing window handle.
- Transform ShowLastWin32Error() to a more generic ShowWin32Error().
- Use iswdigit() instead of isdigit().
- Add extra heap buffer cleanup.
- Split OpenUserEventLog() in two: OpenUserEventLog() that displays
  an open-file dialog, and OpenUserEventLogFile() that does the real
  work of allocating internal structures and opening the log file using
  the event-log service. We also check that the file really exists
  before proceeding further.
- Force treeview repaint when *children* items are inserted, because
  otherwise the expand/collapse buttons do not display next to parent
  items (this problem happens on Windows too).
- Reshuffle the resource string IDs.
2018-04-12 02:32:37 +02:00
Eric Kohl
ef0f6861fb [NET] Replace remaining hard-coded strings by string resources for the NET STATISTICS command. 2018-04-12 00:58:30 +02:00
Adam Słaboń
abe6bbabfb [TRANSLATION] Polish translation update for drwtsn32, winlogon and usersrv. (#475) 2018-04-10 22:54:34 +02:00
Eric Kohl
2e60a17e8b [NET] Improve the NET STATISTICS command
- Add resource strings for the NET STATISTICS SERVER command.
- Convert and display the 'statistics since' time.
2018-04-10 21:34:00 +02:00
Eric Kohl
58b5cdc77c [NET] Add the NET STATISTICS command 2018-04-08 21:27:05 +02:00
Hermès Bélusca-Maïto
c62bccdda0
[EXPLORER] Implement the feature of cleanly shutting down the explorer shell when cancelling the shutdown-dialog while pressing the CTRL-ALT-SHIFT keys.
See the feature description in https://msdn.microsoft.com/en-us/library/windows/desktop/cc144064(v=vs.85).aspx
and the additional observations reported in CORE-14358 .
2018-04-08 00:36:56 +02:00
Hermès Bélusca-Maïto
6093abdebb
[EXPLORER] Remove trailing whitespace. 2018-04-08 00:36:51 +02:00
Hermès Bélusca-Maïto
eff4c2138d
[EXPLORER] Remove double 'return' statement. Determining whether it should be HTBORDER or HTCLIENT is left as an exercise to the reader.
Spotted by 'mudhead'. CORE-14528
2018-04-07 19:06:22 +02:00
Alexander Shaposhnikov
627739aed9
[RAPPS] Introduce 'SizeBytes' DB entry and use it for display
This will allow us to reduce the DB size a little by avoiding
duplication for each and every entry.
Original patch by JIRA user "swyter"

CORE-10310
2018-04-07 19:25:12 +03:00
Timo Kreuzer
6b1ca75899
[REACTOS] Fix 64 bit build (#465)
* [HAL] Simplify HalpReboot() and make it portable
* [NTOS:MM] Cast constant to PVOID
* [BINPATCH] Fix 64 bit build
* [VFDDRV] Fix 64 bit build and buffer overruns
* [USBOHCI] Fix structure alignment issues
* [ATL_APITEST] Fix 64 bit build
* [XDK] Update unwind structures in winnt.h
* [NTDLL_APITEST] Fix 64 bit build
* [NTDLL_WINETEST] Fix 64 bit build
* [TFTPD] Fix x64 build
* [USBPORT] Fix a C_ASSERT
* [DSOUND] Fix x64 build
* [HAL] Remove obsolete GetPteAddress() macro
2018-04-03 15:13:17 -06:00
Alexander Shaposhnikov
a6d2172ccc
[RAPPS] Use FTP in passive mode
This should finally fix FTP downloads in RAPPS.
2018-04-03 00:47:08 +03:00
Eric Kohl
3031de8eed [NET] Implement the NET CONFIG WORKSTATION command 2018-04-02 23:13:50 +02:00
Alexander Shaposhnikov
3261bbb7b9
[RAPPS] Fix FTP downloads 2018-04-02 23:55:05 +03:00
Hermès Bélusca-Maïto
4127024b0d
[EXPLORER] Handle WM_CONTEXTMENU message in CNotifyToolbar and BN_CLICKED notification in CSysPagerWnd.
With these, we generate the WM_CONTEXTMENU and NIN_(KEY)SELECT
shell icon notifications that applications expect when they handle
shell notification icons with uVersion >= 3.

This fixes in particular the previously unresponsive icon of KVIrc 4.x,
and more generally *all* the notifiation icons of Qt applications.
CORE-10605 #resolve
2018-04-02 21:13:35 +02:00
Alexander Shaposhnikov
bb819f1528
[RAPPS] Update rapps .cab download link
This replaces old link to svn.reactos.org with rapps.reactos.org
which is a new stable location for RAPPS database and future community
website. That said, svn.reactos.org link will be kept for some time.

TODO: make this a configurable value.

CORE-14351
2018-04-02 22:11:11 +03:00
Eric Kohl
3318d8d5be [WINLOGON] Fix shutdown timeout format string for long timeout
- Use the "%d days" format for timeouts longer than a day.
- Fail if timeout is 10 years or longer.
- TODO: Replace format strings by resources. German WinXP uses "%d days" instead of "%d Tage". We can do better! ;-)
2018-04-02 19:09:13 +02:00
Joachim Henze
3d66048b16 [TRACERT] Use ConUtils lib and update de-DE.rc CORE-14265
Most likely this also improves formerly unprintable characters for
fr-FR, it-IT, ro-RO, ru-RU, zh-CN.
2018-04-02 18:10:31 +02:00
Hermès Bélusca-Maïto
2f108ac8a8
[EXPLORER] Add missing 'break' statements. Spotted by mudhead. CORE-14518 2018-04-02 16:12:25 +02:00
Hermès Bélusca-Maïto
2da4999011
[WINLOGON] Fix some dialog control dimensions. 2018-04-02 15:05:25 +02:00
Eric Kohl
925176af71 [NET] Reorganize and improve the help texts (3/X)
- Add help texts for the START and STOP commands.
- Add text for the CONFIG command.
2018-04-02 14:53:39 +02:00
Bișoc George
b51b99e766 [TRANSLATION][SERVMAN] Italian translation update (#463)
* [SERVMAN] Italian update translation

* [SERVMAN] Small grammatical typo fixed

* [SERVMAN] Word replaced

- "Accedi" would be more convenient than "Accedere"
2018-04-02 13:57:10 +02:00
Eric Kohl
9a6d4bf0c5 [WINLOGON] System shutdown dialog clean-up
- Replace the winlogon icon by the warning icon.
- Add more space for the main text.
- Move the shutdown time into a separate line to ensure it is always fully visible.
- Add more space for the shutdown message and keep the message empty by default.
- Clean up the resource IDs.
2018-04-02 13:33:41 +02:00
Eric Kohl
2ae4585250 [WINLOGON] Clean up part 2
- Replace the UNICODE_STRING usMessage by a PWSTR pszMessage.
- Use the "%02d:%02d:%02d" time format and get rid of the safe string printf because the string will NEVER be longer than 8 characters.
- Rename the timer id constant because it is NOT a resource id.
- Rename variables according to the coding style.
2018-04-02 12:47:15 +02:00
Eric Kohl
72dc173158 [WINLOGON] Clean up part 1
- Add empty lines to separate logical blocks of code.
- Add spaces according to our coding style.
- Move g_hShutdownDialog and g_bShuttingDown into the shutdown parameters struct.
- Pass a pointer to the shutdown parameters to the shutdown thread and the shutdown dialog and use the pointer instead of the global variables.
- Move the timer code into a separate function because it requires local variables.
2018-04-02 01:37:50 +02:00
Eric Kohl
1fac4b068f [WINLOGON] Missed this file 2018-04-02 00:42:15 +02:00
Eric Kohl
f50d7749d0 [WINLOGON] Move the system shutdown code into a separate file 2018-04-02 00:38:52 +02:00
alpha5056
7ca90b50de [WINLOGON] Implement BaseInitiateSystemShutdownEx(). (#458) 2018-04-01 19:39:41 +02:00