mirrors/reactos
0
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-14 22:53:32 +08:00
Code Issues Packages Projects Releases Wiki Activity
80,577 Commits 94 Branches 276 Tags 1.1 GiB
4c63ed5a7a
Commit Graph

800 Commits

Author SHA1 Message Date
Katayama Hirofumi MZ
ca3fa7197d
[IMM32] Use Imm32IsImmMode and Imm32IsCiceroMode macros (#3971) 
- Define Imm32IsImmMode, Imm32IsCiceroMode and Imm32Is16BitMode macros in "precomp.h".
- Improve Imm32InquireIme and Imm32CleanupContext functions.
- Add IME_SYSINFO_WINLOGON and IME_SYSINFO_WOW16 macros (from DDK) in psdk/imm.h.
- Modify CtfImeInquireExW and CtfImeSelectEx prototype.
CORE-11700
 2021-09-24 22:06:29 +09:00
Joachim Henze
222acf5a3e [NTUSER] Scrollbar.c, Avoid potential out-of-bounds-accesses in co_IntSetScrollInfo() CORE-17777 
This is an addendum to
0.4.15-dev-3174-g dda9c3979e CORE-17769 and
0.4.15-dev-3147-g 3bf7e3ac13 CORE-17754 CORE-17755

We have not seen this happening in real-life yet, but some code-fragments within co_IntSetScrollInfo()
e.g. line 628 if (nBar == SB_CTL) do clearly indicate that nBar can be 2 (SB_CTL).
Some lines below we definitely must not access those 4 static arrays out of bounds then via nBar as access index!

Ftr with a bit of grepping I also found some calls like NtUserSetScrollInfo(Wnd, SB_CTL, &Info, FALSE);
e.g: in win32ss/user/user32/controls/scrollbar.c so I am pretty sure nBar == 2 can happen in practice within co_IntSetScrollInfo().

I question whether any of those reads/writes to those static arrays (or the comparisons) would make any sense on index 2,
so we should aim to eliminate them altogether in the future.
 2021-09-20 03:05:05 +02:00
Joachim Henze
dda9c3979e [NTUSER] Scrollbar.c, improve co_IntSetScrollInfo() CORE-17769 
Fixes CORE-17769 'Rapps Listview manual resize may erroneously not draw the triangles sometimes'
This could happen for both: themed and unthemed.

CORE-17769 was a regression introduced by 0.4.14-dev-1134-g 00adb1a3f9

We don't really like the added state in form of the static variables,
but the patch works good from a pure testing-perspective.

Many Thanks to the patches author: Doug Lyons
 2021-09-19 22:35:37 +02:00
Hermès Bélusca-Maïto
271556e6f8
[WIN32SS] Disable by default the dumping function. Addendum to 69f90508. 2021-09-19 00:46:56 +02:00
Hermès Bélusca-Maïto
69f905081c
[WIN32SS:NTUSER] Move the keyboard layout debugging code to a separate dump function. 
And fix its obvious bugs, e.g. not checking for possible NULL pointers
for the optional keyboard layout sub-tables...
 2021-09-19 00:18:04 +02:00
Katayama Hirofumi MZ
df6fff78bb
[IMM32] Rewrite ImmAssociateContextEx (#3961) 
- Rewrite ImmAssociateContextEx function.
- Modify NtUserAssociateInputContext prototype.
CORE-11700
 2021-09-16 19:29:49 +09:00
Katayama Hirofumi MZ
afb6c8a129
[IMM32] Rewrite ImmEscapeA/W (#3959) 
- Rewrite ImmEscapeA and ImmEscapeW functions.
- Delete useless legacy code.
CORE-11700
 2021-09-16 19:27:43 +09:00
Victor Perevertkin
d74eb54b06
[WIN32SS:GDI] Add a sanity assert 2021-09-14 17:58:23 +03:00
Hermès Bélusca-Maïto
9393fc320e
[FORMATTING] Remove trailing whitespace. Addendum to 34593d93. 
Excluded: 3rd-party code (incl. wine) and most of the win32ss.
 2021-09-13 03:52:22 +02:00
Doug Lyons
3bf7e3ac13
[NTUSER] Improve Themed Scrollbars by Minimizing Updates (#3953) 
This fixes regressions CORE-17754 and CORE-17755 which regressed by
0.4.15-dev-3086-g 236649c626
 2021-09-12 22:54:46 +02:00
Süleyman Poyraz
53221834c5
[TRANSLATION] Add and improve Turkish (tr-TR) translation (#3561) 
Reviewed-by: Can Taşan <ctasan99@hotmail.com>
Reviewed-by: Ercan Ersoy <ercanersoy@ercanersoy.net>
Signed-off-by: Süleyman Poyraz <zaryob.dev@gmail.com>
 2021-09-12 00:34:11 +03:00
Hermès Bélusca-Maïto
4cbc61fd02
[WIN32SS:NTUSER][USER32] NtUserProcessConnect() should return pointers in user client-space. (#3937) 
- Do the kernel/server --> user/client-space pointers conversion within
  NtUserProcessConnect(), instead of having the callers of this function
  doing this job.
  This makes the behaviour Windows-compatible.

  NOTE: the gHandleEntries pointer is ReactOS-specific!

- Drop the g_ulSharedDelta global, just use instead gSharedInfo.ulSharedDelta.

- Add extra documentation aspects for NtUserProcessConnect() that are
  not yet implemented in ReactOS.
 2021-09-09 16:15:12 +02:00
Hermès Bélusca-Maïto
a407cb8f10
[WIN32SS:NTUSER] Update the definition of SHAREDINFO and fix the definition of FNID_LAST. (#3937) 2021-09-09 16:15:11 +02:00
James Tabor
a022dc8eaf [GDI32] Fix Meta file packing recursion issues. 
TextOut was looping back adding additional EMR packet to the meta file.
 2021-09-06 18:37:24 -05:00
James Tabor
03516733ef [GDI32] Do not fail on path with bitmap fonts. 
Patch by Dmitry Timoshkov : ExtTextOut on a path with bitmap font
selected shouldn't fail.
This just leads to empty path generated.
 2021-09-06 17:53:35 -05:00
Doug Lyons
236649c626
[UXTHEME][NTUSER] Fix flashing of scrollbar when scrolling (#3868) 
Based on a patch by I_Kill_Bugs.
 2021-09-03 22:34:26 +03:00
Katayama Hirofumi MZ
4689c8ead8 [USER32][INCLUDE] Move GetImmFileName declaration from user32.h to user32p.h 
From: win32ss/user/user32/include/user32.h
To: win32ss/user/user32/include/user32p.h

CORE-11700
 2021-08-31 13:42:54 +09:00
Katayama Hirofumi MZ
a8d2cd4b9d
[IMM32] Rewrite ImmGetContext (#3923) 
- Add ValidateHwndNoErr and Imm32GetContextEx helper functions.
- Rewrite ImmGetContext function by using the helper functions.
CORE-11700
 2021-08-24 06:50:39 +09:00
Katayama Hirofumi MZ
2ab858c125
[USER32][IMM32] Improve User32InitializeImmEntryTable (#3918) 
- Improve User32InitializeImmEntryTable function and related.
- Complete win32ss/user/user32/include/immtable.h table.
- Delete a hack in user32.DllMain and apply my magical tricks. This will fix some access violations in IMM32.
- Add some stubs into IMM32.
CORE-11700
 2021-08-23 16:25:21 +09:00
Katayama Hirofumi MZ
10c9aa067f
[NTUSER] Improve NtUserQueryWindow (#3915) 
- Improve NtUserQueryWindow function.
- Add IMC structure.
- Modify THREADINFO structure.
CORE-11700
 2021-08-21 07:31:10 +09:00
Katayama Hirofumi MZ
1d0587fc27
[IMM32] Rewrite ImmProcessKey (#3917) 
- Rewrite ImmProcessKey function.
- Modify win32ss/include/imetable.h.
- Modify ImmProcessKey prototype.
CORE-1170
 2021-08-21 07:22:43 +09:00
Katayama Hirofumi MZ
c59c185d1c
[INCLUDE] Move WM_IME_SYSTEM from ntuser.h to undocuser.h (#3920) 
CORE-11700
 2021-08-19 08:18:20 +09:00
Katayama Hirofumi MZ
1f792413f0 [NTUSER][INCLUDE] s/TransMsg[1]/TransMsg[ANYSIZE_ARRAY]/ 
CORE-11700
 2021-08-18 19:59:35 +09:00
Katayama Hirofumi MZ
d83be2e6b6 [NTUSER][INCLUDE] Trivial formatting of TRANSMSG and TRANSMSGLIST 
CORE-11700
 2021-08-18 19:56:47 +09:00
Katayama Hirofumi MZ
f4bc74edc3
[IMM32] ImmGenerateMessage and ImmTranslateMessage (#3914) 
- Rewrite `ImmGenerateMessage` and `ImmTranslateMessage` functions.
- Rename `INPUTCONTEXTDX.bHasVKey` as `bNeedsTrans`.
- Move `TRANSMSG` structure into `ntuser.h`.
- Add `TRANSMSGLIST` structure into `ntuser.h`.
- Add `UNDETERMINESTRUCT` structure to `ddk/imm.h`.
- Modify `NtUserGetAppImeLevel` prototype.
CORE-11700
 2021-08-18 08:42:12 +09:00
Katayama Hirofumi MZ
77911014f3
[IMM32] Rewrite ImmIsUIMessageA/W (#3907) 
- Rewrite ImmIsUIMessageA and ImmIsUIMessageW functions.
- Modify HIMC and HIMCC handle types for strictness. Add typecasts.
- Add WM_IME_SYSTEM macro.
- Modify imm32.spec.
CORE-11700
 2021-08-16 15:33:51 +09:00
Katayama Hirofumi MZ
cc097ec485
[IMM32] Rewrite ImmEnumRegisterWordA/W (#3906) 
- Rewrite ImmEnumRegisterWordA and ImmEnumRegisterWordW functions.
- Modify win32ss/include/imetable.h.
CORE-11700
 2021-08-16 15:31:39 +09:00
Katayama Hirofumi MZ
19d24143e9
[IMM32] Rewrite ImmGetRegisterWordStyleA/W (#3901) 
- Rewrite ImmGetRegisterWordStyleA and ImmGetRegisterWordStyleW functions.
- Modify win32ss/include/imetable.h.
CORE-11700
 2021-08-14 10:39:20 +09:00
Katayama Hirofumi MZ
1e62771c78
[IMM32] Rewrite ImmRegisterWordA (#3881) 
- Rewrite ImmRegisterWordA function.
- Modify imetable.h.
CORE-11700
 2021-08-10 08:08:23 +09:00
Doug Lyons
ad8d8b6628
[GDI32] Revise IntTMWFixUp Raster Font List (#3808) 
CORE-17662
CORE-17723
 2021-08-09 13:07:04 +02:00
Jérôme Gardou
c4801ab696 [WIN32K] Do not release twice the lock on error path 2021-08-06 15:18:21 +02:00
Jérôme Gardou
0bc00267df [WIN32K] Init User part after GDI one. 
But Initialize user lock first thing to avoid hitting newly introduced ASSERTS

This partly reverts commit 515d83a883.
 2021-08-06 10:15:02 +02:00
Katayama Hirofumi MZ
692a30a84a
[IMM32] ImmCreateContext, ImmDestroyContext, DllMain etc. (#3867) 
- Rewrite ImmCreateContext, ImmDestroyContext, and DllMain functions.
- Add g_hImm32Inst, g_bClientRegd, and g_SharedInfo global variables. Delete g_dwImm32Flags (that was g_psi->dwSRVIFlags).
- Implement ImmLoadIME and ImmRegisterClient functions.
- Modify CLIENTIMC and IMEDPI structures. Move CLIENTIMC definition into ntuser.h.
- Add file win32ss/include/imetable.h.
- Rename SRVINFO_METRICS macro as SRVINFO_CICERO_ENABLED.
CORE-11700
 2021-08-04 09:41:59 +09:00
Jérôme Gardou
bd6fb80867 [WIN32K:NTUSER] In debug builds, enable free & tail checking when creating heaps 
Actually catches bugs
 2021-08-03 23:13:19 +02:00
Jérôme Gardou
b783b16cef [WIN32K:USER] Fix potential use after free when painting child windows 2021-08-03 23:13:19 +02:00
Jérôme Gardou
d958dc9bc2 [WIN32K:NTUSER] Assert global user lock is held exclusively when using global & desktop heaps 
They're explicitly not serialized because we count on this.
 2021-08-03 23:13:19 +02:00
Jérôme Gardou
8c098ee8d2 [WIN32K:NTUSER] Make sure to hold User Global Lock before unmapping desktop heap 2021-08-03 23:13:19 +02:00
Jérôme Gardou
6ec0420dc6 [WIN32K:NTUSER] Allocate & free timers under global user lock 2021-08-03 23:13:19 +02:00
Jérôme Gardou
515d83a883 [WIN32K] On init, start by initializing NtUser stuff 
Allocate gpsi (Global Server Info) after initializing & grabbing Userlock
 2021-08-03 23:13:19 +02:00
Katayama Hirofumi MZ
d7f13aa696
[IMM32] Improve ImmSimulateHotKey (#3858) 
- Improve ImmSimulateHotKey function.
- Modify IMEDPI structure.
CORE-11700
 2021-07-31 15:56:11 +09:00
Katayama Hirofumi MZ
89cb8a38b3
[IMM32] Rewrite ImmEnumInputContext (#3859) 
- Rewrite ImmEnumInputContext function.
- Modify NtUserBuildHimcList.
CORE-11700
 2021-07-31 15:45:07 +09:00
Timo Kreuzer
ecf3416f49 [VIDEOPRT] Fix updating of new registry path values 
CORE-17688
When a new driver is installed for the same device (like VBoxVideo), it uses the same hardware enum registry key and thus reuses the same DisplayId and the same display registry key. Therefore we need to update the setting in that key, even when the key already exists.

This seems to work good and not cause any issues, but testing indicated that on Windows some values are only updated, when the driver has changed. If neccessary, this can be achieved by updating and querying the ActiveService value in the device enum key (e.g. HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Enum\PCI\VEN_80EE&DEV_BEEF&SUSYS_00000000&REV_00\3&267a616a&0&10\Control: ActiveService). If that doesn't match the current device name (from DriverExtension->RegistryPath) the values should be copied over.
 2021-07-27 14:44:14 +02:00
Timo Kreuzer
204626f793 [WIN32K] Fix uninitialized variable 2021-07-27 14:44:14 +02:00
Katayama Hirofumi MZ
ecb0c0963d
[IMM32] Imm(Lock|Unlock)ImeDpi and ImmSetOpenStatus (#3830) 
- Add IMEDPI structure to ntuser.h.
- Implement ImmLockImeDpi/ImmUnlockImeDpi functions.
- Rewrite ImmSetOpenStatus function.
- Modify some NTUSER function prototypes.
- Modify imm32.spec.
CORE-11700
 2021-07-25 11:57:57 +09:00
Katayama Hirofumi MZ
97847f2078
[IMM32] Improve ImmGetImeInfoEx (#3833) 
- Rewrite ImmGetImeInfoEx function.
- Implement CtfImmIsTextFrameServiceDisabled function.
- Modify imm32.spec.
CORE-11700
 2021-07-25 11:56:17 +09:00
Timo Kreuzer
5d8e834897 [REACTOS] Fix a number of MSVC warnings 2021-07-23 22:03:48 +02:00
Timo Kreuzer
77e891b8ab [WIN32K] Check if a graphics device already exists before trying to add it 
This avoids DPRINTs alleging a failure to open a device.
Also improve another DPRINT.
 2021-07-15 08:32:46 +02:00
Timo Kreuzer
39d8a822d2 [WIN32K] Fix detection of multiple display devices on VBox 2021-07-15 08:32:46 +02:00
Katayama Hirofumi MZ
92393a7517
[IMM32] Add some candidate handlings (#3799) 
- Implement ImmGetCandidateListA and ImmGetCandidateListW, by using newly added ImmGetCandidateListAW function.
- Implement ImmLockClientImc and ImmUnlockClientImc functions.
- Modify imm32.spec.
- Remove #ifdef's.
CORE-11700
 2021-07-11 09:48:15 +09:00
Hervé Poussineau
8379c87b0b [VIDEOPRT] Write correct MaxObjectNumber to registry 
VideoPortMaxObjectNumber variable will be updated later in the function, if everything went fine.
 2021-07-10 19:03:37 +02:00