From d5265b07bbfb6ac6da190b8213cf2f3f8d9cd675 Mon Sep 17 00:00:00 2001 From: Joachim Henze Date: Sun, 13 Jun 2021 15:30:49 +0200 Subject: [PATCH] [MSI] Enumerate only type DRIVE_FIXED CORE-17623 (& CORE-14432) MSI on 2k3sp2 hides empty CD-ROM, and hides CD-ROM with iso mounted. MSI on 2k3sp2 hides VBox shares, both: writable and read-only-ones. MSI on 2k3sp2 hides floppy drives with a floppy img mounted. MSI on XPSP3 hides a mounted writable USB stick. Thanks to the patches author Doug Lyons. This patch supersedes 0.4.15-dev-2651-g 864e20b881130cbc9668b8e253a31b8c325e9b99 (CORE-14432) and we are also better than Wines https://source.winehq.org/git/wine.git/commit/0dd0d879a1c487dcefedd44762d4ea0fcebd98fe --- dll/win32/msi/dialog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dll/win32/msi/dialog.c b/dll/win32/msi/dialog.c index 2ed6815ad6b..7a8417ff70c 100644 --- a/dll/win32/msi/dialog.c +++ b/dll/win32/msi/dialog.c @@ -3238,7 +3238,7 @@ static void msi_dialog_vcl_add_drives( msi_dialog *dialog, msi_control *control while (*ptr) { #ifdef __REACTOS__ - if (GetDriveTypeW(ptr) == DRIVE_CDROM) + if (GetDriveTypeW(ptr) != DRIVE_FIXED) { ptr += lstrlenW(ptr) + 1; continue;