mirrors/reactos
0
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-11-23 03:23:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

[NTOS:FSRTL] FsRtlAcquireFileExclusiveCommon: don't return before acquiring a file resource, except special cases (#7273)

Browse Source 
Don't return before file object's resource is acquired in FsRtlAcquireFileExclusiveCommon, except some special return cases, when return is required. Based on hpoussin_filter_extra.patch by Herve Poussineau (@hpoussin) with improved comment, which matches the actual behaviour now.
This is required by fltmgr.sys driver from Windows XP/Server 2003 to work correctly, so this change fixes asserts/exceptions when releasing the file via FsRtlReleaseFile after acquiring, when using 3rd party filter drivers from several antivirus programs (e. g., Avast Free Antivirus all versions, AVG Antivirus Free 18.8, Avira AntiVir Personal 8.2, Dr. Web Security Space 8.0, Kaspersky Antivirus 2012 etc. etc.).
CORE-14157, CORE-14635, CORE-19318
This commit is contained in:
Oleg Dubinskiy 2024-11-20 16:47:32 +01:00 committed by GitHub
parent 4d0a26db58
commit 8ed8682256
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ntoskrnl/fsrtl/fastio.c
View File

@ -1605,7 +1605,13 @@ FsRtlAcquireFileExclusiveCommon(IN PFILE_OBJECT FileObject,
FilterCallbacks->PostAcquireForSectionSynchronization(&CbData, Status, CompletionContext);
}
return Status;
/* Return here when the status is based on the synchonization type and write access to the file */
if (Status == STATUS_FSFILTER_OP_COMPLETED_SUCCESSFULLY ||
Status == STATUS_FILE_LOCKED_WITH_ONLY_READERS ||
Status == STATUS_FILE_LOCKED_WITH_WRITERS)
{
return Status;
}
}
FastDispatch = DeviceObject->DriverObject->FastIoDispatch;