mirrors/reactos
0
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-11-24 03:53:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

[BROWSEUI] Refactoring CAutoComplete Part 1 (#3472)

Browse Source 
- Expand tabs to spaces in CAutoComplete.h.
- Add m_ prefix to every member variable.
CORE-9281
This commit is contained in:
Katayama Hirofumi MZ 2021-02-23 06:07:09 +09:00 committed by GitHub
parent 205b6e56c8
commit 6bfb76b68a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 148 additions and 147 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

214
dll/win32/browseui/CAutoComplete.cpp
View File

@ -3,7 +3,7 @@
* *
* Copyright 2004 Maxime Bellengé <maxime.bellenge@laposte.net> * Copyright 2004 Maxime Bellengé <maxime.bellenge@laposte.net>
* Copyright 2009 Andrew Hill * Copyright 2009 Andrew Hill
* Copyright 2020 Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com> * Copyright 2020-2021 Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
* *
* This library is free software; you can redistribute it and/or * This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public * modify it under the terms of the GNU Lesser General Public
@ -47,15 +47,15 @@ static const WCHAR autocomplete_propertyW[] = {'W','i','n','e',' ','A','u','t','
*/ */
CAutoComplete::CAutoComplete() CAutoComplete::CAutoComplete()
{ {
enabled = TRUE; m_enabled = TRUE;
initialized = FALSE; m_initialized = FALSE;
options = ACO_AUTOAPPEND; m_options = ACO_AUTOAPPEND;
wpOrigEditProc = NULL; m_wpOrigEditProc = NULL;
hwndListBox = NULL; m_hwndListBox = NULL;
txtbackup = NULL; m_txtbackup = NULL;
quickComplete = NULL; m_quickComplete = NULL;
hwndEdit = NULL; m_hwndEdit = NULL;
wpOrigLBoxProc = NULL; m_wpOrigLBoxProc = NULL;
} }
/************************************************************************** /**************************************************************************
@ -64,15 +64,15 @@ CAutoComplete::CAutoComplete()
CAutoComplete::~CAutoComplete() CAutoComplete::~CAutoComplete()
{ {
TRACE(" destroying IAutoComplete(%p)\n", this); TRACE(" destroying IAutoComplete(%p)\n", this);
HeapFree(GetProcessHeap(), 0, quickComplete); HeapFree(GetProcessHeap(), 0, m_quickComplete);
HeapFree(GetProcessHeap(), 0, txtbackup); HeapFree(GetProcessHeap(), 0, m_txtbackup);
if (wpOrigEditProc) if (m_wpOrigEditProc)
{ {
SetWindowLongPtrW(hwndEdit, GWLP_WNDPROC, (LONG_PTR)wpOrigEditProc); SetWindowLongPtrW(m_hwndEdit, GWLP_WNDPROC, (LONG_PTR)m_wpOrigEditProc);
RemovePropW(hwndEdit, autocomplete_propertyW); RemovePropW(m_hwndEdit, autocomplete_propertyW);
} }
if (hwndListBox) if (m_hwndListBox)
DestroyWindow(hwndListBox); DestroyWindow(m_hwndListBox);
} }
/****************************************************************************** /******************************************************************************
@ -84,7 +84,7 @@ HRESULT WINAPI CAutoComplete::Enable(BOOL fEnable)
TRACE("(%p)->(%s)\n", this, (fEnable) ? "true" : "false"); TRACE("(%p)->(%s)\n", this, (fEnable) ? "true" : "false");
enabled = fEnable; m_enabled = fEnable;
return hr; return hr;
} }
@ -94,19 +94,19 @@ HRESULT WINAPI CAutoComplete::Enable(BOOL fEnable)
*/ */
void CAutoComplete::CreateListbox() void CAutoComplete::CreateListbox()
{ {
HWND hwndParent = GetParent(hwndEdit); HWND hwndParent = GetParent(m_hwndEdit);
/* FIXME : The listbox should be resizable with the mouse. WS_THICKFRAME looks ugly */ /* FIXME : The listbox should be resizable with the mouse. WS_THICKFRAME looks ugly */
hwndListBox = CreateWindowExW(0, WC_LISTBOXW, NULL, m_hwndListBox = CreateWindowExW(0, WC_LISTBOXW, NULL,
WS_BORDER | WS_CHILD | WS_VSCROLL | LBS_HASSTRINGS | LBS_NOTIFY | LBS_NOINTEGRALHEIGHT, WS_BORDER | WS_CHILD | WS_VSCROLL | LBS_HASSTRINGS | LBS_NOTIFY | LBS_NOINTEGRALHEIGHT,
CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT,
hwndParent, NULL, hwndParent, NULL,
(HINSTANCE)GetWindowLongPtrW(hwndParent, GWLP_HINSTANCE), NULL); (HINSTANCE)GetWindowLongPtrW(hwndParent, GWLP_HINSTANCE), NULL);
if (hwndListBox) if (m_hwndListBox)
{ {
wpOrigLBoxProc = (WNDPROC)SetWindowLongPtrW(hwndListBox, GWLP_WNDPROC, (LONG_PTR)ACLBoxSubclassProc); m_wpOrigLBoxProc = (WNDPROC)SetWindowLongPtrW(m_hwndListBox, GWLP_WNDPROC, (LONG_PTR)ACLBoxSubclassProc);
SetWindowLongPtrW(hwndListBox, GWLP_USERDATA, (LONG_PTR)this); SetWindowLongPtrW(m_hwndListBox, GWLP_USERDATA, (LONG_PTR)this);
} }
} }
@ -119,39 +119,39 @@ HRESULT WINAPI CAutoComplete::Init(HWND hwndEdit, IUnknown *punkACL, LPCOLESTR p
TRACE("(%p)->(0x%08lx, %p, %s, %s)\n", TRACE("(%p)->(0x%08lx, %p, %s, %s)\n",
this, hwndEdit, punkACL, debugstr_w(pwzsRegKeyPath), debugstr_w(pwszQuickComplete)); this, hwndEdit, punkACL, debugstr_w(pwzsRegKeyPath), debugstr_w(pwszQuickComplete));
if (options & ACO_AUTOSUGGEST) if (m_options & ACO_AUTOSUGGEST)
TRACE(" ACO_AUTOSUGGEST\n"); TRACE(" ACO_AUTOSUGGEST\n");
if (options & ACO_AUTOAPPEND) if (m_options & ACO_AUTOAPPEND)
TRACE(" ACO_AUTOAPPEND\n"); TRACE(" ACO_AUTOAPPEND\n");
if (options & ACO_SEARCH) if (m_options & ACO_SEARCH)
FIXME(" ACO_SEARCH not supported\n"); FIXME(" ACO_SEARCH not supported\n");
if (options & ACO_FILTERPREFIXES) if (m_options & ACO_FILTERPREFIXES)
FIXME(" ACO_FILTERPREFIXES not supported\n"); FIXME(" ACO_FILTERPREFIXES not supported\n");
if (options & ACO_USETAB) if (m_options & ACO_USETAB)
FIXME(" ACO_USETAB not supported\n"); FIXME(" ACO_USETAB not supported\n");
if (options & ACO_UPDOWNKEYDROPSLIST) if (m_options & ACO_UPDOWNKEYDROPSLIST)
TRACE(" ACO_UPDOWNKEYDROPSLIST\n"); TRACE(" ACO_UPDOWNKEYDROPSLIST\n");
if (options & ACO_RTLREADING) if (m_options & ACO_RTLREADING)
FIXME(" ACO_RTLREADING not supported\n"); FIXME(" ACO_RTLREADING not supported\n");
if (!hwndEdit || !punkACL) if (!m_hwndEdit || !punkACL)
return E_INVALIDARG; return E_INVALIDARG;
if (this->initialized) if (this->m_initialized)
{ {
WARN("Autocompletion object is already initialized\n"); WARN("Autocompletion object is already initialized\n");
/* This->hwndEdit is set to NULL when the edit window is destroyed. */ /* This->hwndEdit is set to NULL when the edit window is destroyed. */
return this->hwndEdit ? E_FAIL : E_UNEXPECTED; return this->m_hwndEdit ? E_FAIL : E_UNEXPECTED;
} }
if (!SUCCEEDED(punkACL->QueryInterface(IID_PPV_ARG(IEnumString,&enumstr)))) if (!SUCCEEDED(punkACL->QueryInterface(IID_PPV_ARG(IEnumString, &m_enumstr))))
{ {
TRACE("No IEnumString interface\n"); TRACE("No IEnumString interface\n");
return E_NOINTERFACE; return E_NOINTERFACE;
} }
this->hwndEdit = hwndEdit; this->m_hwndEdit = hwndEdit;
this->initialized = TRUE; this->m_initialized = TRUE;
/* Keep at least one reference to the object until the edit window is destroyed. */ /* Keep at least one reference to the object until the edit window is destroyed. */
this->AddRef(); this->AddRef();
@ -159,22 +159,22 @@ HRESULT WINAPI CAutoComplete::Init(HWND hwndEdit, IUnknown *punkACL, LPCOLESTR p
/* If another AutoComplete object was previously assigned to this edit control, /* If another AutoComplete object was previously assigned to this edit control,
release it but keep the same callback on the control, to avoid an infinite release it but keep the same callback on the control, to avoid an infinite
recursive loop in ACEditSubclassProc while the property is set to this object */ recursive loop in ACEditSubclassProc while the property is set to this object */
CAutoComplete *prev = static_cast<CAutoComplete *>(GetPropW(hwndEdit, autocomplete_propertyW)); CAutoComplete *prev = static_cast<CAutoComplete *>(GetPropW(m_hwndEdit, autocomplete_propertyW));
if (prev && prev->initialized) if (prev && prev->m_initialized)
{ {
this->wpOrigEditProc = prev->wpOrigEditProc; this->m_wpOrigEditProc = prev->m_wpOrigEditProc;
SetPropW(hwndEdit, autocomplete_propertyW, this); SetPropW(m_hwndEdit, autocomplete_propertyW, this);
prev->wpOrigEditProc = NULL; prev->m_wpOrigEditProc = NULL;
prev->Release(); prev->Release();
} }
else else
{ {
SetPropW( this->hwndEdit, autocomplete_propertyW, (HANDLE)this ); SetPropW(this->m_hwndEdit, autocomplete_propertyW, (HANDLE)this);
this->wpOrigEditProc = (WNDPROC)SetWindowLongPtrW(hwndEdit, GWLP_WNDPROC, (LONG_PTR)ACEditSubclassProc); this->m_wpOrigEditProc = (WNDPROC)SetWindowLongPtrW(m_hwndEdit, GWLP_WNDPROC, (LONG_PTR)ACEditSubclassProc);
} }
if (options & ACO_AUTOSUGGEST) if (m_options & ACO_AUTOSUGGEST)
{ {
this->CreateListbox(); this->CreateListbox();
} }
@ -215,8 +215,8 @@ HRESULT WINAPI CAutoComplete::Init(HWND hwndEdit, IUnknown *punkACL, LPCOLESTR p
res = RegQueryValueW(hKey, value, result, &len); res = RegQueryValueW(hKey, value, result, &len);
if (res == ERROR_SUCCESS) if (res == ERROR_SUCCESS)
{ {
quickComplete = (WCHAR *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len * sizeof(WCHAR)); m_quickComplete = (WCHAR *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len * sizeof(WCHAR));
wcscpy(quickComplete, result); wcscpy(m_quickComplete, result);
} }
RegCloseKey(hKey); RegCloseKey(hKey);
} }
@ -231,13 +231,13 @@ HRESULT WINAPI CAutoComplete::Init(HWND hwndEdit, IUnknown *punkACL, LPCOLESTR p
} }
} }
if ((pwszQuickComplete) && (!quickComplete)) if ((pwszQuickComplete) && (!m_quickComplete))
{ {
quickComplete = (WCHAR *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, (wcslen(pwszQuickComplete) + 1) * sizeof(WCHAR)); m_quickComplete = (WCHAR *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, (wcslen(pwszQuickComplete) + 1) * sizeof(WCHAR));
if (quickComplete) if (m_quickComplete)
{ {
wcscpy(quickComplete, pwszQuickComplete); wcscpy(m_quickComplete, pwszQuickComplete);
} }
else else
{ {
@ -258,7 +258,7 @@ HRESULT WINAPI CAutoComplete::GetOptions(DWORD *pdwFlag)
TRACE("(%p) -> (%p)\n", this, pdwFlag); TRACE("(%p) -> (%p)\n", this, pdwFlag);
*pdwFlag = options; *pdwFlag = m_options;
return hr; return hr;
} }
@ -272,9 +272,9 @@ HRESULT WINAPI CAutoComplete::SetOptions(DWORD dwFlag)
TRACE("(%p) -> (0x%x)\n", this, dwFlag); TRACE("(%p) -> (0x%x)\n", this, dwFlag);
options = (AUTOCOMPLETEOPTIONS)dwFlag; m_options = (AUTOCOMPLETEOPTIONS)dwFlag;
if ((options & ACO_AUTOSUGGEST) && hwndEdit && !hwndListBox) if ((m_options & ACO_AUTOSUGGEST) && m_hwndEdit && !m_hwndListBox)
CreateListbox(); CreateListbox();
return hr; return hr;
@ -335,25 +335,25 @@ LRESULT APIENTRY CAutoComplete::ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM
int cpt, height, sel; int cpt, height, sel;
ULONG fetched; ULONG fetched;
if (!pThis->enabled) if (!pThis->m_enabled)
{ {
return CallWindowProcW(pThis->wpOrigEditProc, hwnd, uMsg, wParam, lParam); return CallWindowProcW(pThis->m_wpOrigEditProc, hwnd, uMsg, wParam, lParam);
} }
switch (uMsg) switch (uMsg)
{ {
case CB_SHOWDROPDOWN: case CB_SHOWDROPDOWN:
{ {
ShowWindow(pThis->hwndListBox, SW_HIDE); ShowWindow(pThis->m_hwndListBox, SW_HIDE);
}; break; }; break;
case WM_KILLFOCUS: case WM_KILLFOCUS:
{ {
if ((pThis->options & ACO_AUTOSUGGEST) && ((HWND)wParam != pThis->hwndListBox)) if ((pThis->m_options & ACO_AUTOSUGGEST) && ((HWND)wParam != pThis->m_hwndListBox))
{ {
ShowWindow(pThis->hwndListBox, SW_HIDE); ShowWindow(pThis->m_hwndListBox, SW_HIDE);
} }
return CallWindowProcW(pThis->wpOrigEditProc, hwnd, uMsg, wParam, lParam); return CallWindowProcW(pThis->m_wpOrigEditProc, hwnd, uMsg, wParam, lParam);
}; break; }; break;
case WM_KEYUP: case WM_KEYUP:
@ -366,17 +366,17 @@ LRESULT APIENTRY CAutoComplete::ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM
{ {
/* If quickComplete is set and control is pressed, replace the string */ /* If quickComplete is set and control is pressed, replace the string */
control = GetKeyState(VK_CONTROL) & 0x8000; control = GetKeyState(VK_CONTROL) & 0x8000;
if (control && pThis->quickComplete) if (control && pThis->m_quickComplete)
{ {
hwndQCText = (WCHAR *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, hwndQCText = (WCHAR *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
(wcslen(pThis->quickComplete)+wcslen(hwndText))*sizeof(WCHAR)); (wcslen(pThis->m_quickComplete)+wcslen(hwndText))*sizeof(WCHAR));
sel = swprintf(hwndQCText, pThis->quickComplete, hwndText); sel = swprintf(hwndQCText, pThis->m_quickComplete, hwndText);
SendMessageW(hwnd, WM_SETTEXT, 0, (LPARAM)hwndQCText); SendMessageW(hwnd, WM_SETTEXT, 0, (LPARAM)hwndQCText);
SendMessageW(hwnd, EM_SETSEL, 0, sel); SendMessageW(hwnd, EM_SETSEL, 0, sel);
HeapFree(GetProcessHeap(), 0, hwndQCText); HeapFree(GetProcessHeap(), 0, hwndQCText);
} }
ShowWindow(pThis->hwndListBox, SW_HIDE); ShowWindow(pThis->m_hwndListBox, SW_HIDE);
return 0; return 0;
}; break; }; break;
@ -395,39 +395,39 @@ LRESULT APIENTRY CAutoComplete::ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM
is present but does not select anything. is present but does not select anything.
- if the listbox is visible, change the selection - if the listbox is visible, change the selection
*/ */
if ( (pThis->options & (ACO_AUTOSUGGEST | ACO_UPDOWNKEYDROPSLIST)) if ( (pThis->m_options & (ACO_AUTOSUGGEST | ACO_UPDOWNKEYDROPSLIST))
&& (!IsWindowVisible(pThis->hwndListBox) && (! *hwndText)) ) && (!IsWindowVisible(pThis->m_hwndListBox) && (! *hwndText)) )
{ {
/* We must display all the entries */ /* We must display all the entries */
displayall = TRUE; displayall = TRUE;
} }
else else
{ {
if (IsWindowVisible(pThis->hwndListBox)) if (IsWindowVisible(pThis->m_hwndListBox))
{ {
int count; int count;
count = SendMessageW(pThis->hwndListBox, LB_GETCOUNT, 0, 0); count = SendMessageW(pThis->m_hwndListBox, LB_GETCOUNT, 0, 0);
/* Change the selection */ /* Change the selection */
sel = SendMessageW(pThis->hwndListBox, LB_GETCURSEL, 0, 0); sel = SendMessageW(pThis->m_hwndListBox, LB_GETCURSEL, 0, 0);
if (wParam == VK_UP) if (wParam == VK_UP)
sel = ((sel-1) < 0) ? count-1 : sel-1; sel = ((sel-1) < 0) ? count-1 : sel-1;
else else
sel = ((sel+1) >= count) ? -1 : sel+1; sel = ((sel+1) >= count) ? -1 : sel+1;
SendMessageW(pThis->hwndListBox, LB_SETCURSEL, sel, 0); SendMessageW(pThis->m_hwndListBox, LB_SETCURSEL, sel, 0);
if (sel != -1) if (sel != -1)
{ {
WCHAR *msg; WCHAR *msg;
int len; int len;
len = SendMessageW(pThis->hwndListBox, LB_GETTEXTLEN, sel, (LPARAM)NULL); len = SendMessageW(pThis->m_hwndListBox, LB_GETTEXTLEN, sel, (LPARAM)NULL);
msg = (WCHAR *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, (len + 1) * sizeof(WCHAR)); msg = (WCHAR *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, (len + 1) * sizeof(WCHAR));
if (msg) if (msg)
{ {
SendMessageW(pThis->hwndListBox, LB_GETTEXT, sel, (LPARAM)msg); SendMessageW(pThis->m_hwndListBox, LB_GETTEXT, sel, (LPARAM)msg);
SendMessageW(hwnd, WM_SETTEXT, 0, (LPARAM)msg); SendMessageW(hwnd, WM_SETTEXT, 0, (LPARAM)msg);
SendMessageW(hwnd, EM_SETSEL, wcslen(msg), wcslen(msg)); SendMessageW(hwnd, EM_SETSEL, wcslen(msg), wcslen(msg));
@ -440,8 +440,8 @@ LRESULT APIENTRY CAutoComplete::ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM
} }
else else
{ {
SendMessageW(hwnd, WM_SETTEXT, 0, (LPARAM)pThis->txtbackup); SendMessageW(hwnd, WM_SETTEXT, 0, (LPARAM)pThis->m_txtbackup);
SendMessageW(hwnd, EM_SETSEL, wcslen(pThis->txtbackup), wcslen(pThis->txtbackup)); SendMessageW(hwnd, EM_SETSEL, wcslen(pThis->m_txtbackup), wcslen(pThis->m_txtbackup));
} }
} }
return 0; return 0;
@ -459,13 +459,13 @@ LRESULT APIENTRY CAutoComplete::ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM
// FALL THROUGH // FALL THROUGH
case VK_DELETE: case VK_DELETE:
{ {
if ((! *hwndText) && (pThis->options & ACO_AUTOSUGGEST)) if ((! *hwndText) && (pThis->m_options & ACO_AUTOSUGGEST))
{ {
ShowWindow(pThis->hwndListBox, SW_HIDE); ShowWindow(pThis->m_hwndListBox, SW_HIDE);
return CallWindowProcW(pThis->wpOrigEditProc, hwnd, uMsg, wParam, lParam); return CallWindowProcW(pThis->m_wpOrigEditProc, hwnd, uMsg, wParam, lParam);
} }
if (pThis->options & ACO_AUTOAPPEND) if (pThis->m_options & ACO_AUTOAPPEND)
{ {
DWORD b; DWORD b;
SendMessageW(hwnd, EM_GETSEL, (WPARAM)&b, (LPARAM)NULL); SendMessageW(hwnd, EM_GETSEL, (WPARAM)&b, (LPARAM)NULL);
@ -485,15 +485,15 @@ LRESULT APIENTRY CAutoComplete::ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM
; ;
} }
SendMessageW(pThis->hwndListBox, LB_RESETCONTENT, 0, 0); SendMessageW(pThis->m_hwndListBox, LB_RESETCONTENT, 0, 0);
HeapFree(GetProcessHeap(), 0, pThis->txtbackup); HeapFree(GetProcessHeap(), 0, pThis->m_txtbackup);
pThis->txtbackup = (WCHAR *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, (wcslen(hwndText)+1)*sizeof(WCHAR)); pThis->m_txtbackup = (WCHAR *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, (wcslen(hwndText)+1)*sizeof(WCHAR));
if (pThis->txtbackup) if (pThis->m_txtbackup)
{ {
wcscpy(pThis->txtbackup, hwndText); wcscpy(pThis->m_txtbackup, hwndText);
} }
else else
{ {
@ -504,56 +504,56 @@ LRESULT APIENTRY CAutoComplete::ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM
if ((!displayall) && (! *hwndText) ) if ((!displayall) && (! *hwndText) )
break; break;
pThis->enumstr->Reset(); pThis->m_enumstr->Reset();
filled = FALSE; filled = FALSE;
size_t curlen = wcslen(hwndText); size_t curlen = wcslen(hwndText);
for(cpt = 0;;) for(cpt = 0;;)
{ {
CComHeapPtr<OLECHAR> strs; CComHeapPtr<OLECHAR> strs;
hr = pThis->enumstr->Next(1, &strs, &fetched); hr = pThis->m_enumstr->Next(1, &strs, &fetched);
if (hr != S_OK) if (hr != S_OK)
break; break;
if (!_wcsnicmp(hwndText, strs, curlen)) if (!_wcsnicmp(hwndText, strs, curlen))
{ {
if (pThis->options & ACO_AUTOAPPEND && *hwndText) if (pThis->m_options & ACO_AUTOAPPEND && *hwndText)
{ {
CComBSTR str((PCWSTR)strs); CComBSTR str((PCWSTR)strs);
memcpy(str.m_str, hwndText, curlen * sizeof(WCHAR)); memcpy(str.m_str, hwndText, curlen * sizeof(WCHAR));
SetWindowTextW(hwnd, str); SetWindowTextW(hwnd, str);
SendMessageW(hwnd, EM_SETSEL, curlen, str.Length()); SendMessageW(hwnd, EM_SETSEL, curlen, str.Length());
if (!(pThis->options & ACO_AUTOSUGGEST)) if (!(pThis->m_options & ACO_AUTOSUGGEST))
break; break;
} }
if (pThis->options & ACO_AUTOSUGGEST) if (pThis->m_options & ACO_AUTOSUGGEST)
{ {
SendMessageW(pThis->hwndListBox, LB_ADDSTRING, 0, (LPARAM)(LPOLESTR)strs); SendMessageW(pThis->m_hwndListBox, LB_ADDSTRING, 0, (LPARAM)(LPOLESTR)strs);
filled = TRUE; filled = TRUE;
cpt++; cpt++;
} }
} }
} }
if (pThis->options & ACO_AUTOSUGGEST) if (pThis->m_options & ACO_AUTOSUGGEST)
{ {
if (filled) if (filled)
{ {
height = SendMessageW(pThis->hwndListBox, LB_GETITEMHEIGHT, 0, 0); height = SendMessageW(pThis->m_hwndListBox, LB_GETITEMHEIGHT, 0, 0);
SendMessageW(pThis->hwndListBox, LB_CARETOFF, 0, 0); SendMessageW(pThis->m_hwndListBox, LB_CARETOFF, 0, 0);
GetWindowRect(hwnd, &r); GetWindowRect(hwnd, &r);
SetParent(pThis->hwndListBox, HWND_DESKTOP); SetParent(pThis->m_hwndListBox, HWND_DESKTOP);
/* It seems that Windows XP displays 7 lines at most /* It seems that Windows XP displays 7 lines at most
and otherwise displays a vertical scroll bar */ and otherwise displays a vertical scroll bar */
SetWindowPos(pThis->hwndListBox, HWND_TOP, SetWindowPos(pThis->m_hwndListBox, HWND_TOP,
r.left, r.bottom + 1, r.right - r.left, min(height * 7, height * (cpt + 1)), r.left, r.bottom + 1, r.right - r.left, min(height * 7, height * (cpt + 1)),
SWP_SHOWWINDOW ); SWP_SHOWWINDOW );
} }
else else
{ {
ShowWindow(pThis->hwndListBox, SW_HIDE); ShowWindow(pThis->m_hwndListBox, SW_HIDE);
} }
} }
@ -569,7 +569,7 @@ LRESULT APIENTRY CAutoComplete::ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM
default: default:
{ {
return CallWindowProcW(pThis->wpOrigEditProc, hwnd, uMsg, wParam, lParam); return CallWindowProcW(pThis->m_wpOrigEditProc, hwnd, uMsg, wParam, lParam);
} }
} }
@ -598,14 +598,14 @@ LRESULT APIENTRY CAutoComplete::ACLBoxSubclassProc(HWND hwnd, UINT uMsg, WPARAM
if (sel < 0) if (sel < 0)
break; break;
len = SendMessageW(pThis->hwndListBox, LB_GETTEXTLEN, sel, 0); len = SendMessageW(pThis->m_hwndListBox, LB_GETTEXTLEN, sel, 0);
msg = (WCHAR *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, (len + 1) * sizeof(WCHAR)); msg = (WCHAR *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, (len + 1) * sizeof(WCHAR));
if (msg) if (msg)
{ {
SendMessageW(hwnd, LB_GETTEXT, sel, (LPARAM)msg); SendMessageW(hwnd, LB_GETTEXT, sel, (LPARAM)msg);
SendMessageW(pThis->hwndEdit, WM_SETTEXT, 0, (LPARAM)msg); SendMessageW(pThis->m_hwndEdit, WM_SETTEXT, 0, (LPARAM)msg);
SendMessageW(pThis->hwndEdit, EM_SETSEL, 0, wcslen(msg)); SendMessageW(pThis->m_hwndEdit, EM_SETSEL, 0, wcslen(msg));
ShowWindow(hwnd, SW_HIDE); ShowWindow(hwnd, SW_HIDE);
HeapFree(GetProcessHeap(), 0, msg); HeapFree(GetProcessHeap(), 0, msg);
@ -618,7 +618,7 @@ LRESULT APIENTRY CAutoComplete::ACLBoxSubclassProc(HWND hwnd, UINT uMsg, WPARAM
}; break; }; break;
default: default:
return CallWindowProcW(pThis->wpOrigLBoxProc, hwnd, uMsg, wParam, lParam); return CallWindowProcW(pThis->m_wpOrigLBoxProc, hwnd, uMsg, wParam, lParam);
} }
return 0; return 0;
} }
@ -628,7 +628,7 @@ LRESULT APIENTRY CAutoComplete::ACLBoxSubclassProc(HWND hwnd, UINT uMsg, WPARAM
*/ */
HRESULT STDMETHODCALLTYPE CAutoComplete::GetDropDownStatus(DWORD *pdwFlags, LPWSTR *ppwszString) HRESULT STDMETHODCALLTYPE CAutoComplete::GetDropDownStatus(DWORD *pdwFlags, LPWSTR *ppwszString)
{ {
BOOL dropped = IsWindowVisible(hwndListBox); BOOL dropped = IsWindowVisible(m_hwndListBox);
if (pdwFlags) if (pdwFlags)
*pdwFlags = (dropped ? ACDD_VISIBLE : 0); *pdwFlags = (dropped ? ACDD_VISIBLE : 0);
@ -639,12 +639,12 @@ HRESULT STDMETHODCALLTYPE CAutoComplete::GetDropDownStatus(DWORD *pdwFlags, LPWS
if (dropped) if (dropped)
{ {
int sel = SendMessageW(hwndListBox, LB_GETCURSEL, 0, 0); int sel = SendMessageW(m_hwndListBox, LB_GETCURSEL, 0, 0);
if (sel >= 0) if (sel >= 0)
{ {
DWORD len = SendMessageW(hwndListBox, LB_GETTEXTLEN, sel, 0); DWORD len = SendMessageW(m_hwndListBox, LB_GETTEXTLEN, sel, 0);
*ppwszString = (LPWSTR)CoTaskMemAlloc((len+1)*sizeof(WCHAR)); *ppwszString = (LPWSTR)CoTaskMemAlloc((len+1)*sizeof(WCHAR));
SendMessageW(hwndListBox, LB_GETTEXT, sel, (LPARAM)*ppwszString); SendMessageW(m_hwndListBox, LB_GETTEXT, sel, (LPARAM)*ppwszString);
} }
} }
} }

81
dll/win32/browseui/CAutoComplete.h
View File

@ -1,8 +1,9 @@
/* /*
* AutoComplete interfaces implementation. * AutoComplete interfaces implementation.
* *
* Copyright 2004 Maxime Bellengé <maxime.bellenge@laposte.net> * Copyright 2004 Maxime Bellengé <maxime.bellenge@laposte.net>
* Copyright 2009 Andrew Hill * Copyright 2009 Andrew Hill
* Copyright 2021 Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
* *
* This library is free software; you can redistribute it and/or * This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public * modify it under the terms of the GNU Lesser General Public
@ -23,48 +24,48 @@
#define _AUTOCOMPLETE_H_ #define _AUTOCOMPLETE_H_
class CAutoComplete : class CAutoComplete :
public CComCoClass<CAutoComplete, &CLSID_AutoComplete>, public CComCoClass<CAutoComplete, &CLSID_AutoComplete>,
public CComObjectRootEx<CComMultiThreadModelNoCS>, public CComObjectRootEx<CComMultiThreadModelNoCS>,
public IAutoComplete2, public IAutoComplete2,
public IAutoCompleteDropDown, public IAutoCompleteDropDown,
public IEnumString public IEnumString
{ {
private: private:
BOOL enabled; BOOL m_enabled;
BOOL initialized; BOOL m_initialized;
HWND hwndEdit; HWND m_hwndEdit;
HWND hwndListBox; HWND m_hwndListBox;
WNDPROC wpOrigEditProc; WNDPROC m_wpOrigEditProc;
WNDPROC wpOrigLBoxProc; WNDPROC m_wpOrigLBoxProc;
WCHAR *txtbackup; LPWSTR m_txtbackup; // HeapAlloc'ed
WCHAR *quickComplete; LPWSTR m_quickComplete; // HeapAlloc'ed
CComPtr<IEnumString> enumstr; CComPtr<IEnumString> m_enumstr;
AUTOCOMPLETEOPTIONS options; AUTOCOMPLETEOPTIONS m_options;
public: public:
CAutoComplete(); CAutoComplete();
~CAutoComplete(); ~CAutoComplete();
static LRESULT APIENTRY ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam); static LRESULT APIENTRY ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam);
static LRESULT APIENTRY ACLBoxSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam); static LRESULT APIENTRY ACLBoxSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam);
void CreateListbox(); void CreateListbox();
// IAutoComplete2 // IAutoComplete2
virtual HRESULT WINAPI Enable(BOOL fEnable); virtual HRESULT WINAPI Enable(BOOL fEnable);
virtual HRESULT WINAPI Init(HWND hwndEdit, IUnknown *punkACL, LPCOLESTR pwzsRegKeyPath, LPCOLESTR pwszQuickComplete); virtual HRESULT WINAPI Init(HWND hwndEdit, IUnknown *punkACL, LPCOLESTR pwzsRegKeyPath, LPCOLESTR pwszQuickComplete);
virtual HRESULT WINAPI GetOptions(DWORD *pdwFlag); virtual HRESULT WINAPI GetOptions(DWORD *pdwFlag);
virtual HRESULT WINAPI SetOptions(DWORD dwFlag); virtual HRESULT WINAPI SetOptions(DWORD dwFlag);
// IAutoCompleteDropDown // IAutoCompleteDropDown
virtual HRESULT STDMETHODCALLTYPE GetDropDownStatus(DWORD *pdwFlags, LPWSTR *ppwszString); virtual HRESULT STDMETHODCALLTYPE GetDropDownStatus(DWORD *pdwFlags, LPWSTR *ppwszString);
virtual HRESULT STDMETHODCALLTYPE ResetEnumerator(); virtual HRESULT STDMETHODCALLTYPE ResetEnumerator();
// IEnumString methods // IEnumString methods
virtual HRESULT STDMETHODCALLTYPE Next(ULONG celt, LPOLESTR *rgelt, ULONG *pceltFetched); virtual HRESULT STDMETHODCALLTYPE Next(ULONG celt, LPOLESTR *rgelt, ULONG *pceltFetched);
virtual HRESULT STDMETHODCALLTYPE Skip(ULONG celt); virtual HRESULT STDMETHODCALLTYPE Skip(ULONG celt);
virtual HRESULT STDMETHODCALLTYPE Reset(); virtual HRESULT STDMETHODCALLTYPE Reset();
virtual HRESULT STDMETHODCALLTYPE Clone(IEnumString **ppenum); virtual HRESULT STDMETHODCALLTYPE Clone(IEnumString **ppenum);
DECLARE_REGISTRY_RESOURCEID(IDR_AUTOCOMPLETE) DECLARE_REGISTRY_RESOURCEID(IDR_AUTOCOMPLETE)
DECLARE_NOT_AGGREGATABLE(CAutoComplete) DECLARE_NOT_AGGREGATABLE(CAutoComplete)
@ -72,10 +73,10 @@ DECLARE_NOT_AGGREGATABLE(CAutoComplete)
DECLARE_PROTECT_FINAL_CONSTRUCT() DECLARE_PROTECT_FINAL_CONSTRUCT()
BEGIN_COM_MAP(CAutoComplete) BEGIN_COM_MAP(CAutoComplete)
COM_INTERFACE_ENTRY_IID(IID_IAutoComplete, IAutoComplete) COM_INTERFACE_ENTRY_IID(IID_IAutoComplete, IAutoComplete)
COM_INTERFACE_ENTRY_IID(IID_IAutoComplete2, IAutoComplete2) COM_INTERFACE_ENTRY_IID(IID_IAutoComplete2, IAutoComplete2)
COM_INTERFACE_ENTRY_IID(IID_IAutoCompleteDropDown, IAutoCompleteDropDown) COM_INTERFACE_ENTRY_IID(IID_IAutoCompleteDropDown, IAutoCompleteDropDown)
COM_INTERFACE_ENTRY_IID(IID_IEnumString, IEnumString) COM_INTERFACE_ENTRY_IID(IID_IEnumString, IEnumString)
END_COM_MAP() END_COM_MAP()
}; };