mirror of
https://github.com/qemu/qemu.git
synced 2024-11-26 04:13:39 +08:00
b7aa131519
The result of openfile was not checked, leading to failure deep in the
actual command with confusing error message, and exiting with exit code 0.
Here is a simple example - trying to read with the wrong format:
$ touch file
$ qemu-io -f qcow2 -c 'read -P 1 0 1024' file; echo $?
can't open device file: Image is not in qcow2 format
no file open, try 'help open'
0
With this patch, we fail earlier with exit code 1:
$ ./qemu-io -f qcow2 -c 'read -P 1 0 1024' file; echo $?
can't open device file: Image is not in qcow2 format
1
Failing earlier, we don't log this error now:
no file open, try 'help open'
But some tests expected it; the line was removed from the test output.
Signed-off-by: Nir Soffer <nirsof@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 20170201003120.23378-2-nirsof@gmail.com
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
112 lines
2.2 KiB
Plaintext
112 lines
2.2 KiB
Plaintext
QA output created by 083
|
|
=== Check disconnect before neg1 ===
|
|
|
|
can't open device nbd:127.0.0.1:PORT:exportname=foo
|
|
|
|
=== Check disconnect after neg1 ===
|
|
|
|
can't open device nbd:127.0.0.1:PORT:exportname=foo
|
|
|
|
=== Check disconnect 8 neg1 ===
|
|
|
|
can't open device nbd:127.0.0.1:PORT:exportname=foo
|
|
|
|
=== Check disconnect 16 neg1 ===
|
|
|
|
can't open device nbd:127.0.0.1:PORT:exportname=foo
|
|
|
|
=== Check disconnect before export ===
|
|
|
|
can't open device nbd:127.0.0.1:PORT:exportname=foo
|
|
|
|
=== Check disconnect after export ===
|
|
|
|
can't open device nbd:127.0.0.1:PORT:exportname=foo
|
|
|
|
=== Check disconnect 4 export ===
|
|
|
|
can't open device nbd:127.0.0.1:PORT:exportname=foo
|
|
|
|
=== Check disconnect 12 export ===
|
|
|
|
can't open device nbd:127.0.0.1:PORT:exportname=foo
|
|
|
|
=== Check disconnect 16 export ===
|
|
|
|
can't open device nbd:127.0.0.1:PORT:exportname=foo
|
|
|
|
=== Check disconnect before neg2 ===
|
|
|
|
can't open device nbd:127.0.0.1:PORT:exportname=foo
|
|
|
|
=== Check disconnect after neg2 ===
|
|
|
|
read failed: Input/output error
|
|
|
|
=== Check disconnect 8 neg2 ===
|
|
|
|
can't open device nbd:127.0.0.1:PORT:exportname=foo
|
|
|
|
=== Check disconnect 10 neg2 ===
|
|
|
|
can't open device nbd:127.0.0.1:PORT:exportname=foo
|
|
|
|
=== Check disconnect before request ===
|
|
|
|
read failed: Input/output error
|
|
|
|
=== Check disconnect after request ===
|
|
|
|
read failed: Input/output error
|
|
|
|
=== Check disconnect before reply ===
|
|
|
|
read failed: Input/output error
|
|
|
|
=== Check disconnect after reply ===
|
|
|
|
read failed: Input/output error
|
|
|
|
=== Check disconnect 4 reply ===
|
|
|
|
read failed: Input/output error
|
|
|
|
=== Check disconnect 8 reply ===
|
|
|
|
read failed: Input/output error
|
|
|
|
=== Check disconnect before data ===
|
|
|
|
read failed: Input/output error
|
|
|
|
=== Check disconnect after data ===
|
|
|
|
read 512/512 bytes at offset 0
|
|
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
|
|
=== Check disconnect before neg-classic ===
|
|
|
|
can't open device nbd:127.0.0.1:PORT
|
|
|
|
=== Check disconnect 8 neg-classic ===
|
|
|
|
can't open device nbd:127.0.0.1:PORT
|
|
|
|
=== Check disconnect 16 neg-classic ===
|
|
|
|
can't open device nbd:127.0.0.1:PORT
|
|
|
|
=== Check disconnect 24 neg-classic ===
|
|
|
|
can't open device nbd:127.0.0.1:PORT
|
|
|
|
=== Check disconnect 28 neg-classic ===
|
|
|
|
can't open device nbd:127.0.0.1:PORT
|
|
|
|
=== Check disconnect after neg-classic ===
|
|
|
|
read failed: Input/output error
|
|
|
|
*** done
|