mirror of
https://github.com/qemu/qemu.git
synced 2024-12-13 14:33:31 +08:00
3cea09271b
PACK fails on the test from the Principles of Operation: F1F2F3F4 becomes 0000234C instead of 0001234C due to an off-by-one error. Furthermore, it overwrites one extra byte to the left of F1. If len_dest is 0, then we only want to flip the 1st byte and never loop over the rest. Therefore, the loop condition should be > and not >=. If len_src is 1, then we should flip the 1st byte and pack the 2nd. Since len_src is already decremented before the loop, the first condition should be >=, and not >. Likewise for len_src == 2 and the second condition. Signed-off-by: Pavel Zbitskiy <pavel.zbitskiy@gmail.com> Message-Id: <20180821025104.19604-7-pavel.zbitskiy@gmail.com> Reviewed-by: David Hildenbrand <david@redhat.com> Signed-off-by: Cornelia Huck <cohuck@redhat.com> |
||
|---|---|---|
| .. | ||
| csst.c | ||
| exrl-trt.c | ||
| exrl-trtr.c | ||
| hello-s390x.c | ||
| ipm.c | ||
| Makefile.include | ||
| Makefile.target | ||
| pack.c | ||