mirror of
https://github.com/qemu/qemu.git
synced 2024-11-28 06:13:46 +08:00
0d876080a3
There's no reason to pack structures where we don't care about size or
padding, this applies to AcpiStdTable in tests/acpi-utils.h.
OTOH bios-tables-test happens to be passing the address of a field in
this struct to a function that expects a pointer to normally aligned
data which results in a SIGBUS on architectures like SPARC that have
strict alignment requirements.
Fixes: 9e8458c02 ("acpi unit-test: compare DSDT and SSDT tables against expected values")
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Peter Maydell <peter.maydell@linaro.org>
95 lines
3.6 KiB
C
95 lines
3.6 KiB
C
/*
|
|
* Utilities for working with ACPI tables
|
|
*
|
|
* Copyright (c) 2013 Red Hat Inc.
|
|
*
|
|
* Authors:
|
|
* Michael S. Tsirkin <mst@redhat.com>,
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#ifndef TEST_ACPI_UTILS_H
|
|
#define TEST_ACPI_UTILS_H
|
|
|
|
#include "hw/acpi/acpi-defs.h"
|
|
#include "libqtest.h"
|
|
|
|
/* DSDT and SSDTs format */
|
|
typedef struct {
|
|
AcpiTableHeader header;
|
|
gchar *aml; /* aml bytecode from guest */
|
|
gsize aml_len;
|
|
gchar *aml_file;
|
|
gchar *asl; /* asl code generated from aml */
|
|
gsize asl_len;
|
|
gchar *asl_file;
|
|
bool tmp_files_retain; /* do not delete the temp asl/aml */
|
|
} AcpiSdtTable;
|
|
|
|
#define ACPI_READ_FIELD(field, addr) \
|
|
do { \
|
|
switch (sizeof(field)) { \
|
|
case 1: \
|
|
field = readb(addr); \
|
|
break; \
|
|
case 2: \
|
|
field = readw(addr); \
|
|
break; \
|
|
case 4: \
|
|
field = readl(addr); \
|
|
break; \
|
|
case 8: \
|
|
field = readq(addr); \
|
|
break; \
|
|
default: \
|
|
g_assert(false); \
|
|
} \
|
|
addr += sizeof(field); \
|
|
} while (0);
|
|
|
|
#define ACPI_READ_ARRAY_PTR(arr, length, addr) \
|
|
do { \
|
|
int idx; \
|
|
for (idx = 0; idx < length; ++idx) { \
|
|
ACPI_READ_FIELD(arr[idx], addr); \
|
|
} \
|
|
} while (0);
|
|
|
|
#define ACPI_READ_ARRAY(arr, addr) \
|
|
ACPI_READ_ARRAY_PTR(arr, sizeof(arr) / sizeof(arr[0]), addr)
|
|
|
|
#define ACPI_READ_TABLE_HEADER(table, addr) \
|
|
do { \
|
|
ACPI_READ_FIELD((table)->signature, addr); \
|
|
ACPI_READ_FIELD((table)->length, addr); \
|
|
ACPI_READ_FIELD((table)->revision, addr); \
|
|
ACPI_READ_FIELD((table)->checksum, addr); \
|
|
ACPI_READ_ARRAY((table)->oem_id, addr); \
|
|
ACPI_READ_ARRAY((table)->oem_table_id, addr); \
|
|
ACPI_READ_FIELD((table)->oem_revision, addr); \
|
|
ACPI_READ_ARRAY((table)->asl_compiler_id, addr); \
|
|
ACPI_READ_FIELD((table)->asl_compiler_revision, addr); \
|
|
} while (0);
|
|
|
|
#define ACPI_ASSERT_CMP(actual, expected) do { \
|
|
uint32_t ACPI_ASSERT_CMP_le = cpu_to_le32(actual); \
|
|
char ACPI_ASSERT_CMP_str[5] = {}; \
|
|
memcpy(ACPI_ASSERT_CMP_str, &ACPI_ASSERT_CMP_le, 4); \
|
|
g_assert_cmpstr(ACPI_ASSERT_CMP_str, ==, expected); \
|
|
} while (0)
|
|
|
|
#define ACPI_ASSERT_CMP64(actual, expected) do { \
|
|
uint64_t ACPI_ASSERT_CMP_le = cpu_to_le64(actual); \
|
|
char ACPI_ASSERT_CMP_str[9] = {}; \
|
|
memcpy(ACPI_ASSERT_CMP_str, &ACPI_ASSERT_CMP_le, 8); \
|
|
g_assert_cmpstr(ACPI_ASSERT_CMP_str, ==, expected); \
|
|
} while (0)
|
|
|
|
uint8_t acpi_calc_checksum(const uint8_t *data, int len);
|
|
uint32_t acpi_find_rsdp_address(void);
|
|
void acpi_parse_rsdp_table(uint32_t addr, AcpiRsdpDescriptor *rsdp_table);
|
|
|
|
#endif /* TEST_ACPI_UTILS_H */
|