Kevin Wolf dbc9e94a23 nbd/server: Simplify export shutdown ... Closing export is somewhat convoluted because nbd_export_close() and nbd_export_put() call each other and the ways they actually end up being nested is not necessarily obvious. However, it is not really necessary to call nbd_export_close() from nbd_export_put() when putting the last reference because it only does three things: 1. Close all clients. We're going to refcount 0 and all clients hold a reference, so we know there is no active client any more. 2. Close the user reference (represented by exp->name being non-NULL). The same argument applies: If the export were still named, we would still have a reference. 3. Freeing exp->description. This is really cleanup work to be done when the export is finally freed. There is no reason to already clear it while clients are still in the process of shutting down. So after moving the cleanup of exp->description, the code can be simplified so that only nbd_export_close() calls nbd_export_put(), but never the other way around. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Max Reitz <mreitz@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Message-Id: <20200924152717.287415-13-kwolf@redhat.com> Acked-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>		2020-10-02 15:46:40 +02:00
..
client.c	nbd: Use ERRP_GUARD()	2020-07-10 15:18:09 +02:00
common.c	nbd: Prepare for NBD_CMD_FLAG_FAST_ZERO	2019-09-05 16:03:13 -05:00
meson.build	meson: convert block	2020-08-21 06:30:18 -04:00
nbd-internal.h	Include qemu/main-loop.h less	2019-08-16 13:31:52 +02:00
server.c	nbd/server: Simplify export shutdown	2020-10-02 15:46:40 +02:00
trace-events	trace: Remove trailing newline in events	2019-09-18 10:19:47 +01:00
trace.h	trace: switch position of headers to what Meson requires	2020-08-21 06:18:24 -04:00