mirror of
https://github.com/qemu/qemu.git
synced 2024-11-30 23:33:51 +08:00
cbc94d9702
Alias targets have a different name than the alias property itself (e.g. a machine's pflash0 might be an alias of a property named 'drive'). When the target's getter or setter invokes the visitor, it will use a different name than what the caller expects, and the visitor will not be able to find it (or will consume erroneously). The solution is for alias getters and setters to wrap the incoming visitor, and forward the sole field that the target is expecting while renaming it appropriately. This bug has been there forever, but it was exposed after -M parsing switched from QemuOptions and StringInputVisitor to keyval and QObjectInputVisitor. Before, the visitor ignored the name. Now, it checks "drive" against what was passed on the command line and finds that no such property exists. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/484 Reported-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> |
||
|---|---|---|
| .. | ||
| container.c | ||
| meson.build | ||
| object_interfaces.c | ||
| object.c | ||
| qom-hmp-cmds.c | ||
| qom-qmp-cmds.c | ||
| qom-qobject.c | ||
| trace-events | ||
| trace.h | ||