mirror of
https://github.com/qemu/qemu.git
synced 2024-11-24 11:23:43 +08:00
ca5c1457d6
Some time ago we discussed that using "id" as property name is not the right thing to do, as it is a reserved property for other devices and will not work with device_add. Switch to the term "core-id" instead, and use it as an equivalent to "CPU address" mentioned in the PoP. There is no such thing as cpu number, so rename env.cpu_num to env.core_id. We use "core-id" as this is the common term to use for device_add later on (x86 and ppc). We can get rid of cpu->id now. Keep cpu_index and env->core_id in sync. cpu_index was already implicitly used by e.g. cpu_exists(), so keeping both in sync seems to be the right thing to do. cpu_index will now no longer automatically get set via cpu_exec_realizefn(). For now, we were lucky that both implicitly stayed in sync. Our new cpu property "core-id" can be a static property. Range checks can be avoided by using the correct type and the "setting after realized" check is done implicitly. device_add will later need the reserved "id" property. Hotplugging a CPU on s390x will then be: "device_add host-s390-cpu,id=cpu2,core-id=2". Reviewed-by: Matthew Rosato <mjrosato@linux.vnet.ibm.com> Signed-off-by: David Hildenbrand <david@redhat.com> Message-Id: <20170913132417.24384-14-david@redhat.com> Signed-off-by: Cornelia Huck <cohuck@redhat.com> |
||
|---|---|---|
| .. | ||
| arch_dump.c | ||
| cc_helper.c | ||
| cpu_features_def.h | ||
| cpu_features.c | ||
| cpu_features.h | ||
| cpu_models.c | ||
| cpu_models.h | ||
| cpu-qom.h | ||
| cpu.c | ||
| cpu.h | ||
| diag.c | ||
| excp_helper.c | ||
| fpu_helper.c | ||
| gdbstub.c | ||
| gen-features.c | ||
| helper.c | ||
| helper.h | ||
| insn-data.def | ||
| insn-format.def | ||
| int_helper.c | ||
| internal.h | ||
| interrupt.c | ||
| ioinst.c | ||
| kvm_s390x.h | ||
| kvm-stub.c | ||
| kvm.c | ||
| machine.c | ||
| Makefile.objs | ||
| mem_helper.c | ||
| misc_helper.c | ||
| mmu_helper.c | ||
| trace-events | ||
| translate.c | ||