qemu/tests
Connor Kuehl 975a7bd228 block: Raise an error when backing file parameter is an empty string
Providing an empty string for the backing file parameter like so:

	qemu-img create -f qcow2 -b '' /tmp/foo

allows the flow of control to reach and subsequently fail an assert
statement because passing an empty string to

	bdrv_get_full_backing_filename_from_filename()

simply results in NULL being returned without an error being raised.

To fix this, let's check for an empty string when getting the value from
the opts list.

Reported-by: Attila Fazekas <afazekas@redhat.com>
Fixes: https://bugzilla.redhat.com/1809553
Signed-off-by: Connor Kuehl <ckuehl@redhat.com>
Message-Id: <20200813134722.802180-1-ckuehl@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-09-07 12:23:55 +02:00
..
acceptance Acceptance tests patches 2020-08-21 14:51:43 +01:00
data acpi: update expected DSDT files with _UID changes 2020-08-27 08:27:48 -04:00
decode decodetree: Drop check for less than 2 patterns in a group 2020-06-09 09:19:48 -07:00
docker tests/docker: add test script for static linux-user builds 2020-08-21 06:18:35 -04:00
fp meson: convert tests/fp and check-softfloat 2020-08-21 06:30:15 -04:00
guest-debug tests/guest-debug: catch hanging guests 2020-05-15 15:25:07 +01:00
image-fuzzer image-fuzzer: Use OSerror.strerror instead of tuple subscript 2019-11-05 16:36:11 +01:00
keys
migration tests/migration: fix unreachable path in stress test 2020-06-17 17:48:39 +01:00
multiboot meson: link emulators without Makefile.target 2020-08-21 06:30:40 -04:00
perf/block/qcow2
plugin meson: convert sample plugins 2020-08-21 06:30:43 -04:00
qapi-schema meson: convert check-qapi-schema 2020-08-21 06:30:15 -04:00
qemu-iotests block: Raise an error when backing file parameter is an empty string 2020-09-07 12:23:55 +02:00
qtest libqtest: Rename qmp_assert_error_class() to qmp_expect_error_and_unref() 2020-09-03 12:47:33 +02:00
rocker
tcg tests/tcg: Do not require FE_* exception bits 2020-09-01 07:41:38 -07:00
tsan tests/docker: Added docker build support for TSan. 2020-06-16 14:49:05 +01:00
uefi-test-tools edk2 build scripts: work around TianoCore#1607 without forcing Python 2 2019-10-07 15:14:15 +02:00
vm meson: convert po/ 2020-08-21 06:30:45 -04:00
vmstate-static-checker-data
.gitignore tests/tcg/aarch64: add a gdbstub testcase for SVE registers 2020-03-17 17:38:47 +00:00
atomic64-bench.c
atomic_add-bench.c
benchmark-crypto-cipher.c tests: benchmark crypto with fixed data size, not time period 2019-10-28 13:32:21 +01:00
benchmark-crypto-hash.c crypto: extend hash benchmark to cover more algorithms 2020-05-07 12:52:51 +01:00
benchmark-crypto-hmac.c
check-block-qdict.c tests: Use error_free_or_abort() where appropriate 2020-07-02 06:25:28 +02:00
check-block.sh check-block: enable iotests with SafeStack 2020-06-23 15:46:05 +01:00
check-qdict.c
check-qjson.c
check-qlist.c qobject: Eliminate qlist_iter(), use QLIST_FOREACH_ENTRY() instead 2020-04-30 06:51:15 +02:00
check-qlit.c
check-qnull.c
check-qnum.c
check-qobject.c tests: Use &error_abort where appropriate 2020-07-02 06:25:28 +02:00
check-qom-interface.c
check-qom-proplist.c tests: Use error_free_or_abort() where appropriate 2020-07-02 06:25:28 +02:00
check-qstring.c
crypto-tls-psk-helpers.c
crypto-tls-psk-helpers.h
crypto-tls-x509-helpers.c crypto: use a stronger private key for tests 2020-07-17 14:20:57 +02:00
crypto-tls-x509-helpers.h
dbus-vmstate-daemon.sh tests: add dbus-vmstate-test 2020-01-06 18:41:32 +04:00
io-channel-helpers.c
io-channel-helpers.h
iothread.c tests/iothread: Always connect iothread GSource to a GMainContext 2020-01-07 14:32:57 +00:00
iothread.h
Makefile.include meson: convert sample plugins 2020-08-21 06:30:43 -04:00
meson.build meson: convert sample plugins 2020-08-21 06:30:43 -04:00
pkix_asn1_tab.c
ptimer-test-stubs.c
ptimer-test.c tests/ptimer: Remove unnecessary inclusion of libqtest.h 2020-01-12 11:42:40 +01:00
ptimer-test.h
qht-bench.c tests/qht-bench: Adjust threshold computation 2020-07-11 15:53:00 +01:00
rcutorture.c tests/rcutorture: mild documenting refactor of update thread 2020-02-25 17:42:59 +00:00
requirements.txt Acceptance test: add "boot_linux" tests 2020-03-17 18:55:52 -04:00
socket-helpers.c
socket-helpers.h
test-aio-multithread.c
test-aio.c util/async: make bh_aio_poll() O(1) 2020-02-22 08:26:47 +00:00
test-authz-list.c
test-authz-listfile.c
test-authz-pam.c
test-authz-simple.c
test-base64.c tests: Use error_free_or_abort() where appropriate 2020-07-02 06:25:28 +02:00
test-bdrv-drain.c block: Drop @child_class from bdrv_child_perm() 2020-05-18 19:05:25 +02:00
test-bdrv-graph-mod.c tests: Use error_free_or_abort() where appropriate 2020-07-02 06:25:28 +02:00
test-bitcnt.c
test-bitmap.c tests: use g_test_rand_int 2019-12-17 09:05:23 +01:00
test-bitops.c
test-block-backend.c
test-block-iothread.c tests: Use error_free_or_abort() where appropriate 2020-07-02 06:25:28 +02:00
test-blockjob-txn.c job: drop job_drain 2019-09-10 08:58:43 +02:00
test-blockjob.c job: take each job's lock individually in job_txn_apply 2020-04-07 14:34:47 +02:00
test-bufferiszero.c
test-char.c test-char: abort on serial test error 2020-07-28 18:27:59 +04:00
test-clone-visitor.c
test-coroutine.c
test-crypto-afsplit.c
test-crypto-block.c
test-crypto-cipher.c tests: Use error_free_or_abort() where appropriate 2020-07-02 06:25:28 +02:00
test-crypto-hash.c
test-crypto-hmac.c
test-crypto-ivgen.c
test-crypto-pbkdf.c
test-crypto-secret.c test-crypto-secret: add 'secret_keyring' object tests. 2020-06-15 11:33:51 +01:00
test-crypto-tlscredsx509.c glib: use portable g_setenv() 2019-12-17 09:05:23 +01:00
test-crypto-tlssession.c glib: use portable g_setenv() 2019-12-17 09:05:23 +01:00
test-crypto-xts.c
test-cutils.c
test-hbitmap.c block/dirty-bitmap: improve _next_dirty_area API 2020-03-18 14:03:46 -04:00
test-image-locking.c
test-int128.c
test-io-channel-buffer.c
test-io-channel-command.c
test-io-channel-file.c
test-io-channel-socket.c
test-io-channel-tls.c glib: use portable g_setenv() 2019-12-17 09:05:23 +01:00
test-io-task.c tests: Use error_free_or_abort() where appropriate 2020-07-02 06:25:28 +02:00
test-iov.c
test-keyval.c test-keyval: Tighten test of trailing crap after size 2019-12-18 12:28:44 +01:00
test-logging.c tests: Use &error_abort where appropriate 2020-07-02 06:25:28 +02:00
test-mul64.c
test-opts-visitor.c
test-qapi-util.c
test-qdev-global-props.c qdev: Convert bus-less devices to qdev_realize() with Coccinelle 2020-06-15 22:06:04 +02:00
test-qdist.c
test-qemu-opts.c tests: Use &error_abort where appropriate 2020-07-02 06:25:28 +02:00
test-qga.c libqtest: Rename qmp_assert_error_class() to qmp_expect_error_and_unref() 2020-09-03 12:47:33 +02:00
test-qgraph.c meson: convert tests/qtest to meson 2020-08-21 06:30:20 -04:00
test-qht-par.c
test-qht.c
test-qmp-cmds.c qapi: Add feature flags to remaining definitions 2020-03-17 19:58:34 +01:00
test-qmp-event.c tests/test-qmp-event: Check event is actually emitted 2020-03-17 19:58:34 +01:00
test-qobject-input-visitor.c qapi: enable use of g_autoptr with QAPI types 2020-09-03 09:38:36 +02:00
test-qobject-output-visitor.c qapi: Assert output visitors see only valid enum values 2020-04-30 07:26:09 +02:00
test-rcu-list.c tests: Fix a bug with count variables 2020-03-06 10:35:15 +00:00
test-rcu-simpleq.c
test-rcu-slist.c rcu_queue: add QSLIST functions 2020-02-22 08:26:47 +00:00
test-rcu-tailq.c
test-replication.c tests: Use &error_abort where appropriate 2020-07-02 06:25:28 +02:00
test-shift128.c
test-string-input-visitor.c tests: Use &error_abort where appropriate 2020-07-02 06:25:28 +02:00
test-string-output-visitor.c tests: Use &error_abort where appropriate 2020-07-02 06:25:28 +02:00
test-thread-pool.c
test-throttle.c
test-timed-average.c
test-util-filemonitor.c test-util-filemonitor: Plug unlikely memory leak 2020-07-02 06:25:29 +02:00
test-util-sockets.c tests: fix a memory in test_socket_unix_abstract_good 2020-08-25 11:49:49 +01:00
test-uuid.c
test-visitor-serialization.c
test-vmstate.c test-vmstate: Fix memleaks in test_load_qlist 2020-02-28 09:25:49 +01:00
test-write-threshold.c
test-x86-cpuid.c Revert "hw/i386: Update structures to save the number of nodes per package" 2020-09-02 07:29:26 -04:00
test-xbzrle.c
vhost-user-bridge.c core: replace getpagesize() with qemu_real_host_page_size 2019-10-26 15:38:06 +02:00