mirror of
https://github.com/qemu/qemu.git
synced 2024-11-23 19:03:38 +08:00
c1cccad865
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
* error_append_hint(), because that doesn't work with &error_fatal.
* ERRP_GUARD() lifts these restrictions.
*
* To use ERRP_GUARD(), add it right at the beginning of the function.
* @errp can then be used without worrying about the argument being
* NULL or &error_fatal.
ERRP_GUARD() could avoid the case when @errp is &error_fatal, the user
can't see this additional information, because exit() happens in
error_setg earlier than information is added [1].
The iommufd_backend_set_fd() passes @errp to error_prepend(), to avoid
the above issue, add missing ERRP_GUARD() at the beginning of this
function.
[1]: Issue description in the commit message of commit
|
||
|---|---|---|
| .. | ||
| tpm | ||
| confidential-guest-support.c | ||
| cryptodev-builtin.c | ||
| cryptodev-hmp-cmds.c | ||
| cryptodev-lkcf.c | ||
| cryptodev-vhost-user.c | ||
| cryptodev-vhost.c | ||
| cryptodev.c | ||
| dbus-vmstate1.xml | ||
| dbus-vmstate.c | ||
| hostmem-epc.c | ||
| hostmem-file.c | ||
| hostmem-memfd.c | ||
| hostmem-ram.c | ||
| hostmem.c | ||
| iommufd.c | ||
| Kconfig | ||
| meson.build | ||
| rng-builtin.c | ||
| rng-egd.c | ||
| rng-random.c | ||
| rng.c | ||
| trace-events | ||
| trace.h | ||
| vhost-user.c | ||