qemu/hw/dataplane
Stefan Hajnoczi cd7fdfe59f dataplane: avoid reentrancy during virtio_blk_data_plane_stop()
When dataplane is stopping, the s->vdev->binding->set_host_notifier(...,
false) call can invoke the virtqueue handler if an ioeventfd
notification is pending.  This causes hw/virtio-blk.c to invoke
virtio_blk_data_plane_start() before virtio_blk_data_plane_stop()
returns!

The result is that we try to restart dataplane while trying to stop it
and the following assertion is raised:

  msix_set_mask_notifier: Assertion `!dev->msix_mask_notifier' failed.

Although the code was intended to prevent this scenario, the s->started
boolean isn't enough.  Add s->stopping so that we can postpone clearing
s->started until we've completely stopped dataplane.

This way, virtqueue handler calls during virtio_blk_data_plane_stop()
are ignored.  When dataplane is legitimately started again later we
already self-kick ourselves to resume processing.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2013-01-18 16:57:59 +01:00
..
event-poll.c dataplane: add event loop 2013-01-02 15:56:21 +01:00
event-poll.h dataplane: add event loop 2013-01-02 15:56:21 +01:00
hostmem.c
hostmem.h
ioq.c dataplane: add Linux AIO request queue 2013-01-02 15:58:03 +01:00
ioq.h dataplane: add Linux AIO request queue 2013-01-02 15:58:03 +01:00
Makefile.objs dataplane: use linux-headers/ for virtio includes 2013-01-03 07:13:25 -06:00
virtio-blk.c dataplane: avoid reentrancy during virtio_blk_data_plane_stop() 2013-01-18 16:57:59 +01:00
virtio-blk.h dataplane: add virtio-blk data plane code 2013-01-02 16:08:47 +01:00
vring.c dataplane: add virtqueue vring code 2013-01-02 15:55:47 +01:00
vring.h dataplane: add virtqueue vring code 2013-01-02 15:55:47 +01:00