mirror of
https://github.com/qemu/qemu.git
synced 2024-12-01 07:43:35 +08:00
b7aa131519
The result of openfile was not checked, leading to failure deep in the
actual command with confusing error message, and exiting with exit code 0.
Here is a simple example - trying to read with the wrong format:
$ touch file
$ qemu-io -f qcow2 -c 'read -P 1 0 1024' file; echo $?
can't open device file: Image is not in qcow2 format
no file open, try 'help open'
0
With this patch, we fail earlier with exit code 1:
$ ./qemu-io -f qcow2 -c 'read -P 1 0 1024' file; echo $?
can't open device file: Image is not in qcow2 format
1
Failing earlier, we don't log this error now:
no file open, try 'help open'
But some tests expected it; the line was removed from the test output.
Signed-off-by: Nir Soffer <nirsof@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 20170201003120.23378-2-nirsof@gmail.com
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
23 lines
786 B
Plaintext
23 lines
786 B
Plaintext
QA output created by 078
|
|
|
|
== Read from a valid image ==
|
|
read 512/512 bytes at offset 0
|
|
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
|
|
== Negative catalog size ==
|
|
can't open device TEST_DIR/empty.bochs: Catalog size is too large
|
|
|
|
== Overflow for catalog size * sizeof(uint32_t) ==
|
|
can't open device TEST_DIR/empty.bochs: Catalog size is too large
|
|
|
|
== Too small catalog bitmap for image size ==
|
|
can't open device TEST_DIR/empty.bochs: Catalog size is too small for this disk size
|
|
can't open device TEST_DIR/empty.bochs: Catalog size is too small for this disk size
|
|
|
|
== Negative extent size ==
|
|
can't open device TEST_DIR/empty.bochs: Extent size 2147483648 is too large
|
|
|
|
== Zero extent size ==
|
|
can't open device TEST_DIR/empty.bochs: Extent size must be at least 512
|
|
*** done
|