mirror of
https://github.com/qemu/qemu.git
synced 2024-12-03 16:53:53 +08:00
4c315c2766
Several devices don't survive object_unref(object_new(T)): they crash or hang during cleanup, or they leave dangling pointers behind. This breaks at least device-list-properties, because qmp_device_list_properties() needs to create a device to find its properties. Broken in commitf4eb32b
"qmp: show QOM properties in device-list-properties", v2.1. Example reproducer: $ qemu-system-aarch64 -nodefaults -display none -machine none -S -qmp stdio {"QMP": {"version": {"qemu": {"micro": 50, "minor": 4, "major": 2}, "package": ""}, "capabilities": []}} { "execute": "qmp_capabilities" } {"return": {}} { "execute": "device-list-properties", "arguments": { "typename": "pxa2xx-pcmcia" } } qemu-system-aarch64: /home/armbru/work/qemu/memory.c:1307: memory_region_finalize: Assertion `((&mr->subregions)->tqh_first == ((void *)0))' failed. Aborted (core dumped) [Exit 134 (SIGABRT)] Unfortunately, I can't fix the problems in these devices right now. Instead, add DeviceClass member cannot_destroy_with_object_finalize_yet to mark them: * Hang during cleanup (didn't debug, so I can't say why): "realview_pci", "versatile_pci". * Dangling pointer in cpus: most CPUs, plus "allwinner-a10", "digic", "fsl,imx25", "fsl,imx31", "xlnx,zynqmp", because they create such CPUs * Assert kvm_enabled(): "host-x86_64-cpu", host-i386-cpu", "host-powerpc64-cpu", "host-embedded-powerpc-cpu", "host-powerpc-cpu" (the powerpc ones can't currently reach the assertion, because the CPUs are only registered when KVM is enabled, but the assertion is arguably in the wrong place all the same) Make qmp_device_list_properties() fail cleanly when the device is so marked. This improves device-list-properties from "crashes, hangs or leaves dangling pointers behind" to "fails". Not a complete fix, just a better-than-nothing work-around. In the above reproducer, device-list-properties now fails with "Can't list properties of device 'pxa2xx-pcmcia'". This also protects -device FOO,help, which uses the same machinery since commitef52358
"qdev-monitor: include QOM properties in -device FOO, help output", v2.2. Example reproducer: $ qemu-system-aarch64 -machine none -device pxa2xx-pcmcia,help Before: qemu-system-aarch64: .../memory.c:1307: memory_region_finalize: Assertion `((&mr->subregions)->tqh_first == ((void *)0))' failed. After: Can't list properties of device 'pxa2xx-pcmcia' Cc: "Andreas Färber" <afaerber@suse.de> Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com> Cc: Alexander Graf <agraf@suse.de> Cc: Anthony Green <green@moxielogic.com> Cc: Aurelien Jarno <aurelien@aurel32.net> Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de> Cc: Blue Swirl <blauwirbel@gmail.com> Cc: Eduardo Habkost <ehabkost@redhat.com> Cc: Guan Xuetao <gxt@mprc.pku.edu.cn> Cc: Jia Liu <proljc@gmail.com> Cc: Leon Alrae <leon.alrae@imgtec.com> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Cc: Max Filippov <jcmvbkbc@gmail.com> Cc: Michael Walle <michael@walle.cc> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Peter Maydell <peter.maydell@linaro.org> Cc: Richard Henderson <rth@twiddle.net> Cc: qemu-ppc@nongnu.org Cc: qemu-stable@nongnu.org Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <1443689999-12182-10-git-send-email-armbru@redhat.com>
183 lines
5.7 KiB
C
183 lines
5.7 KiB
C
/*
|
|
* QEMU Xtensa CPU
|
|
*
|
|
* Copyright (c) 2011, Max Filippov, Open Source and Linux Lab.
|
|
* Copyright (c) 2012 SUSE LINUX Products GmbH
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* * Neither the name of the Open Source and Linux Lab nor the
|
|
* names of its contributors may be used to endorse or promote products
|
|
* derived from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
|
|
* DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
|
|
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
|
|
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
|
|
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
|
|
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "cpu.h"
|
|
#include "qemu-common.h"
|
|
#include "migration/vmstate.h"
|
|
|
|
|
|
static void xtensa_cpu_set_pc(CPUState *cs, vaddr value)
|
|
{
|
|
XtensaCPU *cpu = XTENSA_CPU(cs);
|
|
|
|
cpu->env.pc = value;
|
|
}
|
|
|
|
static bool xtensa_cpu_has_work(CPUState *cs)
|
|
{
|
|
XtensaCPU *cpu = XTENSA_CPU(cs);
|
|
|
|
return cpu->env.pending_irq_level;
|
|
}
|
|
|
|
/* CPUClass::reset() */
|
|
static void xtensa_cpu_reset(CPUState *s)
|
|
{
|
|
XtensaCPU *cpu = XTENSA_CPU(s);
|
|
XtensaCPUClass *xcc = XTENSA_CPU_GET_CLASS(cpu);
|
|
CPUXtensaState *env = &cpu->env;
|
|
|
|
xcc->parent_reset(s);
|
|
|
|
env->exception_taken = 0;
|
|
env->pc = env->config->exception_vector[EXC_RESET];
|
|
env->sregs[LITBASE] &= ~1;
|
|
env->sregs[PS] = xtensa_option_enabled(env->config,
|
|
XTENSA_OPTION_INTERRUPT) ? 0x1f : 0x10;
|
|
env->sregs[VECBASE] = env->config->vecbase;
|
|
env->sregs[IBREAKENABLE] = 0;
|
|
env->sregs[CACHEATTR] = 0x22222222;
|
|
env->sregs[ATOMCTL] = xtensa_option_enabled(env->config,
|
|
XTENSA_OPTION_ATOMCTL) ? 0x28 : 0x15;
|
|
env->sregs[CONFIGID0] = env->config->configid[0];
|
|
env->sregs[CONFIGID1] = env->config->configid[1];
|
|
|
|
env->pending_irq_level = 0;
|
|
reset_mmu(env);
|
|
}
|
|
|
|
static ObjectClass *xtensa_cpu_class_by_name(const char *cpu_model)
|
|
{
|
|
ObjectClass *oc;
|
|
char *typename;
|
|
|
|
if (cpu_model == NULL) {
|
|
return NULL;
|
|
}
|
|
|
|
typename = g_strdup_printf("%s-" TYPE_XTENSA_CPU, cpu_model);
|
|
oc = object_class_by_name(typename);
|
|
g_free(typename);
|
|
if (oc == NULL || !object_class_dynamic_cast(oc, TYPE_XTENSA_CPU) ||
|
|
object_class_is_abstract(oc)) {
|
|
return NULL;
|
|
}
|
|
return oc;
|
|
}
|
|
|
|
static void xtensa_cpu_realizefn(DeviceState *dev, Error **errp)
|
|
{
|
|
CPUState *cs = CPU(dev);
|
|
XtensaCPUClass *xcc = XTENSA_CPU_GET_CLASS(dev);
|
|
|
|
cs->gdb_num_regs = xcc->config->gdb_regmap.num_regs;
|
|
|
|
qemu_init_vcpu(cs);
|
|
|
|
xcc->parent_realize(dev, errp);
|
|
}
|
|
|
|
static void xtensa_cpu_initfn(Object *obj)
|
|
{
|
|
CPUState *cs = CPU(obj);
|
|
XtensaCPU *cpu = XTENSA_CPU(obj);
|
|
XtensaCPUClass *xcc = XTENSA_CPU_GET_CLASS(obj);
|
|
CPUXtensaState *env = &cpu->env;
|
|
static bool tcg_inited;
|
|
|
|
cs->env_ptr = env;
|
|
env->config = xcc->config;
|
|
cpu_exec_init(cs, &error_abort);
|
|
|
|
if (tcg_enabled() && !tcg_inited) {
|
|
tcg_inited = true;
|
|
xtensa_translate_init();
|
|
}
|
|
}
|
|
|
|
static const VMStateDescription vmstate_xtensa_cpu = {
|
|
.name = "cpu",
|
|
.unmigratable = 1,
|
|
};
|
|
|
|
static void xtensa_cpu_class_init(ObjectClass *oc, void *data)
|
|
{
|
|
DeviceClass *dc = DEVICE_CLASS(oc);
|
|
CPUClass *cc = CPU_CLASS(oc);
|
|
XtensaCPUClass *xcc = XTENSA_CPU_CLASS(cc);
|
|
|
|
xcc->parent_realize = dc->realize;
|
|
dc->realize = xtensa_cpu_realizefn;
|
|
|
|
xcc->parent_reset = cc->reset;
|
|
cc->reset = xtensa_cpu_reset;
|
|
|
|
cc->class_by_name = xtensa_cpu_class_by_name;
|
|
cc->has_work = xtensa_cpu_has_work;
|
|
cc->do_interrupt = xtensa_cpu_do_interrupt;
|
|
cc->cpu_exec_interrupt = xtensa_cpu_exec_interrupt;
|
|
cc->dump_state = xtensa_cpu_dump_state;
|
|
cc->set_pc = xtensa_cpu_set_pc;
|
|
cc->gdb_read_register = xtensa_cpu_gdb_read_register;
|
|
cc->gdb_write_register = xtensa_cpu_gdb_write_register;
|
|
cc->gdb_stop_before_watchpoint = true;
|
|
#ifndef CONFIG_USER_ONLY
|
|
cc->do_unaligned_access = xtensa_cpu_do_unaligned_access;
|
|
cc->get_phys_page_debug = xtensa_cpu_get_phys_page_debug;
|
|
cc->do_unassigned_access = xtensa_cpu_do_unassigned_access;
|
|
#endif
|
|
cc->debug_excp_handler = xtensa_breakpoint_handler;
|
|
dc->vmsd = &vmstate_xtensa_cpu;
|
|
|
|
/*
|
|
* Reason: xtensa_cpu_initfn() calls cpu_exec_init(), which saves
|
|
* the object in cpus -> dangling pointer after final
|
|
* object_unref().
|
|
*/
|
|
dc->cannot_destroy_with_object_finalize_yet = true;
|
|
}
|
|
|
|
static const TypeInfo xtensa_cpu_type_info = {
|
|
.name = TYPE_XTENSA_CPU,
|
|
.parent = TYPE_CPU,
|
|
.instance_size = sizeof(XtensaCPU),
|
|
.instance_init = xtensa_cpu_initfn,
|
|
.abstract = true,
|
|
.class_size = sizeof(XtensaCPUClass),
|
|
.class_init = xtensa_cpu_class_init,
|
|
};
|
|
|
|
static void xtensa_cpu_register_types(void)
|
|
{
|
|
type_register_static(&xtensa_cpu_type_info);
|
|
}
|
|
|
|
type_init(xtensa_cpu_register_types)
|