Mikhail Sennikovsky 7788c3f2e2 virtio-net: prevent offloads reset on migration ... Currently offloads disabled by guest via the VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET command are not preserved on VM migration. Instead all offloads reported by guest features (via VIRTIO_PCI_GUEST_FEATURES) get enabled. What happens is: first the VirtIONet::curr_guest_offloads gets restored and offloads are getting set correctly: #0 qemu_set_offload (nc=0x555556a11400, csum=1, tso4=0, tso6=0, ecn=0, ufo=0) at net/net.c:474 #1 virtio_net_apply_guest_offloads (n=0x555557701ca0) at hw/net/virtio-net.c:720 #2 virtio_net_post_load_device (opaque=0x555557701ca0, version_id=11) at hw/net/virtio-net.c:2334 #3 vmstate_load_state (f=0x5555569dc010, vmsd=0x555556577c80 <vmstate_virtio_net_device>, opaque=0x555557701ca0, version_id=11) at migration/vmstate.c:168 #4 virtio_load (vdev=0x555557701ca0, f=0x5555569dc010, version_id=11) at hw/virtio/virtio.c:2197 #5 virtio_device_get (f=0x5555569dc010, opaque=0x555557701ca0, size=0, field=0x55555668cd00 <__compound_literal.5>) at hw/virtio/virtio.c:2036 #6 vmstate_load_state (f=0x5555569dc010, vmsd=0x555556577ce0 <vmstate_virtio_net>, opaque=0x555557701ca0, version_id=11) at migration/vmstate.c:143 #7 vmstate_load (f=0x5555569dc010, se=0x5555578189e0) at migration/savevm.c:829 #8 qemu_loadvm_section_start_full (f=0x5555569dc010, mis=0x5555569eee20) at migration/savevm.c:2211 #9 qemu_loadvm_state_main (f=0x5555569dc010, mis=0x5555569eee20) at migration/savevm.c:2395 #10 qemu_loadvm_state (f=0x5555569dc010) at migration/savevm.c:2467 #11 process_incoming_migration_co (opaque=0x0) at migration/migration.c:449 However later on the features are getting restored, and offloads get reset to everything supported by features: #0 qemu_set_offload (nc=0x555556a11400, csum=1, tso4=1, tso6=1, ecn=0, ufo=0) at net/net.c:474 #1 virtio_net_apply_guest_offloads (n=0x555557701ca0) at hw/net/virtio-net.c:720 #2 virtio_net_set_features (vdev=0x555557701ca0, features=5104441767) at hw/net/virtio-net.c:773 #3 virtio_set_features_nocheck (vdev=0x555557701ca0, val=5104441767) at hw/virtio/virtio.c:2052 #4 virtio_load (vdev=0x555557701ca0, f=0x5555569dc010, version_id=11) at hw/virtio/virtio.c:2220 #5 virtio_device_get (f=0x5555569dc010, opaque=0x555557701ca0, size=0, field=0x55555668cd00 <__compound_literal.5>) at hw/virtio/virtio.c:2036 #6 vmstate_load_state (f=0x5555569dc010, vmsd=0x555556577ce0 <vmstate_virtio_net>, opaque=0x555557701ca0, version_id=11) at migration/vmstate.c:143 #7 vmstate_load (f=0x5555569dc010, se=0x5555578189e0) at migration/savevm.c:829 #8 qemu_loadvm_section_start_full (f=0x5555569dc010, mis=0x5555569eee20) at migration/savevm.c:2211 #9 qemu_loadvm_state_main (f=0x5555569dc010, mis=0x5555569eee20) at migration/savevm.c:2395 #10 qemu_loadvm_state (f=0x5555569dc010) at migration/savevm.c:2467 #11 process_incoming_migration_co (opaque=0x0) at migration/migration.c:449 Fix this by preserving the state in saved_guest_offloads field and pushing out offload initialization to the new post load hook. Cc: qemu-stable@nongnu.org Signed-off-by: Mikhail Sennikovsky <mikhail.sennikovskii@cloud.ionos.com> Signed-off-by: Jason Wang <jasowang@redhat.com>		2019-10-29 10:28:07 +08:00
..
authz	Include generated QAPI headers less	2019-08-16 13:31:51 +02:00
block	qcow2-bitmap: move bitmap reopen-rw code to qcow2_reopen_commit	2019-10-17 17:53:28 -04:00
chardev	Include qemu/main-loop.h less	2019-08-16 13:31:52 +02:00
crypto	crypto: define cleanup functions for use with g_autoptr	2019-08-22 10:47:12 +01:00
disas	include: Make headers more self-contained	2019-08-16 13:31:51 +02:00
exec	Migration pull 2019-10-11	2019-10-14 16:09:52 +01:00
fpu	fpu: make softfloat-macros "self-contained"	2019-08-19 12:07:13 +01:00
hw	virtio-net: prevent offloads reset on migration	2019-10-29 10:28:07 +08:00
io	socket: Add num connections to qio_net_listener_open_sync()	2019-09-03 23:24:42 +02:00
libdecnumber	include: Make headers more self-contained	2019-08-16 13:31:51 +02:00
migration	migration: Support gtree migration	2019-10-11 17:52:31 +01:00
monitor	Include hw/qdev-properties.h less	2019-08-16 13:31:53 +02:00
net	Include qemu/queue.h slightly less	2019-08-16 13:31:52 +02:00
qapi	qapi: Make visit_next_list()'s comment less confusing	2019-09-24 11:03:44 +02:00
qemu	coroutine: Add qemu_co_mutex_assert_locked()	2019-10-25 15:18:38 +02:00
qom	vl: Split off user_creatable_print_help()	2019-10-14 17:12:48 +02:00
scsi	scsi: explicitly list guest-recoverable sense codes	2019-07-15 11:20:42 +02:00
standard-headers	linux headers: update against v5.4-rc1	2019-10-15 18:09:02 +01:00
sysemu	replay: add BH oneshot event for block layer	2019-10-14 17:12:48 +02:00
ui	ui/egl: fix framebuffer reads	2019-09-17 13:42:02 +02:00
elf.h	linux-user: elf: ELF_HWCAP for s390x	2019-06-07 14:53:26 +02:00
glib-compat.h	glib: bump min required glib library version to 2.48	2019-08-22 10:46:34 +01:00
qemu-common.h	cutils: Move size_to_str() from "qemu-common.h" to "qemu/cutils.h"	2019-09-19 11:57:34 +02:00
qemu-io.h	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
trace-tcg.h	trace: get rid of generated-events.h/generated-events.c	2016-10-12 09:54:52 +02:00