Eduardo Habkost e90f2a8c3e qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable ... cannot_instantiate_with_device_add_yet was introduced by commit efec3dd631 to replace no_user. It was supposed to be a temporary measure. When it was introduced, we had 54 cannot_instantiate_with_device_add_yet=true lines in the code. Today (3 years later) this number has not shrunk: we now have 57 cannot_instantiate_with_device_add_yet=true lines. I think it is safe to say it is not a temporary measure, and we won't see the flag go away soon. Instead of a long field name that misleads people to believe it is temporary, replace it a shorter and less misleading field: user_creatable. Except for code comments, changes were generated using the following Coccinelle patch: @@ expression DC; @@ ( -DC->cannot_instantiate_with_device_add_yet = false; +DC->user_creatable = true; | -DC->cannot_instantiate_with_device_add_yet = true; +DC->user_creatable = false; ) @@ typedef ObjectClass; expression dc; identifier class, data; @@ static void device_class_init(ObjectClass *class, void *data) { ... dc->hotpluggable = true; +dc->user_creatable = true; ... } @@ @@ struct DeviceClass { ... -bool cannot_instantiate_with_device_add_yet; +bool user_creatable; ... } @@ expression DC; @@ ( -!DC->cannot_instantiate_with_device_add_yet +DC->user_creatable | -DC->cannot_instantiate_with_device_add_yet +!DC->user_creatable ) Cc: Alistair Francis <alistair.francis@xilinx.com> Cc: Laszlo Ersek <lersek@redhat.com> Cc: Marcel Apfelbaum <marcel@redhat.com> Cc: Markus Armbruster <armbru@redhat.com> Cc: Peter Maydell <peter.maydell@linaro.org> Cc: Thomas Huth <thuth@redhat.com> Acked-by: Alistair Francis <alistair.francis@xilinx.com> Reviewed-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com> Acked-by: Marcel Apfelbaum <marcel@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <20170503203604.31462-2-ehabkost@redhat.com> [ehabkost: kept "TODO remove once we're there" comment] Reviewed-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>		2017-05-17 10:37:00 -03:00
..
addr.c	mips: Clean up includes	2016-01-23 14:30:04 +00:00
boston.c	hw/mips: MIPS Boston board support	2017-02-24 10:37:21 +00:00
cps.c	error: Strip trailing '\n' from error string arguments (again)	2016-08-08 09:00:44 +02:00
cputimer.c	mips: use MIPSCPU instead of CPUMIPSState	2016-05-19 16:42:27 +02:00
gt64xxx_pci.c	qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable	2017-05-17 10:37:00 -03:00
Makefile.objs	hw/mips: MIPS Boston board support	2017-02-24 10:37:21 +00:00
mips_fulong2e.c	hw: Default -drive to if=ide explicitly where it works	2017-02-21 13:10:53 +01:00
mips_int.c	mips: use MIPSCPU instead of CPUMIPSState	2016-05-19 16:42:27 +02:00
mips_jazz.c	hw: Drop superfluous special checks for orphaned -drive	2017-02-21 13:17:45 +01:00
mips_malta.c	hw: Default -drive to if=ide explicitly where it works	2017-02-21 13:10:53 +01:00
mips_mipssim.c	mips: use MIPSCPU instead of CPUMIPSState	2016-05-19 16:42:27 +02:00
mips_r4k.c	hw: Default -drive to if=ide explicitly where it works	2017-02-21 13:10:53 +01:00