mirror of
https://github.com/qemu/qemu.git
synced 2024-12-13 22:43:32 +08:00
df3c286c53
Commit9af9e0f,6daf194d,be62a2eband312fd5fgot rid of a bunch, but they keep coming back. checkpatch.pl tries to flag them since commit5d596c2, but it's not very good at it. Offenders tracked down with Coccinelle script scripts/coccinelle/err-bad-newline.cocci, an updated version of the script from commit312fd5f. Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <1470224274-31522-2-git-send-email-armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com>
30 lines
601 B
Plaintext
30 lines
601 B
Plaintext
// Error messages should not contain newlines. This script finds
|
|
// messages that do. Fixing them is manual.
|
|
@r@
|
|
expression errp, eno, cls, fmt;
|
|
position p;
|
|
@@
|
|
(
|
|
error_report(fmt, ...)@p
|
|
|
|
|
error_setg(errp, fmt, ...)@p
|
|
|
|
|
error_setg_errno(errp, eno, fmt, ...)@p
|
|
|
|
|
error_setg_win32(errp, eno, cls, fmt, ...)@p
|
|
|
|
|
error_prepend(errp, fmt, ...)@p
|
|
|
|
|
error_setg_file_open(errp, eno, cls, fmt, ...)@p
|
|
|
|
|
error_reportf_err(errp, fmt, ...)@p
|
|
|
|
|
error_set(errp, cls, fmt, ...)@p
|
|
)
|
|
@script:python@
|
|
fmt << r.fmt;
|
|
p << r.p;
|
|
@@
|
|
if "\\n" in str(fmt):
|
|
print "%s:%s:%s:%s" % (p[0].file, p[0].line, p[0].column, fmt)
|