mirror of
https://github.com/qemu/qemu.git
synced 2024-12-14 15:03:33 +08:00
562a7d23bf
Commit69e1c14aa2
("virtio: core: vq reset feature negotation support") enabled VIRTIO_F_RING_RESET by default for all virtio devices. This feature is not currently emulated by QEMU, so for vhost and vhost-user devices we need to make sure it is supported by the offloaded device emulation (in-kernel or in another process). To do this we need to add VIRTIO_F_RING_RESET to the features bitmap passed to vhost_get_features(). This way it will be masked if the device does not support it. This issue was initially discovered with vhost-vsock and vhost-user-vsock, and then also tested with vhost-user-rng which confirmed the same issue. They fail when sending features through VHOST_SET_FEATURES ioctl or VHOST_USER_SET_FEATURES message, since VIRTIO_F_RING_RESET is negotiated by the guest (Linux >= v6.0), but not supported by the device. Fixes:69e1c14aa2
("virtio: core: vq reset feature negotation support") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1318 Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> Message-Id: <20221121101101.29400-1-sgarzare@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Acked-by: Raphael Norwitz <raphael.norwitz@nutanix.com> Acked-by: Jason Wang <jasowang@redhat.com>
241 lines
7.2 KiB
C
241 lines
7.2 KiB
C
/*
|
|
* vhost-user-scsi host device
|
|
*
|
|
* Copyright (c) 2016 Nutanix Inc. All rights reserved.
|
|
*
|
|
* Author:
|
|
* Felipe Franciosi <felipe@nutanix.com>
|
|
*
|
|
* This work is largely based on the "vhost-scsi" implementation by:
|
|
* Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
|
|
* Nicholas Bellinger <nab@risingtidesystems.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU LGPL, version 2 or later.
|
|
* See the COPYING.LIB file in the top-level directory.
|
|
*
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qapi/error.h"
|
|
#include "qemu/error-report.h"
|
|
#include "hw/fw-path-provider.h"
|
|
#include "hw/qdev-core.h"
|
|
#include "hw/qdev-properties.h"
|
|
#include "hw/qdev-properties-system.h"
|
|
#include "hw/virtio/vhost.h"
|
|
#include "hw/virtio/vhost-backend.h"
|
|
#include "hw/virtio/vhost-user-scsi.h"
|
|
#include "hw/virtio/virtio.h"
|
|
#include "hw/virtio/virtio-access.h"
|
|
#include "chardev/char-fe.h"
|
|
#include "sysemu/sysemu.h"
|
|
|
|
/* Features supported by the host application */
|
|
static const int user_feature_bits[] = {
|
|
VIRTIO_F_NOTIFY_ON_EMPTY,
|
|
VIRTIO_RING_F_INDIRECT_DESC,
|
|
VIRTIO_RING_F_EVENT_IDX,
|
|
VIRTIO_SCSI_F_HOTPLUG,
|
|
VIRTIO_F_RING_RESET,
|
|
VHOST_INVALID_FEATURE_BIT
|
|
};
|
|
|
|
enum VhostUserProtocolFeature {
|
|
VHOST_USER_PROTOCOL_F_RESET_DEVICE = 13,
|
|
};
|
|
|
|
static void vhost_user_scsi_set_status(VirtIODevice *vdev, uint8_t status)
|
|
{
|
|
VHostUserSCSI *s = (VHostUserSCSI *)vdev;
|
|
VHostSCSICommon *vsc = VHOST_SCSI_COMMON(s);
|
|
bool start = (status & VIRTIO_CONFIG_S_DRIVER_OK) && vdev->vm_running;
|
|
|
|
if (vhost_dev_is_started(&vsc->dev) == start) {
|
|
return;
|
|
}
|
|
|
|
if (start) {
|
|
int ret;
|
|
|
|
ret = vhost_scsi_common_start(vsc);
|
|
if (ret < 0) {
|
|
error_report("unable to start vhost-user-scsi: %s", strerror(-ret));
|
|
exit(1);
|
|
}
|
|
} else {
|
|
vhost_scsi_common_stop(vsc);
|
|
}
|
|
}
|
|
|
|
static void vhost_user_scsi_reset(VirtIODevice *vdev)
|
|
{
|
|
VHostSCSICommon *vsc = VHOST_SCSI_COMMON(vdev);
|
|
struct vhost_dev *dev = &vsc->dev;
|
|
|
|
/*
|
|
* Historically, reset was not implemented so only reset devices
|
|
* that are expecting it.
|
|
*/
|
|
if (!virtio_has_feature(dev->protocol_features,
|
|
VHOST_USER_PROTOCOL_F_RESET_DEVICE)) {
|
|
return;
|
|
}
|
|
|
|
if (dev->vhost_ops->vhost_reset_device) {
|
|
dev->vhost_ops->vhost_reset_device(dev);
|
|
}
|
|
}
|
|
|
|
static void vhost_dummy_handle_output(VirtIODevice *vdev, VirtQueue *vq)
|
|
{
|
|
}
|
|
|
|
static void vhost_user_scsi_realize(DeviceState *dev, Error **errp)
|
|
{
|
|
VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(dev);
|
|
VHostUserSCSI *s = VHOST_USER_SCSI(dev);
|
|
VHostSCSICommon *vsc = VHOST_SCSI_COMMON(s);
|
|
struct vhost_virtqueue *vqs = NULL;
|
|
Error *err = NULL;
|
|
int ret;
|
|
|
|
if (!vs->conf.chardev.chr) {
|
|
error_setg(errp, "vhost-user-scsi: missing chardev");
|
|
return;
|
|
}
|
|
|
|
virtio_scsi_common_realize(dev, vhost_dummy_handle_output,
|
|
vhost_dummy_handle_output,
|
|
vhost_dummy_handle_output, &err);
|
|
if (err != NULL) {
|
|
error_propagate(errp, err);
|
|
return;
|
|
}
|
|
|
|
if (!vhost_user_init(&s->vhost_user, &vs->conf.chardev, errp)) {
|
|
goto free_virtio;
|
|
}
|
|
|
|
vsc->dev.nvqs = VIRTIO_SCSI_VQ_NUM_FIXED + vs->conf.num_queues;
|
|
vsc->dev.vqs = g_new0(struct vhost_virtqueue, vsc->dev.nvqs);
|
|
vsc->dev.vq_index = 0;
|
|
vsc->dev.backend_features = 0;
|
|
vqs = vsc->dev.vqs;
|
|
|
|
ret = vhost_dev_init(&vsc->dev, &s->vhost_user,
|
|
VHOST_BACKEND_TYPE_USER, 0, errp);
|
|
if (ret < 0) {
|
|
goto free_vhost;
|
|
}
|
|
|
|
/* Channel and lun both are 0 for bootable vhost-user-scsi disk */
|
|
vsc->channel = 0;
|
|
vsc->lun = 0;
|
|
vsc->target = vs->conf.boot_tpgt;
|
|
|
|
return;
|
|
|
|
free_vhost:
|
|
vhost_user_cleanup(&s->vhost_user);
|
|
g_free(vqs);
|
|
free_virtio:
|
|
virtio_scsi_common_unrealize(dev);
|
|
}
|
|
|
|
static void vhost_user_scsi_unrealize(DeviceState *dev)
|
|
{
|
|
VirtIODevice *vdev = VIRTIO_DEVICE(dev);
|
|
VHostUserSCSI *s = VHOST_USER_SCSI(dev);
|
|
VHostSCSICommon *vsc = VHOST_SCSI_COMMON(s);
|
|
struct vhost_virtqueue *vqs = vsc->dev.vqs;
|
|
|
|
/* This will stop the vhost backend. */
|
|
vhost_user_scsi_set_status(vdev, 0);
|
|
|
|
vhost_dev_cleanup(&vsc->dev);
|
|
g_free(vqs);
|
|
|
|
virtio_scsi_common_unrealize(dev);
|
|
vhost_user_cleanup(&s->vhost_user);
|
|
}
|
|
|
|
static Property vhost_user_scsi_properties[] = {
|
|
DEFINE_PROP_CHR("chardev", VirtIOSCSICommon, conf.chardev),
|
|
DEFINE_PROP_UINT32("boot_tpgt", VirtIOSCSICommon, conf.boot_tpgt, 0),
|
|
DEFINE_PROP_UINT32("num_queues", VirtIOSCSICommon, conf.num_queues,
|
|
VIRTIO_SCSI_AUTO_NUM_QUEUES),
|
|
DEFINE_PROP_UINT32("virtqueue_size", VirtIOSCSICommon, conf.virtqueue_size,
|
|
128),
|
|
DEFINE_PROP_UINT32("max_sectors", VirtIOSCSICommon, conf.max_sectors,
|
|
0xFFFF),
|
|
DEFINE_PROP_UINT32("cmd_per_lun", VirtIOSCSICommon, conf.cmd_per_lun, 128),
|
|
DEFINE_PROP_BIT64("hotplug", VHostSCSICommon, host_features,
|
|
VIRTIO_SCSI_F_HOTPLUG,
|
|
true),
|
|
DEFINE_PROP_BIT64("param_change", VHostSCSICommon, host_features,
|
|
VIRTIO_SCSI_F_CHANGE,
|
|
true),
|
|
DEFINE_PROP_BIT64("t10_pi", VHostSCSICommon, host_features,
|
|
VIRTIO_SCSI_F_T10_PI,
|
|
false),
|
|
DEFINE_PROP_END_OF_LIST(),
|
|
};
|
|
|
|
static const VMStateDescription vmstate_vhost_scsi = {
|
|
.name = "virtio-scsi",
|
|
.minimum_version_id = 1,
|
|
.version_id = 1,
|
|
.fields = (VMStateField[]) {
|
|
VMSTATE_VIRTIO_DEVICE,
|
|
VMSTATE_END_OF_LIST()
|
|
},
|
|
};
|
|
|
|
static void vhost_user_scsi_class_init(ObjectClass *klass, void *data)
|
|
{
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
VirtioDeviceClass *vdc = VIRTIO_DEVICE_CLASS(klass);
|
|
FWPathProviderClass *fwc = FW_PATH_PROVIDER_CLASS(klass);
|
|
|
|
device_class_set_props(dc, vhost_user_scsi_properties);
|
|
dc->vmsd = &vmstate_vhost_scsi;
|
|
set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
|
|
vdc->realize = vhost_user_scsi_realize;
|
|
vdc->unrealize = vhost_user_scsi_unrealize;
|
|
vdc->get_features = vhost_scsi_common_get_features;
|
|
vdc->set_config = vhost_scsi_common_set_config;
|
|
vdc->set_status = vhost_user_scsi_set_status;
|
|
vdc->reset = vhost_user_scsi_reset;
|
|
fwc->get_dev_path = vhost_scsi_common_get_fw_dev_path;
|
|
}
|
|
|
|
static void vhost_user_scsi_instance_init(Object *obj)
|
|
{
|
|
VHostSCSICommon *vsc = VHOST_SCSI_COMMON(obj);
|
|
|
|
vsc->feature_bits = user_feature_bits;
|
|
|
|
/* Add the bootindex property for this object */
|
|
device_add_bootindex_property(obj, &vsc->bootindex, "bootindex", NULL,
|
|
DEVICE(vsc));
|
|
}
|
|
|
|
static const TypeInfo vhost_user_scsi_info = {
|
|
.name = TYPE_VHOST_USER_SCSI,
|
|
.parent = TYPE_VHOST_SCSI_COMMON,
|
|
.instance_size = sizeof(VHostUserSCSI),
|
|
.class_init = vhost_user_scsi_class_init,
|
|
.instance_init = vhost_user_scsi_instance_init,
|
|
.interfaces = (InterfaceInfo[]) {
|
|
{ TYPE_FW_PATH_PROVIDER },
|
|
{ }
|
|
},
|
|
};
|
|
|
|
static void virtio_register_types(void)
|
|
{
|
|
type_register_static(&vhost_user_scsi_info);
|
|
}
|
|
|
|
type_init(virtio_register_types)
|