Paolo Bonzini 0b8b8753e4 coroutine: move entry argument to qemu_coroutine_create ... In practice the entry argument is always known at creation time, and it is confusing that sometimes qemu_coroutine_enter is used with a non-NULL argument to re-enter a coroutine (this happens in block/sheepdog.c and tests/test-coroutine.c). So pass the opaque value at creation time, for consistency with e.g. aio_bh_new. Mostly done with the following semantic patch: @ entry1 @ expression entry, arg, co; @@ - co = qemu_coroutine_create(entry); + co = qemu_coroutine_create(entry, arg); ... - qemu_coroutine_enter(co, arg); + qemu_coroutine_enter(co); @ entry2 @ expression entry, arg; identifier co; @@ - Coroutine *co = qemu_coroutine_create(entry); + Coroutine *co = qemu_coroutine_create(entry, arg); ... - qemu_coroutine_enter(co, arg); + qemu_coroutine_enter(co); @ entry3 @ expression entry, arg; @@ - qemu_coroutine_enter(qemu_coroutine_create(entry), arg); + qemu_coroutine_enter(qemu_coroutine_create(entry, arg)); @ reentry @ expression co; @@ - qemu_coroutine_enter(co, NULL); + qemu_coroutine_enter(co); except for the aforementioned few places where the semantic patch stumbled (as expected) and for test_co_queue, which would otherwise produce an uninitialized variable warning. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Fam Zheng <famz@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>		2016-07-13 13:26:02 +02:00
..
client.c	nbd/client.c: Correct trace format string	2016-06-17 15:05:55 +01:00
common.c	nbd: do not hang nbd_wr_syncv if outside a coroutine and no available data	2016-04-08 00:07:44 +02:00
Makefile.objs	nbd: Split nbd.c	2016-01-15 18:58:02 +01:00
nbd-internal.h	qemu-common: stop including qemu/bswap.h from qemu-common.h	2016-05-19 16:42:28 +02:00
server.c	coroutine: move entry argument to qemu_coroutine_create	2016-07-13 13:26:02 +02:00