Hanna Czenczek 37dfcba1a0 migration: Ensure vmstate_save() sets errp ... migration/savevm.c contains some calls to vmstate_save() that are followed by migrate_set_error() if the integer return value indicates an error. migrate_set_error() requires that the `Error *` object passed to it is set. Therefore, vmstate_save() is assumed to always set *errp on error. Right now, that assumption is not met: vmstate_save_state_v() (called internally by vmstate_save()) will not set *errp if vmstate_subsection_save() or vmsd->post_save() fail. Fix that by adding an *errp parameter to vmstate_subsection_save(), and by generating a generic error in case post_save() fails (as is already done for pre_save()). Without this patch, qemu will crash after vmstate_subsection_save() or post_save() have failed inside of a vmstate_save() call (unless migrate_set_error() then happen to discard the new error because s->error is already set). This happens e.g. when receiving the state from a virtio-fs back-end (virtiofsd) fails. Signed-off-by: Hanna Czenczek <hreitz@redhat.com> Link: https://lore.kernel.org/r/20241015170437.310358-1-hreitz@redhat.com Signed-off-by: Peter Xu <peterx@redhat.com>		2024-10-31 15:48:18 -04:00
..
block-dirty-bitmap.c	migration: Add Error** argument to add_bitmaps_to_list()	2024-04-23 18:36:01 -04:00
channel-block.c	io: follow coroutine AioContext in qio_channel_yield()	2023-09-07 20:32:11 -05:00
channel-block.h	migration: introduce a QIOChannel impl for BlockDriverState VMState	2022-06-22 19:33:43 +01:00
channel.c	migration: Fix migration_channel_read_peek() error path	2024-01-04 09:52:42 +08:00
channel.h	migration: check magic value for deciding the mapping of channels	2023-02-06 19:22:57 +01:00
colo-failover.c	migration/colo: Improve an x-colo-lost-heartbeat error message	2023-02-23 14:10:17 +01:00
colo-stubs.c	migration/colo: make colo_incoming_co() return void	2024-05-22 17:34:31 -03:00
colo.c	migration: Put thread names together with macros	2024-10-31 15:48:18 -04:00
dirtyrate.c	migration: Put thread names together with macros	2024-10-31 15:48:18 -04:00
dirtyrate.h	migration/calc-dirty-rate: millisecond-granularity period	2023-10-10 08:03:50 +08:00
exec.c	migration: simplify exec migration functions	2024-03-04 07:12:40 +01:00
exec.h	migration: convert exec backend to accept MigrateAddress.	2023-11-02 11:35:04 +01:00
fd.c	migration: Deprecate fd: for file migration	2024-05-08 09:20:59 -03:00
fd.h	migration: Revert mapped-ram multifd support to fd: URI	2024-03-22 12:12:08 -04:00
file.c	migration/multifd: Pass in MultiFDPages_t to file_write_ramblock_iov	2024-09-03 16:24:35 -03:00
file.h	migration/multifd: Pass in MultiFDPages_t to file_write_ramblock_iov	2024-09-03 16:24:35 -03:00
global_state.c	migration 1st pull for 9.0	2024-01-05 13:35:25 +00:00
meson.build	migration: Introduce 'qatzip' compression method	2024-09-09 10:55:40 -04:00
migration-hmp-cmds.c	migration: replace assert(0) with g_assert_not_reached()	2024-09-24 13:53:35 +02:00
migration-stats.c	migration: migration_rate_limit_reset() don't need the QEMUFile	2023-10-31 08:44:33 +01:00
migration-stats.h	migration: Remove transferred atomic counter	2023-10-31 08:44:33 +01:00
migration.c	migration: Put thread names together with macros	2024-10-31 15:48:18 -04:00
migration.h	migration: Put thread names together with macros	2024-10-31 15:48:18 -04:00
multifd-nocomp.c	migration/multifd: Ensure packet->ramblock is null-terminated	2024-10-08 15:28:55 -04:00
multifd-qatzip.c	migration/multifd: Fix build for qatzip	2024-09-17 17:50:45 -04:00
multifd-qpl.c	migration/multifd: fix build error when qpl compression is enabled	2024-10-09 08:30:53 -04:00
multifd-uadk.c	migration/multifd: Fix p->iov leak in multifd-uadk.c	2024-09-03 16:24:36 -03:00
multifd-zero-page.c	migration/multifd: Move pages accounting into multifd_send_zero_page_detect()	2024-09-03 16:24:35 -03:00
multifd-zlib.c	migration/multifd: Make MultiFDMethods const	2024-09-03 16:24:36 -03:00
multifd-zstd.c	migration/multifd: Fix loop conditions in multifd_zstd_send_prepare and multifd_zstd_recv	2024-09-18 14:27:24 -04:00
multifd.c	migration: Put thread names together with macros	2024-10-31 15:48:18 -04:00
multifd.h	migration: Introduce 'qatzip' compression method	2024-09-09 10:55:40 -04:00
options.c	migration: Deprecate zero-blocks capability	2024-10-08 15:28:55 -04:00
options.h	migration: Remove unused migrate_zero_blocks	2024-10-08 15:28:55 -04:00
page_cache.c	migration: Fix cache_init()'s "Failed to allocate" error messages	2021-02-08 11:19:51 +00:00
page_cache.h	migration: Clean up signed vs. unsigned XBZRLE cache-size	2021-02-08 11:19:51 +00:00
postcopy-ram.c	migration: Put thread names together with macros	2024-10-31 15:48:18 -04:00
postcopy-ram.h	migration/postcopy: Add postcopy-recover-setup phase	2024-06-21 09:47:59 -03:00
qemu-file.c	migration: remove unnecessary zlib dependency	2024-05-25 13:28:02 +02:00
qemu-file.h	migration: Remove non-multifd compression	2024-05-08 09:20:59 -03:00
ram.c	migration: fix -Werror=maybe-uninitialized false-positive	2024-10-02 16:14:29 +04:00
ram.h	migration/multifd: solve zero page causing multiple page faults	2024-04-23 18:36:01 -04:00
rdma.c	migration/rdma: Fix a memory issue for migration	2024-03-11 14:41:40 -04:00
rdma.h	migration: convert rdma backend to accept MigrateAddress	2023-11-02 11:35:03 +01:00
savevm.c	migration: Put thread names together with macros	2024-10-31 15:48:18 -04:00
savevm.h	migration: Add Error** argument to qemu_savevm_state_setup()	2024-04-23 18:36:01 -04:00
socket.c	migration: Remove unused socket_send_channel_create_sync	2024-10-08 15:28:55 -04:00
socket.h	migration: Remove unused socket_send_channel_create_sync	2024-10-08 15:28:55 -04:00
target.c	migration: Add migration prefix to functions in target.c	2023-09-11 08:34:06 +02:00
threadinfo.c	migration/multifd: Protect accesses to migration_threads	2023-07-26 10:55:56 +02:00
threadinfo.h	migration/multifd: Protect accesses to migration_threads	2023-07-26 10:55:56 +02:00
tls.c	migration: Drop unused parameter for migration_tls_client_create()	2023-05-03 11:24:20 +02:00
tls.h	migration: Drop unused parameter for migration_tls_client_create()	2023-05-03 11:24:20 +02:00
trace-events	migration/multifd: Isolate ram pages packet data	2024-09-03 16:24:35 -03:00
trace.h	trace: switch position of headers to what Meson requires	2020-08-21 06:18:24 -04:00
vmstate-types.c	Move CPU softfloat unions to cpu-float.h	2022-04-06 14:31:43 +02:00
vmstate.c	migration: Ensure vmstate_save() sets errp	2024-10-31 15:48:18 -04:00
xbzrle.c	migration/xbzrle: Use i386 host/cpuinfo.h	2023-05-23 16:51:18 -07:00
xbzrle.h	migration/xbzrle: Use i386 host/cpuinfo.h	2023-05-23 16:51:18 -07:00
yank_functions.c	migration/yank: Use channel features	2024-01-29 11:02:12 +08:00
yank_functions.h	migration: Move the yank unregister of channel_close out	2021-07-26 12:45:03 +01:00