mirror of
https://github.com/qemu/qemu.git
synced 2024-12-03 16:53:53 +08:00
83d768b564
Dataplane has been omitting forever the step of setting ISR when an interrupt is raised. This caused little breakage, because the specification actually says that ISR may not be updated in MSI mode. Some versions of the Windows drivers however didn't clear MSI mode correctly, and proceeded using polling mode (using ISR, not the used ring index!) for crashdump and hibernation. If it were just crashdump and hibernation it would not be a big deal, but recent releases of Windows do not really shut down, but rather log out and hibernate to make the next startup faster. Hence, this manifested as a more serious hang during shutdown with e.g. Windows 8.1 and virtio-win 1.8.0 RPMs. Newer versions fixed this, while older versions do not use MSI at all. The failure has always been there for virtio dataplane, but it became visible after commits9ffe337("virtio-blk: always use dataplane path if ioeventfd is active", 2016-10-30) andad07cd6("virtio-scsi: always use dataplane path if ioeventfd is active", 2016-10-30) made virtio-blk and virtio-scsi always use the dataplane code under KVM. The good news therefore is that it was not a bug in the patches---they were doing exactly what they were meant for, i.e. shake out remaining dataplane bugs. The fix is not hard, so it's worth arranging for the broken drivers. The virtio_should_notify+event_notifier_set pair that is common to virtio-blk and virtio-scsi dataplane is replaced with a new public function virtio_notify_irqfd that also sets ISR. The irqfd emulation code now need not set ISR anymore, so virtio_irq is removed. Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Tested-by: Farhan Ali <alifm@linux.vnet.ibm.com> Tested-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
22 lines
1.2 KiB
Plaintext
22 lines
1.2 KiB
Plaintext
# See docs/tracing.txt for syntax documentation.
|
|
|
|
# hw/virtio/virtio.c
|
|
virtqueue_fill(void *vq, const void *elem, unsigned int len, unsigned int idx) "vq %p elem %p len %u idx %u"
|
|
virtqueue_flush(void *vq, unsigned int count) "vq %p count %u"
|
|
virtqueue_pop(void *vq, void *elem, unsigned int in_num, unsigned int out_num) "vq %p elem %p in_num %u out_num %u"
|
|
virtio_queue_notify(void *vdev, int n, void *vq) "vdev %p n %d vq %p"
|
|
virtio_notify_irqfd(void *vdev, void *vq) "vdev %p vq %p"
|
|
virtio_notify(void *vdev, void *vq) "vdev %p vq %p"
|
|
virtio_set_status(void *vdev, uint8_t val) "vdev %p val %u"
|
|
|
|
# hw/virtio/virtio-rng.c
|
|
virtio_rng_guest_not_ready(void *rng) "rng %p: guest not ready"
|
|
virtio_rng_pushed(void *rng, size_t len) "rng %p: %zd bytes pushed"
|
|
virtio_rng_request(void *rng, size_t size, unsigned quota) "rng %p: %zd bytes requested, %u bytes quota left"
|
|
|
|
# hw/virtio/virtio-balloon.c
|
|
virtio_balloon_handle_output(const char *name, uint64_t gpa) "section name: %s gpa: %"PRIx64
|
|
virtio_balloon_get_config(uint32_t num_pages, uint32_t actual) "num_pages: %d actual: %d"
|
|
virtio_balloon_set_config(uint32_t actual, uint32_t oldactual) "actual: %d oldactual: %d"
|
|
virtio_balloon_to_target(uint64_t target, uint32_t num_pages) "balloon target: %"PRIx64" num_pages: %d"
|