mirror of
https://github.com/qemu/qemu.git
synced 2024-12-17 09:13:44 +08:00
985cac8f20
It's unused now (except for permission handling)[*]. The only reasonable user of it was block-stream job, recently updated to use own blk. And other block jobs prefer to use own source node related objects. So, the arguments of dropping the field are: - block jobs prefer not to use it - block jobs usually has more then one node to operate on, and better to operate symmetrically (for example has both source and target blk's in specific block-job state structure) *: BlockJob.blk is used to keep some permissions. We simply move permissions to block-job child created in block_job_create() together with blk. In mirror, we just should not care anymore about restoring state of blk. Most probably this code could be dropped long ago, after dropping bs->job pointer. Now it finally goes away together with BlockJob.blk itself. iotest 141 output is updated, as "bdrv_has_blk(bs)" check in qmp_blockdev_del() doesn't fail (we don't have blk now). Still, new error message looks even better. In iotest 283 we need to add a job id, otherwise "Invalid job ID" happens now earlier than permission check (as permissions moved from blk to block-job node). Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Reviewed-by: Nikita Lapshin <nikita.lapshin@virtuozzo.com>
181 lines
5.1 KiB
C
181 lines
5.1 KiB
C
/*
|
|
* Declarations for long-running block device operations
|
|
*
|
|
* Copyright (c) 2011 IBM Corp.
|
|
* Copyright (c) 2012 Red Hat, Inc.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#ifndef BLOCKJOB_H
|
|
#define BLOCKJOB_H
|
|
|
|
#include "qemu/job.h"
|
|
#include "block/block.h"
|
|
#include "qemu/ratelimit.h"
|
|
|
|
#define BLOCK_JOB_SLICE_TIME 100000000ULL /* ns */
|
|
|
|
typedef struct BlockJobDriver BlockJobDriver;
|
|
|
|
/**
|
|
* BlockJob:
|
|
*
|
|
* Long-running operation on a BlockDriverState.
|
|
*/
|
|
typedef struct BlockJob {
|
|
/** Data belonging to the generic Job infrastructure */
|
|
Job job;
|
|
|
|
/** Status that is published by the query-block-jobs QMP API */
|
|
BlockDeviceIoStatus iostatus;
|
|
|
|
/** Speed that was set with @block_job_set_speed. */
|
|
int64_t speed;
|
|
|
|
/** Rate limiting data structure for implementing @speed. */
|
|
RateLimit limit;
|
|
|
|
/** Block other operations when block job is running */
|
|
Error *blocker;
|
|
|
|
/** Called when a cancelled job is finalised. */
|
|
Notifier finalize_cancelled_notifier;
|
|
|
|
/** Called when a successfully completed job is finalised. */
|
|
Notifier finalize_completed_notifier;
|
|
|
|
/** Called when the job transitions to PENDING */
|
|
Notifier pending_notifier;
|
|
|
|
/** Called when the job transitions to READY */
|
|
Notifier ready_notifier;
|
|
|
|
/** Called when the job coroutine yields or terminates */
|
|
Notifier idle_notifier;
|
|
|
|
/** BlockDriverStates that are involved in this block job */
|
|
GSList *nodes;
|
|
} BlockJob;
|
|
|
|
/**
|
|
* block_job_next:
|
|
* @job: A block job, or %NULL.
|
|
*
|
|
* Get the next element from the list of block jobs after @job, or the
|
|
* first one if @job is %NULL.
|
|
*
|
|
* Returns the requested job, or %NULL if there are no more jobs left.
|
|
*/
|
|
BlockJob *block_job_next(BlockJob *job);
|
|
|
|
/**
|
|
* block_job_get:
|
|
* @id: The id of the block job.
|
|
*
|
|
* Get the block job identified by @id (which must not be %NULL).
|
|
*
|
|
* Returns the requested job, or %NULL if it doesn't exist.
|
|
*/
|
|
BlockJob *block_job_get(const char *id);
|
|
|
|
/**
|
|
* block_job_add_bdrv:
|
|
* @job: A block job
|
|
* @name: The name to assign to the new BdrvChild
|
|
* @bs: A BlockDriverState that is involved in @job
|
|
* @perm, @shared_perm: Permissions to request on the node
|
|
*
|
|
* Add @bs to the list of BlockDriverState that are involved in
|
|
* @job. This means that all operations will be blocked on @bs while
|
|
* @job exists.
|
|
*/
|
|
int block_job_add_bdrv(BlockJob *job, const char *name, BlockDriverState *bs,
|
|
uint64_t perm, uint64_t shared_perm, Error **errp);
|
|
|
|
/**
|
|
* block_job_remove_all_bdrv:
|
|
* @job: The block job
|
|
*
|
|
* Remove all BlockDriverStates from the list of nodes that are involved in the
|
|
* job. This removes the blockers added with block_job_add_bdrv().
|
|
*/
|
|
void block_job_remove_all_bdrv(BlockJob *job);
|
|
|
|
/**
|
|
* block_job_has_bdrv:
|
|
* @job: The block job
|
|
*
|
|
* Searches for @bs in the list of nodes that are involved in the
|
|
* job.
|
|
*/
|
|
bool block_job_has_bdrv(BlockJob *job, BlockDriverState *bs);
|
|
|
|
/**
|
|
* block_job_set_speed:
|
|
* @job: The job to set the speed for.
|
|
* @speed: The new value
|
|
* @errp: Error object.
|
|
*
|
|
* Set a rate-limiting parameter for the job; the actual meaning may
|
|
* vary depending on the job type.
|
|
*/
|
|
bool block_job_set_speed(BlockJob *job, int64_t speed, Error **errp);
|
|
|
|
/**
|
|
* block_job_query:
|
|
* @job: The job to get information about.
|
|
*
|
|
* Return information about a job.
|
|
*/
|
|
BlockJobInfo *block_job_query(BlockJob *job, Error **errp);
|
|
|
|
/**
|
|
* block_job_iostatus_reset:
|
|
* @job: The job whose I/O status should be reset.
|
|
*
|
|
* Reset I/O status on @job and on BlockDriverState objects it uses,
|
|
* other than job->blk.
|
|
*/
|
|
void block_job_iostatus_reset(BlockJob *job);
|
|
|
|
/**
|
|
* block_job_is_internal:
|
|
* @job: The job to determine if it is user-visible or not.
|
|
*
|
|
* Returns true if the job should not be visible to the management layer.
|
|
*/
|
|
bool block_job_is_internal(BlockJob *job);
|
|
|
|
/**
|
|
* block_job_driver:
|
|
*
|
|
* Returns the driver associated with a block job.
|
|
*/
|
|
const BlockJobDriver *block_job_driver(BlockJob *job);
|
|
|
|
/*
|
|
* block_job_get_aio_context:
|
|
*
|
|
* Returns aio context associated with a block job.
|
|
*/
|
|
AioContext *block_job_get_aio_context(BlockJob *job);
|
|
|
|
#endif
|