mirror of
https://github.com/qemu/qemu.git
synced 2024-12-04 01:03:38 +08:00
b66ff2c298
There are many existing qcow2 images that specify a backing file but no format. This has been the source of CVEs in the past, but has become more prominent of a problem now that libvirt has switched to -blockdev. With older -drive, at least the probing was always done by qemu (so the only risk of a changed format between successive boots of a guest was if qemu was upgraded and probed differently). But with newer -blockdev, libvirt must specify a format; if libvirt guesses raw where the image was formatted, this results in data corruption visible to the guest; conversely, if libvirt guesses qcow2 where qemu was using raw, this can result in potential security holes, so modern libvirt instead refuses to use images without explicit backing format. The change in libvirt to reject images without explicit backing format has pointed out that a number of tools have been far too reliant on probing in the past. It's time to set a better example in our own iotests of properly setting this parameter. iotest calls to create, rebase, and convert are all impacted to some degree. It's a bit annoying that we are inconsistent on command line - while all of those accept -o backing_file=...,backing_fmt=..., the shortcuts are different: create and rebase have -b and -F, while convert has -B but no -F. (amend has no shortcuts, but the previous patch just deprecated the use of amend to change backing chains). Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <20200706203954.341758-9-eblake@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
344 lines
12 KiB
Bash
Executable File
344 lines
12 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
#
|
|
# Test case for image option amendment in qcow2.
|
|
#
|
|
# Copyright (C) 2013 Red Hat, Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
|
|
# creator
|
|
owner=mreitz@redhat.com
|
|
|
|
seq=`basename $0`
|
|
echo "QA output created by $seq"
|
|
|
|
status=1 # failure is the default!
|
|
|
|
_cleanup()
|
|
{
|
|
_cleanup_test_img
|
|
_rm_test_img "$TEST_IMG.data"
|
|
}
|
|
trap "_cleanup; exit \$status" 0 1 2 3 15
|
|
|
|
# get standard environment, filters and checks
|
|
. ./common.rc
|
|
. ./common.filter
|
|
|
|
# This tests qcow2-specific low-level functionality
|
|
_supported_fmt qcow2
|
|
_supported_proto file
|
|
_supported_os Linux
|
|
# Conversion between different compat versions can only really work
|
|
# with refcount_bits=16;
|
|
# we have explicit tests for data_file here, but the whole test does
|
|
# not work with it;
|
|
# we have explicit tests for various cluster sizes, the remaining tests
|
|
# require the default 64k cluster
|
|
_unsupported_imgopts 'refcount_bits=\([^1]\|.\([^6]\|$\)\)' data_file cluster_size
|
|
|
|
echo
|
|
echo "=== Testing version downgrade with zero expansion ==="
|
|
echo
|
|
_make_test_img -o "compat=1.1,lazy_refcounts=on" 64M
|
|
$QEMU_IO -c "write -z 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header
|
|
$QEMU_IMG amend -o "compat=0.10" "$TEST_IMG"
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header
|
|
$QEMU_IO -c "read -P 0 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
_check_test_img
|
|
|
|
echo
|
|
echo "=== Testing version downgrade with zero expansion and 4K cache entries ==="
|
|
echo
|
|
_make_test_img -o "compat=1.1,lazy_refcounts=on" 64M
|
|
$QEMU_IO -c "write -z 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IO -c "write -z 32M 128k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IO -c map "$TEST_IMG" | _filter_qemu_io
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header
|
|
$QEMU_IMG amend -o "compat=0.10" --image-opts \
|
|
driver=qcow2,file.filename=$TEST_IMG,l2-cache-entry-size=4096
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header
|
|
$QEMU_IO -c "read -P 0 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IO -c "read -P 0 32M 128k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IO -c map "$TEST_IMG" | _filter_qemu_io
|
|
_check_test_img
|
|
|
|
echo
|
|
echo "=== Testing dirty version downgrade ==="
|
|
echo
|
|
_make_test_img -o "compat=1.1,lazy_refcounts=on" 64M
|
|
_NO_VALGRIND \
|
|
$QEMU_IO -c "write -P 0x2a 0 128k" -c flush \
|
|
-c "sigraise $(kill -l KILL)" "$TEST_IMG" 2>&1 | _filter_qemu_io
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header
|
|
$QEMU_IMG amend -o "compat=0.10" "$TEST_IMG"
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header
|
|
$QEMU_IO -c "read -P 0x2a 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
_check_test_img
|
|
|
|
echo
|
|
echo "=== Testing version downgrade with unknown compat/autoclear flags ==="
|
|
echo
|
|
_make_test_img -o "compat=1.1" 64M
|
|
$PYTHON qcow2.py "$TEST_IMG" set-feature-bit compatible 42
|
|
$PYTHON qcow2.py "$TEST_IMG" set-feature-bit autoclear 42
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header
|
|
$QEMU_IMG amend -o "compat=0.10" "$TEST_IMG"
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header
|
|
_check_test_img
|
|
|
|
echo
|
|
echo "=== Testing version upgrade and resize ==="
|
|
echo
|
|
_make_test_img -o "compat=0.10" 64M
|
|
$QEMU_IO -c "write -P 0x2a 42M 64k" "$TEST_IMG" | _filter_qemu_io
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header
|
|
$QEMU_IMG amend -o "compat=1.1,lazy_refcounts=on,size=128M" "$TEST_IMG"
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header
|
|
$QEMU_IO -c "read -P 0x2a 42M 64k" "$TEST_IMG" | _filter_qemu_io
|
|
_check_test_img
|
|
|
|
echo
|
|
echo "=== Testing resize with snapshots ==="
|
|
echo
|
|
_make_test_img -o "compat=0.10" 32M
|
|
$QEMU_IO -c "write -P 0x2a 24M 64k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IMG snapshot -c foo "$TEST_IMG"
|
|
$QEMU_IMG resize "$TEST_IMG" 64M &&
|
|
echo "unexpected pass"
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap\)'
|
|
|
|
$QEMU_IMG amend -o "compat=1.1,size=128M" "$TEST_IMG" ||
|
|
echo "unexpected fail"
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap\)'
|
|
|
|
$QEMU_IMG snapshot -c bar "$TEST_IMG"
|
|
$QEMU_IMG resize --shrink "$TEST_IMG" 64M ||
|
|
echo "unexpected fail"
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap\)'
|
|
|
|
$QEMU_IMG amend -o "compat=0.10,size=32M" "$TEST_IMG" &&
|
|
echo "unexpected pass"
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap\)'
|
|
|
|
$QEMU_IMG snapshot -a bar "$TEST_IMG" ||
|
|
echo "unexpected fail"
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap\)'
|
|
|
|
$QEMU_IMG snapshot -d bar "$TEST_IMG"
|
|
$QEMU_IMG amend -o "compat=0.10,size=32M" "$TEST_IMG" ||
|
|
echo "unexpected fail"
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap\)'
|
|
|
|
_check_test_img
|
|
|
|
|
|
echo
|
|
echo "=== Testing dirty lazy_refcounts=off ==="
|
|
echo
|
|
_make_test_img -o "compat=1.1,lazy_refcounts=on" 64M
|
|
_NO_VALGRIND \
|
|
$QEMU_IO -c "write -P 0x2a 0 128k" -c flush \
|
|
-c "sigraise $(kill -l KILL)" "$TEST_IMG" 2>&1 | _filter_qemu_io
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header
|
|
$QEMU_IMG amend -o "lazy_refcounts=off" "$TEST_IMG"
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header
|
|
$QEMU_IO -c "read -P 0x2a 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
_check_test_img
|
|
|
|
echo
|
|
echo "=== Testing backing file ==="
|
|
echo
|
|
_make_test_img -o "compat=1.1" 64M
|
|
TEST_IMG="$TEST_IMG.base" _make_test_img -o "compat=1.1" 64M
|
|
$QEMU_IO -c "write -P 0x2a 0 128k" "$TEST_IMG.base" | _filter_qemu_io
|
|
$QEMU_IO -c "read -P 0 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IMG amend -o "backing_file=$TEST_IMG.base,backing_fmt=qcow2" "$TEST_IMG"
|
|
$QEMU_IO -c "read -P 0x2a 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
_check_test_img
|
|
|
|
echo
|
|
echo "=== Testing invalid configurations ==="
|
|
echo
|
|
_make_test_img -o "compat=0.10" 64M
|
|
$QEMU_IMG amend -o "lazy_refcounts=on" "$TEST_IMG"
|
|
$QEMU_IMG amend -o "compat=1.1" "$TEST_IMG" # actually valid
|
|
$QEMU_IMG amend -o "compat=0.10,lazy_refcounts=on" "$TEST_IMG"
|
|
$QEMU_IMG amend -o "compat=0.42" "$TEST_IMG"
|
|
$QEMU_IMG amend -o "foo=bar" "$TEST_IMG"
|
|
$QEMU_IMG amend -o "cluster_size=1k" "$TEST_IMG"
|
|
$QEMU_IMG amend -o "encryption=on" "$TEST_IMG"
|
|
$QEMU_IMG amend -o "preallocation=on" "$TEST_IMG"
|
|
|
|
echo
|
|
echo "=== Testing correct handling of unset value ==="
|
|
echo
|
|
_make_test_img -o "compat=1.1,cluster_size=1k" 64M
|
|
echo "Should work:"
|
|
$QEMU_IMG amend -o "lazy_refcounts=on" "$TEST_IMG"
|
|
echo "Should not work:" # Just to know which of these tests actually fails
|
|
$QEMU_IMG amend -o "cluster_size=64k" "$TEST_IMG"
|
|
|
|
echo
|
|
echo "=== Testing zero expansion on inactive clusters ==="
|
|
echo
|
|
_make_test_img -o "compat=1.1" 64M
|
|
$QEMU_IO -c "write -z 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IMG snapshot -c foo "$TEST_IMG"
|
|
$QEMU_IO -c "write -P 0x2a 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IMG amend -o "compat=0.10" "$TEST_IMG"
|
|
_check_test_img
|
|
$QEMU_IO -c "read -P 0x2a 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IMG snapshot -a foo "$TEST_IMG"
|
|
_check_test_img
|
|
$QEMU_IO -c "read -P 0 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
|
|
echo
|
|
echo "=== Testing zero expansion on shared L2 table ==="
|
|
echo
|
|
_make_test_img -o "compat=1.1" 64M
|
|
$QEMU_IO -c "write -z 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IMG snapshot -c foo "$TEST_IMG"
|
|
$QEMU_IMG amend -o "compat=0.10" "$TEST_IMG"
|
|
_check_test_img
|
|
$QEMU_IO -c "read -P 0 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IMG snapshot -a foo "$TEST_IMG"
|
|
_check_test_img
|
|
$QEMU_IO -c "read -P 0 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
|
|
echo
|
|
echo "=== Testing zero expansion on backed image ==="
|
|
echo
|
|
TEST_IMG="$TEST_IMG.base" _make_test_img -o "compat=1.1" 64M
|
|
$QEMU_IO -c "write -P 0x2a 0 128k" "$TEST_IMG.base" | _filter_qemu_io
|
|
_make_test_img -o "compat=1.1" -b "$TEST_IMG.base" -F $IMGFMT 64M
|
|
$QEMU_IO -c "read -P 0x2a 0 128k" -c "write -z 0 64k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IMG amend -o "compat=0.10" "$TEST_IMG"
|
|
_check_test_img
|
|
$QEMU_IO -c "read -P 0 0 64k" -c "read -P 0x2a 64k 64k" "$TEST_IMG" | _filter_qemu_io
|
|
|
|
echo
|
|
echo "=== Testing zero expansion on backed inactive clusters ==="
|
|
echo
|
|
TEST_IMG="$TEST_IMG.base" _make_test_img -o "compat=1.1" 64M
|
|
$QEMU_IO -c "write -P 0x2a 0 128k" "$TEST_IMG.base" | _filter_qemu_io
|
|
_make_test_img -o "compat=1.1" -b "$TEST_IMG.base" -F $IMGFMT 64M
|
|
$QEMU_IO -c "write -z 0 64k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IMG snapshot -c foo "$TEST_IMG"
|
|
$QEMU_IO -c "write -P 0x42 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IMG amend -o "compat=0.10" "$TEST_IMG"
|
|
_check_test_img
|
|
$QEMU_IO -c "read -P 0x42 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IMG snapshot -a foo "$TEST_IMG"
|
|
_check_test_img
|
|
$QEMU_IO -c "read -P 0 0 64k" -c "read -P 0x2a 64k 64k" "$TEST_IMG" | _filter_qemu_io
|
|
|
|
echo
|
|
echo "=== Testing zero expansion on backed image with shared L2 table ==="
|
|
echo
|
|
TEST_IMG="$TEST_IMG.base" _make_test_img -o "compat=1.1" 64M
|
|
$QEMU_IO -c "write -P 0x2a 0 128k" "$TEST_IMG.base" | _filter_qemu_io
|
|
_make_test_img -o "compat=1.1" -b "$TEST_IMG.base" -F $IMGFMT 64M
|
|
$QEMU_IO -c "write -z 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IMG snapshot -c foo "$TEST_IMG"
|
|
$QEMU_IMG amend -o "compat=0.10" "$TEST_IMG"
|
|
_check_test_img
|
|
$QEMU_IO -c "read -P 0 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IMG snapshot -a foo "$TEST_IMG"
|
|
_check_test_img
|
|
$QEMU_IO -c "read -P 0 0 128k" "$TEST_IMG" | _filter_qemu_io
|
|
|
|
echo
|
|
echo "=== Testing preallocated zero expansion on full image ==="
|
|
echo
|
|
TEST_IMG="$TEST_IMG" _make_test_img -o "compat=1.1" 64M
|
|
$QEMU_IO -c "write -P 0x2a 0 64M" "$TEST_IMG" -c "write -z 0 64M" | _filter_qemu_io
|
|
$QEMU_IMG amend -o "compat=0.10" "$TEST_IMG"
|
|
_check_test_img
|
|
$QEMU_IO -c "read -P 0 0 64M" "$TEST_IMG" | _filter_qemu_io
|
|
|
|
echo
|
|
echo "=== Testing progress report without snapshot ==="
|
|
echo
|
|
TEST_IMG="$TEST_IMG.base" _make_test_img -o "compat=1.1" 4G
|
|
_make_test_img -o "compat=1.1" -b "$TEST_IMG.base" -F $IMGFMT 4G
|
|
$QEMU_IO -c "write -z 0 64k" \
|
|
-c "write -z 1G 64k" \
|
|
-c "write -z 2G 64k" \
|
|
-c "write -z 3G 64k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IMG amend -p -o "compat=0.10" "$TEST_IMG"
|
|
_check_test_img
|
|
|
|
echo
|
|
echo "=== Testing progress report with snapshot ==="
|
|
echo
|
|
TEST_IMG="$TEST_IMG.base" _make_test_img -o "compat=1.1" 4G
|
|
_make_test_img -o "compat=1.1" -b "$TEST_IMG.base" -F $IMGFMT 4G
|
|
$QEMU_IO -c "write -z 0 64k" \
|
|
-c "write -z 1G 64k" \
|
|
-c "write -z 2G 64k" \
|
|
-c "write -z 3G 64k" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IMG snapshot -c foo "$TEST_IMG"
|
|
$QEMU_IMG amend -p -o "compat=0.10" "$TEST_IMG"
|
|
_check_test_img
|
|
|
|
echo
|
|
echo "=== Testing version downgrade with external data file ==="
|
|
echo
|
|
_make_test_img -o "compat=1.1,data_file=$TEST_IMG.data" 64M
|
|
$QEMU_IMG amend -o "compat=0.10" "$TEST_IMG"
|
|
_img_info --format-specific
|
|
_check_test_img
|
|
|
|
echo
|
|
echo "=== Try changing the external data file ==="
|
|
echo
|
|
_make_test_img -o "compat=1.1" 64M
|
|
$QEMU_IMG amend -o "data_file=foo" "$TEST_IMG"
|
|
|
|
echo
|
|
_make_test_img -o "compat=1.1,data_file=$TEST_IMG.data" 64M
|
|
$QEMU_IMG amend -o "data_file=foo" "$TEST_IMG"
|
|
_img_info --format-specific
|
|
TEST_IMG="data-file.filename=$TEST_IMG.data,file.filename=$TEST_IMG" _img_info --format-specific --image-opts
|
|
|
|
echo
|
|
$QEMU_IMG amend -o "data_file=" --image-opts "data-file.filename=$TEST_IMG.data,file.filename=$TEST_IMG"
|
|
_img_info --format-specific
|
|
TEST_IMG="data-file.filename=$TEST_IMG.data,file.filename=$TEST_IMG" _img_info --format-specific --image-opts
|
|
|
|
echo
|
|
echo "=== Clearing and setting data-file-raw ==="
|
|
echo
|
|
_make_test_img -o "compat=1.1,data_file=$TEST_IMG.data,data_file_raw=on" 64M
|
|
$QEMU_IMG amend -o "data_file_raw=on" "$TEST_IMG"
|
|
_img_info --format-specific
|
|
_check_test_img
|
|
|
|
$QEMU_IMG amend -o "data_file_raw=off" "$TEST_IMG"
|
|
_img_info --format-specific
|
|
_check_test_img
|
|
|
|
$QEMU_IMG amend -o "data_file_raw=on" "$TEST_IMG"
|
|
_img_info --format-specific
|
|
_check_test_img
|
|
|
|
|
|
# success, all done
|
|
echo "*** done"
|
|
rm -f $seq.full
|
|
status=0
|