mirror of
https://github.com/qemu/qemu.git
synced 2024-12-18 09:43:38 +08:00
de38b5005e
Disk sizes close to INT64_MAX cause overflow, for some pretty ridiculous output: $ ./nbdkit -U - memory size=$((2**63 - 512)) --run 'qemu-img info $nbd' image: nbd+unix://?socket=/tmp/nbdkitHSAzNz/socket file format: raw virtual size: -8388607T (9223372036854775296 bytes) disk size: unavailable But there's no reason to have two separate implementations of integer to human-readable abbreviation, where one has overflow and stops at 'T', while the other avoids overflow and goes all the way to 'E'. With this patch, the output now claims 8EiB instead of -8388607T, which really is the correct rounding of largest file size supported by qemu (we could go 511 bytes larger if we used byte-accurate sizing instead of rounding up to the next sector boundary, but that wouldn't change the human-readable result). Quite a few iotests need updates to expected output to match. Reported-by: Richard W.M. Jones <rjones@redhat.com> Signed-off-by: Eric Blake <eblake@redhat.com> Tested-by: Richard W.M. Jones <rjones@redhat.com> Reviewed-by: Alberto Garcia <berto@igalia.com> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com> Tested-by: Max Reitz <mreitz@redhat.com>
28 lines
1.0 KiB
Plaintext
28 lines
1.0 KiB
Plaintext
QA output created by 070
|
|
|
|
=== Verify open image read-only fails, due to dirty log ===
|
|
qemu-io: can't open device TEST_DIR/iotest-dirtylog-10G-4M.vhdx: VHDX image file 'TEST_DIR/iotest-dirtylog-10G-4M.vhdx' opened read-only, but contains a log that needs to be replayed
|
|
To replay the log, run:
|
|
qemu-img check -r all 'TEST_DIR/iotest-dirtylog-10G-4M.vhdx'
|
|
=== Verify open image replays log ===
|
|
read 18874368/18874368 bytes at offset 0
|
|
18 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
=== Verify qemu-img check -r all replays log ===
|
|
The following inconsistencies were found and repaired:
|
|
|
|
0 leaked clusters
|
|
1 corruptions
|
|
|
|
Double checking the fixed image now...
|
|
No errors were found on the image.
|
|
=== Verify open image read-only succeeds after log replay ===
|
|
read 18874368/18874368 bytes at offset 0
|
|
18 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
|
|
=== Verify image created by Disk2VHD can be opened ===
|
|
image: TEST_DIR/test-disk2vhd.IMGFMT
|
|
file format: IMGFMT
|
|
virtual size: 256 MiB (268435456 bytes)
|
|
cluster_size: 2097152
|
|
*** done
|