mirror of
https://github.com/qemu/qemu.git
synced 2024-11-26 12:23:36 +08:00
0a982b1bf3
Exposing OS-specific SEEK_ constants in our qapi was a mistake (if the host has SEEK_CUR as 1, but the guest has it as 2, then the semantics are unclear what should happen); if we had a time machine, we would instead expose only a symbolic enum. It's too late to change the fact that we have an integer in qapi, but we can at least document what mapping we want to enforce for all qga clients (and luckily, it happens to be the mapping that both Linux and Windows use); then fix the code to match that mapping. It also helps us filter out unsupported SEEK_DATA and SEEK_HOLE. In the future, we may wish to move our QGA_SEEK_* constants into qga/qapi-schema.json, along with updating the schema to take an alternate type (either the integer, or the string value of the enum name) - but that's too much risk during hard freeze. Signed-off-by: Eric Blake <eblake@redhat.com> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com> |
||
|---|---|---|
| .. | ||
| installer | ||
| vss-win32 | ||
| channel-posix.c | ||
| channel-win32.c | ||
| channel.h | ||
| commands-posix.c | ||
| commands-win32.c | ||
| commands.c | ||
| guest-agent-command-state.c | ||
| guest-agent-core.h | ||
| main.c | ||
| Makefile.objs | ||
| qapi-schema.json | ||
| service-win32.c | ||
| service-win32.h | ||
| vss-win32.c | ||
| vss-win32.h | ||