qemu/qga/vss-win32
Markus Armbruster 08e6464035 qga/vss-win32: Document the DLL requires non-null errp
requester.cpp uses this pattern to receive an error and pass it on to
the caller (err_is_set() macro peeled off for clarity):

    ... code that may set errset->errp ...
    if (errset->errp && *errset->errp) {
        ... handle error ...
    }

This breaks when errset->errp is null.  As far as I can tell, it
currently isn't, so this is merely fragile, not actually broken.

The robust way to do this is to receive the error in a local variable,
then propagate it up, like this:

    Error *err = NULL;

    ... code that may set err ...
    if (err)
        ... handle error ...
        error_propagate(errset->errp, err);
    }

See also commit 5e54769, 0f230bf, a903f40.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
2015-09-10 13:48:06 +02:00
..
install.cpp vss-win32: Fix build with mingw64-headers-3.1.0 2014-04-07 14:39:19 -05:00
Makefile.objs qga: fitering out -fstack-protector-strong 2015-04-02 15:57:27 +02:00
provider.cpp qga: vss-win32: Fix interference with snapshot deletion by other VSS request 2014-02-23 13:11:52 -06:00
qga-vss.def qemu-ga: Add Windows VSS provider and requester as DLL 2013-09-09 14:17:57 -05:00
qga-vss.idl qemu-ga: Add Windows VSS provider and requester as DLL 2013-09-09 14:17:57 -05:00
qga-vss.tlb qemu-ga: Add Windows VSS provider and requester as DLL 2013-09-09 14:17:57 -05:00
requester.cpp qga/vss-win32: Document the DLL requires non-null errp 2015-09-10 13:48:06 +02:00
requester.h qga/vss-win32: Document the DLL requires non-null errp 2015-09-10 13:48:06 +02:00
vss-common.h qemu-ga: Add Windows VSS provider and requester as DLL 2013-09-09 14:17:57 -05:00