qemu/monitor
Markus Armbruster f22c225e23 hmp: Unbreak "change vnc"
HMP command "change vnc" can take the password as argument, or prompt
for it:

    (qemu) change vnc password 123
    (qemu) change vnc password
    Password: ***
    (qemu)

This regressed in commit cfb5387a1d "hmp: remove "change vnc TARGET"
command", v6.0.0.

    (qemu) change vnc passwd 123
    Password: ***
    (qemu) change vnc passwd
    (qemu)

The latter passes NULL to qmp_change_vnc_password(), which is a no-no.
Looks like it puts the display into "password required, but none set"
state.

The logic error is easy to miss in review, but testing should've
caught it.

Fix the obvious way.

Fixes: cfb5387a1d
Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Message-Id: <20210909081219.308065-2-armbru@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
(cherry picked from commit 6193344f93)
Signed-off-by: Michael Roth <michael.roth@amd.com>
2021-10-15 17:54:16 -05:00
..
hmp-cmds.c hmp: Unbreak "change vnc" 2021-10-15 17:54:16 -05:00
hmp.c machine: introduce MachineInitPhase 2020-12-15 12:51:52 -05:00
meson.build meson: add spice_headers dependency. 2020-10-15 11:14:40 +02:00
misc.c monitor: Drop query-qmp-schema 'gen': false hack 2021-03-19 16:05:09 +01:00
monitor-internal.h monitor: Drop query-qmp-schema 'gen': false hack 2021-03-19 16:05:09 +01:00
monitor.c monitor: raise error when 'pretty' option is used with HMP 2021-03-18 09:22:55 +00:00
qmp-cmds-control.c qapi: Implement deprecated-output=hide for QMP introspection 2021-03-19 16:05:11 +01:00
qmp-cmds.c qmp: add new qmp display-reload 2021-03-23 08:48:21 +01:00
qmp.c monitor/qmp: fix race on CHR_EVENT_CLOSED without OOB 2021-10-14 14:49:46 -05:00
trace-events qmp: Add more tracepoints 2021-02-04 13:20:29 +01:00
trace.h trace: switch position of headers to what Meson requires 2020-08-21 06:18:24 -04:00