mirrors/qemu
0
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2024-11-29 06:43:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

strtosz(): use unsigned char and switch to qemu_isspace()

Browse Source 
isspace() behavior is undefined for signed char.

Bug pointed out by Eric Blake, thanks!

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Jes Sorensen 2011-01-24 16:33:28 +01:00 committed by Kevin Wolf
parent 45d1aa828f
commit f3bd362a18
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
cutils.c
View File

@ -294,7 +294,8 @@ int fcntl_setfl(int fd, int flag)
int64_t strtosz_suffix(const char *nptr, char **end, const char default_suffix) int64_t strtosz_suffix(const char *nptr, char **end, const char default_suffix)
{ {
int64_t retval = -1; int64_t retval = -1;
char *endptr, c, d; char *endptr;
unsigned char c, d;
int mul_required = 0; int mul_required = 0;
double val, mul, integral, fraction; double val, mul, integral, fraction;
@ -314,7 +315,7 @@ int64_t strtosz_suffix(const char *nptr, char **end, const char default_suffix)
*/ */
c = *endptr; c = *endptr;
d = c; d = c;
if (isspace(c) || c == '\0' || c == ',') { if (qemu_isspace(c) || c == '\0' || c == ',') {
c = 0; c = 0;
if (default_suffix) { if (default_suffix) {
d = default_suffix; d = default_suffix;
@ -361,7 +362,7 @@ int64_t strtosz_suffix(const char *nptr, char **end, const char default_suffix)
*/ */
if (c != 0) { if (c != 0) {
endptr++; endptr++;
if (!isspace(*endptr) && *endptr != ',' && *endptr != 0) { if (!qemu_isspace(*endptr) && *endptr != ',' && *endptr != 0) {
goto fail; goto fail;
} }
} }