mirror of
https://github.com/qemu/qemu.git
synced 2024-11-28 22:33:36 +08:00
checkpatch: remove tests that are not relevant outside the kernel
Fully removing Sparse support requires more invasive changes. Only remove the really kernel-specific parts such as address space names. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Paolo Bonzini
parent
71c47b01ca
commit
f1e155bbf8
@ -141,14 +141,7 @@ our $Ident = qr{
|
||||
}x;
|
||||
our $Storage = qr{extern|static|asmlinkage};
|
||||
our $Sparse = qr{
|
||||
__user|
|
||||
__kernel|
|
||||
__force|
|
||||
__iomem|
|
||||
__must_check|
|
||||
__init_refok|
|
||||
__kprobes|
|
||||
__ref
|
||||
__force
|
||||
}x;
|
||||
|
||||
# Notes to $Attribute:
|
||||
@ -200,14 +193,6 @@ our $typeTypedefs = qr{(?x:
|
||||
| QEMUBH # all uppercase
|
||||
)};
|
||||
|
||||
our $logFunctions = qr{(?x:
|
||||
printk|
|
||||
pr_(debug|dbg|vdbg|devel|info|warning|err|notice|alert|crit|emerg|cont)|
|
||||
(dev|netdev|netif)_(printk|dbg|vdbg|info|warn|err|notice|alert|crit|emerg|WARN)|
|
||||
WARN|
|
||||
panic
|
||||
)};
|
||||
|
||||
our @typeList = (
|
||||
qr{void},
|
||||
qr{(?:unsigned\s+)?char},
|
||||
@ -228,20 +213,20 @@ our @typeList = (
|
||||
qr{${Ident}_handler},
|
||||
qr{${Ident}_handler_fn},
|
||||
);
|
||||
|
||||
# This can be modified by sub possible. Since it can be empty, be careful
|
||||
# about regexes that always match, because they can cause infinite loops.
|
||||
our @modifierList = (
|
||||
qr{fastcall},
|
||||
);
|
||||
|
||||
our $allowed_asm_includes = qr{(?x:
|
||||
irq|
|
||||
memory
|
||||
)};
|
||||
# memory.h: ARM has a custom one
|
||||
|
||||
sub build_types {
|
||||
my $mods = "(?x: \n" . join("|\n ", @modifierList) . "\n)";
|
||||
my $all = "(?x: \n" . join("|\n ", @typeList) . "\n)";
|
||||
$Modifier = qr{(?:$Attribute|$Sparse|$mods)};
|
||||
if (@modifierList > 0) {
|
||||
my $mods = "(?x: \n" . join("|\n ", @modifierList) . "\n)";
|
||||
$Modifier = qr{(?:$Attribute|$Sparse|$mods)};
|
||||
} else {
|
||||
$Modifier = qr{(?:$Attribute|$Sparse)};
|
||||
}
|
||||
$NonptrType = qr{
|
||||
(?:$Modifier\s+|const\s+)*
|
||||
(?:
|
||||
@ -262,27 +247,6 @@ build_types();
|
||||
|
||||
$chk_signoff = 0 if ($file);
|
||||
|
||||
my @dep_includes = ();
|
||||
my @dep_functions = ();
|
||||
my $removal = "Documentation/feature-removal-schedule.txt";
|
||||
if ($tree && -f "$root/$removal") {
|
||||
open(my $REMOVE, '<', "$root/$removal") ||
|
||||
die "$P: $removal: open failed - $!\n";
|
||||
while (<$REMOVE>) {
|
||||
if (/^Check:\s+(.*\S)/) {
|
||||
for my $entry (split(/[, ]+/, $1)) {
|
||||
if ($entry =~ m@include/(.*)@) {
|
||||
push(@dep_includes, $1);
|
||||
|
||||
} elsif ($entry !~ m@/@) {
|
||||
push(@dep_functions, $entry);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
close($REMOVE);
|
||||
}
|
||||
|
||||
my @rawlines = ();
|
||||
my @lines = ();
|
||||
my $vname;
|
||||
@ -1112,33 +1076,6 @@ sub CHK {
|
||||
}
|
||||
}
|
||||
|
||||
sub check_absolute_file {
|
||||
my ($absolute, $herecurr) = @_;
|
||||
my $file = $absolute;
|
||||
|
||||
##print "absolute<$absolute>\n";
|
||||
|
||||
# See if any suffix of this path is a path within the tree.
|
||||
while ($file =~ s@^[^/]*/@@) {
|
||||
if (-f "$root/$file") {
|
||||
##print "file<$file>\n";
|
||||
last;
|
||||
}
|
||||
}
|
||||
if (! -f _) {
|
||||
return 0;
|
||||
}
|
||||
|
||||
# It is, so see if the prefix is acceptable.
|
||||
my $prefix = $absolute;
|
||||
substr($prefix, -length($file)) = '';
|
||||
|
||||
##print "prefix<$prefix>\n";
|
||||
if ($prefix ne ".../") {
|
||||
WARN("use relative pathname instead of absolute in changelog text\n" . $herecurr);
|
||||
}
|
||||
}
|
||||
|
||||
sub process {
|
||||
my $filename = shift;
|
||||
|
||||
@ -1181,10 +1118,6 @@ sub process {
|
||||
my %suppress_export;
|
||||
|
||||
# Pre-scan the patch sanitizing the lines.
|
||||
# Pre-scan the patch looking for any __setup documentation.
|
||||
#
|
||||
my @setup_docs = ();
|
||||
my $setup_docs = 0;
|
||||
|
||||
sanitise_line_reset();
|
||||
my $line;
|
||||
@ -1192,13 +1125,6 @@ sub process {
|
||||
$linenr++;
|
||||
$line = $rawline;
|
||||
|
||||
if ($rawline=~/^\+\+\+\s+(\S+)/) {
|
||||
$setup_docs = 0;
|
||||
if ($1 =~ m@Documentation/kernel-parameters.txt$@) {
|
||||
$setup_docs = 1;
|
||||
}
|
||||
#next;
|
||||
}
|
||||
if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
|
||||
$realline=$1-1;
|
||||
if (defined $2) {
|
||||
@ -1257,10 +1183,6 @@ sub process {
|
||||
|
||||
#print "==>$rawline\n";
|
||||
#print "-->$line\n";
|
||||
|
||||
if ($setup_docs && $line =~ /^\+/) {
|
||||
push(@setup_docs, $line);
|
||||
}
|
||||
}
|
||||
|
||||
$prefix = '';
|
||||
@ -1335,9 +1257,6 @@ sub process {
|
||||
WARN("patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
|
||||
}
|
||||
|
||||
if ($realfile =~ m@^include/asm/@) {
|
||||
ERROR("do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
|
||||
}
|
||||
next;
|
||||
}
|
||||
|
||||
@ -1377,20 +1296,6 @@ sub process {
|
||||
$herecurr) if (!$emitted_corrupt++);
|
||||
}
|
||||
|
||||
# Check for absolute kernel paths.
|
||||
if ($tree) {
|
||||
while ($line =~ m{(?:^|\s)(/\S*)}g) {
|
||||
my $file = $1;
|
||||
|
||||
if ($file =~ m{^(.*?)(?::\d+)+:?$} &&
|
||||
check_absolute_file($1, $herecurr)) {
|
||||
#
|
||||
} else {
|
||||
check_absolute_file($file, $herecurr);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
# UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
|
||||
if (($realfile =~ /^$/ || $line =~ /^\+/) &&
|
||||
$rawline !~ m/^$UTF8*$/) {
|
||||
@ -1417,45 +1322,12 @@ sub process {
|
||||
$rpt_cleaners = 1;
|
||||
}
|
||||
|
||||
# check for Kconfig help text having a real description
|
||||
# Only applies when adding the entry originally, after that we do not have
|
||||
# sufficient context to determine whether it is indeed long enough.
|
||||
if ($realfile =~ /Kconfig/ &&
|
||||
$line =~ /\+\s*(?:---)?help(?:---)?$/) {
|
||||
my $length = 0;
|
||||
my $cnt = $realcnt;
|
||||
my $ln = $linenr + 1;
|
||||
my $f;
|
||||
my $is_end = 0;
|
||||
while ($cnt > 0 && defined $lines[$ln - 1]) {
|
||||
$f = $lines[$ln - 1];
|
||||
$cnt-- if ($lines[$ln - 1] !~ /^-/);
|
||||
$is_end = $lines[$ln - 1] =~ /^\+/;
|
||||
$ln++;
|
||||
|
||||
next if ($f =~ /^-/);
|
||||
$f =~ s/^.//;
|
||||
$f =~ s/#.*//;
|
||||
$f =~ s/^\s+//;
|
||||
next if ($f =~ /^$/);
|
||||
if ($f =~ /^\s*config\s/) {
|
||||
$is_end = 1;
|
||||
last;
|
||||
}
|
||||
$length++;
|
||||
}
|
||||
WARN("please write a paragraph that describes the config symbol fully\n" . $herecurr) if ($is_end && $length < 4);
|
||||
#print "is_end<$is_end> length<$length>\n";
|
||||
}
|
||||
|
||||
# check we are in a valid source file if not then ignore this hunk
|
||||
next if ($realfile !~ /\.(h|c|cpp|s|S|pl|sh)$/);
|
||||
|
||||
#80 column limit
|
||||
if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
|
||||
$rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
|
||||
!($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ ||
|
||||
$line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) &&
|
||||
if ($line =~ /^\+/ &&
|
||||
!($line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) &&
|
||||
$length > 80)
|
||||
{
|
||||
WARN("line over 80 characters\n" . $herecurr);
|
||||
@ -1471,18 +1343,6 @@ sub process {
|
||||
WARN("adding a line without newline at end of file\n" . $herecurr);
|
||||
}
|
||||
|
||||
# Blackfin: use hi/lo macros
|
||||
if ($realfile =~ m@arch/blackfin/.*\.S$@) {
|
||||
if ($line =~ /\.[lL][[:space:]]*=.*&[[:space:]]*0x[fF][fF][fF][fF]/) {
|
||||
my $herevet = "$here\n" . cat_vet($line) . "\n";
|
||||
ERROR("use the LO() macro, not (... & 0xFFFF)\n" . $herevet);
|
||||
}
|
||||
if ($line =~ /\.[hH][[:space:]]*=.*>>[[:space:]]*16/) {
|
||||
my $herevet = "$here\n" . cat_vet($line) . "\n";
|
||||
ERROR("use the HI() macro, not (... >> 16)\n" . $herevet);
|
||||
}
|
||||
}
|
||||
|
||||
# check we are in a valid source file C or perl if not then ignore this hunk
|
||||
next if ($realfile !~ /\.(h|c|cpp|pl)$/);
|
||||
|
||||
@ -1501,16 +1361,6 @@ sub process {
|
||||
WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr);
|
||||
}
|
||||
|
||||
# Blackfin: don't use __builtin_bfin_[cs]sync
|
||||
if ($line =~ /__builtin_bfin_csync/) {
|
||||
my $herevet = "$here\n" . cat_vet($line) . "\n";
|
||||
ERROR("use the CSYNC() macro in asm/blackfin.h\n" . $herevet);
|
||||
}
|
||||
if ($line =~ /__builtin_bfin_ssync/) {
|
||||
my $herevet = "$here\n" . cat_vet($line) . "\n";
|
||||
ERROR("use the SSYNC() macro in asm/blackfin.h\n" . $herevet);
|
||||
}
|
||||
|
||||
# Check for potential 'bare' types
|
||||
my ($stat, $cond, $line_nr_next, $remain_next, $off_next,
|
||||
$realline_next);
|
||||
@ -1794,50 +1644,6 @@ sub process {
|
||||
$line =~ s@//.*@@;
|
||||
$opline =~ s@//.*@@;
|
||||
|
||||
# EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
|
||||
# the whole statement.
|
||||
#print "APW <$lines[$realline_next - 1]>\n";
|
||||
if (defined $realline_next &&
|
||||
exists $lines[$realline_next - 1] &&
|
||||
!defined $suppress_export{$realline_next} &&
|
||||
($lines[$realline_next - 1] =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
|
||||
$lines[$realline_next - 1] =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
|
||||
# Handle definitions which produce identifiers with
|
||||
# a prefix:
|
||||
# XXX(foo);
|
||||
# EXPORT_SYMBOL(something_foo);
|
||||
my $name = $1;
|
||||
if ($stat =~ /^.([A-Z_]+)\s*\(\s*($Ident)/ &&
|
||||
$name =~ /^${Ident}_$2/) {
|
||||
#print "FOO C name<$name>\n";
|
||||
$suppress_export{$realline_next} = 1;
|
||||
|
||||
} elsif ($stat !~ /(?:
|
||||
\n.}\s*$|
|
||||
^.DEFINE_$Ident\(\Q$name\E\)|
|
||||
^.DECLARE_$Ident\(\Q$name\E\)|
|
||||
^.LIST_HEAD\(\Q$name\E\)|
|
||||
^.(?:$Storage\s+)?$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(|
|
||||
\b\Q$name\E(?:\s+$Attribute)*\s*(?:;|=|\[|\()
|
||||
)/x) {
|
||||
#print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
|
||||
$suppress_export{$realline_next} = 2;
|
||||
} else {
|
||||
$suppress_export{$realline_next} = 1;
|
||||
}
|
||||
}
|
||||
if (!defined $suppress_export{$linenr} &&
|
||||
$prevline =~ /^.\s*$/ &&
|
||||
($line =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
|
||||
$line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
|
||||
#print "FOO B <$lines[$linenr - 1]>\n";
|
||||
$suppress_export{$linenr} = 2;
|
||||
}
|
||||
if (defined $suppress_export{$linenr} &&
|
||||
$suppress_export{$linenr} == 2) {
|
||||
WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
|
||||
}
|
||||
|
||||
# check for global initialisers.
|
||||
if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) {
|
||||
ERROR("do not initialise globals to 0 or NULL\n" .
|
||||
@ -1885,40 +1691,6 @@ sub process {
|
||||
}
|
||||
}
|
||||
|
||||
# # no BUG() or BUG_ON()
|
||||
# if ($line =~ /\b(BUG|BUG_ON)\b/) {
|
||||
# print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
|
||||
# print "$herecurr";
|
||||
# $clean = 0;
|
||||
# }
|
||||
|
||||
if ($line =~ /\bLINUX_VERSION_CODE\b/) {
|
||||
WARN("LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
|
||||
}
|
||||
|
||||
# printk should use KERN_* levels. Note that follow on printk's on the
|
||||
# same line do not need a level, so we use the current block context
|
||||
# to try and find and validate the current printk. In summary the current
|
||||
# printk includes all preceding printk's which have no newline on the end.
|
||||
# we assume the first bad printk is the one to report.
|
||||
if ($line =~ /\bprintk\((?!KERN_)\s*"/) {
|
||||
my $ok = 0;
|
||||
for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) {
|
||||
#print "CHECK<$lines[$ln - 1]\n";
|
||||
# we have a preceding printk if it ends
|
||||
# with "\n" ignore it, else it is to blame
|
||||
if ($lines[$ln - 1] =~ m{\bprintk\(}) {
|
||||
if ($rawlines[$ln - 1] !~ m{\\n"}) {
|
||||
$ok = 1;
|
||||
}
|
||||
last;
|
||||
}
|
||||
}
|
||||
if ($ok == 0) {
|
||||
WARN("printk() should include KERN_ facility level\n" . $herecurr);
|
||||
}
|
||||
}
|
||||
|
||||
# function brace can't be on same line, except for #defines of do while,
|
||||
# or if closed on same line
|
||||
if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and
|
||||
@ -2180,26 +1952,6 @@ sub process {
|
||||
}
|
||||
}
|
||||
|
||||
# check for multiple assignments
|
||||
if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) {
|
||||
CHK("multiple assignments should be avoided\n" . $herecurr);
|
||||
}
|
||||
|
||||
## # check for multiple declarations, allowing for a function declaration
|
||||
## # continuation.
|
||||
## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
|
||||
## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
|
||||
##
|
||||
## # Remove any bracketed sections to ensure we do not
|
||||
## # falsly report the parameters of functions.
|
||||
## my $ln = $line;
|
||||
## while ($ln =~ s/\([^\(\)]*\)//g) {
|
||||
## }
|
||||
## if ($ln =~ /,/) {
|
||||
## WARN("declaring multiple variables together should be avoided\n" . $herecurr);
|
||||
## }
|
||||
## }
|
||||
|
||||
#need space before brace following if, while, etc
|
||||
if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) ||
|
||||
$line =~ /do{/) {
|
||||
@ -2388,22 +2140,6 @@ sub process {
|
||||
WARN("Whitepspace after \\ makes next lines useless\n" . $herecurr);
|
||||
}
|
||||
|
||||
#warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line)
|
||||
if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) {
|
||||
my $file = "$1.h";
|
||||
my $checkfile = "include/linux/$file";
|
||||
if (-f "$root/$checkfile" &&
|
||||
$realfile ne $checkfile &&
|
||||
$1 !~ /$allowed_asm_includes/)
|
||||
{
|
||||
if ($realfile =~ m{^arch/}) {
|
||||
CHK("Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
|
||||
} else {
|
||||
WARN("Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
# multi-statement macros should be enclosed in a do while loop, grab the
|
||||
# first statement and ensure its the whole macro if its not enclosed
|
||||
# in a known good container
|
||||
@ -2498,15 +2234,6 @@ sub process {
|
||||
}
|
||||
}
|
||||
|
||||
# make sure symbols are always wrapped with VMLINUX_SYMBOL() ...
|
||||
# all assignments may have only one of the following with an assignment:
|
||||
# .
|
||||
# ALIGN(...)
|
||||
# VMLINUX_SYMBOL(...)
|
||||
if ($realfile eq 'vmlinux.lds.h' && $line =~ /(?:(?:^|\s)$Ident\s*=|=\s*$Ident(?:\s|$))/) {
|
||||
WARN("vmlinux.lds.h needs VMLINUX_SYMBOL() around C-visible symbols\n" . $herecurr);
|
||||
}
|
||||
|
||||
# check for missing bracing round if etc
|
||||
if ($line =~ /(^.*)\bif\b/ && $line !~ /\#\s*if/) {
|
||||
my ($level, $endln, @chunks) =
|
||||
@ -2634,31 +2361,12 @@ sub process {
|
||||
}
|
||||
}
|
||||
|
||||
# don't include deprecated include files (uses RAW line)
|
||||
for my $inc (@dep_includes) {
|
||||
if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) {
|
||||
ERROR("Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr);
|
||||
}
|
||||
}
|
||||
|
||||
# don't use deprecated functions
|
||||
for my $func (@dep_functions) {
|
||||
if ($line =~ /\b$func\b/) {
|
||||
ERROR("Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr);
|
||||
}
|
||||
}
|
||||
|
||||
# no volatiles please
|
||||
my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
|
||||
if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
|
||||
WARN("Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
|
||||
}
|
||||
|
||||
# SPIN_LOCK_UNLOCKED & RW_LOCK_UNLOCKED are deprecated
|
||||
if ($line =~ /\b(SPIN_LOCK_UNLOCKED|RW_LOCK_UNLOCKED)/) {
|
||||
ERROR("Use of $1 is deprecated: see Documentation/spinlocks.txt\n" . $herecurr);
|
||||
}
|
||||
|
||||
# warn about #if 0
|
||||
if ($line =~ /^.\s*\#\s*if\s+0\b/) {
|
||||
WARN("if this code is redundant consider removing it\n" .
|
||||
@ -2672,28 +2380,6 @@ sub process {
|
||||
WARN("g_free(NULL) is safe this check is probably not required\n" . $hereprev);
|
||||
}
|
||||
}
|
||||
# check for needless usb_free_urb() checks
|
||||
if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
|
||||
my $expr = $1;
|
||||
if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) {
|
||||
WARN("usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev);
|
||||
}
|
||||
}
|
||||
|
||||
# prefer usleep_range over udelay
|
||||
if ($line =~ /\budelay\s*\(\s*(\w+)\s*\)/) {
|
||||
# ignore udelay's < 10, however
|
||||
if (! (($1 =~ /(\d+)/) && ($1 < 10)) ) {
|
||||
CHK("usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $line);
|
||||
}
|
||||
}
|
||||
|
||||
# warn about unexpectedly long msleep's
|
||||
if ($line =~ /\bmsleep\s*\((\d+)\);/) {
|
||||
if ($1 < 20) {
|
||||
WARN("msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt\n" . $line);
|
||||
}
|
||||
}
|
||||
|
||||
# warn about #ifdefs in C files
|
||||
# if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
|
||||
@ -2706,15 +2392,6 @@ sub process {
|
||||
if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) {
|
||||
ERROR("exactly one space required after that #$1\n" . $herecurr);
|
||||
}
|
||||
|
||||
# check for spinlock_t definitions without a comment.
|
||||
if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
|
||||
$line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
|
||||
my $which = $1;
|
||||
if (!ctx_has_comment($first_line, $linenr)) {
|
||||
CHK("$1 definition without comment\n" . $herecurr);
|
||||
}
|
||||
}
|
||||
# check for memory barriers without a comment.
|
||||
if ($line =~ /\b(smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
|
||||
if (!ctx_has_comment($first_line, $linenr)) {
|
||||
@ -2740,11 +2417,6 @@ sub process {
|
||||
ERROR("inline keyword should sit between storage class and type\n" . $herecurr);
|
||||
}
|
||||
|
||||
# Check for __inline__ and __inline, prefer inline
|
||||
if ($line =~ /\b(__inline__|__inline)\b/) {
|
||||
WARN("plain inline is preferred over $1\n" . $herecurr);
|
||||
}
|
||||
|
||||
# check for sizeof(&)
|
||||
if ($line =~ /\bsizeof\s*\(\s*\&/) {
|
||||
WARN("sizeof(& should be avoided\n" . $herecurr);
|
||||
@ -2777,15 +2449,6 @@ sub process {
|
||||
WARN("externs should be avoided in .c files\n" . $herecurr);
|
||||
}
|
||||
|
||||
# checks for new __setup's
|
||||
if ($rawline =~ /\b__setup\("([^"]*)"/) {
|
||||
my $name = $1;
|
||||
|
||||
if (!grep(/$name/, @setup_docs)) {
|
||||
CHK("__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr);
|
||||
}
|
||||
}
|
||||
|
||||
# check for pointless casting of g_malloc return
|
||||
if ($line =~ /\*\s*\)\s*g_(try)?(m|re)alloc(0?)(_n)?\b/) {
|
||||
if ($2 == 'm') {
|
||||
@ -2800,15 +2463,6 @@ sub process {
|
||||
WARN("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr);
|
||||
}
|
||||
|
||||
# check for semaphores used as mutexes
|
||||
if ($line =~ /^.\s*(DECLARE_MUTEX|init_MUTEX)\s*\(/) {
|
||||
WARN("mutexes are preferred for single holder semaphores\n" . $herecurr);
|
||||
}
|
||||
# check for semaphores used as mutexes
|
||||
if ($line =~ /^.\s*init_MUTEX_LOCKED\s*\(/) {
|
||||
WARN("consider using a completion\n" . $herecurr);
|
||||
|
||||
}
|
||||
# recommend qemu_strto* over strto*
|
||||
if ($line =~ /\b(strto.*?)\s*\(/) {
|
||||
WARN("consider using qemu_$1 in preference to $1\n" . $herecurr);
|
||||
@ -2844,18 +2498,6 @@ sub process {
|
||||
$herecurr);
|
||||
}
|
||||
|
||||
# use of NR_CPUS is usually wrong
|
||||
# ignore definitions of NR_CPUS and usage to define arrays as likely right
|
||||
if ($line =~ /\bNR_CPUS\b/ &&
|
||||
$line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ &&
|
||||
$line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ &&
|
||||
$line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ &&
|
||||
$line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ &&
|
||||
$line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/)
|
||||
{
|
||||
WARN("usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
|
||||
}
|
||||
|
||||
# check for %L{u,d,i} in strings
|
||||
my $string;
|
||||
while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
|
||||
@ -2867,25 +2509,6 @@ sub process {
|
||||
}
|
||||
}
|
||||
|
||||
# whine mightly about in_atomic
|
||||
if ($line =~ /\bin_atomic\s*\(/) {
|
||||
if ($realfile =~ m@^drivers/@) {
|
||||
ERROR("do not use in_atomic in drivers\n" . $herecurr);
|
||||
} elsif ($realfile !~ m@^kernel/@) {
|
||||
WARN("use of in_atomic() is incorrect outside core kernel code\n" . $herecurr);
|
||||
}
|
||||
}
|
||||
|
||||
# check for lockdep_set_novalidate_class
|
||||
if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ ||
|
||||
$line =~ /__lockdep_no_validate__\s*\)/ ) {
|
||||
if ($realfile !~ m@^kernel/lockdep@ &&
|
||||
$realfile !~ m@^include/linux/lockdep@ &&
|
||||
$realfile !~ m@^drivers/base/core@) {
|
||||
ERROR("lockdep_no_validate class is reserved for device->mutex.\n" . $herecurr);
|
||||
}
|
||||
}
|
||||
|
||||
# QEMU specific tests
|
||||
if ($rawline =~ /\b(?:Qemu|QEmu)\b/) {
|
||||
WARN("use QEMU instead of Qemu or QEmu\n" . $herecurr);
|
||||
|
||||
Loading…
Reference in New Issue
Block a user