char: add and use tcp_chr_wait_connected

Add a chr_wait_connected for the tcp backend, and use it in the
open_socket() function.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Marc-André Lureau 2016-07-27 01:15:18 +04:00 committed by Michael S. Tsirkin
parent 6b6723c3b5
commit d7a04fd7d5

View File

@ -3139,6 +3139,32 @@ static gboolean tcp_chr_accept(QIOChannel *channel,
return TRUE; return TRUE;
} }
static int tcp_chr_wait_connected(CharDriverState *chr, Error **errp)
{
TCPCharDriver *s = chr->opaque;
QIOChannelSocket *sioc;
while (!s->connected) {
if (s->is_listen) {
fprintf(stderr, "QEMU waiting for connection on: %s\n",
chr->filename);
qio_channel_set_blocking(QIO_CHANNEL(s->listen_ioc), true, NULL);
tcp_chr_accept(QIO_CHANNEL(s->listen_ioc), G_IO_IN, chr);
qio_channel_set_blocking(QIO_CHANNEL(s->listen_ioc), false, NULL);
} else {
sioc = qio_channel_socket_new();
if (qio_channel_socket_connect_sync(sioc, s->addr, errp) < 0) {
object_unref(OBJECT(sioc));
return -1;
}
tcp_chr_new_client(chr, sioc);
object_unref(OBJECT(sioc));
}
}
return 0;
}
int qemu_chr_wait_connected(CharDriverState *chr, Error **errp) int qemu_chr_wait_connected(CharDriverState *chr, Error **errp)
{ {
if (chr->chr_wait_connected) { if (chr->chr_wait_connected) {
@ -4402,6 +4428,7 @@ static CharDriverState *qmp_chardev_open_socket(const char *id,
s->addr = QAPI_CLONE(SocketAddress, sock->addr); s->addr = QAPI_CLONE(SocketAddress, sock->addr);
chr->opaque = s; chr->opaque = s;
chr->chr_wait_connected = tcp_chr_wait_connected;
chr->chr_write = tcp_chr_write; chr->chr_write = tcp_chr_write;
chr->chr_sync_read = tcp_chr_sync_read; chr->chr_sync_read = tcp_chr_sync_read;
chr->chr_close = tcp_chr_close; chr->chr_close = tcp_chr_close;
@ -4425,32 +4452,30 @@ static CharDriverState *qmp_chardev_open_socket(const char *id,
s->reconnect_time = reconnect; s->reconnect_time = reconnect;
} }
sioc = qio_channel_socket_new();
if (s->reconnect_time) { if (s->reconnect_time) {
sioc = qio_channel_socket_new();
qio_channel_socket_connect_async(sioc, s->addr, qio_channel_socket_connect_async(sioc, s->addr,
qemu_chr_socket_connected, qemu_chr_socket_connected,
chr, NULL); chr, NULL);
} else if (s->is_listen) {
if (qio_channel_socket_listen_sync(sioc, s->addr, errp) < 0) {
goto error;
}
s->listen_ioc = sioc;
if (is_waitconnect) {
fprintf(stderr, "QEMU waiting for connection on: %s\n",
chr->filename);
tcp_chr_accept(QIO_CHANNEL(s->listen_ioc), G_IO_IN, chr);
}
qio_channel_set_blocking(QIO_CHANNEL(s->listen_ioc), false, NULL);
if (!s->ioc) {
s->listen_tag = qio_channel_add_watch(
QIO_CHANNEL(s->listen_ioc), G_IO_IN, tcp_chr_accept, chr, NULL);
}
} else { } else {
if (qio_channel_socket_connect_sync(sioc, s->addr, errp) < 0) { if (s->is_listen) {
sioc = qio_channel_socket_new();
if (qio_channel_socket_listen_sync(sioc, s->addr, errp) < 0) {
goto error;
}
s->listen_ioc = sioc;
if (is_waitconnect &&
qemu_chr_wait_connected(chr, errp) < 0) {
goto error;
}
if (!s->ioc) {
s->listen_tag = qio_channel_add_watch(
QIO_CHANNEL(s->listen_ioc), G_IO_IN,
tcp_chr_accept, chr, NULL);
}
} else if (qemu_chr_wait_connected(chr, errp) < 0) {
goto error; goto error;
} }
tcp_chr_new_client(chr, sioc);
object_unref(OBJECT(sioc));
} }
return chr; return chr;