mirror of
https://github.com/qemu/qemu.git
synced 2024-11-24 19:33:39 +08:00
linux-user: Expand log_page_dump inline
We have extra stuff to log at the same time. Hoist the qemu_log_lock/unlock to the caller and use fprintf. Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Message-Id: <20220417183019.755276-23-richard.henderson@linaro.org>
This commit is contained in:
parent
43b761618d
commit
93756fdcf6
@ -42,19 +42,4 @@ static inline void log_cpu_state_mask(int mask, CPUState *cpu, int flags)
|
||||
}
|
||||
}
|
||||
|
||||
#ifdef NEED_CPU_H
|
||||
#if defined(CONFIG_USER_ONLY)
|
||||
/* page_dump() output to the log file: */
|
||||
static inline void log_page_dump(const char *operation)
|
||||
{
|
||||
FILE *logfile = qemu_log_trylock();
|
||||
if (logfile) {
|
||||
fprintf(logfile, "page layout changed following %s\n", operation);
|
||||
page_dump(logfile);
|
||||
}
|
||||
qemu_log_unlock(logfile);
|
||||
}
|
||||
#endif
|
||||
#endif
|
||||
|
||||
#endif
|
||||
|
@ -857,21 +857,36 @@ int main(int argc, char **argv, char **envp)
|
||||
g_free(target_environ);
|
||||
|
||||
if (qemu_loglevel_mask(CPU_LOG_PAGE)) {
|
||||
qemu_log("guest_base %p\n", (void *)guest_base);
|
||||
log_page_dump("binary load");
|
||||
FILE *f = qemu_log_trylock();
|
||||
if (f) {
|
||||
fprintf(f, "guest_base %p\n", (void *)guest_base);
|
||||
fprintf(f, "page layout changed following binary load\n");
|
||||
page_dump(f);
|
||||
|
||||
qemu_log("start_brk 0x" TARGET_ABI_FMT_lx "\n", info->start_brk);
|
||||
qemu_log("end_code 0x" TARGET_ABI_FMT_lx "\n", info->end_code);
|
||||
qemu_log("start_code 0x" TARGET_ABI_FMT_lx "\n", info->start_code);
|
||||
qemu_log("start_data 0x" TARGET_ABI_FMT_lx "\n", info->start_data);
|
||||
qemu_log("end_data 0x" TARGET_ABI_FMT_lx "\n", info->end_data);
|
||||
qemu_log("start_stack 0x" TARGET_ABI_FMT_lx "\n", info->start_stack);
|
||||
qemu_log("brk 0x" TARGET_ABI_FMT_lx "\n", info->brk);
|
||||
qemu_log("entry 0x" TARGET_ABI_FMT_lx "\n", info->entry);
|
||||
qemu_log("argv_start 0x" TARGET_ABI_FMT_lx "\n", info->arg_start);
|
||||
qemu_log("env_start 0x" TARGET_ABI_FMT_lx "\n",
|
||||
info->arg_end + (abi_ulong)sizeof(abi_ulong));
|
||||
qemu_log("auxv_start 0x" TARGET_ABI_FMT_lx "\n", info->saved_auxv);
|
||||
fprintf(f, "start_brk 0x" TARGET_ABI_FMT_lx "\n",
|
||||
info->start_brk);
|
||||
fprintf(f, "end_code 0x" TARGET_ABI_FMT_lx "\n",
|
||||
info->end_code);
|
||||
fprintf(f, "start_code 0x" TARGET_ABI_FMT_lx "\n",
|
||||
info->start_code);
|
||||
fprintf(f, "start_data 0x" TARGET_ABI_FMT_lx "\n",
|
||||
info->start_data);
|
||||
fprintf(f, "end_data 0x" TARGET_ABI_FMT_lx "\n",
|
||||
info->end_data);
|
||||
fprintf(f, "start_stack 0x" TARGET_ABI_FMT_lx "\n",
|
||||
info->start_stack);
|
||||
fprintf(f, "brk 0x" TARGET_ABI_FMT_lx "\n",
|
||||
info->brk);
|
||||
fprintf(f, "entry 0x" TARGET_ABI_FMT_lx "\n",
|
||||
info->entry);
|
||||
fprintf(f, "argv_start 0x" TARGET_ABI_FMT_lx "\n",
|
||||
info->arg_start);
|
||||
fprintf(f, "env_start 0x" TARGET_ABI_FMT_lx "\n",
|
||||
info->arg_end + (abi_ulong)sizeof(abi_ulong));
|
||||
fprintf(f, "auxv_start 0x" TARGET_ABI_FMT_lx "\n",
|
||||
info->saved_auxv);
|
||||
qemu_log_unlock(f);
|
||||
}
|
||||
}
|
||||
|
||||
target_set_brk(info->brk);
|
||||
|
@ -630,7 +630,12 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int target_prot,
|
||||
the_end:
|
||||
trace_target_mmap_complete(start);
|
||||
if (qemu_loglevel_mask(CPU_LOG_PAGE)) {
|
||||
log_page_dump(__func__);
|
||||
FILE *f = qemu_log_trylock();
|
||||
if (f) {
|
||||
fprintf(f, "page layout changed following mmap\n");
|
||||
page_dump(f);
|
||||
qemu_log_unlock(f);
|
||||
}
|
||||
}
|
||||
tb_invalidate_phys_range(start, start + len);
|
||||
mmap_unlock();
|
||||
|
Loading…
Reference in New Issue
Block a user