mirrors/qemu
0
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2024-12-01 07:43:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

target-i386: Don't left shift negative constant

Browse Source 
Left shift of negative values is undefined behavior. Detected by clang:
  qemu/target-i386/translate.c:2423:26: runtime error:
    left shift of negative value -8

This changes the code to reverse the sign after the left shift.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
This commit is contained in:
Eduardo Habkost 2015-09-29 17:34:23 -03:00
parent 7e038b94e7
commit 712b4243c7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
target-i386/translate.c
View File

@ -2432,7 +2432,7 @@ static void gen_pusha(DisasContext *s)
{ {
int i; int i;
gen_op_movl_A0_reg(R_ESP); gen_op_movl_A0_reg(R_ESP);
gen_op_addl_A0_im(-8 << s->dflag); gen_op_addl_A0_im(-(8 << s->dflag));
if (!s->ss32) if (!s->ss32)
tcg_gen_ext16u_tl(cpu_A0, cpu_A0); tcg_gen_ext16u_tl(cpu_A0, cpu_A0);
tcg_gen_mov_tl(cpu_T[1], cpu_A0); tcg_gen_mov_tl(cpu_T[1], cpu_A0);