mirrors/qemu
0
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2024-11-23 19:03:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

blockdev: fix drive-mirror 'granularity' error message

Browse Source 
Name the 'granularity' parameter and give its expected value range.
Previously the device name was mistakenly reported as the parameter
name.

Note that the error class is unchanged from ERROR_CLASS_GENERIC_ERROR.

Reported-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Benoît Canet <benoit.canet@nodalink.com>
This commit is contained in:
Stefan Hajnoczi 2014-08-27 14:29:59 +01:00
parent 0b9caf9b31
commit 3cbbe9fd1f
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
blockdev.c
View File

@ -2179,11 +2179,12 @@ void qmp_drive_mirror(const char *device, const char *target,
} }
if (granularity != 0 && (granularity < 512 || granularity > 1048576 * 64)) { if (granularity != 0 && (granularity < 512 || granularity > 1048576 * 64)) {
error_set(errp, QERR_INVALID_PARAMETER, device); error_set(errp, QERR_INVALID_PARAMETER_VALUE, "granularity",
"a value in range [512B, 64MB]");
return; return;
} }
if (granularity & (granularity - 1)) { if (granularity & (granularity - 1)) {
error_set(errp, QERR_INVALID_PARAMETER, device); error_set(errp, QERR_INVALID_PARAMETER_VALUE, "granularity", "power of 2");
return; return;
} }