mirrors/qemu
0
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2024-11-28 22:33:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

tests/qtest/ide-test: Verify that DIAGNOSTIC clears DEV to zero

Browse Source 
Verify correction of EXECUTE DEVICE DIAGNOSTIC introduced in commit
72423831c3 (hw/ide/core: Clear LBA and drive bits for EXECUTE DEVICE
DIAGNOSTIC, 2022-05-28).

Signed-off-by: Lev Kujawski <lkujaw@member.fsf.org>
Message-Id: <20220707031140.158958-4-lkujaw@member.fsf.org>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Lev Kujawski 2022-07-07 03:11:37 +00:00 committed by Kevin Wolf
parent 3195c9e6ab
commit 2cc38a02e6
1 changed files with 33 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
tests/qtest/ide-test.c
View File

@ -90,6 +90,7 @@ enum {
enum { enum {
CMD_DSM = 0x06, CMD_DSM = 0x06,
CMD_DIAGNOSE = 0x90,
CMD_READ_DMA = 0xc8, CMD_READ_DMA = 0xc8,
CMD_WRITE_DMA = 0xca, CMD_WRITE_DMA = 0xca,
CMD_FLUSH_CACHE = 0xe7, CMD_FLUSH_CACHE = 0xe7,
@ -614,6 +615,36 @@ static void test_identify(void)
free_pci_device(dev); free_pci_device(dev);
} }
static void test_diagnostic(void)
{
QTestState *qts;
QPCIDevice *dev;
QPCIBar bmdma_bar, ide_bar;
uint8_t data;
qts = ide_test_start(
"-blockdev driver=file,node-name=hda,filename=%s "
"-blockdev driver=file,node-name=hdb,filename=%s "
"-device ide-hd,drive=hda,bus=ide.0,unit=0 "
"-device ide-hd,drive=hdb,bus=ide.0,unit=1 ",
tmp_path[0], tmp_path[1]);
dev = get_pci_device(qts, &bmdma_bar, &ide_bar);
/* DIAGNOSE command on device 1 */
qpci_io_writeb(dev, ide_bar, reg_device, DEV);
data = qpci_io_readb(dev, ide_bar, reg_device);
g_assert_cmphex(data & DEV, ==, DEV);
qpci_io_writeb(dev, ide_bar, reg_command, CMD_DIAGNOSE);
/* Verify that DEVICE is now 0 */
data = qpci_io_readb(dev, ide_bar, reg_device);
g_assert_cmphex(data & DEV, ==, 0);
ide_test_quit(qts);
free_pci_device(dev);
}
/* /*
* Write sector 1 with random data to make IDE storage dirty * Write sector 1 with random data to make IDE storage dirty
* Needed for flush tests so that flushes actually go though the block layer * Needed for flush tests so that flushes actually go though the block layer
@ -1050,6 +1081,8 @@ int main(int argc, char **argv)
qtest_add_func("/ide/identify", test_identify); qtest_add_func("/ide/identify", test_identify);
qtest_add_func("/ide/diagnostic", test_diagnostic);
qtest_add_func("/ide/bmdma/simple_rw", test_bmdma_simple_rw); qtest_add_func("/ide/bmdma/simple_rw", test_bmdma_simple_rw);
qtest_add_func("/ide/bmdma/trim", test_bmdma_trim); qtest_add_func("/ide/bmdma/trim", test_bmdma_trim);
qtest_add_func("/ide/bmdma/various_prdts", test_bmdma_various_prdts); qtest_add_func("/ide/bmdma/various_prdts", test_bmdma_various_prdts);