2020-01-22 23:16:07 +08:00
|
|
|
/*
|
|
|
|
* Multifd common code
|
|
|
|
*
|
|
|
|
* Copyright (c) 2019-2020 Red Hat Inc
|
|
|
|
*
|
|
|
|
* Authors:
|
|
|
|
* Juan Quintela <quintela@redhat.com>
|
|
|
|
*
|
|
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
|
|
* See the COPYING file in the top-level directory.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "qemu/osdep.h"
|
|
|
|
#include "qemu/rcu.h"
|
|
|
|
#include "exec/target_page.h"
|
|
|
|
#include "sysemu/sysemu.h"
|
|
|
|
#include "exec/ramblock.h"
|
|
|
|
#include "qemu/error-report.h"
|
|
|
|
#include "qapi/error.h"
|
|
|
|
#include "ram.h"
|
|
|
|
#include "migration.h"
|
2023-04-27 01:04:06 +08:00
|
|
|
#include "migration-stats.h"
|
2020-01-22 23:16:07 +08:00
|
|
|
#include "socket.h"
|
2020-09-15 11:04:01 +08:00
|
|
|
#include "tls.h"
|
2020-01-22 23:16:07 +08:00
|
|
|
#include "qemu-file.h"
|
|
|
|
#include "trace.h"
|
|
|
|
#include "multifd.h"
|
2023-02-03 15:35:19 +08:00
|
|
|
#include "threadinfo.h"
|
2023-03-02 05:17:14 +08:00
|
|
|
#include "options.h"
|
2020-12-28 23:08:52 +08:00
|
|
|
#include "qemu/yank.h"
|
|
|
|
#include "io/channel-socket.h"
|
2021-03-24 01:52:42 +08:00
|
|
|
#include "yank_functions.h"
|
2020-12-28 23:08:52 +08:00
|
|
|
|
2020-01-22 23:16:07 +08:00
|
|
|
/* Multiple fd's */
|
|
|
|
|
|
|
|
#define MULTIFD_MAGIC 0x11223344U
|
|
|
|
#define MULTIFD_VERSION 1
|
|
|
|
|
|
|
|
typedef struct {
|
|
|
|
uint32_t magic;
|
|
|
|
uint32_t version;
|
|
|
|
unsigned char uuid[16]; /* QemuUUID */
|
|
|
|
uint8_t id;
|
|
|
|
uint8_t unused1[7]; /* Reserved for future use */
|
|
|
|
uint64_t unused2[4]; /* Reserved for future use */
|
|
|
|
} __attribute__((packed)) MultiFDInit_t;
|
|
|
|
|
2024-02-02 18:28:56 +08:00
|
|
|
struct {
|
|
|
|
MultiFDSendParams *params;
|
|
|
|
/* array of pages to sent */
|
|
|
|
MultiFDPages_t *pages;
|
|
|
|
/*
|
|
|
|
* Global number of generated multifd packets.
|
|
|
|
*
|
|
|
|
* Note that we used 'uintptr_t' because it'll naturally support atomic
|
|
|
|
* operations on both 32bit / 64 bits hosts. It means on 32bit systems
|
|
|
|
* multifd will overflow the packet_num easier, but that should be
|
|
|
|
* fine.
|
|
|
|
*
|
|
|
|
* Another option is to use QEMU's Stat64 then it'll be 64 bits on all
|
|
|
|
* hosts, however so far it does not support atomic fetch_add() yet.
|
|
|
|
* Make it easy for now.
|
|
|
|
*/
|
|
|
|
uintptr_t packet_num;
|
2024-02-07 05:51:18 +08:00
|
|
|
/*
|
|
|
|
* Synchronization point past which no more channels will be
|
|
|
|
* created.
|
|
|
|
*/
|
|
|
|
QemuSemaphore channels_created;
|
2024-02-02 18:28:56 +08:00
|
|
|
/* send channels ready */
|
|
|
|
QemuSemaphore channels_ready;
|
|
|
|
/*
|
|
|
|
* Have we already run terminate threads. There is a race when it
|
|
|
|
* happens that we got one error while we are exiting.
|
|
|
|
* We will use atomic operations. Only valid values are 0 and 1.
|
|
|
|
*/
|
|
|
|
int exiting;
|
|
|
|
/* multifd ops */
|
|
|
|
MultiFDMethods *ops;
|
|
|
|
} *multifd_send_state;
|
|
|
|
|
2024-02-21 06:41:08 +08:00
|
|
|
struct {
|
|
|
|
MultiFDRecvParams *params;
|
|
|
|
/* number of created threads */
|
|
|
|
int count;
|
|
|
|
/* syncs main thread and channels */
|
|
|
|
QemuSemaphore sem_sync;
|
|
|
|
/* global number of generated multifd packets */
|
|
|
|
uint64_t packet_num;
|
|
|
|
int exiting;
|
|
|
|
/* multifd ops */
|
|
|
|
MultiFDMethods *ops;
|
|
|
|
} *multifd_recv_state;
|
|
|
|
|
2019-05-15 19:37:46 +08:00
|
|
|
/* Multifd without compression */
|
|
|
|
|
|
|
|
/**
|
|
|
|
* nocomp_send_setup: setup send side
|
|
|
|
*
|
|
|
|
* @p: Params for the channel that we are using
|
|
|
|
* @errp: pointer to an error
|
|
|
|
*/
|
|
|
|
static int nocomp_send_setup(MultiFDSendParams *p, Error **errp)
|
|
|
|
{
|
2024-02-02 18:28:47 +08:00
|
|
|
if (migrate_zero_copy_send()) {
|
|
|
|
p->write_flags |= QIO_CHANNEL_WRITE_FLAG_ZERO_COPY;
|
|
|
|
}
|
|
|
|
|
2019-05-15 19:37:46 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* nocomp_send_cleanup: cleanup send side
|
|
|
|
*
|
|
|
|
* For no compression this function does nothing.
|
|
|
|
*
|
|
|
|
* @p: Params for the channel that we are using
|
2021-11-22 18:58:41 +08:00
|
|
|
* @errp: pointer to an error
|
2019-05-15 19:37:46 +08:00
|
|
|
*/
|
|
|
|
static void nocomp_send_cleanup(MultiFDSendParams *p, Error **errp)
|
|
|
|
{
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* nocomp_send_prepare: prepare date to be able to send
|
|
|
|
*
|
|
|
|
* For no compression we just have to calculate the size of the
|
|
|
|
* packet.
|
|
|
|
*
|
|
|
|
* Returns 0 for success or -1 for error
|
|
|
|
*
|
|
|
|
* @p: Params for the channel that we are using
|
|
|
|
* @errp: pointer to an error
|
|
|
|
*/
|
2021-11-22 19:08:08 +08:00
|
|
|
static int nocomp_send_prepare(MultiFDSendParams *p, Error **errp)
|
2019-05-15 19:37:46 +08:00
|
|
|
{
|
2024-02-02 18:28:47 +08:00
|
|
|
bool use_zero_copy_send = migrate_zero_copy_send();
|
2021-11-19 19:06:05 +08:00
|
|
|
MultiFDPages_t *pages = p->pages;
|
2024-02-02 18:28:47 +08:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (!use_zero_copy_send) {
|
|
|
|
/*
|
|
|
|
* Only !zerocopy needs the header in IOV; zerocopy will
|
|
|
|
* send it separately.
|
|
|
|
*/
|
|
|
|
multifd_send_prepare_header(p);
|
|
|
|
}
|
2021-11-19 19:06:05 +08:00
|
|
|
|
2024-02-02 18:28:39 +08:00
|
|
|
for (int i = 0; i < pages->num; i++) {
|
|
|
|
p->iov[p->iovs_num].iov_base = pages->block->host + pages->offset[i];
|
2022-05-02 22:45:35 +08:00
|
|
|
p->iov[p->iovs_num].iov_len = p->page_size;
|
2021-11-19 19:06:05 +08:00
|
|
|
p->iovs_num++;
|
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:39 +08:00
|
|
|
p->next_packet_size = pages->num * p->page_size;
|
2019-05-15 19:37:46 +08:00
|
|
|
p->flags |= MULTIFD_FLAG_NOCOMP;
|
2024-02-02 18:28:47 +08:00
|
|
|
|
|
|
|
multifd_send_fill_packet(p);
|
|
|
|
|
|
|
|
if (use_zero_copy_send) {
|
|
|
|
/* Send header first, without zerocopy */
|
|
|
|
ret = qio_channel_write_all(p->c, (void *)p->packet,
|
|
|
|
p->packet_len, errp);
|
|
|
|
if (ret != 0) {
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-05-15 19:37:46 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* nocomp_recv_setup: setup receive side
|
|
|
|
*
|
|
|
|
* For no compression this function does nothing.
|
|
|
|
*
|
|
|
|
* Returns 0 for success or -1 for error
|
|
|
|
*
|
|
|
|
* @p: Params for the channel that we are using
|
|
|
|
* @errp: pointer to an error
|
|
|
|
*/
|
|
|
|
static int nocomp_recv_setup(MultiFDRecvParams *p, Error **errp)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* nocomp_recv_cleanup: setup receive side
|
|
|
|
*
|
|
|
|
* For no compression this function does nothing.
|
|
|
|
*
|
|
|
|
* @p: Params for the channel that we are using
|
|
|
|
*/
|
|
|
|
static void nocomp_recv_cleanup(MultiFDRecvParams *p)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* nocomp_recv_pages: read the data from the channel into actual pages
|
|
|
|
*
|
|
|
|
* For no compression we just need to read things into the correct place.
|
|
|
|
*
|
|
|
|
* Returns 0 for success or -1 for error
|
|
|
|
*
|
|
|
|
* @p: Params for the channel that we are using
|
|
|
|
* @errp: pointer to an error
|
|
|
|
*/
|
2021-11-22 19:49:43 +08:00
|
|
|
static int nocomp_recv_pages(MultiFDRecvParams *p, Error **errp)
|
2019-05-15 19:37:46 +08:00
|
|
|
{
|
|
|
|
uint32_t flags = p->flags & MULTIFD_FLAG_COMPRESSION_MASK;
|
|
|
|
|
|
|
|
if (flags != MULTIFD_FLAG_NOCOMP) {
|
2021-12-15 21:20:48 +08:00
|
|
|
error_setg(errp, "multifd %u: flags received %x flags expected %x",
|
2019-05-15 19:37:46 +08:00
|
|
|
p->id, flags, MULTIFD_FLAG_NOCOMP);
|
|
|
|
return -1;
|
|
|
|
}
|
2021-11-22 20:41:06 +08:00
|
|
|
for (int i = 0; i < p->normal_num; i++) {
|
2021-11-22 21:10:57 +08:00
|
|
|
p->iov[i].iov_base = p->host + p->normal[i];
|
2022-05-02 22:45:35 +08:00
|
|
|
p->iov[i].iov_len = p->page_size;
|
2021-11-19 19:06:05 +08:00
|
|
|
}
|
2021-11-22 20:41:06 +08:00
|
|
|
return qio_channel_readv_all(p->c, p->iov, p->normal_num, errp);
|
2019-05-15 19:37:46 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static MultiFDMethods multifd_nocomp_ops = {
|
|
|
|
.send_setup = nocomp_send_setup,
|
|
|
|
.send_cleanup = nocomp_send_cleanup,
|
|
|
|
.send_prepare = nocomp_send_prepare,
|
|
|
|
.recv_setup = nocomp_recv_setup,
|
|
|
|
.recv_cleanup = nocomp_recv_cleanup,
|
|
|
|
.recv_pages = nocomp_recv_pages
|
|
|
|
};
|
|
|
|
|
|
|
|
static MultiFDMethods *multifd_ops[MULTIFD_COMPRESSION__MAX] = {
|
|
|
|
[MULTIFD_COMPRESSION_NONE] = &multifd_nocomp_ops,
|
|
|
|
};
|
|
|
|
|
2019-01-04 22:30:06 +08:00
|
|
|
void multifd_register_ops(int method, MultiFDMethods *ops)
|
|
|
|
{
|
|
|
|
assert(0 < method && method < MULTIFD_COMPRESSION__MAX);
|
|
|
|
multifd_ops[method] = ops;
|
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:38 +08:00
|
|
|
/* Reset a MultiFDPages_t* object for the next use */
|
|
|
|
static void multifd_pages_reset(MultiFDPages_t *pages)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* We don't need to touch offset[] array, because it will be
|
|
|
|
* overwritten later when reused.
|
|
|
|
*/
|
|
|
|
pages->num = 0;
|
|
|
|
pages->block = NULL;
|
|
|
|
}
|
|
|
|
|
2020-01-22 23:16:07 +08:00
|
|
|
static int multifd_send_initial_packet(MultiFDSendParams *p, Error **errp)
|
|
|
|
{
|
|
|
|
MultiFDInit_t msg = {};
|
2023-05-16 03:57:09 +08:00
|
|
|
size_t size = sizeof(msg);
|
2020-01-22 23:16:07 +08:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
msg.magic = cpu_to_be32(MULTIFD_MAGIC);
|
|
|
|
msg.version = cpu_to_be32(MULTIFD_VERSION);
|
|
|
|
msg.id = p->id;
|
|
|
|
memcpy(msg.uuid, &qemu_uuid.data, sizeof(msg.uuid));
|
|
|
|
|
2023-05-16 03:57:09 +08:00
|
|
|
ret = qio_channel_write_all(p->c, (char *)&msg, size, errp);
|
2020-01-22 23:16:07 +08:00
|
|
|
if (ret != 0) {
|
|
|
|
return -1;
|
|
|
|
}
|
2023-05-16 03:57:09 +08:00
|
|
|
stat64_add(&mig_stats.multifd_bytes, size);
|
2020-01-22 23:16:07 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int multifd_recv_initial_packet(QIOChannel *c, Error **errp)
|
|
|
|
{
|
|
|
|
MultiFDInit_t msg;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = qio_channel_read_all(c, (char *)&msg, sizeof(msg), errp);
|
|
|
|
if (ret != 0) {
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
msg.magic = be32_to_cpu(msg.magic);
|
|
|
|
msg.version = be32_to_cpu(msg.version);
|
|
|
|
|
|
|
|
if (msg.magic != MULTIFD_MAGIC) {
|
|
|
|
error_setg(errp, "multifd: received packet magic %x "
|
|
|
|
"expected %x", msg.magic, MULTIFD_MAGIC);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (msg.version != MULTIFD_VERSION) {
|
2021-12-15 21:20:48 +08:00
|
|
|
error_setg(errp, "multifd: received packet version %u "
|
|
|
|
"expected %u", msg.version, MULTIFD_VERSION);
|
2020-01-22 23:16:07 +08:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (memcmp(msg.uuid, &qemu_uuid, sizeof(qemu_uuid))) {
|
|
|
|
char *uuid = qemu_uuid_unparse_strdup(&qemu_uuid);
|
|
|
|
char *msg_uuid = qemu_uuid_unparse_strdup((const QemuUUID *)msg.uuid);
|
|
|
|
|
|
|
|
error_setg(errp, "multifd: received uuid '%s' and expected "
|
|
|
|
"uuid '%s' for channel %hhd", msg_uuid, uuid, msg.id);
|
|
|
|
g_free(uuid);
|
|
|
|
g_free(msg_uuid);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (msg.id > migrate_multifd_channels()) {
|
2023-12-31 17:30:10 +08:00
|
|
|
error_setg(errp, "multifd: received channel id %u is greater than "
|
|
|
|
"number of channels %u", msg.id, migrate_multifd_channels());
|
2020-01-22 23:16:07 +08:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
return msg.id;
|
|
|
|
}
|
|
|
|
|
2024-01-04 22:21:40 +08:00
|
|
|
static MultiFDPages_t *multifd_pages_init(uint32_t n)
|
2020-01-22 23:16:07 +08:00
|
|
|
{
|
|
|
|
MultiFDPages_t *pages = g_new0(MultiFDPages_t, 1);
|
|
|
|
|
2024-01-04 22:21:40 +08:00
|
|
|
pages->allocated = n;
|
|
|
|
pages->offset = g_new0(ram_addr_t, n);
|
2020-01-22 23:16:07 +08:00
|
|
|
|
|
|
|
return pages;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void multifd_pages_clear(MultiFDPages_t *pages)
|
|
|
|
{
|
2024-02-02 18:28:38 +08:00
|
|
|
multifd_pages_reset(pages);
|
2020-01-22 23:16:07 +08:00
|
|
|
pages->allocated = 0;
|
|
|
|
g_free(pages->offset);
|
|
|
|
pages->offset = NULL;
|
|
|
|
g_free(pages);
|
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:47 +08:00
|
|
|
void multifd_send_fill_packet(MultiFDSendParams *p)
|
2020-01-22 23:16:07 +08:00
|
|
|
{
|
|
|
|
MultiFDPacket_t *packet = p->packet;
|
2024-02-02 18:28:39 +08:00
|
|
|
MultiFDPages_t *pages = p->pages;
|
2024-02-02 18:28:56 +08:00
|
|
|
uint64_t packet_num;
|
2020-01-22 23:16:07 +08:00
|
|
|
int i;
|
|
|
|
|
|
|
|
packet->flags = cpu_to_be32(p->flags);
|
|
|
|
packet->pages_alloc = cpu_to_be32(p->pages->allocated);
|
2024-02-02 18:28:39 +08:00
|
|
|
packet->normal_pages = cpu_to_be32(pages->num);
|
2020-01-22 23:16:07 +08:00
|
|
|
packet->next_packet_size = cpu_to_be32(p->next_packet_size);
|
2024-02-02 18:28:56 +08:00
|
|
|
|
|
|
|
packet_num = qatomic_fetch_inc(&multifd_send_state->packet_num);
|
|
|
|
packet->packet_num = cpu_to_be64(packet_num);
|
2020-01-22 23:16:07 +08:00
|
|
|
|
2024-02-02 18:28:39 +08:00
|
|
|
if (pages->block) {
|
|
|
|
strncpy(packet->ramblock, pages->block->idstr, 256);
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:39 +08:00
|
|
|
for (i = 0; i < pages->num; i++) {
|
2020-01-22 23:16:07 +08:00
|
|
|
/* there are architectures where ram_addr_t is 32 bit */
|
2024-02-02 18:28:39 +08:00
|
|
|
uint64_t temp = pages->offset[i];
|
2020-01-22 23:16:07 +08:00
|
|
|
|
|
|
|
packet->offset[i] = cpu_to_be64(temp);
|
|
|
|
}
|
2024-02-02 18:28:43 +08:00
|
|
|
|
|
|
|
p->packets_sent++;
|
2024-02-02 18:28:44 +08:00
|
|
|
p->total_normal_pages += pages->num;
|
2024-02-02 18:28:45 +08:00
|
|
|
|
2024-02-02 18:28:56 +08:00
|
|
|
trace_multifd_send(p->id, packet_num, pages->num, p->flags,
|
2024-02-02 18:28:45 +08:00
|
|
|
p->next_packet_size);
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static int multifd_recv_unfill_packet(MultiFDRecvParams *p, Error **errp)
|
|
|
|
{
|
|
|
|
MultiFDPacket_t *packet = p->packet;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
packet->magic = be32_to_cpu(packet->magic);
|
|
|
|
if (packet->magic != MULTIFD_MAGIC) {
|
|
|
|
error_setg(errp, "multifd: received packet "
|
|
|
|
"magic %x and expected magic %x",
|
|
|
|
packet->magic, MULTIFD_MAGIC);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
packet->version = be32_to_cpu(packet->version);
|
|
|
|
if (packet->version != MULTIFD_VERSION) {
|
|
|
|
error_setg(errp, "multifd: received packet "
|
2021-12-15 21:20:48 +08:00
|
|
|
"version %u and expected version %u",
|
2020-01-22 23:16:07 +08:00
|
|
|
packet->version, MULTIFD_VERSION);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
p->flags = be32_to_cpu(packet->flags);
|
|
|
|
|
|
|
|
packet->pages_alloc = be32_to_cpu(packet->pages_alloc);
|
|
|
|
/*
|
|
|
|
* If we received a packet that is 100 times bigger than expected
|
|
|
|
* just stop migration. It is a magic number.
|
|
|
|
*/
|
2022-05-02 22:53:12 +08:00
|
|
|
if (packet->pages_alloc > p->page_count) {
|
2020-01-22 23:16:07 +08:00
|
|
|
error_setg(errp, "multifd: received packet "
|
2021-11-22 20:41:06 +08:00
|
|
|
"with size %u and expected a size of %u",
|
2022-05-02 22:53:12 +08:00
|
|
|
packet->pages_alloc, p->page_count) ;
|
2020-01-22 23:16:07 +08:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2021-11-22 21:13:51 +08:00
|
|
|
p->normal_num = be32_to_cpu(packet->normal_pages);
|
2021-11-22 20:41:06 +08:00
|
|
|
if (p->normal_num > packet->pages_alloc) {
|
2020-01-22 23:16:07 +08:00
|
|
|
error_setg(errp, "multifd: received packet "
|
2021-12-15 21:20:48 +08:00
|
|
|
"with %u pages and expected maximum pages are %u",
|
2021-11-22 20:41:06 +08:00
|
|
|
p->normal_num, packet->pages_alloc) ;
|
2020-01-22 23:16:07 +08:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
p->next_packet_size = be32_to_cpu(packet->next_packet_size);
|
|
|
|
p->packet_num = be64_to_cpu(packet->packet_num);
|
2024-02-02 18:28:43 +08:00
|
|
|
p->packets_recved++;
|
2024-02-02 18:28:44 +08:00
|
|
|
p->total_normal_pages += p->normal_num;
|
2020-01-22 23:16:07 +08:00
|
|
|
|
2024-02-02 18:28:45 +08:00
|
|
|
trace_multifd_recv(p->id, p->packet_num, p->normal_num, p->flags,
|
|
|
|
p->next_packet_size);
|
|
|
|
|
2021-11-22 20:41:06 +08:00
|
|
|
if (p->normal_num == 0) {
|
2020-01-22 23:16:07 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* make sure that ramblock is 0 terminated */
|
|
|
|
packet->ramblock[255] = 0;
|
2023-05-09 03:11:07 +08:00
|
|
|
p->block = qemu_ram_block_by_name(packet->ramblock);
|
|
|
|
if (!p->block) {
|
2020-01-22 23:16:07 +08:00
|
|
|
error_setg(errp, "multifd: unknown ram block %s",
|
|
|
|
packet->ramblock);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2023-05-09 03:11:07 +08:00
|
|
|
p->host = p->block->host;
|
2021-11-22 20:41:06 +08:00
|
|
|
for (i = 0; i < p->normal_num; i++) {
|
2020-01-22 23:16:07 +08:00
|
|
|
uint64_t offset = be64_to_cpu(packet->offset[i]);
|
|
|
|
|
2023-05-09 03:11:07 +08:00
|
|
|
if (offset > (p->block->used_length - p->page_size)) {
|
2020-01-22 23:16:07 +08:00
|
|
|
error_setg(errp, "multifd: offset too long %" PRIu64
|
|
|
|
" (max " RAM_ADDR_FMT ")",
|
2023-05-09 03:11:07 +08:00
|
|
|
offset, p->block->used_length);
|
2020-01-22 23:16:07 +08:00
|
|
|
return -1;
|
|
|
|
}
|
2021-11-22 20:41:06 +08:00
|
|
|
p->normal[i] = offset;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:37 +08:00
|
|
|
static bool multifd_send_should_exit(void)
|
|
|
|
{
|
|
|
|
return qatomic_read(&multifd_send_state->exiting);
|
|
|
|
}
|
|
|
|
|
2024-02-21 06:41:08 +08:00
|
|
|
static bool multifd_recv_should_exit(void)
|
|
|
|
{
|
|
|
|
return qatomic_read(&multifd_recv_state->exiting);
|
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:36 +08:00
|
|
|
/*
|
|
|
|
* The migration thread can wait on either of the two semaphores. This
|
|
|
|
* function can be used to kick the main thread out of waiting on either of
|
|
|
|
* them. Should mostly only be called when something wrong happened with
|
|
|
|
* the current multifd send thread.
|
|
|
|
*/
|
|
|
|
static void multifd_send_kick_main(MultiFDSendParams *p)
|
|
|
|
{
|
|
|
|
qemu_sem_post(&p->sem_sync);
|
|
|
|
qemu_sem_post(&multifd_send_state->channels_ready);
|
|
|
|
}
|
|
|
|
|
2020-01-22 23:16:07 +08:00
|
|
|
/*
|
|
|
|
* How we use multifd_send_state->pages and channel->pages?
|
|
|
|
*
|
|
|
|
* We create a pages for each channel, and a main one. Each time that
|
|
|
|
* we need to send a batch of pages we interchange the ones between
|
|
|
|
* multifd_send_state and the channel that is sending it. There are
|
|
|
|
* two reasons for that:
|
|
|
|
* - to not have to do so many mallocs during migration
|
|
|
|
* - to make easier to know what to free at the end of migration
|
|
|
|
*
|
|
|
|
* This way we always know who is the owner of each "pages" struct,
|
|
|
|
* and we don't need any locking. It belongs to the migration thread
|
|
|
|
* or to the channel thread. Switching is safe because the migration
|
|
|
|
* thread is using the channel mutex when changing it, and the channel
|
|
|
|
* have to had finish with its own, otherwise pending_job can't be
|
|
|
|
* false.
|
2024-02-02 18:28:51 +08:00
|
|
|
*
|
|
|
|
* Returns true if succeed, false otherwise.
|
2020-01-22 23:16:07 +08:00
|
|
|
*/
|
2024-02-02 18:28:51 +08:00
|
|
|
static bool multifd_send_pages(void)
|
2020-01-22 23:16:07 +08:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
static int next_channel;
|
|
|
|
MultiFDSendParams *p = NULL; /* make happy gcc */
|
|
|
|
MultiFDPages_t *pages = multifd_send_state->pages;
|
|
|
|
|
2024-02-02 18:28:37 +08:00
|
|
|
if (multifd_send_should_exit()) {
|
2024-02-02 18:28:51 +08:00
|
|
|
return false;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:41 +08:00
|
|
|
/* We wait here, until at least one channel is ready */
|
2020-01-22 23:16:07 +08:00
|
|
|
qemu_sem_wait(&multifd_send_state->channels_ready);
|
2024-02-02 18:28:41 +08:00
|
|
|
|
2020-06-17 19:31:54 +08:00
|
|
|
/*
|
|
|
|
* next_channel can remain from a previous migration that was
|
|
|
|
* using more channels, so ensure it doesn't overflow if the
|
|
|
|
* limit is lower now.
|
|
|
|
*/
|
|
|
|
next_channel %= migrate_multifd_channels();
|
2020-01-22 23:16:07 +08:00
|
|
|
for (i = next_channel;; i = (i + 1) % migrate_multifd_channels()) {
|
2024-02-02 18:28:37 +08:00
|
|
|
if (multifd_send_should_exit()) {
|
2024-02-02 18:28:51 +08:00
|
|
|
return false;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
2024-02-02 18:28:37 +08:00
|
|
|
p = &multifd_send_state->params[i];
|
2024-02-02 18:28:41 +08:00
|
|
|
/*
|
|
|
|
* Lockless read to p->pending_job is safe, because only multifd
|
|
|
|
* sender thread can clear it.
|
|
|
|
*/
|
migration/multifd: Separate SYNC request with normal jobs
Multifd provide a threaded model for processing jobs. On sender side,
there can be two kinds of job: (1) a list of pages to send, or (2) a sync
request.
The sync request is a very special kind of job. It never contains a page
array, but only a multifd packet telling the dest side to synchronize with
sent pages.
Before this patch, both requests use the pending_job field, no matter what
the request is, it will boost pending_job, while multifd sender thread will
decrement it after it finishes one job.
However this should be racy, because SYNC is special in that it needs to
set p->flags with MULTIFD_FLAG_SYNC, showing that this is a sync request.
Consider a sequence of operations where:
- migration thread enqueue a job to send some pages, pending_job++ (0->1)
- [...before the selected multifd sender thread wakes up...]
- migration thread enqueue another job to sync, pending_job++ (1->2),
setup p->flags=MULTIFD_FLAG_SYNC
- multifd sender thread wakes up, found pending_job==2
- send the 1st packet with MULTIFD_FLAG_SYNC and list of pages
- send the 2nd packet with flags==0 and no pages
This is not expected, because MULTIFD_FLAG_SYNC should hopefully be done
after all the pages are received. Meanwhile, the 2nd packet will be
completely useless, which contains zero information.
I didn't verify above, but I think this issue is still benign in that at
least on the recv side we always receive pages before handling
MULTIFD_FLAG_SYNC. However that's not always guaranteed and just tricky.
One other reason I want to separate it is using p->flags to communicate
between the two threads is also not clearly defined, it's very hard to read
and understand why accessing p->flags is always safe; see the current impl
of multifd_send_thread() where we tried to cache only p->flags. It doesn't
need to be that complicated.
This patch introduces pending_sync, a separate flag just to show that the
requester needs a sync. Alongside, we remove the tricky caching of
p->flags now because after this patch p->flags should only be used by
multifd sender thread now, which will be crystal clear. So it is always
thread safe to access p->flags.
With that, we can also safely convert the pending_job into a boolean,
because we don't support >1 pending jobs anyway.
Always use atomic ops to access both flags to make sure no cache effect.
When at it, drop the initial setting of "pending_job = 0" because it's
always allocated using g_new0().
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20240202102857.110210-7-peterx@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
2024-02-02 18:28:40 +08:00
|
|
|
if (qatomic_read(&p->pending_job) == false) {
|
2020-01-22 23:16:07 +08:00
|
|
|
next_channel = (i + 1) % migrate_multifd_channels();
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2024-02-02 18:28:41 +08:00
|
|
|
|
|
|
|
/*
|
2024-02-02 18:28:57 +08:00
|
|
|
* Make sure we read p->pending_job before all the rest. Pairs with
|
|
|
|
* qatomic_store_release() in multifd_send_thread().
|
2024-02-02 18:28:41 +08:00
|
|
|
*/
|
2024-02-02 18:28:57 +08:00
|
|
|
smp_mb_acquire();
|
|
|
|
assert(!p->pages->num);
|
2020-01-22 23:16:07 +08:00
|
|
|
multifd_send_state->pages = p->pages;
|
|
|
|
p->pages = pages;
|
2024-02-02 18:28:57 +08:00
|
|
|
/*
|
|
|
|
* Making sure p->pages is setup before marking pending_job=true. Pairs
|
|
|
|
* with the qatomic_load_acquire() in multifd_send_thread().
|
|
|
|
*/
|
|
|
|
qatomic_store_release(&p->pending_job, true);
|
2020-01-22 23:16:07 +08:00
|
|
|
qemu_sem_post(&p->sem);
|
|
|
|
|
2024-02-02 18:28:51 +08:00
|
|
|
return true;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:52 +08:00
|
|
|
static inline bool multifd_queue_empty(MultiFDPages_t *pages)
|
|
|
|
{
|
|
|
|
return pages->num == 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline bool multifd_queue_full(MultiFDPages_t *pages)
|
|
|
|
{
|
|
|
|
return pages->num == pages->allocated;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void multifd_enqueue(MultiFDPages_t *pages, ram_addr_t offset)
|
|
|
|
{
|
|
|
|
pages->offset[pages->num++] = offset;
|
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:50 +08:00
|
|
|
/* Returns true if enqueue successful, false otherwise */
|
|
|
|
bool multifd_queue_page(RAMBlock *block, ram_addr_t offset)
|
2020-01-22 23:16:07 +08:00
|
|
|
{
|
2024-02-02 18:28:52 +08:00
|
|
|
MultiFDPages_t *pages;
|
2020-01-22 23:16:07 +08:00
|
|
|
|
2024-02-02 18:28:52 +08:00
|
|
|
retry:
|
|
|
|
pages = multifd_send_state->pages;
|
|
|
|
|
|
|
|
/* If the queue is empty, we can already enqueue now */
|
|
|
|
if (multifd_queue_empty(pages)) {
|
2020-01-22 23:16:07 +08:00
|
|
|
pages->block = block;
|
2024-02-02 18:28:52 +08:00
|
|
|
multifd_enqueue(pages, offset);
|
|
|
|
return true;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:52 +08:00
|
|
|
/*
|
|
|
|
* Not empty, meanwhile we need a flush. It can because of either:
|
|
|
|
*
|
|
|
|
* (1) The page is not on the same ramblock of previous ones, or,
|
|
|
|
* (2) The queue is full.
|
|
|
|
*
|
|
|
|
* After flush, always retry.
|
|
|
|
*/
|
|
|
|
if (pages->block != block || multifd_queue_full(pages)) {
|
|
|
|
if (!multifd_send_pages()) {
|
|
|
|
return false;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
2024-02-02 18:28:52 +08:00
|
|
|
goto retry;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:52 +08:00
|
|
|
/* Not empty, and we still have space, do it! */
|
|
|
|
multifd_enqueue(pages, offset);
|
2024-02-02 18:28:50 +08:00
|
|
|
return true;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:49 +08:00
|
|
|
/* Multifd send side hit an error; remember it and prepare to quit */
|
|
|
|
static void multifd_send_set_error(Error *err)
|
2020-01-22 23:16:07 +08:00
|
|
|
{
|
2024-02-02 18:28:37 +08:00
|
|
|
/*
|
|
|
|
* We don't want to exit each threads twice. Depending on where
|
|
|
|
* we get the error, or if there are two independent errors in two
|
|
|
|
* threads at the same time, we can end calling this function
|
|
|
|
* twice.
|
|
|
|
*/
|
|
|
|
if (qatomic_xchg(&multifd_send_state->exiting, 1)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2020-01-22 23:16:07 +08:00
|
|
|
if (err) {
|
|
|
|
MigrationState *s = migrate_get_current();
|
|
|
|
migrate_set_error(s, err);
|
|
|
|
if (s->state == MIGRATION_STATUS_SETUP ||
|
|
|
|
s->state == MIGRATION_STATUS_PRE_SWITCHOVER ||
|
|
|
|
s->state == MIGRATION_STATUS_DEVICE ||
|
|
|
|
s->state == MIGRATION_STATUS_ACTIVE) {
|
|
|
|
migrate_set_state(&s->state, s->state,
|
|
|
|
MIGRATION_STATUS_FAILED);
|
|
|
|
}
|
|
|
|
}
|
2024-02-02 18:28:49 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void multifd_send_terminate_threads(void)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
trace_multifd_send_terminate_threads();
|
2020-01-22 23:16:07 +08:00
|
|
|
|
2024-02-02 18:28:49 +08:00
|
|
|
/*
|
|
|
|
* Tell everyone we're quitting. No xchg() needed here; we simply
|
|
|
|
* always set it.
|
|
|
|
*/
|
|
|
|
qatomic_set(&multifd_send_state->exiting, 1);
|
2024-02-02 18:28:53 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Firstly, kick all threads out; no matter whether they are just idle,
|
|
|
|
* or blocked in an IO system call.
|
|
|
|
*/
|
2020-01-22 23:16:07 +08:00
|
|
|
for (i = 0; i < migrate_multifd_channels(); i++) {
|
|
|
|
MultiFDSendParams *p = &multifd_send_state->params[i];
|
|
|
|
|
|
|
|
qemu_sem_post(&p->sem);
|
2021-12-03 19:55:33 +08:00
|
|
|
if (p->c) {
|
|
|
|
qio_channel_shutdown(p->c, QIO_CHANNEL_SHUTDOWN_BOTH, NULL);
|
|
|
|
}
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
2024-02-02 18:28:53 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Finally recycle all the threads.
|
|
|
|
*/
|
|
|
|
for (i = 0; i < migrate_multifd_channels(); i++) {
|
|
|
|
MultiFDSendParams *p = &multifd_send_state->params[i];
|
|
|
|
|
2024-02-07 05:51:13 +08:00
|
|
|
if (p->tls_thread_created) {
|
|
|
|
qemu_thread_join(&p->tls_thread);
|
|
|
|
}
|
|
|
|
|
2024-02-07 05:51:14 +08:00
|
|
|
if (p->thread_created) {
|
2024-02-02 18:28:53 +08:00
|
|
|
qemu_thread_join(&p->thread);
|
|
|
|
}
|
|
|
|
}
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
2023-10-12 21:43:41 +08:00
|
|
|
static int multifd_send_channel_destroy(QIOChannel *send)
|
|
|
|
{
|
|
|
|
return socket_send_channel_destroy(send);
|
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:53 +08:00
|
|
|
static bool multifd_send_cleanup_channel(MultiFDSendParams *p, Error **errp)
|
|
|
|
{
|
2024-02-22 17:52:58 +08:00
|
|
|
if (p->c) {
|
2024-02-02 18:28:53 +08:00
|
|
|
migration_ioc_unregister_yank(p->c);
|
2024-02-22 17:52:58 +08:00
|
|
|
multifd_send_channel_destroy(p->c);
|
|
|
|
p->c = NULL;
|
2024-02-02 18:28:53 +08:00
|
|
|
}
|
|
|
|
qemu_sem_destroy(&p->sem);
|
|
|
|
qemu_sem_destroy(&p->sem_sync);
|
|
|
|
g_free(p->name);
|
|
|
|
p->name = NULL;
|
|
|
|
multifd_pages_clear(p->pages);
|
|
|
|
p->pages = NULL;
|
|
|
|
p->packet_len = 0;
|
|
|
|
g_free(p->packet);
|
|
|
|
p->packet = NULL;
|
|
|
|
g_free(p->iov);
|
|
|
|
p->iov = NULL;
|
|
|
|
multifd_send_state->ops->send_cleanup(p, errp);
|
|
|
|
|
|
|
|
return *errp == NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void multifd_send_cleanup_state(void)
|
|
|
|
{
|
2024-02-22 17:53:00 +08:00
|
|
|
socket_cleanup_outgoing_migration();
|
2024-02-07 05:51:18 +08:00
|
|
|
qemu_sem_destroy(&multifd_send_state->channels_created);
|
2024-02-02 18:28:53 +08:00
|
|
|
qemu_sem_destroy(&multifd_send_state->channels_ready);
|
|
|
|
g_free(multifd_send_state->params);
|
|
|
|
multifd_send_state->params = NULL;
|
|
|
|
multifd_pages_clear(multifd_send_state->pages);
|
|
|
|
multifd_send_state->pages = NULL;
|
|
|
|
g_free(multifd_send_state);
|
|
|
|
multifd_send_state = NULL;
|
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:55 +08:00
|
|
|
void multifd_send_shutdown(void)
|
2020-01-22 23:16:07 +08:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
2023-03-02 05:10:29 +08:00
|
|
|
if (!migrate_multifd()) {
|
2020-01-22 23:16:07 +08:00
|
|
|
return;
|
|
|
|
}
|
2024-02-02 18:28:53 +08:00
|
|
|
|
2024-02-02 18:28:49 +08:00
|
|
|
multifd_send_terminate_threads();
|
2020-01-22 23:16:07 +08:00
|
|
|
|
|
|
|
for (i = 0; i < migrate_multifd_channels(); i++) {
|
|
|
|
MultiFDSendParams *p = &multifd_send_state->params[i];
|
2019-05-15 19:37:46 +08:00
|
|
|
Error *local_err = NULL;
|
2020-01-22 23:16:07 +08:00
|
|
|
|
2024-02-02 18:28:53 +08:00
|
|
|
if (!multifd_send_cleanup_channel(p, &local_err)) {
|
2019-05-15 19:37:46 +08:00
|
|
|
migrate_set_error(migrate_get_current(), local_err);
|
2020-05-06 17:54:16 +08:00
|
|
|
error_free(local_err);
|
2019-05-15 19:37:46 +08:00
|
|
|
}
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
2024-02-02 18:28:53 +08:00
|
|
|
|
|
|
|
multifd_send_cleanup_state();
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
2022-10-25 12:47:28 +08:00
|
|
|
static int multifd_zero_copy_flush(QIOChannel *c)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
Error *err = NULL;
|
|
|
|
|
|
|
|
ret = qio_channel_flush(c, &err);
|
|
|
|
if (ret < 0) {
|
|
|
|
error_report_err(err);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (ret == 1) {
|
2023-04-27 01:37:19 +08:00
|
|
|
stat64_add(&mig_stats.dirty_sync_missed_zero_copy, 1);
|
2022-10-25 12:47:28 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2024-01-04 22:21:39 +08:00
|
|
|
int multifd_send_sync_main(void)
|
2020-01-22 23:16:07 +08:00
|
|
|
{
|
|
|
|
int i;
|
2022-05-13 14:28:37 +08:00
|
|
|
bool flush_zero_copy;
|
2020-01-22 23:16:07 +08:00
|
|
|
|
2023-03-02 05:10:29 +08:00
|
|
|
if (!migrate_multifd()) {
|
2022-05-13 14:28:35 +08:00
|
|
|
return 0;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
2021-11-22 18:51:40 +08:00
|
|
|
if (multifd_send_state->pages->num) {
|
2024-02-02 18:28:51 +08:00
|
|
|
if (!multifd_send_pages()) {
|
2020-01-22 23:16:07 +08:00
|
|
|
error_report("%s: multifd_send_pages fail", __func__);
|
2022-05-13 14:28:35 +08:00
|
|
|
return -1;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
}
|
2022-05-13 14:28:37 +08:00
|
|
|
|
2023-03-02 05:17:14 +08:00
|
|
|
flush_zero_copy = migrate_zero_copy_send();
|
2022-05-13 14:28:37 +08:00
|
|
|
|
2020-01-22 23:16:07 +08:00
|
|
|
for (i = 0; i < migrate_multifd_channels(); i++) {
|
|
|
|
MultiFDSendParams *p = &multifd_send_state->params[i];
|
|
|
|
|
2024-02-02 18:28:37 +08:00
|
|
|
if (multifd_send_should_exit()) {
|
2022-05-13 14:28:35 +08:00
|
|
|
return -1;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:37 +08:00
|
|
|
trace_multifd_send_sync_main_signal(p->id);
|
|
|
|
|
migration/multifd: Separate SYNC request with normal jobs
Multifd provide a threaded model for processing jobs. On sender side,
there can be two kinds of job: (1) a list of pages to send, or (2) a sync
request.
The sync request is a very special kind of job. It never contains a page
array, but only a multifd packet telling the dest side to synchronize with
sent pages.
Before this patch, both requests use the pending_job field, no matter what
the request is, it will boost pending_job, while multifd sender thread will
decrement it after it finishes one job.
However this should be racy, because SYNC is special in that it needs to
set p->flags with MULTIFD_FLAG_SYNC, showing that this is a sync request.
Consider a sequence of operations where:
- migration thread enqueue a job to send some pages, pending_job++ (0->1)
- [...before the selected multifd sender thread wakes up...]
- migration thread enqueue another job to sync, pending_job++ (1->2),
setup p->flags=MULTIFD_FLAG_SYNC
- multifd sender thread wakes up, found pending_job==2
- send the 1st packet with MULTIFD_FLAG_SYNC and list of pages
- send the 2nd packet with flags==0 and no pages
This is not expected, because MULTIFD_FLAG_SYNC should hopefully be done
after all the pages are received. Meanwhile, the 2nd packet will be
completely useless, which contains zero information.
I didn't verify above, but I think this issue is still benign in that at
least on the recv side we always receive pages before handling
MULTIFD_FLAG_SYNC. However that's not always guaranteed and just tricky.
One other reason I want to separate it is using p->flags to communicate
between the two threads is also not clearly defined, it's very hard to read
and understand why accessing p->flags is always safe; see the current impl
of multifd_send_thread() where we tried to cache only p->flags. It doesn't
need to be that complicated.
This patch introduces pending_sync, a separate flag just to show that the
requester needs a sync. Alongside, we remove the tricky caching of
p->flags now because after this patch p->flags should only be used by
multifd sender thread now, which will be crystal clear. So it is always
thread safe to access p->flags.
With that, we can also safely convert the pending_job into a boolean,
because we don't support >1 pending jobs anyway.
Always use atomic ops to access both flags to make sure no cache effect.
When at it, drop the initial setting of "pending_job = 0" because it's
always allocated using g_new0().
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20240202102857.110210-7-peterx@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
2024-02-02 18:28:40 +08:00
|
|
|
/*
|
|
|
|
* We should be the only user so far, so not possible to be set by
|
|
|
|
* others concurrently.
|
|
|
|
*/
|
|
|
|
assert(qatomic_read(&p->pending_sync) == false);
|
|
|
|
qatomic_set(&p->pending_sync, true);
|
2020-01-22 23:16:07 +08:00
|
|
|
qemu_sem_post(&p->sem);
|
|
|
|
}
|
|
|
|
for (i = 0; i < migrate_multifd_channels(); i++) {
|
|
|
|
MultiFDSendParams *p = &multifd_send_state->params[i];
|
|
|
|
|
2024-02-02 18:28:37 +08:00
|
|
|
if (multifd_send_should_exit()) {
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2023-04-26 18:20:36 +08:00
|
|
|
qemu_sem_wait(&multifd_send_state->channels_ready);
|
2020-01-22 23:16:07 +08:00
|
|
|
trace_multifd_send_sync_main_wait(p->id);
|
|
|
|
qemu_sem_wait(&p->sem_sync);
|
2022-10-17 15:53:51 +08:00
|
|
|
|
|
|
|
if (flush_zero_copy && p->c && (multifd_zero_copy_flush(p->c) < 0)) {
|
|
|
|
return -1;
|
|
|
|
}
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
trace_multifd_send_sync_main(multifd_send_state->packet_num);
|
2022-05-13 14:28:35 +08:00
|
|
|
|
|
|
|
return 0;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void *multifd_send_thread(void *opaque)
|
|
|
|
{
|
|
|
|
MultiFDSendParams *p = opaque;
|
2023-02-03 15:35:19 +08:00
|
|
|
MigrationThread *thread = NULL;
|
2020-01-22 23:16:07 +08:00
|
|
|
Error *local_err = NULL;
|
|
|
|
int ret = 0;
|
|
|
|
|
2023-06-08 00:13:04 +08:00
|
|
|
thread = migration_threads_add(p->name, qemu_get_thread_id());
|
2023-02-03 15:35:19 +08:00
|
|
|
|
2020-01-22 23:16:07 +08:00
|
|
|
trace_multifd_send_thread_start(p->id);
|
|
|
|
rcu_register_thread();
|
|
|
|
|
|
|
|
if (multifd_send_initial_packet(p, &local_err) < 0) {
|
|
|
|
ret = -1;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
while (true) {
|
2023-04-26 18:20:36 +08:00
|
|
|
qemu_sem_post(&multifd_send_state->channels_ready);
|
2020-01-22 23:16:07 +08:00
|
|
|
qemu_sem_wait(&p->sem);
|
|
|
|
|
2024-02-02 18:28:37 +08:00
|
|
|
if (multifd_send_should_exit()) {
|
2020-01-22 23:16:07 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:57 +08:00
|
|
|
/*
|
|
|
|
* Read pending_job flag before p->pages. Pairs with the
|
|
|
|
* qatomic_store_release() in multifd_send_pages().
|
|
|
|
*/
|
|
|
|
if (qatomic_load_acquire(&p->pending_job)) {
|
2024-02-02 18:28:39 +08:00
|
|
|
MultiFDPages_t *pages = p->pages;
|
2021-11-22 20:26:18 +08:00
|
|
|
|
2024-02-02 18:28:46 +08:00
|
|
|
p->iovs_num = 0;
|
2024-02-02 18:28:42 +08:00
|
|
|
assert(pages->num);
|
|
|
|
|
|
|
|
ret = multifd_send_state->ops->send_prepare(p, &local_err);
|
|
|
|
if (ret != 0) {
|
|
|
|
break;
|
2019-05-15 19:37:46 +08:00
|
|
|
}
|
2024-02-02 18:28:42 +08:00
|
|
|
|
2022-05-13 14:28:37 +08:00
|
|
|
ret = qio_channel_writev_full_all(p->c, p->iov, p->iovs_num, NULL,
|
|
|
|
0, p->write_flags, &local_err);
|
2020-01-22 23:16:07 +08:00
|
|
|
if (ret != 0) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2023-10-12 02:43:57 +08:00
|
|
|
stat64_add(&mig_stats.multifd_bytes,
|
|
|
|
p->next_packet_size + p->packet_len);
|
2024-02-02 18:28:38 +08:00
|
|
|
|
|
|
|
multifd_pages_reset(p->pages);
|
2023-10-12 02:43:58 +08:00
|
|
|
p->next_packet_size = 0;
|
2024-02-02 18:28:57 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Making sure p->pages is published before saying "we're
|
|
|
|
* free". Pairs with the smp_mb_acquire() in
|
|
|
|
* multifd_send_pages().
|
|
|
|
*/
|
|
|
|
qatomic_store_release(&p->pending_job, false);
|
2024-02-02 18:28:48 +08:00
|
|
|
} else {
|
2024-02-02 18:28:57 +08:00
|
|
|
/*
|
|
|
|
* If not a normal job, must be a sync request. Note that
|
|
|
|
* pending_sync is a standalone flag (unlike pending_job), so
|
|
|
|
* it doesn't require explicit memory barriers.
|
|
|
|
*/
|
2024-02-02 18:28:48 +08:00
|
|
|
assert(qatomic_read(&p->pending_sync));
|
migration/multifd: Separate SYNC request with normal jobs
Multifd provide a threaded model for processing jobs. On sender side,
there can be two kinds of job: (1) a list of pages to send, or (2) a sync
request.
The sync request is a very special kind of job. It never contains a page
array, but only a multifd packet telling the dest side to synchronize with
sent pages.
Before this patch, both requests use the pending_job field, no matter what
the request is, it will boost pending_job, while multifd sender thread will
decrement it after it finishes one job.
However this should be racy, because SYNC is special in that it needs to
set p->flags with MULTIFD_FLAG_SYNC, showing that this is a sync request.
Consider a sequence of operations where:
- migration thread enqueue a job to send some pages, pending_job++ (0->1)
- [...before the selected multifd sender thread wakes up...]
- migration thread enqueue another job to sync, pending_job++ (1->2),
setup p->flags=MULTIFD_FLAG_SYNC
- multifd sender thread wakes up, found pending_job==2
- send the 1st packet with MULTIFD_FLAG_SYNC and list of pages
- send the 2nd packet with flags==0 and no pages
This is not expected, because MULTIFD_FLAG_SYNC should hopefully be done
after all the pages are received. Meanwhile, the 2nd packet will be
completely useless, which contains zero information.
I didn't verify above, but I think this issue is still benign in that at
least on the recv side we always receive pages before handling
MULTIFD_FLAG_SYNC. However that's not always guaranteed and just tricky.
One other reason I want to separate it is using p->flags to communicate
between the two threads is also not clearly defined, it's very hard to read
and understand why accessing p->flags is always safe; see the current impl
of multifd_send_thread() where we tried to cache only p->flags. It doesn't
need to be that complicated.
This patch introduces pending_sync, a separate flag just to show that the
requester needs a sync. Alongside, we remove the tricky caching of
p->flags now because after this patch p->flags should only be used by
multifd sender thread now, which will be crystal clear. So it is always
thread safe to access p->flags.
With that, we can also safely convert the pending_job into a boolean,
because we don't support >1 pending jobs anyway.
Always use atomic ops to access both flags to make sure no cache effect.
When at it, drop the initial setting of "pending_job = 0" because it's
always allocated using g_new0().
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20240202102857.110210-7-peterx@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
2024-02-02 18:28:40 +08:00
|
|
|
p->flags = MULTIFD_FLAG_SYNC;
|
|
|
|
multifd_send_fill_packet(p);
|
|
|
|
ret = qio_channel_write_all(p->c, (void *)p->packet,
|
|
|
|
p->packet_len, &local_err);
|
|
|
|
if (ret != 0) {
|
|
|
|
break;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
migration/multifd: Separate SYNC request with normal jobs
Multifd provide a threaded model for processing jobs. On sender side,
there can be two kinds of job: (1) a list of pages to send, or (2) a sync
request.
The sync request is a very special kind of job. It never contains a page
array, but only a multifd packet telling the dest side to synchronize with
sent pages.
Before this patch, both requests use the pending_job field, no matter what
the request is, it will boost pending_job, while multifd sender thread will
decrement it after it finishes one job.
However this should be racy, because SYNC is special in that it needs to
set p->flags with MULTIFD_FLAG_SYNC, showing that this is a sync request.
Consider a sequence of operations where:
- migration thread enqueue a job to send some pages, pending_job++ (0->1)
- [...before the selected multifd sender thread wakes up...]
- migration thread enqueue another job to sync, pending_job++ (1->2),
setup p->flags=MULTIFD_FLAG_SYNC
- multifd sender thread wakes up, found pending_job==2
- send the 1st packet with MULTIFD_FLAG_SYNC and list of pages
- send the 2nd packet with flags==0 and no pages
This is not expected, because MULTIFD_FLAG_SYNC should hopefully be done
after all the pages are received. Meanwhile, the 2nd packet will be
completely useless, which contains zero information.
I didn't verify above, but I think this issue is still benign in that at
least on the recv side we always receive pages before handling
MULTIFD_FLAG_SYNC. However that's not always guaranteed and just tricky.
One other reason I want to separate it is using p->flags to communicate
between the two threads is also not clearly defined, it's very hard to read
and understand why accessing p->flags is always safe; see the current impl
of multifd_send_thread() where we tried to cache only p->flags. It doesn't
need to be that complicated.
This patch introduces pending_sync, a separate flag just to show that the
requester needs a sync. Alongside, we remove the tricky caching of
p->flags now because after this patch p->flags should only be used by
multifd sender thread now, which will be crystal clear. So it is always
thread safe to access p->flags.
With that, we can also safely convert the pending_job into a boolean,
because we don't support >1 pending jobs anyway.
Always use atomic ops to access both flags to make sure no cache effect.
When at it, drop the initial setting of "pending_job = 0" because it's
always allocated using g_new0().
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20240202102857.110210-7-peterx@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
2024-02-02 18:28:40 +08:00
|
|
|
/* p->next_packet_size will always be zero for a SYNC packet */
|
|
|
|
stat64_add(&mig_stats.multifd_bytes, p->packet_len);
|
|
|
|
p->flags = 0;
|
|
|
|
qatomic_set(&p->pending_sync, false);
|
|
|
|
qemu_sem_post(&p->sem_sync);
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
out:
|
2023-10-12 21:43:42 +08:00
|
|
|
if (ret) {
|
|
|
|
assert(local_err);
|
2020-01-22 23:16:07 +08:00
|
|
|
trace_multifd_send_error(p->id);
|
2024-02-02 18:28:49 +08:00
|
|
|
multifd_send_set_error(local_err);
|
2024-02-02 18:28:36 +08:00
|
|
|
multifd_send_kick_main(p);
|
2023-10-12 21:43:42 +08:00
|
|
|
error_free(local_err);
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
rcu_unregister_thread();
|
2023-06-08 00:13:04 +08:00
|
|
|
migration_threads_remove(thread);
|
2024-02-02 18:28:43 +08:00
|
|
|
trace_multifd_send_thread_end(p->id, p->packets_sent, p->total_normal_pages);
|
2020-01-22 23:16:07 +08:00
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2024-02-07 05:51:17 +08:00
|
|
|
static void multifd_new_send_channel_async(QIOTask *task, gpointer opaque);
|
2020-09-15 11:04:01 +08:00
|
|
|
|
2024-02-22 17:52:57 +08:00
|
|
|
typedef struct {
|
|
|
|
MultiFDSendParams *p;
|
|
|
|
QIOChannelTLS *tioc;
|
|
|
|
} MultiFDTLSThreadArgs;
|
|
|
|
|
2020-11-06 14:24:53 +08:00
|
|
|
static void *multifd_tls_handshake_thread(void *opaque)
|
|
|
|
{
|
2024-02-22 17:52:57 +08:00
|
|
|
MultiFDTLSThreadArgs *args = opaque;
|
2020-11-06 14:24:53 +08:00
|
|
|
|
2024-02-22 17:52:57 +08:00
|
|
|
qio_channel_tls_handshake(args->tioc,
|
2024-02-07 05:51:17 +08:00
|
|
|
multifd_new_send_channel_async,
|
2024-02-22 17:52:57 +08:00
|
|
|
args->p,
|
2020-11-06 14:24:53 +08:00
|
|
|
NULL,
|
|
|
|
NULL);
|
2024-02-22 17:52:57 +08:00
|
|
|
g_free(args);
|
|
|
|
|
2020-11-06 14:24:53 +08:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2023-10-12 21:43:43 +08:00
|
|
|
static bool multifd_tls_channel_connect(MultiFDSendParams *p,
|
2020-09-15 11:04:01 +08:00
|
|
|
QIOChannel *ioc,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
MigrationState *s = migrate_get_current();
|
2022-03-31 23:08:40 +08:00
|
|
|
const char *hostname = s->hostname;
|
2024-02-22 17:52:57 +08:00
|
|
|
MultiFDTLSThreadArgs *args;
|
2020-09-15 11:04:01 +08:00
|
|
|
QIOChannelTLS *tioc;
|
|
|
|
|
2023-04-27 03:33:08 +08:00
|
|
|
tioc = migration_tls_client_create(ioc, hostname, errp);
|
2020-09-15 11:04:01 +08:00
|
|
|
if (!tioc) {
|
2023-10-12 21:43:43 +08:00
|
|
|
return false;
|
2020-09-15 11:04:01 +08:00
|
|
|
}
|
|
|
|
|
2024-02-07 05:51:17 +08:00
|
|
|
/*
|
|
|
|
* Ownership of the socket channel now transfers to the newly
|
|
|
|
* created TLS channel, which has already taken a reference.
|
|
|
|
*/
|
2020-11-11 22:26:03 +08:00
|
|
|
object_unref(OBJECT(ioc));
|
2020-09-15 11:04:02 +08:00
|
|
|
trace_multifd_tls_outgoing_handshake_start(ioc, tioc, hostname);
|
2020-09-15 11:04:01 +08:00
|
|
|
qio_channel_set_name(QIO_CHANNEL(tioc), "multifd-tls-outgoing");
|
2024-02-22 17:52:57 +08:00
|
|
|
|
|
|
|
args = g_new0(MultiFDTLSThreadArgs, 1);
|
|
|
|
args->tioc = tioc;
|
|
|
|
args->p = p;
|
2024-02-07 05:51:13 +08:00
|
|
|
|
|
|
|
p->tls_thread_created = true;
|
|
|
|
qemu_thread_create(&p->tls_thread, "multifd-tls-handshake-worker",
|
2024-02-22 17:52:57 +08:00
|
|
|
multifd_tls_handshake_thread, args,
|
2020-11-06 14:24:53 +08:00
|
|
|
QEMU_THREAD_JOINABLE);
|
2023-10-12 21:43:43 +08:00
|
|
|
return true;
|
2020-09-15 11:04:01 +08:00
|
|
|
}
|
|
|
|
|
2024-02-22 17:52:59 +08:00
|
|
|
static void multifd_channel_connect(MultiFDSendParams *p, QIOChannel *ioc)
|
2020-09-15 11:04:01 +08:00
|
|
|
{
|
2024-02-07 05:51:17 +08:00
|
|
|
qio_channel_set_delay(ioc, false);
|
2023-12-31 17:30:11 +08:00
|
|
|
|
|
|
|
migration_ioc_register_yank(ioc);
|
2024-02-22 17:52:57 +08:00
|
|
|
/* Setup p->c only if the channel is completely setup */
|
2023-12-31 17:30:11 +08:00
|
|
|
p->c = ioc;
|
2024-02-07 05:51:14 +08:00
|
|
|
|
|
|
|
p->thread_created = true;
|
2023-12-31 17:30:11 +08:00
|
|
|
qemu_thread_create(&p->thread, p->name, multifd_send_thread, p,
|
|
|
|
QEMU_THREAD_JOINABLE);
|
2020-09-15 11:04:01 +08:00
|
|
|
}
|
|
|
|
|
2024-02-07 05:51:17 +08:00
|
|
|
/*
|
|
|
|
* When TLS is enabled this function is called once to establish the
|
|
|
|
* TLS connection and a second time after the TLS handshake to create
|
|
|
|
* the multifd channel. Without TLS it goes straight into the channel
|
|
|
|
* creation.
|
|
|
|
*/
|
2020-01-22 23:16:07 +08:00
|
|
|
static void multifd_new_send_channel_async(QIOTask *task, gpointer opaque)
|
|
|
|
{
|
|
|
|
MultiFDSendParams *p = opaque;
|
2023-10-12 21:43:41 +08:00
|
|
|
QIOChannel *ioc = QIO_CHANNEL(qio_task_get_source(task));
|
2020-01-22 23:16:07 +08:00
|
|
|
Error *local_err = NULL;
|
2024-02-07 05:51:17 +08:00
|
|
|
bool ret;
|
2020-01-22 23:16:07 +08:00
|
|
|
|
|
|
|
trace_multifd_new_send_channel_async(p->id);
|
2024-02-07 05:51:17 +08:00
|
|
|
|
|
|
|
if (qio_task_propagate_error(task, &local_err)) {
|
|
|
|
ret = false;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
trace_multifd_set_outgoing_channel(ioc, object_get_typename(OBJECT(ioc)),
|
|
|
|
migrate_get_current()->hostname);
|
|
|
|
|
|
|
|
if (migrate_channel_requires_tls_upgrade(ioc)) {
|
|
|
|
ret = multifd_tls_channel_connect(p, ioc, &local_err);
|
2024-02-07 05:51:18 +08:00
|
|
|
if (ret) {
|
|
|
|
return;
|
|
|
|
}
|
2024-02-07 05:51:17 +08:00
|
|
|
} else {
|
2024-02-22 17:52:59 +08:00
|
|
|
multifd_channel_connect(p, ioc);
|
|
|
|
ret = true;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
2020-09-15 11:04:00 +08:00
|
|
|
|
2024-02-07 05:51:18 +08:00
|
|
|
out:
|
|
|
|
/*
|
|
|
|
* Here we're not interested whether creation succeeded, only that
|
|
|
|
* it happened at all.
|
|
|
|
*/
|
|
|
|
qemu_sem_post(&multifd_send_state->channels_created);
|
|
|
|
|
2024-02-07 05:51:17 +08:00
|
|
|
if (ret) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2023-10-12 21:43:43 +08:00
|
|
|
trace_multifd_new_send_channel_async_error(p->id, local_err);
|
2024-02-02 18:28:49 +08:00
|
|
|
multifd_send_set_error(local_err);
|
2024-02-22 17:52:57 +08:00
|
|
|
/*
|
|
|
|
* For error cases (TLS or non-TLS), IO channel is always freed here
|
|
|
|
* rather than when cleanup multifd: since p->c is not set, multifd
|
|
|
|
* cleanup code doesn't even know its existence.
|
|
|
|
*/
|
|
|
|
object_unref(OBJECT(ioc));
|
2024-02-02 18:28:37 +08:00
|
|
|
error_free(local_err);
|
2023-10-12 21:43:41 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void multifd_new_send_channel_create(gpointer opaque)
|
|
|
|
{
|
|
|
|
socket_send_channel_create(multifd_new_send_channel_async, opaque);
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
2024-02-07 05:51:15 +08:00
|
|
|
bool multifd_send_setup(void)
|
2020-01-22 23:16:07 +08:00
|
|
|
{
|
2024-02-07 05:51:15 +08:00
|
|
|
MigrationState *s = migrate_get_current();
|
|
|
|
Error *local_err = NULL;
|
|
|
|
int thread_count, ret = 0;
|
2020-01-22 23:16:07 +08:00
|
|
|
uint32_t page_count = MULTIFD_PACKET_SIZE / qemu_target_page_size();
|
|
|
|
uint8_t i;
|
|
|
|
|
2023-03-02 05:10:29 +08:00
|
|
|
if (!migrate_multifd()) {
|
2024-02-07 05:51:15 +08:00
|
|
|
return true;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
2021-09-09 15:29:50 +08:00
|
|
|
|
2020-01-22 23:16:07 +08:00
|
|
|
thread_count = migrate_multifd_channels();
|
|
|
|
multifd_send_state = g_malloc0(sizeof(*multifd_send_state));
|
|
|
|
multifd_send_state->params = g_new0(MultiFDSendParams, thread_count);
|
|
|
|
multifd_send_state->pages = multifd_pages_init(page_count);
|
2024-02-07 05:51:18 +08:00
|
|
|
qemu_sem_init(&multifd_send_state->channels_created, 0);
|
2020-01-22 23:16:07 +08:00
|
|
|
qemu_sem_init(&multifd_send_state->channels_ready, 0);
|
2020-09-23 18:56:46 +08:00
|
|
|
qatomic_set(&multifd_send_state->exiting, 0);
|
2019-05-15 19:37:46 +08:00
|
|
|
multifd_send_state->ops = multifd_ops[migrate_multifd_compression()];
|
2020-01-22 23:16:07 +08:00
|
|
|
|
|
|
|
for (i = 0; i < thread_count; i++) {
|
|
|
|
MultiFDSendParams *p = &multifd_send_state->params[i];
|
|
|
|
|
|
|
|
qemu_sem_init(&p->sem, 0);
|
|
|
|
qemu_sem_init(&p->sem_sync, 0);
|
|
|
|
p->id = i;
|
|
|
|
p->pages = multifd_pages_init(page_count);
|
|
|
|
p->packet_len = sizeof(MultiFDPacket_t)
|
|
|
|
+ sizeof(uint64_t) * page_count;
|
|
|
|
p->packet = g_malloc0(p->packet_len);
|
|
|
|
p->packet->magic = cpu_to_be32(MULTIFD_MAGIC);
|
|
|
|
p->packet->version = cpu_to_be32(MULTIFD_VERSION);
|
|
|
|
p->name = g_strdup_printf("multifdsend_%d", i);
|
2021-11-19 22:35:58 +08:00
|
|
|
/* We need one extra place for the packet header */
|
|
|
|
p->iov = g_new0(struct iovec, page_count + 1);
|
2022-05-02 22:45:35 +08:00
|
|
|
p->page_size = qemu_target_page_size();
|
2022-05-02 22:53:12 +08:00
|
|
|
p->page_count = page_count;
|
2024-02-02 18:28:47 +08:00
|
|
|
p->write_flags = 0;
|
2023-10-12 21:43:41 +08:00
|
|
|
multifd_new_send_channel_create(p);
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
2019-05-15 19:37:46 +08:00
|
|
|
|
2024-02-07 05:51:18 +08:00
|
|
|
/*
|
|
|
|
* Wait until channel creation has started for all channels. The
|
|
|
|
* creation can still fail, but no more channels will be created
|
|
|
|
* past this point.
|
|
|
|
*/
|
|
|
|
for (i = 0; i < thread_count; i++) {
|
|
|
|
qemu_sem_wait(&multifd_send_state->channels_created);
|
|
|
|
}
|
|
|
|
|
2019-05-15 19:37:46 +08:00
|
|
|
for (i = 0; i < thread_count; i++) {
|
|
|
|
MultiFDSendParams *p = &multifd_send_state->params[i];
|
|
|
|
|
2024-02-07 05:51:15 +08:00
|
|
|
ret = multifd_send_state->ops->send_setup(p, &local_err);
|
2019-05-15 19:37:46 +08:00
|
|
|
if (ret) {
|
2024-02-07 05:51:15 +08:00
|
|
|
break;
|
2019-05-15 19:37:46 +08:00
|
|
|
}
|
|
|
|
}
|
2024-02-07 05:51:15 +08:00
|
|
|
|
|
|
|
if (ret) {
|
|
|
|
migrate_set_error(s, local_err);
|
|
|
|
error_report_err(local_err);
|
|
|
|
migrate_set_state(&s->state, MIGRATION_STATUS_SETUP,
|
|
|
|
MIGRATION_STATUS_FAILED);
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void multifd_recv_terminate_threads(Error *err)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
trace_multifd_recv_terminate_threads(err != NULL);
|
|
|
|
|
2024-02-21 06:41:08 +08:00
|
|
|
if (qatomic_xchg(&multifd_recv_state->exiting, 1)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2020-01-22 23:16:07 +08:00
|
|
|
if (err) {
|
|
|
|
MigrationState *s = migrate_get_current();
|
|
|
|
migrate_set_error(s, err);
|
|
|
|
if (s->state == MIGRATION_STATUS_SETUP ||
|
|
|
|
s->state == MIGRATION_STATUS_ACTIVE) {
|
|
|
|
migrate_set_state(&s->state, s->state,
|
|
|
|
MIGRATION_STATUS_FAILED);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
for (i = 0; i < migrate_multifd_channels(); i++) {
|
|
|
|
MultiFDRecvParams *p = &multifd_recv_state->params[i];
|
|
|
|
|
2024-02-21 06:41:09 +08:00
|
|
|
/*
|
|
|
|
* multifd_recv_thread may hung at MULTIFD_FLAG_SYNC handle code,
|
|
|
|
* however try to wakeup it without harm in cleanup phase.
|
|
|
|
*/
|
|
|
|
qemu_sem_post(&p->sem_sync);
|
|
|
|
|
2020-01-22 23:16:07 +08:00
|
|
|
/*
|
|
|
|
* We could arrive here for two reasons:
|
|
|
|
* - normal quit, i.e. everything went fine, just finished
|
|
|
|
* - error quit: We close the channels so the channel threads
|
|
|
|
* finish the qio_channel_read_all_eof()
|
|
|
|
*/
|
|
|
|
if (p->c) {
|
|
|
|
qio_channel_shutdown(p->c, QIO_CHANNEL_SHUTDOWN_BOTH, NULL);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:55 +08:00
|
|
|
void multifd_recv_shutdown(void)
|
2023-02-10 14:36:31 +08:00
|
|
|
{
|
2023-03-02 05:10:29 +08:00
|
|
|
if (migrate_multifd()) {
|
2023-02-10 14:36:31 +08:00
|
|
|
multifd_recv_terminate_threads(NULL);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:54 +08:00
|
|
|
static void multifd_recv_cleanup_channel(MultiFDRecvParams *p)
|
|
|
|
{
|
|
|
|
migration_ioc_unregister_yank(p->c);
|
|
|
|
object_unref(OBJECT(p->c));
|
|
|
|
p->c = NULL;
|
|
|
|
qemu_mutex_destroy(&p->mutex);
|
|
|
|
qemu_sem_destroy(&p->sem_sync);
|
|
|
|
g_free(p->name);
|
|
|
|
p->name = NULL;
|
|
|
|
p->packet_len = 0;
|
|
|
|
g_free(p->packet);
|
|
|
|
p->packet = NULL;
|
|
|
|
g_free(p->iov);
|
|
|
|
p->iov = NULL;
|
|
|
|
g_free(p->normal);
|
|
|
|
p->normal = NULL;
|
|
|
|
multifd_recv_state->ops->recv_cleanup(p);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void multifd_recv_cleanup_state(void)
|
|
|
|
{
|
|
|
|
qemu_sem_destroy(&multifd_recv_state->sem_sync);
|
|
|
|
g_free(multifd_recv_state->params);
|
|
|
|
multifd_recv_state->params = NULL;
|
|
|
|
g_free(multifd_recv_state);
|
|
|
|
multifd_recv_state = NULL;
|
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:55 +08:00
|
|
|
void multifd_recv_cleanup(void)
|
2020-01-22 23:16:07 +08:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
2023-03-02 05:10:29 +08:00
|
|
|
if (!migrate_multifd()) {
|
2023-02-10 14:36:28 +08:00
|
|
|
return;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
multifd_recv_terminate_threads(NULL);
|
|
|
|
for (i = 0; i < migrate_multifd_channels(); i++) {
|
|
|
|
MultiFDRecvParams *p = &multifd_recv_state->params[i];
|
|
|
|
|
2024-02-07 05:51:14 +08:00
|
|
|
if (p->thread_created) {
|
|
|
|
qemu_thread_join(&p->thread);
|
|
|
|
}
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
for (i = 0; i < migrate_multifd_channels(); i++) {
|
2024-02-02 18:28:54 +08:00
|
|
|
multifd_recv_cleanup_channel(&multifd_recv_state->params[i]);
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
2024-02-02 18:28:54 +08:00
|
|
|
multifd_recv_cleanup_state();
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void multifd_recv_sync_main(void)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
2023-03-02 05:10:29 +08:00
|
|
|
if (!migrate_multifd()) {
|
2020-01-22 23:16:07 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
for (i = 0; i < migrate_multifd_channels(); i++) {
|
|
|
|
MultiFDRecvParams *p = &multifd_recv_state->params[i];
|
|
|
|
|
|
|
|
trace_multifd_recv_sync_main_wait(p->id);
|
|
|
|
qemu_sem_wait(&multifd_recv_state->sem_sync);
|
|
|
|
}
|
|
|
|
for (i = 0; i < migrate_multifd_channels(); i++) {
|
|
|
|
MultiFDRecvParams *p = &multifd_recv_state->params[i];
|
|
|
|
|
2020-04-04 12:21:08 +08:00
|
|
|
WITH_QEMU_LOCK_GUARD(&p->mutex) {
|
|
|
|
if (multifd_recv_state->packet_num < p->packet_num) {
|
|
|
|
multifd_recv_state->packet_num = p->packet_num;
|
|
|
|
}
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
trace_multifd_recv_sync_main_signal(p->id);
|
|
|
|
qemu_sem_post(&p->sem_sync);
|
|
|
|
}
|
|
|
|
trace_multifd_recv_sync_main(multifd_recv_state->packet_num);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void *multifd_recv_thread(void *opaque)
|
|
|
|
{
|
|
|
|
MultiFDRecvParams *p = opaque;
|
|
|
|
Error *local_err = NULL;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
trace_multifd_recv_thread_start(p->id);
|
|
|
|
rcu_register_thread();
|
|
|
|
|
|
|
|
while (true) {
|
|
|
|
uint32_t flags;
|
|
|
|
|
2024-02-21 06:41:08 +08:00
|
|
|
if (multifd_recv_should_exit()) {
|
2020-01-22 23:16:07 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = qio_channel_read_all_eof(p->c, (void *)p->packet,
|
|
|
|
p->packet_len, &local_err);
|
2022-01-28 04:02:01 +08:00
|
|
|
if (ret == 0 || ret == -1) { /* 0: EOF -1: Error */
|
2020-01-22 23:16:07 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
qemu_mutex_lock(&p->mutex);
|
|
|
|
ret = multifd_recv_unfill_packet(p, &local_err);
|
|
|
|
if (ret) {
|
|
|
|
qemu_mutex_unlock(&p->mutex);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
flags = p->flags;
|
2019-05-15 19:37:46 +08:00
|
|
|
/* recv methods don't know how to handle the SYNC flag */
|
|
|
|
p->flags &= ~MULTIFD_FLAG_SYNC;
|
2020-01-22 23:16:07 +08:00
|
|
|
qemu_mutex_unlock(&p->mutex);
|
|
|
|
|
2021-11-22 20:41:06 +08:00
|
|
|
if (p->normal_num) {
|
2021-11-22 19:49:43 +08:00
|
|
|
ret = multifd_recv_state->ops->recv_pages(p, &local_err);
|
2020-01-22 23:16:07 +08:00
|
|
|
if (ret != 0) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (flags & MULTIFD_FLAG_SYNC) {
|
|
|
|
qemu_sem_post(&multifd_recv_state->sem_sync);
|
|
|
|
qemu_sem_wait(&p->sem_sync);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (local_err) {
|
|
|
|
multifd_recv_terminate_threads(local_err);
|
2020-05-06 17:54:16 +08:00
|
|
|
error_free(local_err);
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
rcu_unregister_thread();
|
2024-02-02 18:28:43 +08:00
|
|
|
trace_multifd_recv_thread_end(p->id, p->packets_recved, p->total_normal_pages);
|
2020-01-22 23:16:07 +08:00
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2024-02-02 18:28:55 +08:00
|
|
|
int multifd_recv_setup(Error **errp)
|
2020-01-22 23:16:07 +08:00
|
|
|
{
|
|
|
|
int thread_count;
|
|
|
|
uint32_t page_count = MULTIFD_PACKET_SIZE / qemu_target_page_size();
|
|
|
|
uint8_t i;
|
|
|
|
|
2022-12-21 02:44:18 +08:00
|
|
|
/*
|
|
|
|
* Return successfully if multiFD recv state is already initialised
|
|
|
|
* or multiFD is not enabled.
|
|
|
|
*/
|
2023-03-02 05:10:29 +08:00
|
|
|
if (multifd_recv_state || !migrate_multifd()) {
|
2020-01-22 23:16:07 +08:00
|
|
|
return 0;
|
|
|
|
}
|
2022-12-21 02:44:18 +08:00
|
|
|
|
2020-01-22 23:16:07 +08:00
|
|
|
thread_count = migrate_multifd_channels();
|
|
|
|
multifd_recv_state = g_malloc0(sizeof(*multifd_recv_state));
|
|
|
|
multifd_recv_state->params = g_new0(MultiFDRecvParams, thread_count);
|
2020-09-23 18:56:46 +08:00
|
|
|
qatomic_set(&multifd_recv_state->count, 0);
|
2024-02-21 06:41:08 +08:00
|
|
|
qatomic_set(&multifd_recv_state->exiting, 0);
|
2020-01-22 23:16:07 +08:00
|
|
|
qemu_sem_init(&multifd_recv_state->sem_sync, 0);
|
2019-05-15 19:37:46 +08:00
|
|
|
multifd_recv_state->ops = multifd_ops[migrate_multifd_compression()];
|
2020-01-22 23:16:07 +08:00
|
|
|
|
|
|
|
for (i = 0; i < thread_count; i++) {
|
|
|
|
MultiFDRecvParams *p = &multifd_recv_state->params[i];
|
|
|
|
|
|
|
|
qemu_mutex_init(&p->mutex);
|
|
|
|
qemu_sem_init(&p->sem_sync, 0);
|
|
|
|
p->id = i;
|
|
|
|
p->packet_len = sizeof(MultiFDPacket_t)
|
|
|
|
+ sizeof(uint64_t) * page_count;
|
|
|
|
p->packet = g_malloc0(p->packet_len);
|
|
|
|
p->name = g_strdup_printf("multifdrecv_%d", i);
|
2021-11-19 19:06:05 +08:00
|
|
|
p->iov = g_new0(struct iovec, page_count);
|
2021-11-22 20:41:06 +08:00
|
|
|
p->normal = g_new0(ram_addr_t, page_count);
|
2022-05-02 22:53:12 +08:00
|
|
|
p->page_count = page_count;
|
2022-05-02 22:45:35 +08:00
|
|
|
p->page_size = qemu_target_page_size();
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
2019-05-15 19:37:46 +08:00
|
|
|
|
|
|
|
for (i = 0; i < thread_count; i++) {
|
|
|
|
MultiFDRecvParams *p = &multifd_recv_state->params[i];
|
|
|
|
int ret;
|
|
|
|
|
2023-12-31 17:30:16 +08:00
|
|
|
ret = multifd_recv_state->ops->recv_setup(p, errp);
|
2019-05-15 19:37:46 +08:00
|
|
|
if (ret) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
}
|
2020-01-22 23:16:07 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool multifd_recv_all_channels_created(void)
|
|
|
|
{
|
|
|
|
int thread_count = migrate_multifd_channels();
|
|
|
|
|
2023-03-02 05:10:29 +08:00
|
|
|
if (!migrate_multifd()) {
|
2020-01-22 23:16:07 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2021-04-21 19:28:33 +08:00
|
|
|
if (!multifd_recv_state) {
|
|
|
|
/* Called before any connections created */
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2020-09-23 18:56:46 +08:00
|
|
|
return thread_count == qatomic_read(&multifd_recv_state->count);
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Try to receive all multifd channels to get ready for the migration.
|
2022-12-21 02:44:18 +08:00
|
|
|
* Sets @errp when failing to receive the current channel.
|
2020-01-22 23:16:07 +08:00
|
|
|
*/
|
2022-12-21 02:44:18 +08:00
|
|
|
void multifd_recv_new_channel(QIOChannel *ioc, Error **errp)
|
2020-01-22 23:16:07 +08:00
|
|
|
{
|
|
|
|
MultiFDRecvParams *p;
|
|
|
|
Error *local_err = NULL;
|
|
|
|
int id;
|
|
|
|
|
|
|
|
id = multifd_recv_initial_packet(ioc, &local_err);
|
|
|
|
if (id < 0) {
|
|
|
|
multifd_recv_terminate_threads(local_err);
|
|
|
|
error_propagate_prepend(errp, local_err,
|
|
|
|
"failed to receive packet"
|
|
|
|
" via multifd channel %d: ",
|
2020-09-23 18:56:46 +08:00
|
|
|
qatomic_read(&multifd_recv_state->count));
|
2022-12-21 02:44:18 +08:00
|
|
|
return;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
trace_multifd_recv_new_channel(id);
|
|
|
|
|
|
|
|
p = &multifd_recv_state->params[id];
|
|
|
|
if (p->c != NULL) {
|
|
|
|
error_setg(&local_err, "multifd: received id '%d' already setup'",
|
|
|
|
id);
|
|
|
|
multifd_recv_terminate_threads(local_err);
|
|
|
|
error_propagate(errp, local_err);
|
2022-12-21 02:44:18 +08:00
|
|
|
return;
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|
|
|
|
p->c = ioc;
|
|
|
|
object_ref(OBJECT(ioc));
|
|
|
|
|
2024-02-07 05:51:14 +08:00
|
|
|
p->thread_created = true;
|
2020-01-22 23:16:07 +08:00
|
|
|
qemu_thread_create(&p->thread, p->name, multifd_recv_thread, p,
|
|
|
|
QEMU_THREAD_JOINABLE);
|
2020-09-23 18:56:46 +08:00
|
|
|
qatomic_inc(&multifd_recv_state->count);
|
2020-01-22 23:16:07 +08:00
|
|
|
}
|