2009-05-18 22:42:09 +08:00
|
|
|
/*
|
|
|
|
* Commandline option parsing functions
|
|
|
|
*
|
|
|
|
* Copyright (c) 2003-2008 Fabrice Bellard
|
|
|
|
* Copyright (c) 2009 Kevin Wolf <kwolf@redhat.com>
|
|
|
|
*
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
|
|
* in the Software without restriction, including without limitation the rights
|
|
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
|
|
* furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice shall be included in
|
|
|
|
* all copies or substantial portions of the Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
|
|
* THE SOFTWARE.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <string.h>
|
|
|
|
|
|
|
|
#include "qemu-common.h"
|
2012-12-18 01:20:00 +08:00
|
|
|
#include "qemu/error-report.h"
|
2012-12-18 01:19:43 +08:00
|
|
|
#include "qapi/qmp/types.h"
|
|
|
|
#include "qapi/error.h"
|
|
|
|
#include "qapi/qmp/qerror.h"
|
2012-12-18 01:20:00 +08:00
|
|
|
#include "qemu/option_int.h"
|
2009-05-18 22:42:09 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Extracts the name of an option from the parameter string (p points at the
|
|
|
|
* first byte of the option name)
|
|
|
|
*
|
|
|
|
* The option name is delimited by delim (usually , or =) or the string end
|
|
|
|
* and is copied into buf. If the option name is longer than buf_size, it is
|
|
|
|
* truncated. buf is always zero terminated.
|
|
|
|
*
|
|
|
|
* The return value is the position of the delimiter/zero byte after the option
|
|
|
|
* name in p.
|
|
|
|
*/
|
|
|
|
const char *get_opt_name(char *buf, int buf_size, const char *p, char delim)
|
|
|
|
{
|
|
|
|
char *q;
|
|
|
|
|
|
|
|
q = buf;
|
|
|
|
while (*p != '\0' && *p != delim) {
|
|
|
|
if (q && (q - buf) < buf_size - 1)
|
|
|
|
*q++ = *p;
|
|
|
|
p++;
|
|
|
|
}
|
|
|
|
if (q)
|
|
|
|
*q = '\0';
|
|
|
|
|
|
|
|
return p;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Extracts the value of an option from the parameter string p (p points at the
|
|
|
|
* first byte of the option value)
|
|
|
|
*
|
|
|
|
* This function is comparable to get_opt_name with the difference that the
|
|
|
|
* delimiter is fixed to be comma which starts a new option. To specify an
|
|
|
|
* option value that contains commas, double each comma.
|
|
|
|
*/
|
|
|
|
const char *get_opt_value(char *buf, int buf_size, const char *p)
|
|
|
|
{
|
|
|
|
char *q;
|
|
|
|
|
|
|
|
q = buf;
|
|
|
|
while (*p != '\0') {
|
|
|
|
if (*p == ',') {
|
|
|
|
if (*(p + 1) != ',')
|
|
|
|
break;
|
|
|
|
p++;
|
|
|
|
}
|
|
|
|
if (q && (q - buf) < buf_size - 1)
|
|
|
|
*q++ = *p;
|
|
|
|
p++;
|
|
|
|
}
|
|
|
|
if (q)
|
|
|
|
*q = '\0';
|
|
|
|
|
|
|
|
return p;
|
|
|
|
}
|
|
|
|
|
2009-07-22 22:43:00 +08:00
|
|
|
int get_next_param_value(char *buf, int buf_size,
|
|
|
|
const char *tag, const char **pstr)
|
|
|
|
{
|
|
|
|
const char *p;
|
|
|
|
char option[128];
|
|
|
|
|
|
|
|
p = *pstr;
|
|
|
|
for(;;) {
|
|
|
|
p = get_opt_name(option, sizeof(option), p, '=');
|
|
|
|
if (*p != '=')
|
|
|
|
break;
|
|
|
|
p++;
|
|
|
|
if (!strcmp(tag, option)) {
|
|
|
|
*pstr = get_opt_value(buf, buf_size, p);
|
|
|
|
if (**pstr == ',') {
|
|
|
|
(*pstr)++;
|
|
|
|
}
|
|
|
|
return strlen(buf);
|
|
|
|
} else {
|
|
|
|
p = get_opt_value(NULL, 0, p);
|
|
|
|
}
|
|
|
|
if (*p != ',')
|
|
|
|
break;
|
|
|
|
p++;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
int get_param_value(char *buf, int buf_size,
|
|
|
|
const char *tag, const char *str)
|
|
|
|
{
|
|
|
|
return get_next_param_value(buf, buf_size, tag, &str);
|
|
|
|
}
|
|
|
|
|
2012-03-22 01:54:42 +08:00
|
|
|
static void parse_option_bool(const char *name, const char *value, bool *ret,
|
|
|
|
Error **errp)
|
2009-07-22 22:43:01 +08:00
|
|
|
{
|
|
|
|
if (value != NULL) {
|
|
|
|
if (!strcmp(value, "on")) {
|
|
|
|
*ret = 1;
|
|
|
|
} else if (!strcmp(value, "off")) {
|
|
|
|
*ret = 0;
|
|
|
|
} else {
|
2012-03-22 01:54:42 +08:00
|
|
|
error_set(errp,QERR_INVALID_PARAMETER_VALUE, name, "'on' or 'off'");
|
2009-07-22 22:43:01 +08:00
|
|
|
}
|
|
|
|
} else {
|
|
|
|
*ret = 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-03-22 01:37:44 +08:00
|
|
|
static void parse_option_number(const char *name, const char *value,
|
|
|
|
uint64_t *ret, Error **errp)
|
2009-07-22 22:43:03 +08:00
|
|
|
{
|
|
|
|
char *postfix;
|
|
|
|
uint64_t number;
|
|
|
|
|
|
|
|
if (value != NULL) {
|
|
|
|
number = strtoull(value, &postfix, 0);
|
|
|
|
if (*postfix != '\0') {
|
2012-03-22 01:37:44 +08:00
|
|
|
error_set(errp, QERR_INVALID_PARAMETER_VALUE, name, "a number");
|
|
|
|
return;
|
2009-07-22 22:43:03 +08:00
|
|
|
}
|
2009-07-29 16:39:59 +08:00
|
|
|
*ret = number;
|
2009-07-22 22:43:03 +08:00
|
|
|
} else {
|
2012-03-22 01:37:44 +08:00
|
|
|
error_set(errp, QERR_INVALID_PARAMETER_VALUE, name, "a number");
|
2009-07-22 22:43:03 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-06-05 17:20:40 +08:00
|
|
|
static const QemuOptDesc *find_desc_by_name(const QemuOptDesc *desc,
|
|
|
|
const char *name)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; desc[i].name != NULL; i++) {
|
|
|
|
if (strcmp(desc[i].name, name) == 0) {
|
|
|
|
return &desc[i];
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2013-07-29 22:47:56 +08:00
|
|
|
void parse_option_size(const char *name, const char *value,
|
|
|
|
uint64_t *ret, Error **errp)
|
2009-07-22 22:43:02 +08:00
|
|
|
{
|
|
|
|
char *postfix;
|
|
|
|
double sizef;
|
|
|
|
|
|
|
|
if (value != NULL) {
|
|
|
|
sizef = strtod(value, &postfix);
|
|
|
|
switch (*postfix) {
|
|
|
|
case 'T':
|
|
|
|
sizef *= 1024;
|
2012-01-10 01:29:51 +08:00
|
|
|
/* fall through */
|
2009-07-22 22:43:02 +08:00
|
|
|
case 'G':
|
|
|
|
sizef *= 1024;
|
2012-01-10 01:29:51 +08:00
|
|
|
/* fall through */
|
2009-07-22 22:43:02 +08:00
|
|
|
case 'M':
|
|
|
|
sizef *= 1024;
|
2012-01-10 01:29:51 +08:00
|
|
|
/* fall through */
|
2009-07-22 22:43:02 +08:00
|
|
|
case 'K':
|
|
|
|
case 'k':
|
|
|
|
sizef *= 1024;
|
2012-01-10 01:29:51 +08:00
|
|
|
/* fall through */
|
2009-07-22 22:43:02 +08:00
|
|
|
case 'b':
|
|
|
|
case '\0':
|
|
|
|
*ret = (uint64_t) sizef;
|
|
|
|
break;
|
|
|
|
default:
|
2012-03-22 02:03:45 +08:00
|
|
|
error_set(errp, QERR_INVALID_PARAMETER_VALUE, name, "a size");
|
qemu-option: Disable two helpful messages that got broken recently
commit 8be7e7e4 and commit ec7b2ccb messed up the ordering of error
message and the helpful explanation that should follow it, like this:
$ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=,
Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
qemu-system-x86_64: -chardev null,id=,: Parameter 'id' expects an identifier
$ qemu-system-x86_64 --nodefaults -S --vnc :0 --machine kvm_shadow_mem=dunno
You may use k, M, G or T suffixes for kilobytes, megabytes, gigabytes and terabytes.
qemu-system-x86_64: -machine kvm_shadow_mem=dunno: Parameter 'kvm_shadow_mem' expects a size
Pity. Disable them for now.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1360354939-10994-5-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
2013-02-09 04:22:17 +08:00
|
|
|
#if 0 /* conversion from qerror_report() to error_set() broke this: */
|
2010-03-26 00:22:34 +08:00
|
|
|
error_printf_unless_qmp("You may use k, M, G or T suffixes for "
|
2009-07-22 22:43:02 +08:00
|
|
|
"kilobytes, megabytes, gigabytes and terabytes.\n");
|
qemu-option: Disable two helpful messages that got broken recently
commit 8be7e7e4 and commit ec7b2ccb messed up the ordering of error
message and the helpful explanation that should follow it, like this:
$ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=,
Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
qemu-system-x86_64: -chardev null,id=,: Parameter 'id' expects an identifier
$ qemu-system-x86_64 --nodefaults -S --vnc :0 --machine kvm_shadow_mem=dunno
You may use k, M, G or T suffixes for kilobytes, megabytes, gigabytes and terabytes.
qemu-system-x86_64: -machine kvm_shadow_mem=dunno: Parameter 'kvm_shadow_mem' expects a size
Pity. Disable them for now.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1360354939-10994-5-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
2013-02-09 04:22:17 +08:00
|
|
|
#endif
|
2012-03-22 02:03:45 +08:00
|
|
|
return;
|
2009-07-22 22:43:02 +08:00
|
|
|
}
|
|
|
|
} else {
|
2012-03-22 02:03:45 +08:00
|
|
|
error_set(errp, QERR_INVALID_PARAMETER_VALUE, name, "a size");
|
2009-07-22 22:43:02 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-02-21 23:24:03 +08:00
|
|
|
bool has_help_option(const char *param)
|
|
|
|
{
|
|
|
|
size_t buflen = strlen(param) + 1;
|
2015-01-28 22:54:01 +08:00
|
|
|
char *buf = g_malloc(buflen);
|
2014-02-21 23:24:03 +08:00
|
|
|
const char *p = param;
|
|
|
|
bool result = false;
|
|
|
|
|
|
|
|
while (*p) {
|
|
|
|
p = get_opt_value(buf, buflen, p);
|
|
|
|
if (*p) {
|
|
|
|
p++;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (is_help_option(buf)) {
|
|
|
|
result = true;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
out:
|
2015-01-28 22:54:02 +08:00
|
|
|
g_free(buf);
|
2014-02-21 23:24:03 +08:00
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool is_valid_option_list(const char *param)
|
|
|
|
{
|
|
|
|
size_t buflen = strlen(param) + 1;
|
2015-01-28 22:54:01 +08:00
|
|
|
char *buf = g_malloc(buflen);
|
2014-02-21 23:24:03 +08:00
|
|
|
const char *p = param;
|
|
|
|
bool result = true;
|
|
|
|
|
|
|
|
while (*p) {
|
|
|
|
p = get_opt_value(buf, buflen, p);
|
|
|
|
if (*p && !*++p) {
|
|
|
|
result = false;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!*buf || *buf == ',') {
|
|
|
|
result = false;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
out:
|
2015-01-28 22:54:02 +08:00
|
|
|
g_free(buf);
|
2014-02-21 23:24:03 +08:00
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
2014-06-05 17:20:47 +08:00
|
|
|
void qemu_opts_print_help(QemuOptsList *list)
|
|
|
|
{
|
|
|
|
QemuOptDesc *desc;
|
|
|
|
|
|
|
|
assert(list);
|
|
|
|
desc = list->desc;
|
|
|
|
printf("Supported options:\n");
|
|
|
|
while (desc && desc->name) {
|
|
|
|
printf("%-16s %s\n", desc->name,
|
|
|
|
desc->help ? desc->help : "No description available");
|
|
|
|
desc++;
|
|
|
|
}
|
|
|
|
}
|
2009-07-22 22:43:03 +08:00
|
|
|
/* ------------------------------------------------------------------ */
|
|
|
|
|
2014-06-05 17:20:58 +08:00
|
|
|
QemuOpt *qemu_opt_find(QemuOpts *opts, const char *name)
|
2009-07-22 22:43:03 +08:00
|
|
|
{
|
|
|
|
QemuOpt *opt;
|
|
|
|
|
2009-10-06 19:17:04 +08:00
|
|
|
QTAILQ_FOREACH_REVERSE(opt, &opts->head, QemuOptHead, next) {
|
2009-07-22 22:43:03 +08:00
|
|
|
if (strcmp(opt->name, name) != 0)
|
|
|
|
continue;
|
|
|
|
return opt;
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2014-06-05 17:20:45 +08:00
|
|
|
static void qemu_opt_del(QemuOpt *opt)
|
|
|
|
{
|
|
|
|
QTAILQ_REMOVE(&opt->opts->head, opt, next);
|
|
|
|
g_free(opt->name);
|
|
|
|
g_free(opt->str);
|
|
|
|
g_free(opt);
|
|
|
|
}
|
|
|
|
|
QemuOpts: add qemu_opt_get_*_del functions for replace work
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to a
second driver for further option processing. get_*_del makes it easier
to retrieve a known option (or its default) and remove it from the list
all in one action.
Share common helper function:
For qemu_opt_get_bool/size/number, they and their get_*_del counterpart
could share most of the code except whether or not deleting the opt from
option list, so generate common helper functions.
For qemu_opt_get and qemu_opt_get_del, keep code duplication, since
1. qemu_opt_get_del returns malloc'd memory while qemu_opt_get returns
in-place memory
2. qemu_opt_get_del returns (char *), qemu_opt_get returns (const char *),
and could not change to (char *), since in one case, it will return
desc->def_value_str, which is (const char *).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-05 17:20:46 +08:00
|
|
|
/* qemu_opt_set allows many settings for the same option.
|
|
|
|
* This function deletes all settings for an option.
|
|
|
|
*/
|
|
|
|
static void qemu_opt_del_all(QemuOpts *opts, const char *name)
|
|
|
|
{
|
|
|
|
QemuOpt *opt, *next_opt;
|
|
|
|
|
|
|
|
QTAILQ_FOREACH_SAFE(opt, &opts->head, next, next_opt) {
|
|
|
|
if (!strcmp(opt->name, name)) {
|
|
|
|
qemu_opt_del(opt);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-07-22 22:43:03 +08:00
|
|
|
const char *qemu_opt_get(QemuOpts *opts, const char *name)
|
|
|
|
{
|
2014-06-18 10:47:26 +08:00
|
|
|
QemuOpt *opt;
|
|
|
|
|
|
|
|
if (opts == NULL) {
|
|
|
|
return NULL;
|
|
|
|
}
|
2014-06-05 17:20:42 +08:00
|
|
|
|
2014-06-18 10:47:26 +08:00
|
|
|
opt = qemu_opt_find(opts, name);
|
2014-06-05 17:20:42 +08:00
|
|
|
if (!opt) {
|
|
|
|
const QemuOptDesc *desc = find_desc_by_name(opts->list->desc, name);
|
|
|
|
if (desc && desc->def_value_str) {
|
|
|
|
return desc->def_value_str;
|
|
|
|
}
|
|
|
|
}
|
2009-07-22 22:43:03 +08:00
|
|
|
return opt ? opt->str : NULL;
|
|
|
|
}
|
|
|
|
|
QemuOpts: add qemu_opt_get_*_del functions for replace work
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to a
second driver for further option processing. get_*_del makes it easier
to retrieve a known option (or its default) and remove it from the list
all in one action.
Share common helper function:
For qemu_opt_get_bool/size/number, they and their get_*_del counterpart
could share most of the code except whether or not deleting the opt from
option list, so generate common helper functions.
For qemu_opt_get and qemu_opt_get_del, keep code duplication, since
1. qemu_opt_get_del returns malloc'd memory while qemu_opt_get returns
in-place memory
2. qemu_opt_get_del returns (char *), qemu_opt_get returns (const char *),
and could not change to (char *), since in one case, it will return
desc->def_value_str, which is (const char *).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-05 17:20:46 +08:00
|
|
|
/* Get a known option (or its default) and remove it from the list
|
|
|
|
* all in one action. Return a malloced string of the option value.
|
|
|
|
* Result must be freed by caller with g_free().
|
|
|
|
*/
|
|
|
|
char *qemu_opt_get_del(QemuOpts *opts, const char *name)
|
|
|
|
{
|
|
|
|
QemuOpt *opt;
|
|
|
|
const QemuOptDesc *desc;
|
|
|
|
char *str = NULL;
|
|
|
|
|
|
|
|
if (opts == NULL) {
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
opt = qemu_opt_find(opts, name);
|
|
|
|
if (!opt) {
|
|
|
|
desc = find_desc_by_name(opts->list->desc, name);
|
|
|
|
if (desc && desc->def_value_str) {
|
|
|
|
str = g_strdup(desc->def_value_str);
|
|
|
|
}
|
|
|
|
return str;
|
|
|
|
}
|
|
|
|
str = opt->str;
|
|
|
|
opt->str = NULL;
|
|
|
|
qemu_opt_del_all(opts, name);
|
|
|
|
return str;
|
|
|
|
}
|
|
|
|
|
2012-08-02 20:45:54 +08:00
|
|
|
bool qemu_opt_has_help_opt(QemuOpts *opts)
|
|
|
|
{
|
|
|
|
QemuOpt *opt;
|
|
|
|
|
|
|
|
QTAILQ_FOREACH_REVERSE(opt, &opts->head, QemuOptHead, next) {
|
|
|
|
if (is_help_option(opt->name)) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
QemuOpts: add qemu_opt_get_*_del functions for replace work
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to a
second driver for further option processing. get_*_del makes it easier
to retrieve a known option (or its default) and remove it from the list
all in one action.
Share common helper function:
For qemu_opt_get_bool/size/number, they and their get_*_del counterpart
could share most of the code except whether or not deleting the opt from
option list, so generate common helper functions.
For qemu_opt_get and qemu_opt_get_del, keep code duplication, since
1. qemu_opt_get_del returns malloc'd memory while qemu_opt_get returns
in-place memory
2. qemu_opt_get_del returns (char *), qemu_opt_get returns (const char *),
and could not change to (char *), since in one case, it will return
desc->def_value_str, which is (const char *).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-05 17:20:46 +08:00
|
|
|
static bool qemu_opt_get_bool_helper(QemuOpts *opts, const char *name,
|
|
|
|
bool defval, bool del)
|
2009-07-22 22:43:03 +08:00
|
|
|
{
|
2014-06-18 10:47:26 +08:00
|
|
|
QemuOpt *opt;
|
QemuOpts: add qemu_opt_get_*_del functions for replace work
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to a
second driver for further option processing. get_*_del makes it easier
to retrieve a known option (or its default) and remove it from the list
all in one action.
Share common helper function:
For qemu_opt_get_bool/size/number, they and their get_*_del counterpart
could share most of the code except whether or not deleting the opt from
option list, so generate common helper functions.
For qemu_opt_get and qemu_opt_get_del, keep code duplication, since
1. qemu_opt_get_del returns malloc'd memory while qemu_opt_get returns
in-place memory
2. qemu_opt_get_del returns (char *), qemu_opt_get returns (const char *),
and could not change to (char *), since in one case, it will return
desc->def_value_str, which is (const char *).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-05 17:20:46 +08:00
|
|
|
bool ret = defval;
|
2009-07-22 22:43:03 +08:00
|
|
|
|
2014-06-18 10:47:26 +08:00
|
|
|
if (opts == NULL) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
opt = qemu_opt_find(opts, name);
|
2014-06-05 17:20:42 +08:00
|
|
|
if (opt == NULL) {
|
|
|
|
const QemuOptDesc *desc = find_desc_by_name(opts->list->desc, name);
|
|
|
|
if (desc && desc->def_value_str) {
|
QemuOpts: add qemu_opt_get_*_del functions for replace work
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to a
second driver for further option processing. get_*_del makes it easier
to retrieve a known option (or its default) and remove it from the list
all in one action.
Share common helper function:
For qemu_opt_get_bool/size/number, they and their get_*_del counterpart
could share most of the code except whether or not deleting the opt from
option list, so generate common helper functions.
For qemu_opt_get and qemu_opt_get_del, keep code duplication, since
1. qemu_opt_get_del returns malloc'd memory while qemu_opt_get returns
in-place memory
2. qemu_opt_get_del returns (char *), qemu_opt_get returns (const char *),
and could not change to (char *), since in one case, it will return
desc->def_value_str, which is (const char *).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-05 17:20:46 +08:00
|
|
|
parse_option_bool(name, desc->def_value_str, &ret, &error_abort);
|
2014-06-05 17:20:42 +08:00
|
|
|
}
|
QemuOpts: add qemu_opt_get_*_del functions for replace work
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to a
second driver for further option processing. get_*_del makes it easier
to retrieve a known option (or its default) and remove it from the list
all in one action.
Share common helper function:
For qemu_opt_get_bool/size/number, they and their get_*_del counterpart
could share most of the code except whether or not deleting the opt from
option list, so generate common helper functions.
For qemu_opt_get and qemu_opt_get_del, keep code duplication, since
1. qemu_opt_get_del returns malloc'd memory while qemu_opt_get returns
in-place memory
2. qemu_opt_get_del returns (char *), qemu_opt_get returns (const char *),
and could not change to (char *), since in one case, it will return
desc->def_value_str, which is (const char *).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-05 17:20:46 +08:00
|
|
|
return ret;
|
2014-06-05 17:20:42 +08:00
|
|
|
}
|
2009-07-22 22:43:03 +08:00
|
|
|
assert(opt->desc && opt->desc->type == QEMU_OPT_BOOL);
|
QemuOpts: add qemu_opt_get_*_del functions for replace work
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to a
second driver for further option processing. get_*_del makes it easier
to retrieve a known option (or its default) and remove it from the list
all in one action.
Share common helper function:
For qemu_opt_get_bool/size/number, they and their get_*_del counterpart
could share most of the code except whether or not deleting the opt from
option list, so generate common helper functions.
For qemu_opt_get and qemu_opt_get_del, keep code duplication, since
1. qemu_opt_get_del returns malloc'd memory while qemu_opt_get returns
in-place memory
2. qemu_opt_get_del returns (char *), qemu_opt_get returns (const char *),
and could not change to (char *), since in one case, it will return
desc->def_value_str, which is (const char *).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-05 17:20:46 +08:00
|
|
|
ret = opt->value.boolean;
|
|
|
|
if (del) {
|
|
|
|
qemu_opt_del_all(opts, name);
|
|
|
|
}
|
|
|
|
return ret;
|
2009-07-22 22:43:03 +08:00
|
|
|
}
|
|
|
|
|
QemuOpts: add qemu_opt_get_*_del functions for replace work
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to a
second driver for further option processing. get_*_del makes it easier
to retrieve a known option (or its default) and remove it from the list
all in one action.
Share common helper function:
For qemu_opt_get_bool/size/number, they and their get_*_del counterpart
could share most of the code except whether or not deleting the opt from
option list, so generate common helper functions.
For qemu_opt_get and qemu_opt_get_del, keep code duplication, since
1. qemu_opt_get_del returns malloc'd memory while qemu_opt_get returns
in-place memory
2. qemu_opt_get_del returns (char *), qemu_opt_get returns (const char *),
and could not change to (char *), since in one case, it will return
desc->def_value_str, which is (const char *).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-05 17:20:46 +08:00
|
|
|
bool qemu_opt_get_bool(QemuOpts *opts, const char *name, bool defval)
|
|
|
|
{
|
|
|
|
return qemu_opt_get_bool_helper(opts, name, defval, false);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool qemu_opt_get_bool_del(QemuOpts *opts, const char *name, bool defval)
|
|
|
|
{
|
|
|
|
return qemu_opt_get_bool_helper(opts, name, defval, true);
|
|
|
|
}
|
|
|
|
|
|
|
|
static uint64_t qemu_opt_get_number_helper(QemuOpts *opts, const char *name,
|
|
|
|
uint64_t defval, bool del)
|
2009-07-22 22:43:03 +08:00
|
|
|
{
|
2014-06-18 10:47:26 +08:00
|
|
|
QemuOpt *opt;
|
QemuOpts: add qemu_opt_get_*_del functions for replace work
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to a
second driver for further option processing. get_*_del makes it easier
to retrieve a known option (or its default) and remove it from the list
all in one action.
Share common helper function:
For qemu_opt_get_bool/size/number, they and their get_*_del counterpart
could share most of the code except whether or not deleting the opt from
option list, so generate common helper functions.
For qemu_opt_get and qemu_opt_get_del, keep code duplication, since
1. qemu_opt_get_del returns malloc'd memory while qemu_opt_get returns
in-place memory
2. qemu_opt_get_del returns (char *), qemu_opt_get returns (const char *),
and could not change to (char *), since in one case, it will return
desc->def_value_str, which is (const char *).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-05 17:20:46 +08:00
|
|
|
uint64_t ret = defval;
|
2009-07-22 22:43:03 +08:00
|
|
|
|
2014-06-18 10:47:26 +08:00
|
|
|
if (opts == NULL) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
opt = qemu_opt_find(opts, name);
|
2014-06-05 17:20:42 +08:00
|
|
|
if (opt == NULL) {
|
|
|
|
const QemuOptDesc *desc = find_desc_by_name(opts->list->desc, name);
|
|
|
|
if (desc && desc->def_value_str) {
|
QemuOpts: add qemu_opt_get_*_del functions for replace work
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to a
second driver for further option processing. get_*_del makes it easier
to retrieve a known option (or its default) and remove it from the list
all in one action.
Share common helper function:
For qemu_opt_get_bool/size/number, they and their get_*_del counterpart
could share most of the code except whether or not deleting the opt from
option list, so generate common helper functions.
For qemu_opt_get and qemu_opt_get_del, keep code duplication, since
1. qemu_opt_get_del returns malloc'd memory while qemu_opt_get returns
in-place memory
2. qemu_opt_get_del returns (char *), qemu_opt_get returns (const char *),
and could not change to (char *), since in one case, it will return
desc->def_value_str, which is (const char *).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-05 17:20:46 +08:00
|
|
|
parse_option_number(name, desc->def_value_str, &ret, &error_abort);
|
2014-06-05 17:20:42 +08:00
|
|
|
}
|
QemuOpts: add qemu_opt_get_*_del functions for replace work
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to a
second driver for further option processing. get_*_del makes it easier
to retrieve a known option (or its default) and remove it from the list
all in one action.
Share common helper function:
For qemu_opt_get_bool/size/number, they and their get_*_del counterpart
could share most of the code except whether or not deleting the opt from
option list, so generate common helper functions.
For qemu_opt_get and qemu_opt_get_del, keep code duplication, since
1. qemu_opt_get_del returns malloc'd memory while qemu_opt_get returns
in-place memory
2. qemu_opt_get_del returns (char *), qemu_opt_get returns (const char *),
and could not change to (char *), since in one case, it will return
desc->def_value_str, which is (const char *).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-05 17:20:46 +08:00
|
|
|
return ret;
|
2014-06-05 17:20:42 +08:00
|
|
|
}
|
2009-07-22 22:43:03 +08:00
|
|
|
assert(opt->desc && opt->desc->type == QEMU_OPT_NUMBER);
|
QemuOpts: add qemu_opt_get_*_del functions for replace work
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to a
second driver for further option processing. get_*_del makes it easier
to retrieve a known option (or its default) and remove it from the list
all in one action.
Share common helper function:
For qemu_opt_get_bool/size/number, they and their get_*_del counterpart
could share most of the code except whether or not deleting the opt from
option list, so generate common helper functions.
For qemu_opt_get and qemu_opt_get_del, keep code duplication, since
1. qemu_opt_get_del returns malloc'd memory while qemu_opt_get returns
in-place memory
2. qemu_opt_get_del returns (char *), qemu_opt_get returns (const char *),
and could not change to (char *), since in one case, it will return
desc->def_value_str, which is (const char *).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-05 17:20:46 +08:00
|
|
|
ret = opt->value.uint;
|
|
|
|
if (del) {
|
|
|
|
qemu_opt_del_all(opts, name);
|
|
|
|
}
|
|
|
|
return ret;
|
2009-07-22 22:43:03 +08:00
|
|
|
}
|
|
|
|
|
QemuOpts: add qemu_opt_get_*_del functions for replace work
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to a
second driver for further option processing. get_*_del makes it easier
to retrieve a known option (or its default) and remove it from the list
all in one action.
Share common helper function:
For qemu_opt_get_bool/size/number, they and their get_*_del counterpart
could share most of the code except whether or not deleting the opt from
option list, so generate common helper functions.
For qemu_opt_get and qemu_opt_get_del, keep code duplication, since
1. qemu_opt_get_del returns malloc'd memory while qemu_opt_get returns
in-place memory
2. qemu_opt_get_del returns (char *), qemu_opt_get returns (const char *),
and could not change to (char *), since in one case, it will return
desc->def_value_str, which is (const char *).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-05 17:20:46 +08:00
|
|
|
uint64_t qemu_opt_get_number(QemuOpts *opts, const char *name, uint64_t defval)
|
|
|
|
{
|
|
|
|
return qemu_opt_get_number_helper(opts, name, defval, false);
|
|
|
|
}
|
|
|
|
|
|
|
|
uint64_t qemu_opt_get_number_del(QemuOpts *opts, const char *name,
|
|
|
|
uint64_t defval)
|
|
|
|
{
|
|
|
|
return qemu_opt_get_number_helper(opts, name, defval, true);
|
|
|
|
}
|
|
|
|
|
|
|
|
static uint64_t qemu_opt_get_size_helper(QemuOpts *opts, const char *name,
|
|
|
|
uint64_t defval, bool del)
|
2009-07-22 22:43:03 +08:00
|
|
|
{
|
2014-06-18 10:47:26 +08:00
|
|
|
QemuOpt *opt;
|
QemuOpts: add qemu_opt_get_*_del functions for replace work
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to a
second driver for further option processing. get_*_del makes it easier
to retrieve a known option (or its default) and remove it from the list
all in one action.
Share common helper function:
For qemu_opt_get_bool/size/number, they and their get_*_del counterpart
could share most of the code except whether or not deleting the opt from
option list, so generate common helper functions.
For qemu_opt_get and qemu_opt_get_del, keep code duplication, since
1. qemu_opt_get_del returns malloc'd memory while qemu_opt_get returns
in-place memory
2. qemu_opt_get_del returns (char *), qemu_opt_get returns (const char *),
and could not change to (char *), since in one case, it will return
desc->def_value_str, which is (const char *).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-05 17:20:46 +08:00
|
|
|
uint64_t ret = defval;
|
2009-07-22 22:43:03 +08:00
|
|
|
|
2014-06-18 10:47:26 +08:00
|
|
|
if (opts == NULL) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
opt = qemu_opt_find(opts, name);
|
2014-06-05 17:20:42 +08:00
|
|
|
if (opt == NULL) {
|
|
|
|
const QemuOptDesc *desc = find_desc_by_name(opts->list->desc, name);
|
|
|
|
if (desc && desc->def_value_str) {
|
QemuOpts: add qemu_opt_get_*_del functions for replace work
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to a
second driver for further option processing. get_*_del makes it easier
to retrieve a known option (or its default) and remove it from the list
all in one action.
Share common helper function:
For qemu_opt_get_bool/size/number, they and their get_*_del counterpart
could share most of the code except whether or not deleting the opt from
option list, so generate common helper functions.
For qemu_opt_get and qemu_opt_get_del, keep code duplication, since
1. qemu_opt_get_del returns malloc'd memory while qemu_opt_get returns
in-place memory
2. qemu_opt_get_del returns (char *), qemu_opt_get returns (const char *),
and could not change to (char *), since in one case, it will return
desc->def_value_str, which is (const char *).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-05 17:20:46 +08:00
|
|
|
parse_option_size(name, desc->def_value_str, &ret, &error_abort);
|
2014-06-05 17:20:42 +08:00
|
|
|
}
|
QemuOpts: add qemu_opt_get_*_del functions for replace work
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to a
second driver for further option processing. get_*_del makes it easier
to retrieve a known option (or its default) and remove it from the list
all in one action.
Share common helper function:
For qemu_opt_get_bool/size/number, they and their get_*_del counterpart
could share most of the code except whether or not deleting the opt from
option list, so generate common helper functions.
For qemu_opt_get and qemu_opt_get_del, keep code duplication, since
1. qemu_opt_get_del returns malloc'd memory while qemu_opt_get returns
in-place memory
2. qemu_opt_get_del returns (char *), qemu_opt_get returns (const char *),
and could not change to (char *), since in one case, it will return
desc->def_value_str, which is (const char *).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-05 17:20:46 +08:00
|
|
|
return ret;
|
2014-06-05 17:20:42 +08:00
|
|
|
}
|
2009-07-22 22:43:03 +08:00
|
|
|
assert(opt->desc && opt->desc->type == QEMU_OPT_SIZE);
|
QemuOpts: add qemu_opt_get_*_del functions for replace work
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to a
second driver for further option processing. get_*_del makes it easier
to retrieve a known option (or its default) and remove it from the list
all in one action.
Share common helper function:
For qemu_opt_get_bool/size/number, they and their get_*_del counterpart
could share most of the code except whether or not deleting the opt from
option list, so generate common helper functions.
For qemu_opt_get and qemu_opt_get_del, keep code duplication, since
1. qemu_opt_get_del returns malloc'd memory while qemu_opt_get returns
in-place memory
2. qemu_opt_get_del returns (char *), qemu_opt_get returns (const char *),
and could not change to (char *), since in one case, it will return
desc->def_value_str, which is (const char *).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-05 17:20:46 +08:00
|
|
|
ret = opt->value.uint;
|
|
|
|
if (del) {
|
|
|
|
qemu_opt_del_all(opts, name);
|
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
uint64_t qemu_opt_get_size(QemuOpts *opts, const char *name, uint64_t defval)
|
|
|
|
{
|
|
|
|
return qemu_opt_get_size_helper(opts, name, defval, false);
|
|
|
|
}
|
|
|
|
|
|
|
|
uint64_t qemu_opt_get_size_del(QemuOpts *opts, const char *name,
|
|
|
|
uint64_t defval)
|
|
|
|
{
|
|
|
|
return qemu_opt_get_size_helper(opts, name, defval, true);
|
2009-07-22 22:43:03 +08:00
|
|
|
}
|
|
|
|
|
2012-03-22 02:21:26 +08:00
|
|
|
static void qemu_opt_parse(QemuOpt *opt, Error **errp)
|
2009-07-22 22:43:03 +08:00
|
|
|
{
|
|
|
|
if (opt->desc == NULL)
|
2012-03-22 02:21:26 +08:00
|
|
|
return;
|
2012-03-22 01:37:44 +08:00
|
|
|
|
2009-07-22 22:43:03 +08:00
|
|
|
switch (opt->desc->type) {
|
|
|
|
case QEMU_OPT_STRING:
|
|
|
|
/* nothing */
|
2012-03-22 02:21:26 +08:00
|
|
|
return;
|
2009-07-22 22:43:03 +08:00
|
|
|
case QEMU_OPT_BOOL:
|
2012-03-22 02:21:26 +08:00
|
|
|
parse_option_bool(opt->name, opt->str, &opt->value.boolean, errp);
|
2012-03-22 01:54:42 +08:00
|
|
|
break;
|
2009-07-22 22:43:03 +08:00
|
|
|
case QEMU_OPT_NUMBER:
|
2012-03-22 02:21:26 +08:00
|
|
|
parse_option_number(opt->name, opt->str, &opt->value.uint, errp);
|
2012-03-22 01:37:44 +08:00
|
|
|
break;
|
2009-07-22 22:43:03 +08:00
|
|
|
case QEMU_OPT_SIZE:
|
2012-03-22 02:21:26 +08:00
|
|
|
parse_option_size(opt->name, opt->str, &opt->value.uint, errp);
|
2012-03-22 02:03:45 +08:00
|
|
|
break;
|
2009-07-22 22:43:03 +08:00
|
|
|
default:
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-12-06 14:47:18 +08:00
|
|
|
static bool opts_accepts_any(const QemuOpts *opts)
|
|
|
|
{
|
|
|
|
return opts->list->desc[0].name == NULL;
|
|
|
|
}
|
|
|
|
|
2013-07-17 20:40:37 +08:00
|
|
|
int qemu_opt_unset(QemuOpts *opts, const char *name)
|
|
|
|
{
|
|
|
|
QemuOpt *opt = qemu_opt_find(opts, name);
|
|
|
|
|
|
|
|
assert(opts_accepts_any(opts));
|
|
|
|
|
|
|
|
if (opt == NULL) {
|
|
|
|
return -1;
|
|
|
|
} else {
|
|
|
|
qemu_opt_del(opt);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-12-06 14:47:18 +08:00
|
|
|
static void opt_set(QemuOpts *opts, const char *name, const char *value,
|
|
|
|
bool prepend, Error **errp)
|
|
|
|
{
|
|
|
|
QemuOpt *opt;
|
|
|
|
const QemuOptDesc *desc;
|
|
|
|
Error *local_err = NULL;
|
|
|
|
|
|
|
|
desc = find_desc_by_name(opts->list->desc, name);
|
|
|
|
if (!desc && !opts_accepts_any(opts)) {
|
|
|
|
error_set(errp, QERR_INVALID_PARAMETER, name);
|
|
|
|
return;
|
2009-07-22 22:43:03 +08:00
|
|
|
}
|
2009-10-06 19:17:04 +08:00
|
|
|
|
2011-08-21 11:09:37 +08:00
|
|
|
opt = g_malloc0(sizeof(*opt));
|
|
|
|
opt->name = g_strdup(name);
|
2009-10-06 19:17:04 +08:00
|
|
|
opt->opts = opts;
|
2012-01-28 02:54:54 +08:00
|
|
|
if (prepend) {
|
|
|
|
QTAILQ_INSERT_HEAD(&opts->head, opt, next);
|
|
|
|
} else {
|
|
|
|
QTAILQ_INSERT_TAIL(&opts->head, opt, next);
|
|
|
|
}
|
2012-12-06 14:47:18 +08:00
|
|
|
opt->desc = desc;
|
2013-01-22 18:07:57 +08:00
|
|
|
opt->str = g_strdup(value);
|
2012-03-22 02:21:26 +08:00
|
|
|
qemu_opt_parse(opt, &local_err);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2012-03-22 03:13:24 +08:00
|
|
|
error_propagate(errp, local_err);
|
2009-07-22 22:43:03 +08:00
|
|
|
qemu_opt_del(opt);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-02-13 00:52:20 +08:00
|
|
|
void qemu_opt_set(QemuOpts *opts, const char *name, const char *value,
|
|
|
|
Error **errp)
|
2012-03-22 03:17:21 +08:00
|
|
|
{
|
|
|
|
opt_set(opts, name, value, false, errp);
|
|
|
|
}
|
|
|
|
|
2015-02-12 23:37:44 +08:00
|
|
|
void qemu_opt_set_bool(QemuOpts *opts, const char *name, bool val,
|
|
|
|
Error **errp)
|
2011-10-25 14:40:39 +08:00
|
|
|
{
|
|
|
|
QemuOpt *opt;
|
|
|
|
const QemuOptDesc *desc = opts->list->desc;
|
|
|
|
|
2012-12-06 14:47:20 +08:00
|
|
|
opt = g_malloc0(sizeof(*opt));
|
|
|
|
opt->desc = find_desc_by_name(desc, name);
|
|
|
|
if (!opt->desc && !opts_accepts_any(opts)) {
|
2015-02-12 23:37:44 +08:00
|
|
|
error_set(errp, QERR_INVALID_PARAMETER, name);
|
2012-12-06 14:47:20 +08:00
|
|
|
g_free(opt);
|
2015-02-12 23:37:44 +08:00
|
|
|
return;
|
2011-10-25 14:40:39 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
opt->name = g_strdup(name);
|
|
|
|
opt->opts = opts;
|
|
|
|
opt->value.boolean = !!val;
|
2012-12-06 14:47:20 +08:00
|
|
|
opt->str = g_strdup(val ? "on" : "off");
|
|
|
|
QTAILQ_INSERT_TAIL(&opts->head, opt, next);
|
2011-10-25 14:40:39 +08:00
|
|
|
}
|
|
|
|
|
2015-02-12 23:46:36 +08:00
|
|
|
void qemu_opt_set_number(QemuOpts *opts, const char *name, int64_t val,
|
|
|
|
Error **errp)
|
2012-12-06 14:47:23 +08:00
|
|
|
{
|
|
|
|
QemuOpt *opt;
|
|
|
|
const QemuOptDesc *desc = opts->list->desc;
|
|
|
|
|
|
|
|
opt = g_malloc0(sizeof(*opt));
|
|
|
|
opt->desc = find_desc_by_name(desc, name);
|
|
|
|
if (!opt->desc && !opts_accepts_any(opts)) {
|
2015-02-12 23:46:36 +08:00
|
|
|
error_set(errp, QERR_INVALID_PARAMETER, name);
|
2012-12-06 14:47:23 +08:00
|
|
|
g_free(opt);
|
2015-02-12 23:46:36 +08:00
|
|
|
return;
|
2012-12-06 14:47:23 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
opt->name = g_strdup(name);
|
|
|
|
opt->opts = opts;
|
|
|
|
opt->value.uint = val;
|
|
|
|
opt->str = g_strdup_printf("%" PRId64, val);
|
|
|
|
QTAILQ_INSERT_TAIL(&opts->head, opt, next);
|
|
|
|
}
|
|
|
|
|
2009-07-31 18:25:32 +08:00
|
|
|
int qemu_opt_foreach(QemuOpts *opts, qemu_opt_loopfunc func, void *opaque,
|
|
|
|
int abort_on_failure)
|
|
|
|
{
|
|
|
|
QemuOpt *opt;
|
|
|
|
int rc = 0;
|
|
|
|
|
2009-09-12 15:36:22 +08:00
|
|
|
QTAILQ_FOREACH(opt, &opts->head, next) {
|
2009-07-31 18:25:32 +08:00
|
|
|
rc = func(opt->name, opt->str, opaque);
|
|
|
|
if (abort_on_failure && rc != 0)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2009-07-22 22:43:03 +08:00
|
|
|
QemuOpts *qemu_opts_find(QemuOptsList *list, const char *id)
|
|
|
|
{
|
|
|
|
QemuOpts *opts;
|
|
|
|
|
2009-09-12 15:36:22 +08:00
|
|
|
QTAILQ_FOREACH(opts, &list->head, next) {
|
2013-07-04 21:09:17 +08:00
|
|
|
if (!opts->id && !id) {
|
|
|
|
return opts;
|
2009-07-22 22:43:03 +08:00
|
|
|
}
|
2013-07-04 21:09:17 +08:00
|
|
|
if (opts->id && id && !strcmp(opts->id, id)) {
|
|
|
|
return opts;
|
2009-07-22 22:43:03 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2012-03-21 02:51:57 +08:00
|
|
|
QemuOpts *qemu_opts_create(QemuOptsList *list, const char *id,
|
|
|
|
int fail_if_exists, Error **errp)
|
2009-07-22 22:43:03 +08:00
|
|
|
{
|
|
|
|
QemuOpts *opts = NULL;
|
|
|
|
|
|
|
|
if (id) {
|
2014-09-30 19:59:30 +08:00
|
|
|
if (!id_wellformed(id)) {
|
2012-03-21 02:51:57 +08:00
|
|
|
error_set(errp,QERR_INVALID_PARAMETER_VALUE, "id", "an identifier");
|
qemu-option: Disable two helpful messages that got broken recently
commit 8be7e7e4 and commit ec7b2ccb messed up the ordering of error
message and the helpful explanation that should follow it, like this:
$ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=,
Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
qemu-system-x86_64: -chardev null,id=,: Parameter 'id' expects an identifier
$ qemu-system-x86_64 --nodefaults -S --vnc :0 --machine kvm_shadow_mem=dunno
You may use k, M, G or T suffixes for kilobytes, megabytes, gigabytes and terabytes.
qemu-system-x86_64: -machine kvm_shadow_mem=dunno: Parameter 'kvm_shadow_mem' expects a size
Pity. Disable them for now.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1360354939-10994-5-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
2013-02-09 04:22:17 +08:00
|
|
|
#if 0 /* conversion from qerror_report() to error_set() broke this: */
|
2010-06-08 19:54:26 +08:00
|
|
|
error_printf_unless_qmp("Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.\n");
|
qemu-option: Disable two helpful messages that got broken recently
commit 8be7e7e4 and commit ec7b2ccb messed up the ordering of error
message and the helpful explanation that should follow it, like this:
$ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=,
Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
qemu-system-x86_64: -chardev null,id=,: Parameter 'id' expects an identifier
$ qemu-system-x86_64 --nodefaults -S --vnc :0 --machine kvm_shadow_mem=dunno
You may use k, M, G or T suffixes for kilobytes, megabytes, gigabytes and terabytes.
qemu-system-x86_64: -machine kvm_shadow_mem=dunno: Parameter 'kvm_shadow_mem' expects a size
Pity. Disable them for now.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1360354939-10994-5-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
2013-02-09 04:22:17 +08:00
|
|
|
#endif
|
2010-06-08 19:54:26 +08:00
|
|
|
return NULL;
|
|
|
|
}
|
2009-07-22 22:43:03 +08:00
|
|
|
opts = qemu_opts_find(list, id);
|
|
|
|
if (opts != NULL) {
|
2012-02-08 13:41:37 +08:00
|
|
|
if (fail_if_exists && !list->merge_lists) {
|
2014-03-22 07:42:26 +08:00
|
|
|
error_setg(errp, "Duplicate ID '%s' for %s", id, list->name);
|
2009-07-22 22:43:03 +08:00
|
|
|
return NULL;
|
|
|
|
} else {
|
|
|
|
return opts;
|
|
|
|
}
|
|
|
|
}
|
2012-02-08 13:41:37 +08:00
|
|
|
} else if (list->merge_lists) {
|
|
|
|
opts = qemu_opts_find(list, NULL);
|
|
|
|
if (opts) {
|
|
|
|
return opts;
|
|
|
|
}
|
2009-07-22 22:43:03 +08:00
|
|
|
}
|
2011-08-21 11:09:37 +08:00
|
|
|
opts = g_malloc0(sizeof(*opts));
|
2013-01-22 18:07:57 +08:00
|
|
|
opts->id = g_strdup(id);
|
2009-07-22 22:43:03 +08:00
|
|
|
opts->list = list;
|
2010-02-19 02:46:49 +08:00
|
|
|
loc_save(&opts->loc);
|
2009-09-12 15:36:22 +08:00
|
|
|
QTAILQ_INIT(&opts->head);
|
|
|
|
QTAILQ_INSERT_TAIL(&list->head, opts, next);
|
2009-07-22 22:43:03 +08:00
|
|
|
return opts;
|
|
|
|
}
|
|
|
|
|
2010-06-01 16:47:34 +08:00
|
|
|
void qemu_opts_reset(QemuOptsList *list)
|
|
|
|
{
|
|
|
|
QemuOpts *opts, *next_opts;
|
|
|
|
|
|
|
|
QTAILQ_FOREACH_SAFE(opts, &list->head, next, next_opts) {
|
|
|
|
qemu_opts_del(opts);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-05-28 03:06:04 +08:00
|
|
|
void qemu_opts_loc_restore(QemuOpts *opts)
|
|
|
|
{
|
|
|
|
loc_restore(&opts->loc);
|
|
|
|
}
|
|
|
|
|
2015-02-13 00:07:34 +08:00
|
|
|
void qemu_opts_set(QemuOptsList *list, const char *id,
|
|
|
|
const char *name, const char *value, Error **errp)
|
2009-07-22 22:43:03 +08:00
|
|
|
{
|
|
|
|
QemuOpts *opts;
|
2012-03-21 02:51:57 +08:00
|
|
|
Error *local_err = NULL;
|
2009-07-22 22:43:03 +08:00
|
|
|
|
2012-03-21 02:51:57 +08:00
|
|
|
opts = qemu_opts_create(list, id, 1, &local_err);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2015-02-13 00:07:34 +08:00
|
|
|
error_propagate(errp, local_err);
|
|
|
|
return;
|
2009-07-22 22:43:03 +08:00
|
|
|
}
|
2015-02-13 00:52:20 +08:00
|
|
|
qemu_opt_set(opts, name, value, errp);
|
2009-07-22 22:43:03 +08:00
|
|
|
}
|
|
|
|
|
2009-07-31 18:25:32 +08:00
|
|
|
const char *qemu_opts_id(QemuOpts *opts)
|
|
|
|
{
|
|
|
|
return opts->id;
|
|
|
|
}
|
|
|
|
|
2013-07-11 18:52:34 +08:00
|
|
|
/* The id string will be g_free()d by qemu_opts_del */
|
|
|
|
void qemu_opts_set_id(QemuOpts *opts, char *id)
|
|
|
|
{
|
|
|
|
opts->id = id;
|
|
|
|
}
|
|
|
|
|
2009-07-22 22:43:03 +08:00
|
|
|
void qemu_opts_del(QemuOpts *opts)
|
|
|
|
{
|
|
|
|
QemuOpt *opt;
|
|
|
|
|
2014-06-05 17:20:50 +08:00
|
|
|
if (opts == NULL) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2009-07-22 22:43:03 +08:00
|
|
|
for (;;) {
|
2009-09-12 15:36:22 +08:00
|
|
|
opt = QTAILQ_FIRST(&opts->head);
|
2009-07-22 22:43:03 +08:00
|
|
|
if (opt == NULL)
|
|
|
|
break;
|
|
|
|
qemu_opt_del(opt);
|
|
|
|
}
|
2009-09-12 15:36:22 +08:00
|
|
|
QTAILQ_REMOVE(&opts->list->head, opts, next);
|
2011-08-21 11:09:37 +08:00
|
|
|
g_free(opts->id);
|
|
|
|
g_free(opts);
|
2009-07-22 22:43:03 +08:00
|
|
|
}
|
|
|
|
|
2014-12-09 15:38:04 +08:00
|
|
|
void qemu_opts_print(QemuOpts *opts, const char *sep)
|
2009-07-22 22:43:03 +08:00
|
|
|
{
|
|
|
|
QemuOpt *opt;
|
2014-06-05 17:20:42 +08:00
|
|
|
QemuOptDesc *desc = opts->list->desc;
|
2009-07-22 22:43:03 +08:00
|
|
|
|
2014-06-05 17:20:42 +08:00
|
|
|
if (desc[0].name == NULL) {
|
|
|
|
QTAILQ_FOREACH(opt, &opts->head, next) {
|
2014-12-09 15:38:04 +08:00
|
|
|
printf("%s%s=\"%s\"", sep, opt->name, opt->str);
|
2014-06-05 17:20:42 +08:00
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
for (; desc && desc->name; desc++) {
|
|
|
|
const char *value;
|
|
|
|
QemuOpt *opt = qemu_opt_find(opts, desc->name);
|
|
|
|
|
|
|
|
value = opt ? opt->str : desc->def_value_str;
|
|
|
|
if (!value) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if (desc->type == QEMU_OPT_STRING) {
|
2014-12-09 15:38:04 +08:00
|
|
|
printf("%s%s='%s'", sep, desc->name, value);
|
2014-06-05 17:20:42 +08:00
|
|
|
} else if ((desc->type == QEMU_OPT_SIZE ||
|
|
|
|
desc->type == QEMU_OPT_NUMBER) && opt) {
|
2014-12-09 15:38:04 +08:00
|
|
|
printf("%s%s=%" PRId64, sep, desc->name, opt->value.uint);
|
2014-06-05 17:20:42 +08:00
|
|
|
} else {
|
2014-12-09 15:38:04 +08:00
|
|
|
printf("%s%s=%s", sep, desc->name, value);
|
2014-06-05 17:20:42 +08:00
|
|
|
}
|
2009-07-22 22:43:03 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-02-13 00:59:06 +08:00
|
|
|
static void opts_do_parse(QemuOpts *opts, const char *params,
|
|
|
|
const char *firstname, bool prepend, Error **errp)
|
2009-07-22 22:43:03 +08:00
|
|
|
{
|
2009-12-10 18:11:08 +08:00
|
|
|
char option[128], value[1024];
|
2009-07-22 22:43:03 +08:00
|
|
|
const char *p,*pe,*pc;
|
2012-03-22 03:13:24 +08:00
|
|
|
Error *local_err = NULL;
|
2009-07-22 22:43:03 +08:00
|
|
|
|
2009-10-06 19:17:02 +08:00
|
|
|
for (p = params; *p != '\0'; p++) {
|
2009-07-22 22:43:03 +08:00
|
|
|
pe = strchr(p, '=');
|
|
|
|
pc = strchr(p, ',');
|
|
|
|
if (!pe || (pc && pc < pe)) {
|
|
|
|
/* found "foo,more" */
|
|
|
|
if (p == params && firstname) {
|
|
|
|
/* implicitly named first option */
|
|
|
|
pstrcpy(option, sizeof(option), firstname);
|
|
|
|
p = get_opt_value(value, sizeof(value), p);
|
|
|
|
} else {
|
|
|
|
/* option without value, probably a flag */
|
|
|
|
p = get_opt_name(option, sizeof(option), p, ',');
|
2009-09-10 16:58:33 +08:00
|
|
|
if (strncmp(option, "no", 2) == 0) {
|
2009-07-22 22:43:03 +08:00
|
|
|
memmove(option, option+2, strlen(option+2)+1);
|
|
|
|
pstrcpy(value, sizeof(value), "off");
|
|
|
|
} else {
|
|
|
|
pstrcpy(value, sizeof(value), "on");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
/* found "foo=bar,more" */
|
|
|
|
p = get_opt_name(option, sizeof(option), p, '=');
|
|
|
|
if (*p != '=') {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
p++;
|
|
|
|
p = get_opt_value(value, sizeof(value), p);
|
|
|
|
}
|
|
|
|
if (strcmp(option, "id") != 0) {
|
|
|
|
/* store and parse */
|
2012-03-22 03:13:24 +08:00
|
|
|
opt_set(opts, option, value, prepend, &local_err);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2015-02-13 00:59:06 +08:00
|
|
|
error_propagate(errp, local_err);
|
|
|
|
return;
|
2009-07-22 22:43:03 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
if (*p != ',') {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2009-09-10 16:58:33 +08:00
|
|
|
}
|
|
|
|
|
2012-01-28 02:54:54 +08:00
|
|
|
int qemu_opts_do_parse(QemuOpts *opts, const char *params, const char *firstname)
|
|
|
|
{
|
2015-02-13 00:59:06 +08:00
|
|
|
Error *err = NULL;
|
|
|
|
|
|
|
|
opts_do_parse(opts, params, firstname, false, &err);
|
|
|
|
if (err) {
|
|
|
|
qerror_report_err(err);
|
|
|
|
error_free(err);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
return 0;
|
2012-01-28 02:54:54 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static QemuOpts *opts_parse(QemuOptsList *list, const char *params,
|
2015-02-13 01:24:10 +08:00
|
|
|
int permit_abbrev, bool defaults, Error **errp)
|
2009-09-10 16:58:33 +08:00
|
|
|
{
|
2010-02-11 02:52:18 +08:00
|
|
|
const char *firstname;
|
2009-12-10 18:11:08 +08:00
|
|
|
char value[1024], *id = NULL;
|
2009-09-10 16:58:33 +08:00
|
|
|
const char *p;
|
|
|
|
QemuOpts *opts;
|
2012-03-21 02:51:57 +08:00
|
|
|
Error *local_err = NULL;
|
2009-09-10 16:58:33 +08:00
|
|
|
|
2010-02-11 02:52:18 +08:00
|
|
|
assert(!permit_abbrev || list->implied_opt_name);
|
|
|
|
firstname = permit_abbrev ? list->implied_opt_name : NULL;
|
|
|
|
|
2009-09-10 16:58:33 +08:00
|
|
|
if (strncmp(params, "id=", 3) == 0) {
|
|
|
|
get_opt_value(value, sizeof(value), params+3);
|
2010-04-30 00:24:43 +08:00
|
|
|
id = value;
|
2009-09-10 16:58:33 +08:00
|
|
|
} else if ((p = strstr(params, ",id=")) != NULL) {
|
|
|
|
get_opt_value(value, sizeof(value), p+4);
|
2010-04-30 00:24:43 +08:00
|
|
|
id = value;
|
2009-09-10 16:58:33 +08:00
|
|
|
}
|
qemu-option: Guard against qemu_opts_set_defaults() misuse
Commit 6d4cd40 fixed qemu_opts_set_defaults() for an existing corner
case, but broke it for another one that can't be reached in current
code.
Quote from its commit message:
I believe [opts_parse()] attempts to do the following:
If options don't yet exist, create new options
Else, if defaults, modify the existing options
Else, if list->merge_lists, modify the existing options
Else, fail
The only caller that passes true for defaults is
qemu_opts_set_defaults().
The commit message then claims:
A straightforward call of qemu_opts_create() does exactly that.
Wrong. When !list->merge_lists, and the option string doesn't contain
id=, and options without ID exist, then we don't actually modify the
existing options, we create new ones.
Not reachable, because we never pass lists with !list->merge_lists to
qemu_opts_set_defaults().
Guard against possible (if unlikely) future misuse with assert().
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 1375428840-5275-1-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
2013-08-02 15:34:00 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* This code doesn't work for defaults && !list->merge_lists: when
|
|
|
|
* params has no id=, and list has an element with !opts->id, it
|
|
|
|
* appends a new element instead of returning the existing opts.
|
|
|
|
* However, we got no use for this case. Guard against possible
|
|
|
|
* (if unlikely) future misuse:
|
|
|
|
*/
|
|
|
|
assert(!defaults || list->merge_lists);
|
qemu-option: Fix qemu_opts_set_defaults() for corner cases
Commit 4f6dd9a changed the initialization of opts in opts_parse() to
this:
if (defaults) {
if (!id && !QTAILQ_EMPTY(&list->head)) {
opts = qemu_opts_find(list, NULL);
} else {
opts = qemu_opts_create(list, id, 0);
}
} else {
opts = qemu_opts_create(list, id, 1);
}
Same as before for !defaults.
If defaults is true, and params has no ID, and options exist, we use
the first assignment. It sets opts to null if all options have an ID.
opts_parse() then returns null. qemu_opts_set_defaults() asserts the
value is non-null. It's the only caller that passes true for
defaults.
To reproduce, try "-M xenpv -machine id=foo" (yes, "id=foo" is silly,
but it shouldn't crash).
I believe the function attempts to do the following:
If options don't yet exist, create new options
Else, if defaults, modify the existing options
Else, if list->merge_lists, modify the existing options
Else, fail
A straightforward call of qemu_opts_create() does exactly that.
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1372943363-24081-3-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
2013-07-04 21:09:18 +08:00
|
|
|
opts = qemu_opts_create(list, id, !defaults, &local_err);
|
2012-03-21 02:51:57 +08:00
|
|
|
if (opts == NULL) {
|
2015-02-13 01:24:10 +08:00
|
|
|
error_propagate(errp, local_err);
|
2009-09-10 16:58:33 +08:00
|
|
|
return NULL;
|
2012-03-21 02:51:57 +08:00
|
|
|
}
|
2009-09-10 16:58:33 +08:00
|
|
|
|
2015-02-13 00:59:06 +08:00
|
|
|
opts_do_parse(opts, params, firstname, defaults, &local_err);
|
|
|
|
if (local_err) {
|
2015-02-13 01:24:10 +08:00
|
|
|
error_propagate(errp, local_err);
|
2009-09-10 16:58:33 +08:00
|
|
|
qemu_opts_del(opts);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2009-07-22 22:43:03 +08:00
|
|
|
return opts;
|
|
|
|
}
|
|
|
|
|
2015-02-13 01:24:10 +08:00
|
|
|
/**
|
|
|
|
* Create a QemuOpts in @list and with options parsed from @params.
|
|
|
|
* If @permit_abbrev, the first key=value in @params may omit key=,
|
|
|
|
* and is treated as if key was @list->implied_opt_name.
|
|
|
|
* Report errors with qerror_report_err().
|
|
|
|
* Return the new QemuOpts on success, null pointer on error.
|
|
|
|
*/
|
2012-01-28 02:54:54 +08:00
|
|
|
QemuOpts *qemu_opts_parse(QemuOptsList *list, const char *params,
|
|
|
|
int permit_abbrev)
|
|
|
|
{
|
2015-02-13 01:24:10 +08:00
|
|
|
Error *err = NULL;
|
|
|
|
QemuOpts *opts;
|
|
|
|
|
|
|
|
opts = opts_parse(list, params, permit_abbrev, false, &err);
|
|
|
|
if (!opts) {
|
|
|
|
qerror_report_err(err);
|
|
|
|
error_free(err);
|
|
|
|
}
|
|
|
|
return opts;
|
2012-01-28 02:54:54 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void qemu_opts_set_defaults(QemuOptsList *list, const char *params,
|
|
|
|
int permit_abbrev)
|
|
|
|
{
|
|
|
|
QemuOpts *opts;
|
|
|
|
|
2015-02-13 01:24:10 +08:00
|
|
|
opts = opts_parse(list, params, permit_abbrev, true, NULL);
|
2012-01-28 02:54:54 +08:00
|
|
|
assert(opts);
|
|
|
|
}
|
|
|
|
|
2012-04-19 04:24:01 +08:00
|
|
|
typedef struct OptsFromQDictState {
|
|
|
|
QemuOpts *opts;
|
|
|
|
Error **errp;
|
|
|
|
} OptsFromQDictState;
|
|
|
|
|
2010-02-11 03:15:29 +08:00
|
|
|
static void qemu_opts_from_qdict_1(const char *key, QObject *obj, void *opaque)
|
|
|
|
{
|
2012-04-19 04:24:01 +08:00
|
|
|
OptsFromQDictState *state = opaque;
|
2010-02-11 03:15:29 +08:00
|
|
|
char buf[32];
|
|
|
|
const char *value;
|
|
|
|
int n;
|
|
|
|
|
2014-05-02 19:26:40 +08:00
|
|
|
if (!strcmp(key, "id") || *state->errp) {
|
2010-02-11 03:15:29 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (qobject_type(obj)) {
|
|
|
|
case QTYPE_QSTRING:
|
|
|
|
value = qstring_get_str(qobject_to_qstring(obj));
|
|
|
|
break;
|
|
|
|
case QTYPE_QINT:
|
|
|
|
n = snprintf(buf, sizeof(buf), "%" PRId64,
|
|
|
|
qint_get_int(qobject_to_qint(obj)));
|
|
|
|
assert(n < sizeof(buf));
|
|
|
|
value = buf;
|
|
|
|
break;
|
|
|
|
case QTYPE_QFLOAT:
|
|
|
|
n = snprintf(buf, sizeof(buf), "%.17g",
|
|
|
|
qfloat_get_double(qobject_to_qfloat(obj)));
|
|
|
|
assert(n < sizeof(buf));
|
|
|
|
value = buf;
|
|
|
|
break;
|
|
|
|
case QTYPE_QBOOL:
|
2010-03-19 04:48:19 +08:00
|
|
|
pstrcpy(buf, sizeof(buf),
|
|
|
|
qbool_get_int(qobject_to_qbool(obj)) ? "on" : "off");
|
2010-02-11 03:15:29 +08:00
|
|
|
value = buf;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return;
|
|
|
|
}
|
2012-04-19 04:24:01 +08:00
|
|
|
|
2015-02-13 00:52:20 +08:00
|
|
|
qemu_opt_set(state->opts, key, value, state->errp);
|
2010-02-11 03:15:29 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Create QemuOpts from a QDict.
|
|
|
|
* Use value of key "id" as ID if it exists and is a QString.
|
|
|
|
* Only QStrings, QInts, QFloats and QBools are copied. Entries with
|
|
|
|
* other types are silently ignored.
|
|
|
|
*/
|
2012-04-19 04:24:01 +08:00
|
|
|
QemuOpts *qemu_opts_from_qdict(QemuOptsList *list, const QDict *qdict,
|
|
|
|
Error **errp)
|
2010-02-11 03:15:29 +08:00
|
|
|
{
|
2012-04-19 04:24:01 +08:00
|
|
|
OptsFromQDictState state;
|
2012-03-21 02:51:57 +08:00
|
|
|
Error *local_err = NULL;
|
2012-04-19 04:24:01 +08:00
|
|
|
QemuOpts *opts;
|
2010-02-11 03:15:29 +08:00
|
|
|
|
2012-03-21 02:51:57 +08:00
|
|
|
opts = qemu_opts_create(list, qdict_get_try_str(qdict, "id"), 1,
|
|
|
|
&local_err);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2012-04-19 04:24:01 +08:00
|
|
|
error_propagate(errp, local_err);
|
2010-02-11 03:15:29 +08:00
|
|
|
return NULL;
|
2012-03-21 02:51:57 +08:00
|
|
|
}
|
2010-02-11 03:15:29 +08:00
|
|
|
|
2012-03-21 02:51:57 +08:00
|
|
|
assert(opts != NULL);
|
2012-04-19 04:24:01 +08:00
|
|
|
|
|
|
|
state.errp = &local_err;
|
|
|
|
state.opts = opts;
|
|
|
|
qdict_iter(qdict, qemu_opts_from_qdict_1, &state);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2012-04-19 04:24:01 +08:00
|
|
|
error_propagate(errp, local_err);
|
|
|
|
qemu_opts_del(opts);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2010-02-11 03:15:29 +08:00
|
|
|
return opts;
|
|
|
|
}
|
|
|
|
|
2013-03-15 17:35:05 +08:00
|
|
|
/*
|
|
|
|
* Adds all QDict entries to the QemuOpts that can be added and removes them
|
|
|
|
* from the QDict. When this function returns, the QDict contains only those
|
|
|
|
* entries that couldn't be added to the QemuOpts.
|
|
|
|
*/
|
|
|
|
void qemu_opts_absorb_qdict(QemuOpts *opts, QDict *qdict, Error **errp)
|
|
|
|
{
|
|
|
|
const QDictEntry *entry, *next;
|
|
|
|
|
|
|
|
entry = qdict_first(qdict);
|
|
|
|
|
|
|
|
while (entry != NULL) {
|
|
|
|
Error *local_err = NULL;
|
|
|
|
OptsFromQDictState state = {
|
|
|
|
.errp = &local_err,
|
|
|
|
.opts = opts,
|
|
|
|
};
|
|
|
|
|
|
|
|
next = qdict_next(qdict, entry);
|
|
|
|
|
|
|
|
if (find_desc_by_name(opts->list->desc, entry->key)) {
|
|
|
|
qemu_opts_from_qdict_1(entry->key, entry->value, &state);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2013-03-15 17:35:05 +08:00
|
|
|
error_propagate(errp, local_err);
|
|
|
|
return;
|
|
|
|
} else {
|
|
|
|
qdict_del(qdict, entry->key);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
entry = next;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-02-11 03:15:29 +08:00
|
|
|
/*
|
|
|
|
* Convert from QemuOpts to QDict.
|
|
|
|
* The QDict values are of type QString.
|
|
|
|
* TODO We'll want to use types appropriate for opt->desc->type, but
|
|
|
|
* this is enough for now.
|
|
|
|
*/
|
|
|
|
QDict *qemu_opts_to_qdict(QemuOpts *opts, QDict *qdict)
|
|
|
|
{
|
|
|
|
QemuOpt *opt;
|
|
|
|
QObject *val;
|
|
|
|
|
|
|
|
if (!qdict) {
|
|
|
|
qdict = qdict_new();
|
|
|
|
}
|
|
|
|
if (opts->id) {
|
|
|
|
qdict_put(qdict, "id", qstring_from_str(opts->id));
|
|
|
|
}
|
|
|
|
QTAILQ_FOREACH(opt, &opts->head, next) {
|
|
|
|
val = QOBJECT(qstring_from_str(opt->str));
|
|
|
|
qdict_put_obj(qdict, opt->name, val);
|
|
|
|
}
|
|
|
|
return qdict;
|
|
|
|
}
|
|
|
|
|
2009-10-06 19:17:03 +08:00
|
|
|
/* Validate parsed opts against descriptions where no
|
|
|
|
* descriptions were provided in the QemuOptsList.
|
|
|
|
*/
|
2012-04-12 22:58:57 +08:00
|
|
|
void qemu_opts_validate(QemuOpts *opts, const QemuOptDesc *desc, Error **errp)
|
2009-10-06 19:17:03 +08:00
|
|
|
{
|
|
|
|
QemuOpt *opt;
|
2012-03-22 02:21:26 +08:00
|
|
|
Error *local_err = NULL;
|
2009-10-06 19:17:03 +08:00
|
|
|
|
2012-12-06 14:47:19 +08:00
|
|
|
assert(opts_accepts_any(opts));
|
2009-10-06 19:17:03 +08:00
|
|
|
|
|
|
|
QTAILQ_FOREACH(opt, &opts->head, next) {
|
2012-12-06 14:47:19 +08:00
|
|
|
opt->desc = find_desc_by_name(desc, opt->name);
|
|
|
|
if (!opt->desc) {
|
2012-04-12 22:58:57 +08:00
|
|
|
error_set(errp, QERR_INVALID_PARAMETER, opt->name);
|
|
|
|
return;
|
2009-10-06 19:17:03 +08:00
|
|
|
}
|
|
|
|
|
2012-03-22 02:21:26 +08:00
|
|
|
qemu_opt_parse(opt, &local_err);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2012-04-12 22:58:57 +08:00
|
|
|
error_propagate(errp, local_err);
|
|
|
|
return;
|
2009-10-06 19:17:03 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-07-22 22:43:03 +08:00
|
|
|
int qemu_opts_foreach(QemuOptsList *list, qemu_opts_loopfunc func, void *opaque,
|
|
|
|
int abort_on_failure)
|
|
|
|
{
|
2010-02-19 02:46:49 +08:00
|
|
|
Location loc;
|
2009-07-22 22:43:03 +08:00
|
|
|
QemuOpts *opts;
|
|
|
|
int rc = 0;
|
|
|
|
|
2010-02-19 02:46:49 +08:00
|
|
|
loc_push_none(&loc);
|
2009-09-12 15:36:22 +08:00
|
|
|
QTAILQ_FOREACH(opts, &list->head, next) {
|
2010-02-19 02:46:49 +08:00
|
|
|
loc_restore(&opts->loc);
|
2010-01-30 02:48:56 +08:00
|
|
|
rc |= func(opts, opaque);
|
2009-07-22 22:43:03 +08:00
|
|
|
if (abort_on_failure && rc != 0)
|
|
|
|
break;
|
|
|
|
}
|
2010-02-19 02:46:49 +08:00
|
|
|
loc_pop(&loc);
|
2009-07-22 22:43:03 +08:00
|
|
|
return rc;
|
|
|
|
}
|
2014-06-05 17:20:48 +08:00
|
|
|
|
|
|
|
static size_t count_opts_list(QemuOptsList *list)
|
|
|
|
{
|
|
|
|
QemuOptDesc *desc = NULL;
|
|
|
|
size_t num_opts = 0;
|
|
|
|
|
|
|
|
if (!list) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
desc = list->desc;
|
|
|
|
while (desc && desc->name) {
|
|
|
|
num_opts++;
|
|
|
|
desc++;
|
|
|
|
}
|
|
|
|
|
|
|
|
return num_opts;
|
|
|
|
}
|
|
|
|
|
|
|
|
void qemu_opts_free(QemuOptsList *list)
|
|
|
|
{
|
|
|
|
g_free(list);
|
|
|
|
}
|
2014-06-05 17:20:49 +08:00
|
|
|
|
2014-06-05 17:21:11 +08:00
|
|
|
/* Realloc dst option list and append options from an option list (list)
|
|
|
|
* to it. dst could be NULL or a malloced list.
|
2014-06-05 17:21:12 +08:00
|
|
|
* The lifetime of dst must be shorter than the input list because the
|
|
|
|
* QemuOptDesc->name, ->help, and ->def_value_str strings are shared.
|
2014-06-05 17:20:49 +08:00
|
|
|
*/
|
|
|
|
QemuOptsList *qemu_opts_append(QemuOptsList *dst,
|
2014-06-05 17:21:11 +08:00
|
|
|
QemuOptsList *list)
|
2014-06-05 17:20:49 +08:00
|
|
|
{
|
|
|
|
size_t num_opts, num_dst_opts;
|
|
|
|
QemuOptDesc *desc;
|
|
|
|
bool need_init = false;
|
2014-06-25 16:38:41 +08:00
|
|
|
bool need_head_update;
|
2014-06-05 17:20:49 +08:00
|
|
|
|
2014-06-05 17:21:11 +08:00
|
|
|
if (!list) {
|
2014-06-05 17:20:49 +08:00
|
|
|
return dst;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* If dst is NULL, after realloc, some area of dst should be initialized
|
|
|
|
* before adding options to it.
|
|
|
|
*/
|
|
|
|
if (!dst) {
|
|
|
|
need_init = true;
|
2014-06-25 16:38:41 +08:00
|
|
|
need_head_update = true;
|
|
|
|
} else {
|
|
|
|
/* Moreover, even if dst is not NULL, the realloc may move it to a
|
|
|
|
* different address in which case we may get a stale tail pointer
|
|
|
|
* in dst->head. */
|
|
|
|
need_head_update = QTAILQ_EMPTY(&dst->head);
|
2014-06-05 17:20:49 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
num_opts = count_opts_list(dst);
|
|
|
|
num_dst_opts = num_opts;
|
|
|
|
num_opts += count_opts_list(list);
|
|
|
|
dst = g_realloc(dst, sizeof(QemuOptsList) +
|
|
|
|
(num_opts + 1) * sizeof(QemuOptDesc));
|
|
|
|
if (need_init) {
|
|
|
|
dst->name = NULL;
|
|
|
|
dst->implied_opt_name = NULL;
|
|
|
|
dst->merge_lists = false;
|
|
|
|
}
|
2014-06-25 16:38:41 +08:00
|
|
|
if (need_head_update) {
|
|
|
|
QTAILQ_INIT(&dst->head);
|
|
|
|
}
|
2014-06-05 17:20:49 +08:00
|
|
|
dst->desc[num_dst_opts].name = NULL;
|
|
|
|
|
|
|
|
/* append list->desc to dst->desc */
|
|
|
|
if (list) {
|
|
|
|
desc = list->desc;
|
|
|
|
while (desc && desc->name) {
|
|
|
|
if (find_desc_by_name(dst->desc, desc->name) == NULL) {
|
2014-06-05 17:21:12 +08:00
|
|
|
dst->desc[num_dst_opts++] = *desc;
|
2014-06-05 17:20:49 +08:00
|
|
|
dst->desc[num_dst_opts].name = NULL;
|
|
|
|
}
|
|
|
|
desc++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return dst;
|
|
|
|
}
|