2009-05-15 05:35:06 +08:00
|
|
|
/*
|
|
|
|
* Dynamic device configuration and creation.
|
|
|
|
*
|
|
|
|
* Copyright (c) 2009 CodeSourcery
|
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
* version 2 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
2009-07-17 04:47:01 +08:00
|
|
|
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
2009-05-15 05:35:06 +08:00
|
|
|
*/
|
|
|
|
|
|
|
|
/* The theory here is that it should be possible to create a machine without
|
|
|
|
knowledge of specific devices. Historically board init routines have
|
|
|
|
passed a bunch of arguments to each device, requiring the board know
|
|
|
|
exactly which device it is dealing with. This file provides an abstract
|
|
|
|
API for device configuration and initialization. Devices will generally
|
|
|
|
inherit from a particular bus (e.g. PCI or I2C) rather than
|
|
|
|
this API directly. */
|
|
|
|
|
2016-01-27 02:17:29 +08:00
|
|
|
#include "qemu/osdep.h"
|
2018-02-01 19:18:31 +08:00
|
|
|
#include "qapi/error.h"
|
2019-06-20 04:10:37 +08:00
|
|
|
#include "qapi/qapi-events-qdev.h"
|
2013-02-04 18:37:52 +08:00
|
|
|
#include "qapi/qmp/qerror.h"
|
2012-12-18 01:19:43 +08:00
|
|
|
#include "qapi/visitor.h"
|
2015-03-18 01:29:20 +08:00
|
|
|
#include "qemu/error-report.h"
|
2018-02-01 19:18:46 +08:00
|
|
|
#include "qemu/option.h"
|
2014-02-05 23:36:45 +08:00
|
|
|
#include "hw/hotplug.h"
|
2019-08-12 13:23:42 +08:00
|
|
|
#include "hw/irq.h"
|
2019-08-12 13:23:51 +08:00
|
|
|
#include "hw/qdev-properties.h"
|
2014-06-02 21:25:03 +08:00
|
|
|
#include "hw/boards.h"
|
2016-05-10 18:30:42 +08:00
|
|
|
#include "hw/sysbus.h"
|
2020-04-06 21:52:45 +08:00
|
|
|
#include "hw/qdev-clock.h"
|
2019-08-12 13:23:45 +08:00
|
|
|
#include "migration/vmstate.h"
|
2020-01-31 00:02:03 +08:00
|
|
|
#include "trace.h"
|
2009-05-15 05:35:06 +08:00
|
|
|
|
2017-03-28 17:08:52 +08:00
|
|
|
bool qdev_hotplug = false;
|
2011-01-05 03:37:50 +08:00
|
|
|
static bool qdev_hot_added = false;
|
2017-03-28 17:22:10 +08:00
|
|
|
bool qdev_hot_removed = false;
|
2009-09-26 03:42:41 +08:00
|
|
|
|
2011-12-10 00:51:49 +08:00
|
|
|
const VMStateDescription *qdev_get_vmsd(DeviceState *dev)
|
|
|
|
{
|
2011-12-10 01:06:57 +08:00
|
|
|
DeviceClass *dc = DEVICE_GET_CLASS(dev);
|
|
|
|
return dc->vmsd;
|
2011-12-10 00:51:49 +08:00
|
|
|
}
|
|
|
|
|
2011-12-24 05:34:39 +08:00
|
|
|
static void bus_remove_child(BusState *bus, DeviceState *child)
|
2010-02-20 02:12:18 +08:00
|
|
|
{
|
2011-12-24 05:34:39 +08:00
|
|
|
BusChild *kid;
|
|
|
|
|
|
|
|
QTAILQ_FOREACH(kid, &bus->children, sibling) {
|
|
|
|
if (kid->child == child) {
|
|
|
|
char name[32];
|
|
|
|
|
|
|
|
snprintf(name, sizeof(name), "child[%d]", kid->index);
|
|
|
|
QTAILQ_REMOVE(&bus->children, kid, sibling);
|
2013-01-25 21:12:32 +08:00
|
|
|
|
2018-12-17 23:57:30 +08:00
|
|
|
bus->num_children--;
|
|
|
|
|
2013-01-25 21:12:32 +08:00
|
|
|
/* This gives back ownership of kid->child back to us. */
|
2020-05-05 23:29:26 +08:00
|
|
|
object_property_del(OBJECT(bus), name);
|
2013-01-25 21:12:32 +08:00
|
|
|
object_unref(OBJECT(kid->child));
|
2011-12-24 05:34:39 +08:00
|
|
|
g_free(kid);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void bus_add_child(BusState *bus, DeviceState *child)
|
|
|
|
{
|
|
|
|
char name[32];
|
|
|
|
BusChild *kid = g_malloc0(sizeof(*kid));
|
2010-02-20 02:12:18 +08:00
|
|
|
|
2018-12-17 23:57:30 +08:00
|
|
|
bus->num_children++;
|
2011-12-24 05:34:39 +08:00
|
|
|
kid->index = bus->max_index++;
|
|
|
|
kid->child = child;
|
2013-01-25 21:12:32 +08:00
|
|
|
object_ref(OBJECT(kid->child));
|
2011-12-13 04:29:27 +08:00
|
|
|
|
2011-12-24 05:34:39 +08:00
|
|
|
QTAILQ_INSERT_HEAD(&bus->children, kid, sibling);
|
|
|
|
|
2013-01-25 21:12:32 +08:00
|
|
|
/* This transfers ownership of kid->child to the property. */
|
2011-12-24 05:34:39 +08:00
|
|
|
snprintf(name, sizeof(name), "child[%d]", kid->index);
|
|
|
|
object_property_add_link(OBJECT(bus), name,
|
|
|
|
object_get_typename(OBJECT(child)),
|
2014-03-19 15:58:56 +08:00
|
|
|
(Object **)&kid->child,
|
|
|
|
NULL, /* read-only property */
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
0);
|
2011-12-24 05:34:39 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void qdev_set_parent_bus(DeviceState *dev, BusState *bus)
|
|
|
|
{
|
hw/core/qdev: handle parent bus change regarding resettable
In qdev_set_parent_bus(), when changing the parent bus of a
realized device, if the source and destination buses are not in the
same reset state, some adaptations are required. This patch adds
needed call to resettable_change_parent() to make sure a device reset
state stays coherent with its parent bus.
The addition is a no-op if:
1. the device being parented is not realized.
2. the device is realized, but both buses are not under reset.
Case 2 means that as long as qdev_set_parent_bus() is called
during the machine realization procedure (which is before the
machine reset so nothing is in reset), it is a no op.
There are 52 call sites of qdev_set_parent_bus(). All but one fall
into the no-op case:
+ 29 trivial calls related to virtio (in hw/{s390x,display,virtio}/
{vhost,virtio}-xxx.c) to set a vdev(or vgpu) composing device
parent bus just before realizing the same vdev(vgpu).
+ hw/core/qdev.c: when creating a device in qdev_try_create()
+ hw/core/sysbus.c: when initializing a device in the sysbus
+ hw/i386/amd_iommu.c: before realizing AMDVIState/pci
+ hw/isa/piix4.c: before realizing PIIX4State/rtc
+ hw/misc/auxbus.c: when creating an AUXBus
+ hw/misc/auxbus.c: when creating an AUXBus child
+ hw/misc/macio/macio.c: when initializing a MACIOState child
+ hw/misc/macio/macio.c: before realizing NewWorldMacIOState/pmu
+ hw/misc/macio/macio.c: before realizing NewWorldMacIOState/cuda
+ hw/net/virtio-net.c: Used for migration when using the failover
mechanism to migration a vfio-pci/net. It is
a no-op because at this point the device is
already on the bus.
+ hw/pci-host/designware.c: before realizing DesignwarePCIEHost/root
+ hw/pci-host/gpex.c: before realizing GPEXHost/root
+ hw/pci-host/prep.c: when initialiazing PREPPCIState/pci_dev
+ hw/pci-host/q35.c: before realizing Q35PCIHost/mch
+ hw/pci-host/versatile.c: when initializing PCIVPBState/pci_dev
+ hw/pci-host/xilinx-pcie.c: before realizing XilinxPCIEHost/root
+ hw/s390x/event-facility.c: when creating SCLPEventFacility/
TYPE_SCLP_QUIESCE
+ hw/s390x/event-facility.c: ditto with SCLPEventFacility/
TYPE_SCLP_CPU_HOTPLUG
+ hw/s390x/sclp.c: Not trivial because it is called on a SLCPDevice
just after realizing it. Ok because at this point the destination
bus (sysbus) is not in reset; the realize step is before the
machine reset.
+ hw/sd/core.c: Not OK. Used in sdbus_reparent_card(). See below.
+ hw/ssi/ssi.c: Used to put spi slave on spi bus and connect the cs
line in ssi_auto_connect_slave(). Ok because this function is only
used in realize step in hw/ssi/aspeed_smc.ci, hw/ssi/imx_spi.c,
hw/ssi/mss-spi.c, hw/ssi/xilinx_spi.c and hw/ssi/xilinx_spips.c.
+ hw/xen/xen-legacy-backend.c: when creating a XenLegacyDevice device
+ qdev-monitor.c: in device hotplug creation procedure before realize
Note that this commit alone will have no effect, right now there is no
use of resettable API to reset anything. So a bus will never be tagged
as in-reset by this same API.
The one place where side-effect will occurs is in hw/sd/core.c in
sdbus_reparent_card(). This function is only used in the raspi machines,
including during the sysbus reset procedure. This case will be
carrefully handled when doing the multiple phase reset transition.
Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200123132823.1117486-7-damien.hedde@greensocs.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
2020-01-31 00:02:04 +08:00
|
|
|
BusState *old_parent_bus = dev->parent_bus;
|
2020-06-09 20:23:37 +08:00
|
|
|
DeviceClass *dc = DEVICE_GET_CLASS(dev);
|
|
|
|
|
|
|
|
assert(dc->bus_type && object_dynamic_cast(OBJECT(bus), dc->bus_type));
|
2017-02-28 22:55:08 +08:00
|
|
|
|
hw/core/qdev: handle parent bus change regarding resettable
In qdev_set_parent_bus(), when changing the parent bus of a
realized device, if the source and destination buses are not in the
same reset state, some adaptations are required. This patch adds
needed call to resettable_change_parent() to make sure a device reset
state stays coherent with its parent bus.
The addition is a no-op if:
1. the device being parented is not realized.
2. the device is realized, but both buses are not under reset.
Case 2 means that as long as qdev_set_parent_bus() is called
during the machine realization procedure (which is before the
machine reset so nothing is in reset), it is a no op.
There are 52 call sites of qdev_set_parent_bus(). All but one fall
into the no-op case:
+ 29 trivial calls related to virtio (in hw/{s390x,display,virtio}/
{vhost,virtio}-xxx.c) to set a vdev(or vgpu) composing device
parent bus just before realizing the same vdev(vgpu).
+ hw/core/qdev.c: when creating a device in qdev_try_create()
+ hw/core/sysbus.c: when initializing a device in the sysbus
+ hw/i386/amd_iommu.c: before realizing AMDVIState/pci
+ hw/isa/piix4.c: before realizing PIIX4State/rtc
+ hw/misc/auxbus.c: when creating an AUXBus
+ hw/misc/auxbus.c: when creating an AUXBus child
+ hw/misc/macio/macio.c: when initializing a MACIOState child
+ hw/misc/macio/macio.c: before realizing NewWorldMacIOState/pmu
+ hw/misc/macio/macio.c: before realizing NewWorldMacIOState/cuda
+ hw/net/virtio-net.c: Used for migration when using the failover
mechanism to migration a vfio-pci/net. It is
a no-op because at this point the device is
already on the bus.
+ hw/pci-host/designware.c: before realizing DesignwarePCIEHost/root
+ hw/pci-host/gpex.c: before realizing GPEXHost/root
+ hw/pci-host/prep.c: when initialiazing PREPPCIState/pci_dev
+ hw/pci-host/q35.c: before realizing Q35PCIHost/mch
+ hw/pci-host/versatile.c: when initializing PCIVPBState/pci_dev
+ hw/pci-host/xilinx-pcie.c: before realizing XilinxPCIEHost/root
+ hw/s390x/event-facility.c: when creating SCLPEventFacility/
TYPE_SCLP_QUIESCE
+ hw/s390x/event-facility.c: ditto with SCLPEventFacility/
TYPE_SCLP_CPU_HOTPLUG
+ hw/s390x/sclp.c: Not trivial because it is called on a SLCPDevice
just after realizing it. Ok because at this point the destination
bus (sysbus) is not in reset; the realize step is before the
machine reset.
+ hw/sd/core.c: Not OK. Used in sdbus_reparent_card(). See below.
+ hw/ssi/ssi.c: Used to put spi slave on spi bus and connect the cs
line in ssi_auto_connect_slave(). Ok because this function is only
used in realize step in hw/ssi/aspeed_smc.ci, hw/ssi/imx_spi.c,
hw/ssi/mss-spi.c, hw/ssi/xilinx_spi.c and hw/ssi/xilinx_spips.c.
+ hw/xen/xen-legacy-backend.c: when creating a XenLegacyDevice device
+ qdev-monitor.c: in device hotplug creation procedure before realize
Note that this commit alone will have no effect, right now there is no
use of resettable API to reset anything. So a bus will never be tagged
as in-reset by this same API.
The one place where side-effect will occurs is in hw/sd/core.c in
sdbus_reparent_card(). This function is only used in the raspi machines,
including during the sysbus reset procedure. This case will be
carrefully handled when doing the multiple phase reset transition.
Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200123132823.1117486-7-damien.hedde@greensocs.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
2020-01-31 00:02:04 +08:00
|
|
|
if (old_parent_bus) {
|
2020-01-31 00:02:03 +08:00
|
|
|
trace_qdev_update_parent_bus(dev, object_get_typename(OBJECT(dev)),
|
hw/core/qdev: handle parent bus change regarding resettable
In qdev_set_parent_bus(), when changing the parent bus of a
realized device, if the source and destination buses are not in the
same reset state, some adaptations are required. This patch adds
needed call to resettable_change_parent() to make sure a device reset
state stays coherent with its parent bus.
The addition is a no-op if:
1. the device being parented is not realized.
2. the device is realized, but both buses are not under reset.
Case 2 means that as long as qdev_set_parent_bus() is called
during the machine realization procedure (which is before the
machine reset so nothing is in reset), it is a no op.
There are 52 call sites of qdev_set_parent_bus(). All but one fall
into the no-op case:
+ 29 trivial calls related to virtio (in hw/{s390x,display,virtio}/
{vhost,virtio}-xxx.c) to set a vdev(or vgpu) composing device
parent bus just before realizing the same vdev(vgpu).
+ hw/core/qdev.c: when creating a device in qdev_try_create()
+ hw/core/sysbus.c: when initializing a device in the sysbus
+ hw/i386/amd_iommu.c: before realizing AMDVIState/pci
+ hw/isa/piix4.c: before realizing PIIX4State/rtc
+ hw/misc/auxbus.c: when creating an AUXBus
+ hw/misc/auxbus.c: when creating an AUXBus child
+ hw/misc/macio/macio.c: when initializing a MACIOState child
+ hw/misc/macio/macio.c: before realizing NewWorldMacIOState/pmu
+ hw/misc/macio/macio.c: before realizing NewWorldMacIOState/cuda
+ hw/net/virtio-net.c: Used for migration when using the failover
mechanism to migration a vfio-pci/net. It is
a no-op because at this point the device is
already on the bus.
+ hw/pci-host/designware.c: before realizing DesignwarePCIEHost/root
+ hw/pci-host/gpex.c: before realizing GPEXHost/root
+ hw/pci-host/prep.c: when initialiazing PREPPCIState/pci_dev
+ hw/pci-host/q35.c: before realizing Q35PCIHost/mch
+ hw/pci-host/versatile.c: when initializing PCIVPBState/pci_dev
+ hw/pci-host/xilinx-pcie.c: before realizing XilinxPCIEHost/root
+ hw/s390x/event-facility.c: when creating SCLPEventFacility/
TYPE_SCLP_QUIESCE
+ hw/s390x/event-facility.c: ditto with SCLPEventFacility/
TYPE_SCLP_CPU_HOTPLUG
+ hw/s390x/sclp.c: Not trivial because it is called on a SLCPDevice
just after realizing it. Ok because at this point the destination
bus (sysbus) is not in reset; the realize step is before the
machine reset.
+ hw/sd/core.c: Not OK. Used in sdbus_reparent_card(). See below.
+ hw/ssi/ssi.c: Used to put spi slave on spi bus and connect the cs
line in ssi_auto_connect_slave(). Ok because this function is only
used in realize step in hw/ssi/aspeed_smc.ci, hw/ssi/imx_spi.c,
hw/ssi/mss-spi.c, hw/ssi/xilinx_spi.c and hw/ssi/xilinx_spips.c.
+ hw/xen/xen-legacy-backend.c: when creating a XenLegacyDevice device
+ qdev-monitor.c: in device hotplug creation procedure before realize
Note that this commit alone will have no effect, right now there is no
use of resettable API to reset anything. So a bus will never be tagged
as in-reset by this same API.
The one place where side-effect will occurs is in hw/sd/core.c in
sdbus_reparent_card(). This function is only used in the raspi machines,
including during the sysbus reset procedure. This case will be
carrefully handled when doing the multiple phase reset transition.
Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200123132823.1117486-7-damien.hedde@greensocs.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
2020-01-31 00:02:04 +08:00
|
|
|
old_parent_bus, object_get_typename(OBJECT(old_parent_bus)),
|
2020-01-31 00:02:03 +08:00
|
|
|
OBJECT(bus), object_get_typename(OBJECT(bus)));
|
|
|
|
/*
|
|
|
|
* Keep a reference to the device while it's not plugged into
|
2017-02-28 22:55:08 +08:00
|
|
|
* any bus, to avoid it potentially evaporating when it is
|
|
|
|
* dereffed in bus_remove_child().
|
hw/core/qdev: handle parent bus change regarding resettable
In qdev_set_parent_bus(), when changing the parent bus of a
realized device, if the source and destination buses are not in the
same reset state, some adaptations are required. This patch adds
needed call to resettable_change_parent() to make sure a device reset
state stays coherent with its parent bus.
The addition is a no-op if:
1. the device being parented is not realized.
2. the device is realized, but both buses are not under reset.
Case 2 means that as long as qdev_set_parent_bus() is called
during the machine realization procedure (which is before the
machine reset so nothing is in reset), it is a no op.
There are 52 call sites of qdev_set_parent_bus(). All but one fall
into the no-op case:
+ 29 trivial calls related to virtio (in hw/{s390x,display,virtio}/
{vhost,virtio}-xxx.c) to set a vdev(or vgpu) composing device
parent bus just before realizing the same vdev(vgpu).
+ hw/core/qdev.c: when creating a device in qdev_try_create()
+ hw/core/sysbus.c: when initializing a device in the sysbus
+ hw/i386/amd_iommu.c: before realizing AMDVIState/pci
+ hw/isa/piix4.c: before realizing PIIX4State/rtc
+ hw/misc/auxbus.c: when creating an AUXBus
+ hw/misc/auxbus.c: when creating an AUXBus child
+ hw/misc/macio/macio.c: when initializing a MACIOState child
+ hw/misc/macio/macio.c: before realizing NewWorldMacIOState/pmu
+ hw/misc/macio/macio.c: before realizing NewWorldMacIOState/cuda
+ hw/net/virtio-net.c: Used for migration when using the failover
mechanism to migration a vfio-pci/net. It is
a no-op because at this point the device is
already on the bus.
+ hw/pci-host/designware.c: before realizing DesignwarePCIEHost/root
+ hw/pci-host/gpex.c: before realizing GPEXHost/root
+ hw/pci-host/prep.c: when initialiazing PREPPCIState/pci_dev
+ hw/pci-host/q35.c: before realizing Q35PCIHost/mch
+ hw/pci-host/versatile.c: when initializing PCIVPBState/pci_dev
+ hw/pci-host/xilinx-pcie.c: before realizing XilinxPCIEHost/root
+ hw/s390x/event-facility.c: when creating SCLPEventFacility/
TYPE_SCLP_QUIESCE
+ hw/s390x/event-facility.c: ditto with SCLPEventFacility/
TYPE_SCLP_CPU_HOTPLUG
+ hw/s390x/sclp.c: Not trivial because it is called on a SLCPDevice
just after realizing it. Ok because at this point the destination
bus (sysbus) is not in reset; the realize step is before the
machine reset.
+ hw/sd/core.c: Not OK. Used in sdbus_reparent_card(). See below.
+ hw/ssi/ssi.c: Used to put spi slave on spi bus and connect the cs
line in ssi_auto_connect_slave(). Ok because this function is only
used in realize step in hw/ssi/aspeed_smc.ci, hw/ssi/imx_spi.c,
hw/ssi/mss-spi.c, hw/ssi/xilinx_spi.c and hw/ssi/xilinx_spips.c.
+ hw/xen/xen-legacy-backend.c: when creating a XenLegacyDevice device
+ qdev-monitor.c: in device hotplug creation procedure before realize
Note that this commit alone will have no effect, right now there is no
use of resettable API to reset anything. So a bus will never be tagged
as in-reset by this same API.
The one place where side-effect will occurs is in hw/sd/core.c in
sdbus_reparent_card(). This function is only used in the raspi machines,
including during the sysbus reset procedure. This case will be
carrefully handled when doing the multiple phase reset transition.
Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200123132823.1117486-7-damien.hedde@greensocs.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
2020-01-31 00:02:04 +08:00
|
|
|
* Also keep the ref of the parent bus until the end, so that
|
|
|
|
* we can safely call resettable_change_parent() below.
|
2017-02-28 22:55:08 +08:00
|
|
|
*/
|
|
|
|
object_ref(OBJECT(dev));
|
|
|
|
bus_remove_child(dev->parent_bus, dev);
|
|
|
|
}
|
2011-12-23 05:14:27 +08:00
|
|
|
dev->parent_bus = bus;
|
2013-01-25 21:12:35 +08:00
|
|
|
object_ref(OBJECT(bus));
|
2011-12-24 05:34:39 +08:00
|
|
|
bus_add_child(bus, dev);
|
hw/core/qdev: handle parent bus change regarding resettable
In qdev_set_parent_bus(), when changing the parent bus of a
realized device, if the source and destination buses are not in the
same reset state, some adaptations are required. This patch adds
needed call to resettable_change_parent() to make sure a device reset
state stays coherent with its parent bus.
The addition is a no-op if:
1. the device being parented is not realized.
2. the device is realized, but both buses are not under reset.
Case 2 means that as long as qdev_set_parent_bus() is called
during the machine realization procedure (which is before the
machine reset so nothing is in reset), it is a no op.
There are 52 call sites of qdev_set_parent_bus(). All but one fall
into the no-op case:
+ 29 trivial calls related to virtio (in hw/{s390x,display,virtio}/
{vhost,virtio}-xxx.c) to set a vdev(or vgpu) composing device
parent bus just before realizing the same vdev(vgpu).
+ hw/core/qdev.c: when creating a device in qdev_try_create()
+ hw/core/sysbus.c: when initializing a device in the sysbus
+ hw/i386/amd_iommu.c: before realizing AMDVIState/pci
+ hw/isa/piix4.c: before realizing PIIX4State/rtc
+ hw/misc/auxbus.c: when creating an AUXBus
+ hw/misc/auxbus.c: when creating an AUXBus child
+ hw/misc/macio/macio.c: when initializing a MACIOState child
+ hw/misc/macio/macio.c: before realizing NewWorldMacIOState/pmu
+ hw/misc/macio/macio.c: before realizing NewWorldMacIOState/cuda
+ hw/net/virtio-net.c: Used for migration when using the failover
mechanism to migration a vfio-pci/net. It is
a no-op because at this point the device is
already on the bus.
+ hw/pci-host/designware.c: before realizing DesignwarePCIEHost/root
+ hw/pci-host/gpex.c: before realizing GPEXHost/root
+ hw/pci-host/prep.c: when initialiazing PREPPCIState/pci_dev
+ hw/pci-host/q35.c: before realizing Q35PCIHost/mch
+ hw/pci-host/versatile.c: when initializing PCIVPBState/pci_dev
+ hw/pci-host/xilinx-pcie.c: before realizing XilinxPCIEHost/root
+ hw/s390x/event-facility.c: when creating SCLPEventFacility/
TYPE_SCLP_QUIESCE
+ hw/s390x/event-facility.c: ditto with SCLPEventFacility/
TYPE_SCLP_CPU_HOTPLUG
+ hw/s390x/sclp.c: Not trivial because it is called on a SLCPDevice
just after realizing it. Ok because at this point the destination
bus (sysbus) is not in reset; the realize step is before the
machine reset.
+ hw/sd/core.c: Not OK. Used in sdbus_reparent_card(). See below.
+ hw/ssi/ssi.c: Used to put spi slave on spi bus and connect the cs
line in ssi_auto_connect_slave(). Ok because this function is only
used in realize step in hw/ssi/aspeed_smc.ci, hw/ssi/imx_spi.c,
hw/ssi/mss-spi.c, hw/ssi/xilinx_spi.c and hw/ssi/xilinx_spips.c.
+ hw/xen/xen-legacy-backend.c: when creating a XenLegacyDevice device
+ qdev-monitor.c: in device hotplug creation procedure before realize
Note that this commit alone will have no effect, right now there is no
use of resettable API to reset anything. So a bus will never be tagged
as in-reset by this same API.
The one place where side-effect will occurs is in hw/sd/core.c in
sdbus_reparent_card(). This function is only used in the raspi machines,
including during the sysbus reset procedure. This case will be
carrefully handled when doing the multiple phase reset transition.
Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200123132823.1117486-7-damien.hedde@greensocs.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
2020-01-31 00:02:04 +08:00
|
|
|
if (dev->realized) {
|
|
|
|
resettable_change_parent(OBJECT(dev), OBJECT(bus),
|
|
|
|
OBJECT(old_parent_bus));
|
|
|
|
}
|
|
|
|
if (old_parent_bus) {
|
|
|
|
object_unref(OBJECT(old_parent_bus));
|
2017-02-28 22:55:08 +08:00
|
|
|
object_unref(OBJECT(dev));
|
|
|
|
}
|
2010-02-20 02:12:18 +08:00
|
|
|
}
|
|
|
|
|
qdev: New qdev_new(), qdev_realize(), etc.
We commonly plug devices into their bus right when we create them,
like this:
dev = qdev_create(bus, type_name);
Note that @dev is a weak reference. The reference from @bus to @dev
is the only strong one.
We realize at some later time, either with
object_property_set_bool(OBJECT(dev), true, "realized", errp);
or its convenience wrapper
qdev_init_nofail(dev);
If @dev still has no QOM parent then, realizing makes the
/machine/unattached/ orphanage its QOM parent.
Note that the device returned by qdev_create() is plugged into a bus,
but doesn't have a QOM parent, yet. Until it acquires one,
unrealizing the bus will hang in bus_unparent():
while ((kid = QTAILQ_FIRST(&bus->children)) != NULL) {
DeviceState *dev = kid->child;
object_unparent(OBJECT(dev));
}
object_unparent() does nothing when its argument has no QOM parent,
and the loop spins forever.
Device state "no QOM parent, but plugged into bus" is dangerous.
Paolo suggested to delay plugging into the bus until realize. We need
to plug into the parent bus before we call the device's realize
method, in case it uses the parent bus. So the dangerous state still
exists, but only within realization, where we can manage it safely.
This commit creates infrastructure to do this:
dev = qdev_new(type_name);
...
qdev_realize_and_unref(dev, bus, errp)
Note that @dev becomes a strong reference here.
qdev_realize_and_unref() drops it. There is also plain
qdev_realize(), which doesn't drop it.
The remainder of this series will convert all users to this new
interface.
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: Alistair Francis <alistair@alistair23.me>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-5-armbru@redhat.com>
2020-06-10 13:31:53 +08:00
|
|
|
DeviceState *qdev_new(const char *name)
|
|
|
|
{
|
2020-06-24 21:10:38 +08:00
|
|
|
if (!object_class_by_name(name)) {
|
|
|
|
module_load_qom_one(name);
|
|
|
|
}
|
qdev: New qdev_new(), qdev_realize(), etc.
We commonly plug devices into their bus right when we create them,
like this:
dev = qdev_create(bus, type_name);
Note that @dev is a weak reference. The reference from @bus to @dev
is the only strong one.
We realize at some later time, either with
object_property_set_bool(OBJECT(dev), true, "realized", errp);
or its convenience wrapper
qdev_init_nofail(dev);
If @dev still has no QOM parent then, realizing makes the
/machine/unattached/ orphanage its QOM parent.
Note that the device returned by qdev_create() is plugged into a bus,
but doesn't have a QOM parent, yet. Until it acquires one,
unrealizing the bus will hang in bus_unparent():
while ((kid = QTAILQ_FIRST(&bus->children)) != NULL) {
DeviceState *dev = kid->child;
object_unparent(OBJECT(dev));
}
object_unparent() does nothing when its argument has no QOM parent,
and the loop spins forever.
Device state "no QOM parent, but plugged into bus" is dangerous.
Paolo suggested to delay plugging into the bus until realize. We need
to plug into the parent bus before we call the device's realize
method, in case it uses the parent bus. So the dangerous state still
exists, but only within realization, where we can manage it safely.
This commit creates infrastructure to do this:
dev = qdev_new(type_name);
...
qdev_realize_and_unref(dev, bus, errp)
Note that @dev becomes a strong reference here.
qdev_realize_and_unref() drops it. There is also plain
qdev_realize(), which doesn't drop it.
The remainder of this series will convert all users to this new
interface.
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: Alistair Francis <alistair@alistair23.me>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-5-armbru@redhat.com>
2020-06-10 13:31:53 +08:00
|
|
|
return DEVICE(object_new(name));
|
|
|
|
}
|
|
|
|
|
|
|
|
DeviceState *qdev_try_new(const char *name)
|
|
|
|
{
|
2020-06-24 21:10:38 +08:00
|
|
|
if (!module_object_class_by_name(name)) {
|
qdev: New qdev_new(), qdev_realize(), etc.
We commonly plug devices into their bus right when we create them,
like this:
dev = qdev_create(bus, type_name);
Note that @dev is a weak reference. The reference from @bus to @dev
is the only strong one.
We realize at some later time, either with
object_property_set_bool(OBJECT(dev), true, "realized", errp);
or its convenience wrapper
qdev_init_nofail(dev);
If @dev still has no QOM parent then, realizing makes the
/machine/unattached/ orphanage its QOM parent.
Note that the device returned by qdev_create() is plugged into a bus,
but doesn't have a QOM parent, yet. Until it acquires one,
unrealizing the bus will hang in bus_unparent():
while ((kid = QTAILQ_FIRST(&bus->children)) != NULL) {
DeviceState *dev = kid->child;
object_unparent(OBJECT(dev));
}
object_unparent() does nothing when its argument has no QOM parent,
and the loop spins forever.
Device state "no QOM parent, but plugged into bus" is dangerous.
Paolo suggested to delay plugging into the bus until realize. We need
to plug into the parent bus before we call the device's realize
method, in case it uses the parent bus. So the dangerous state still
exists, but only within realization, where we can manage it safely.
This commit creates infrastructure to do this:
dev = qdev_new(type_name);
...
qdev_realize_and_unref(dev, bus, errp)
Note that @dev becomes a strong reference here.
qdev_realize_and_unref() drops it. There is also plain
qdev_realize(), which doesn't drop it.
The remainder of this series will convert all users to this new
interface.
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: Alistair Francis <alistair@alistair23.me>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-5-armbru@redhat.com>
2020-06-10 13:31:53 +08:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
return DEVICE(object_new(name));
|
|
|
|
}
|
|
|
|
|
2018-12-06 20:10:34 +08:00
|
|
|
static QTAILQ_HEAD(, DeviceListener) device_listeners
|
2015-01-20 19:05:07 +08:00
|
|
|
= QTAILQ_HEAD_INITIALIZER(device_listeners);
|
|
|
|
|
|
|
|
enum ListenerDirection { Forward, Reverse };
|
|
|
|
|
|
|
|
#define DEVICE_LISTENER_CALL(_callback, _direction, _args...) \
|
|
|
|
do { \
|
|
|
|
DeviceListener *_listener; \
|
|
|
|
\
|
|
|
|
switch (_direction) { \
|
|
|
|
case Forward: \
|
|
|
|
QTAILQ_FOREACH(_listener, &device_listeners, link) { \
|
|
|
|
if (_listener->_callback) { \
|
|
|
|
_listener->_callback(_listener, ##_args); \
|
|
|
|
} \
|
|
|
|
} \
|
|
|
|
break; \
|
|
|
|
case Reverse: \
|
|
|
|
QTAILQ_FOREACH_REVERSE(_listener, &device_listeners, \
|
2018-12-06 20:10:34 +08:00
|
|
|
link) { \
|
2015-01-20 19:05:07 +08:00
|
|
|
if (_listener->_callback) { \
|
|
|
|
_listener->_callback(_listener, ##_args); \
|
|
|
|
} \
|
|
|
|
} \
|
|
|
|
break; \
|
|
|
|
default: \
|
|
|
|
abort(); \
|
|
|
|
} \
|
|
|
|
} while (0)
|
|
|
|
|
|
|
|
static int device_listener_add(DeviceState *dev, void *opaque)
|
|
|
|
{
|
|
|
|
DEVICE_LISTENER_CALL(realize, Forward, dev);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
void device_listener_register(DeviceListener *listener)
|
|
|
|
{
|
|
|
|
QTAILQ_INSERT_TAIL(&device_listeners, listener, link);
|
|
|
|
|
|
|
|
qbus_walk_children(sysbus_get_default(), NULL, NULL, device_listener_add,
|
|
|
|
NULL, NULL);
|
|
|
|
}
|
|
|
|
|
|
|
|
void device_listener_unregister(DeviceListener *listener)
|
|
|
|
{
|
|
|
|
QTAILQ_REMOVE(&device_listeners, listener, link);
|
|
|
|
}
|
|
|
|
|
2019-10-29 19:48:55 +08:00
|
|
|
bool qdev_should_hide_device(QemuOpts *opts)
|
|
|
|
{
|
|
|
|
int rc = -1;
|
|
|
|
DeviceListener *listener;
|
|
|
|
|
|
|
|
QTAILQ_FOREACH(listener, &device_listeners, link) {
|
|
|
|
if (listener->should_be_hidden) {
|
|
|
|
/*
|
|
|
|
* should_be_hidden_will return
|
|
|
|
* 1 if device matches opts and it should be hidden
|
|
|
|
* 0 if device matches opts and should not be hidden
|
|
|
|
* -1 if device doesn't match ops
|
|
|
|
*/
|
|
|
|
rc = listener->should_be_hidden(listener, opts);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (rc > 0) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return rc > 0;
|
|
|
|
}
|
|
|
|
|
2010-05-15 19:32:40 +08:00
|
|
|
void qdev_set_legacy_instance_id(DeviceState *dev, int alias_id,
|
|
|
|
int required_for_version)
|
|
|
|
{
|
2013-01-09 10:58:10 +08:00
|
|
|
assert(!dev->realized);
|
2010-05-15 19:32:40 +08:00
|
|
|
dev->instance_id_alias = alias_id;
|
|
|
|
dev->alias_required_for_version = required_for_version;
|
|
|
|
}
|
|
|
|
|
2017-11-02 18:10:06 +08:00
|
|
|
HotplugHandler *qdev_get_machine_hotplug_handler(DeviceState *dev)
|
|
|
|
{
|
|
|
|
MachineState *machine;
|
|
|
|
MachineClass *mc;
|
|
|
|
Object *m_obj = qdev_get_machine();
|
|
|
|
|
|
|
|
if (object_dynamic_cast(m_obj, TYPE_MACHINE)) {
|
|
|
|
machine = MACHINE(m_obj);
|
|
|
|
mc = MACHINE_GET_CLASS(machine);
|
|
|
|
if (mc->get_hotplug_handler) {
|
|
|
|
return mc->get_hotplug_handler(machine, dev);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2019-09-16 16:07:16 +08:00
|
|
|
bool qdev_hotplug_allowed(DeviceState *dev, Error **errp)
|
|
|
|
{
|
|
|
|
MachineState *machine;
|
|
|
|
MachineClass *mc;
|
|
|
|
Object *m_obj = qdev_get_machine();
|
|
|
|
|
|
|
|
if (object_dynamic_cast(m_obj, TYPE_MACHINE)) {
|
|
|
|
machine = MACHINE(m_obj);
|
|
|
|
mc = MACHINE_GET_CLASS(machine);
|
|
|
|
if (mc->hotplug_allowed) {
|
|
|
|
return mc->hotplug_allowed(machine, dev, errp);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2019-02-28 20:28:49 +08:00
|
|
|
HotplugHandler *qdev_get_bus_hotplug_handler(DeviceState *dev)
|
|
|
|
{
|
|
|
|
if (dev->parent_bus) {
|
|
|
|
return dev->parent_bus->hotplug_handler;
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2015-04-27 16:47:21 +08:00
|
|
|
HotplugHandler *qdev_get_hotplug_handler(DeviceState *dev)
|
2014-09-26 17:28:41 +08:00
|
|
|
{
|
2019-02-28 20:28:48 +08:00
|
|
|
HotplugHandler *hotplug_ctrl = qdev_get_machine_hotplug_handler(dev);
|
2014-09-26 17:28:41 +08:00
|
|
|
|
2019-02-28 20:28:48 +08:00
|
|
|
if (hotplug_ctrl == NULL && dev->parent_bus) {
|
2019-02-28 20:28:49 +08:00
|
|
|
hotplug_ctrl = qdev_get_bus_hotplug_handler(dev);
|
2014-09-26 17:28:41 +08:00
|
|
|
}
|
|
|
|
return hotplug_ctrl;
|
|
|
|
}
|
|
|
|
|
2020-01-31 00:02:03 +08:00
|
|
|
static int qdev_prereset(DeviceState *dev, void *opaque)
|
|
|
|
{
|
|
|
|
trace_qdev_reset_tree(dev, object_get_typename(OBJECT(dev)));
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int qbus_prereset(BusState *bus, void *opaque)
|
|
|
|
{
|
|
|
|
trace_qbus_reset_tree(bus, object_get_typename(OBJECT(bus)));
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-11-19 17:55:59 +08:00
|
|
|
static int qdev_reset_one(DeviceState *dev, void *opaque)
|
|
|
|
{
|
2020-01-31 00:02:03 +08:00
|
|
|
device_legacy_reset(dev);
|
2010-11-19 17:55:59 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-11-19 17:56:00 +08:00
|
|
|
static int qbus_reset_one(BusState *bus, void *opaque)
|
|
|
|
{
|
2012-05-02 15:00:20 +08:00
|
|
|
BusClass *bc = BUS_GET_CLASS(bus);
|
2020-01-31 00:02:03 +08:00
|
|
|
trace_qbus_reset(bus, object_get_typename(OBJECT(bus)));
|
2012-05-02 15:00:20 +08:00
|
|
|
if (bc->reset) {
|
2013-12-07 00:54:27 +08:00
|
|
|
bc->reset(bus);
|
2010-11-19 17:56:00 +08:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-11-19 17:56:01 +08:00
|
|
|
void qdev_reset_all(DeviceState *dev)
|
|
|
|
{
|
2020-01-31 00:02:03 +08:00
|
|
|
trace_qdev_reset_all(dev, object_get_typename(OBJECT(dev)));
|
|
|
|
qdev_walk_children(dev, qdev_prereset, qbus_prereset,
|
|
|
|
qdev_reset_one, qbus_reset_one, NULL);
|
2010-11-19 17:56:01 +08:00
|
|
|
}
|
|
|
|
|
2015-07-21 14:32:07 +08:00
|
|
|
void qdev_reset_all_fn(void *opaque)
|
|
|
|
{
|
|
|
|
qdev_reset_all(DEVICE(opaque));
|
|
|
|
}
|
|
|
|
|
2013-01-10 22:49:07 +08:00
|
|
|
void qbus_reset_all(BusState *bus)
|
|
|
|
{
|
2020-01-31 00:02:03 +08:00
|
|
|
trace_qbus_reset_all(bus, object_get_typename(OBJECT(bus)));
|
|
|
|
qbus_walk_children(bus, qdev_prereset, qbus_prereset,
|
|
|
|
qdev_reset_one, qbus_reset_one, NULL);
|
2013-01-10 22:49:07 +08:00
|
|
|
}
|
|
|
|
|
2010-12-20 13:33:35 +08:00
|
|
|
void qbus_reset_all_fn(void *opaque)
|
|
|
|
{
|
|
|
|
BusState *bus = opaque;
|
2013-01-10 22:49:07 +08:00
|
|
|
qbus_reset_all(bus);
|
2010-12-20 13:33:35 +08:00
|
|
|
}
|
|
|
|
|
2020-01-31 00:02:04 +08:00
|
|
|
void device_cold_reset(DeviceState *dev)
|
|
|
|
{
|
|
|
|
resettable_reset(OBJECT(dev), RESET_TYPE_COLD);
|
|
|
|
}
|
|
|
|
|
2020-01-31 00:02:04 +08:00
|
|
|
bool device_is_in_reset(DeviceState *dev)
|
|
|
|
{
|
|
|
|
return resettable_is_in_reset(OBJECT(dev));
|
|
|
|
}
|
|
|
|
|
|
|
|
static ResettableState *device_get_reset_state(Object *obj)
|
|
|
|
{
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
|
|
|
return &dev->reset;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void device_reset_child_foreach(Object *obj, ResettableChildCallback cb,
|
|
|
|
void *opaque, ResetType type)
|
|
|
|
{
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
|
|
|
BusState *bus;
|
|
|
|
|
|
|
|
QLIST_FOREACH(bus, &dev->child_bus, sibling) {
|
|
|
|
cb(OBJECT(bus), opaque, type);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-09-26 03:42:41 +08:00
|
|
|
/* can be used as ->unplug() callback for the simple cases */
|
2014-09-26 17:28:21 +08:00
|
|
|
void qdev_simple_device_unplug_cb(HotplugHandler *hotplug_dev,
|
|
|
|
DeviceState *dev, Error **errp)
|
|
|
|
{
|
2020-06-10 13:31:57 +08:00
|
|
|
qdev_unrealize(dev);
|
2014-09-26 17:28:21 +08:00
|
|
|
}
|
2011-04-06 21:51:59 +08:00
|
|
|
|
qdev: New qdev_new(), qdev_realize(), etc.
We commonly plug devices into their bus right when we create them,
like this:
dev = qdev_create(bus, type_name);
Note that @dev is a weak reference. The reference from @bus to @dev
is the only strong one.
We realize at some later time, either with
object_property_set_bool(OBJECT(dev), true, "realized", errp);
or its convenience wrapper
qdev_init_nofail(dev);
If @dev still has no QOM parent then, realizing makes the
/machine/unattached/ orphanage its QOM parent.
Note that the device returned by qdev_create() is plugged into a bus,
but doesn't have a QOM parent, yet. Until it acquires one,
unrealizing the bus will hang in bus_unparent():
while ((kid = QTAILQ_FIRST(&bus->children)) != NULL) {
DeviceState *dev = kid->child;
object_unparent(OBJECT(dev));
}
object_unparent() does nothing when its argument has no QOM parent,
and the loop spins forever.
Device state "no QOM parent, but plugged into bus" is dangerous.
Paolo suggested to delay plugging into the bus until realize. We need
to plug into the parent bus before we call the device's realize
method, in case it uses the parent bus. So the dangerous state still
exists, but only within realization, where we can manage it safely.
This commit creates infrastructure to do this:
dev = qdev_new(type_name);
...
qdev_realize_and_unref(dev, bus, errp)
Note that @dev becomes a strong reference here.
qdev_realize_and_unref() drops it. There is also plain
qdev_realize(), which doesn't drop it.
The remainder of this series will convert all users to this new
interface.
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: Alistair Francis <alistair@alistair23.me>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-5-armbru@redhat.com>
2020-06-10 13:31:53 +08:00
|
|
|
bool qdev_realize(DeviceState *dev, BusState *bus, Error **errp)
|
|
|
|
{
|
|
|
|
assert(!dev->realized && !dev->parent_bus);
|
|
|
|
|
2020-06-10 13:32:43 +08:00
|
|
|
if (bus) {
|
|
|
|
qdev_set_parent_bus(dev, bus);
|
|
|
|
} else {
|
|
|
|
assert(!DEVICE_GET_CLASS(dev)->bus_type);
|
|
|
|
}
|
qdev: New qdev_new(), qdev_realize(), etc.
We commonly plug devices into their bus right when we create them,
like this:
dev = qdev_create(bus, type_name);
Note that @dev is a weak reference. The reference from @bus to @dev
is the only strong one.
We realize at some later time, either with
object_property_set_bool(OBJECT(dev), true, "realized", errp);
or its convenience wrapper
qdev_init_nofail(dev);
If @dev still has no QOM parent then, realizing makes the
/machine/unattached/ orphanage its QOM parent.
Note that the device returned by qdev_create() is plugged into a bus,
but doesn't have a QOM parent, yet. Until it acquires one,
unrealizing the bus will hang in bus_unparent():
while ((kid = QTAILQ_FIRST(&bus->children)) != NULL) {
DeviceState *dev = kid->child;
object_unparent(OBJECT(dev));
}
object_unparent() does nothing when its argument has no QOM parent,
and the loop spins forever.
Device state "no QOM parent, but plugged into bus" is dangerous.
Paolo suggested to delay plugging into the bus until realize. We need
to plug into the parent bus before we call the device's realize
method, in case it uses the parent bus. So the dangerous state still
exists, but only within realization, where we can manage it safely.
This commit creates infrastructure to do this:
dev = qdev_new(type_name);
...
qdev_realize_and_unref(dev, bus, errp)
Note that @dev becomes a strong reference here.
qdev_realize_and_unref() drops it. There is also plain
qdev_realize(), which doesn't drop it.
The remainder of this series will convert all users to this new
interface.
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: Alistair Francis <alistair@alistair23.me>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-5-armbru@redhat.com>
2020-06-10 13:31:53 +08:00
|
|
|
|
2020-07-08 00:05:57 +08:00
|
|
|
return object_property_set_bool(OBJECT(dev), "realized", true, errp);
|
qdev: New qdev_new(), qdev_realize(), etc.
We commonly plug devices into their bus right when we create them,
like this:
dev = qdev_create(bus, type_name);
Note that @dev is a weak reference. The reference from @bus to @dev
is the only strong one.
We realize at some later time, either with
object_property_set_bool(OBJECT(dev), true, "realized", errp);
or its convenience wrapper
qdev_init_nofail(dev);
If @dev still has no QOM parent then, realizing makes the
/machine/unattached/ orphanage its QOM parent.
Note that the device returned by qdev_create() is plugged into a bus,
but doesn't have a QOM parent, yet. Until it acquires one,
unrealizing the bus will hang in bus_unparent():
while ((kid = QTAILQ_FIRST(&bus->children)) != NULL) {
DeviceState *dev = kid->child;
object_unparent(OBJECT(dev));
}
object_unparent() does nothing when its argument has no QOM parent,
and the loop spins forever.
Device state "no QOM parent, but plugged into bus" is dangerous.
Paolo suggested to delay plugging into the bus until realize. We need
to plug into the parent bus before we call the device's realize
method, in case it uses the parent bus. So the dangerous state still
exists, but only within realization, where we can manage it safely.
This commit creates infrastructure to do this:
dev = qdev_new(type_name);
...
qdev_realize_and_unref(dev, bus, errp)
Note that @dev becomes a strong reference here.
qdev_realize_and_unref() drops it. There is also plain
qdev_realize(), which doesn't drop it.
The remainder of this series will convert all users to this new
interface.
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: Alistair Francis <alistair@alistair23.me>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-5-armbru@redhat.com>
2020-06-10 13:31:53 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
bool qdev_realize_and_unref(DeviceState *dev, BusState *bus, Error **errp)
|
|
|
|
{
|
|
|
|
bool ret;
|
|
|
|
|
|
|
|
ret = qdev_realize(dev, bus, errp);
|
|
|
|
object_unref(OBJECT(dev));
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
void qdev_unrealize(DeviceState *dev)
|
|
|
|
{
|
qom: Put name parameter before value / visitor parameter
The object_property_set_FOO() setters take property name and value in
an unusual order:
void object_property_set_FOO(Object *obj, FOO_TYPE value,
const char *name, Error **errp)
Having to pass value before name feels grating. Swap them.
Same for object_property_set(), object_property_get(), and
object_property_parse().
Convert callers with this Coccinelle script:
@@
identifier fun = {
object_property_get, object_property_parse, object_property_set_str,
object_property_set_link, object_property_set_bool,
object_property_set_int, object_property_set_uint, object_property_set,
object_property_set_qobject
};
expression obj, v, name, errp;
@@
- fun(obj, v, name, errp)
+ fun(obj, name, v, errp)
Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
message "no position information". Convert that one manually.
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Fails to convert hw/rx/rx-gdbsim.c, because Coccinelle gets confused
by RXCPU being used both as typedef and function-like macro there.
Convert manually. The other files using RXCPU that way don't need
conversion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-27-armbru@redhat.com>
[Straightforwad conflict with commit 2336172d9b "audio: set default
value for pcspk.iobase property" resolved]
2020-07-08 00:05:54 +08:00
|
|
|
object_property_set_bool(OBJECT(dev), "realized", false, &error_abort);
|
qdev: New qdev_new(), qdev_realize(), etc.
We commonly plug devices into their bus right when we create them,
like this:
dev = qdev_create(bus, type_name);
Note that @dev is a weak reference. The reference from @bus to @dev
is the only strong one.
We realize at some later time, either with
object_property_set_bool(OBJECT(dev), true, "realized", errp);
or its convenience wrapper
qdev_init_nofail(dev);
If @dev still has no QOM parent then, realizing makes the
/machine/unattached/ orphanage its QOM parent.
Note that the device returned by qdev_create() is plugged into a bus,
but doesn't have a QOM parent, yet. Until it acquires one,
unrealizing the bus will hang in bus_unparent():
while ((kid = QTAILQ_FIRST(&bus->children)) != NULL) {
DeviceState *dev = kid->child;
object_unparent(OBJECT(dev));
}
object_unparent() does nothing when its argument has no QOM parent,
and the loop spins forever.
Device state "no QOM parent, but plugged into bus" is dangerous.
Paolo suggested to delay plugging into the bus until realize. We need
to plug into the parent bus before we call the device's realize
method, in case it uses the parent bus. So the dangerous state still
exists, but only within realization, where we can manage it safely.
This commit creates infrastructure to do this:
dev = qdev_new(type_name);
...
qdev_realize_and_unref(dev, bus, errp)
Note that @dev becomes a strong reference here.
qdev_realize_and_unref() drops it. There is also plain
qdev_realize(), which doesn't drop it.
The remainder of this series will convert all users to this new
interface.
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: Alistair Francis <alistair@alistair23.me>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-5-armbru@redhat.com>
2020-06-10 13:31:53 +08:00
|
|
|
}
|
|
|
|
|
2020-06-09 20:23:39 +08:00
|
|
|
static int qdev_assert_realized_properly(Object *obj, void *opaque)
|
|
|
|
{
|
|
|
|
DeviceState *dev = DEVICE(object_dynamic_cast(obj, TYPE_DEVICE));
|
|
|
|
DeviceClass *dc;
|
|
|
|
|
|
|
|
if (dev) {
|
|
|
|
dc = DEVICE_GET_CLASS(dev);
|
|
|
|
assert(dev->realized);
|
|
|
|
assert(dev->parent_bus || !dc->bus_type);
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-09-26 03:42:41 +08:00
|
|
|
void qdev_machine_creation_done(void)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* ok, initial machine setup is done, starting from now we can
|
|
|
|
* only create hotpluggable devices
|
|
|
|
*/
|
2017-03-28 17:08:52 +08:00
|
|
|
qdev_hotplug = true;
|
2020-06-09 20:23:39 +08:00
|
|
|
|
|
|
|
object_child_foreach_recursive(object_get_root(),
|
|
|
|
qdev_assert_realized_properly, NULL);
|
2009-09-26 03:42:41 +08:00
|
|
|
}
|
|
|
|
|
2011-01-05 03:37:50 +08:00
|
|
|
bool qdev_machine_modified(void)
|
|
|
|
{
|
|
|
|
return qdev_hot_added || qdev_hot_removed;
|
|
|
|
}
|
|
|
|
|
2009-05-23 07:05:19 +08:00
|
|
|
BusState *qdev_get_parent_bus(DeviceState *dev)
|
2009-05-15 05:35:06 +08:00
|
|
|
{
|
2009-05-23 07:05:19 +08:00
|
|
|
return dev->parent_bus;
|
2009-05-15 05:35:06 +08:00
|
|
|
}
|
|
|
|
|
2014-05-20 14:30:58 +08:00
|
|
|
static NamedGPIOList *qdev_get_named_gpio_list(DeviceState *dev,
|
|
|
|
const char *name)
|
|
|
|
{
|
|
|
|
NamedGPIOList *ngl;
|
|
|
|
|
|
|
|
QLIST_FOREACH(ngl, &dev->gpios, node) {
|
2019-11-20 21:42:01 +08:00
|
|
|
/* NULL is a valid and matchable name. */
|
|
|
|
if (g_strcmp0(name, ngl->name) == 0) {
|
2014-05-20 14:30:58 +08:00
|
|
|
return ngl;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ngl = g_malloc0(sizeof(*ngl));
|
|
|
|
ngl->name = g_strdup(name);
|
|
|
|
QLIST_INSERT_HEAD(&dev->gpios, ngl, node);
|
|
|
|
return ngl;
|
|
|
|
}
|
|
|
|
|
2018-03-02 18:45:38 +08:00
|
|
|
void qdev_init_gpio_in_named_with_opaque(DeviceState *dev,
|
|
|
|
qemu_irq_handler handler,
|
|
|
|
void *opaque,
|
|
|
|
const char *name, int n)
|
2014-05-20 14:30:58 +08:00
|
|
|
{
|
2014-09-26 13:17:41 +08:00
|
|
|
int i;
|
2014-05-20 14:30:58 +08:00
|
|
|
NamedGPIOList *gpio_list = qdev_get_named_gpio_list(dev, name);
|
|
|
|
|
2014-09-26 13:17:08 +08:00
|
|
|
assert(gpio_list->num_out == 0 || !name);
|
2014-05-20 14:30:58 +08:00
|
|
|
gpio_list->in = qemu_extend_irqs(gpio_list->in, gpio_list->num_in, handler,
|
2018-03-02 18:45:38 +08:00
|
|
|
opaque, n);
|
2014-09-26 13:17:41 +08:00
|
|
|
|
2015-07-31 20:23:22 +08:00
|
|
|
if (!name) {
|
|
|
|
name = "unnamed-gpio-in";
|
|
|
|
}
|
2014-09-26 13:17:41 +08:00
|
|
|
for (i = gpio_list->num_in; i < gpio_list->num_in + n; i++) {
|
2015-07-31 20:23:22 +08:00
|
|
|
gchar *propname = g_strdup_printf("%s[%u]", name, i);
|
|
|
|
|
2014-09-26 13:17:41 +08:00
|
|
|
object_property_add_child(OBJECT(dev), propname,
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
OBJECT(gpio_list->in[i]));
|
2015-07-31 20:23:22 +08:00
|
|
|
g_free(propname);
|
2014-09-26 13:17:41 +08:00
|
|
|
}
|
|
|
|
|
2014-05-20 14:30:58 +08:00
|
|
|
gpio_list->num_in += n;
|
|
|
|
}
|
|
|
|
|
2009-05-15 05:35:06 +08:00
|
|
|
void qdev_init_gpio_in(DeviceState *dev, qemu_irq_handler handler, int n)
|
|
|
|
{
|
2014-05-20 14:30:58 +08:00
|
|
|
qdev_init_gpio_in_named(dev, handler, NULL, n);
|
|
|
|
}
|
|
|
|
|
|
|
|
void qdev_init_gpio_out_named(DeviceState *dev, qemu_irq *pins,
|
|
|
|
const char *name, int n)
|
|
|
|
{
|
2014-09-26 13:18:14 +08:00
|
|
|
int i;
|
2014-05-20 14:30:58 +08:00
|
|
|
NamedGPIOList *gpio_list = qdev_get_named_gpio_list(dev, name);
|
|
|
|
|
2014-09-26 13:17:08 +08:00
|
|
|
assert(gpio_list->num_in == 0 || !name);
|
2014-09-26 13:18:14 +08:00
|
|
|
|
2015-07-31 20:23:22 +08:00
|
|
|
if (!name) {
|
|
|
|
name = "unnamed-gpio-out";
|
|
|
|
}
|
|
|
|
memset(pins, 0, sizeof(*pins) * n);
|
2014-09-26 13:18:14 +08:00
|
|
|
for (i = 0; i < n; ++i) {
|
2015-07-31 20:23:22 +08:00
|
|
|
gchar *propname = g_strdup_printf("%s[%u]", name,
|
|
|
|
gpio_list->num_out + i);
|
|
|
|
|
2014-09-26 13:18:14 +08:00
|
|
|
object_property_add_link(OBJECT(dev), propname, TYPE_IRQ,
|
|
|
|
(Object **)&pins[i],
|
|
|
|
object_property_allow_set_link,
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
OBJ_PROP_LINK_STRONG);
|
2015-07-31 20:23:22 +08:00
|
|
|
g_free(propname);
|
2014-09-26 13:18:14 +08:00
|
|
|
}
|
2015-07-31 20:23:22 +08:00
|
|
|
gpio_list->num_out += n;
|
2009-05-15 05:35:06 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void qdev_init_gpio_out(DeviceState *dev, qemu_irq *pins, int n)
|
|
|
|
{
|
2014-05-20 14:30:58 +08:00
|
|
|
qdev_init_gpio_out_named(dev, pins, NULL, n);
|
|
|
|
}
|
|
|
|
|
|
|
|
qemu_irq qdev_get_gpio_in_named(DeviceState *dev, const char *name, int n)
|
|
|
|
{
|
|
|
|
NamedGPIOList *gpio_list = qdev_get_named_gpio_list(dev, name);
|
|
|
|
|
|
|
|
assert(n >= 0 && n < gpio_list->num_in);
|
|
|
|
return gpio_list->in[n];
|
2009-05-15 05:35:06 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
qemu_irq qdev_get_gpio_in(DeviceState *dev, int n)
|
|
|
|
{
|
2014-05-20 14:30:58 +08:00
|
|
|
return qdev_get_gpio_in_named(dev, NULL, n);
|
|
|
|
}
|
|
|
|
|
|
|
|
void qdev_connect_gpio_out_named(DeviceState *dev, const char *name, int n,
|
|
|
|
qemu_irq pin)
|
|
|
|
{
|
2014-09-26 13:20:25 +08:00
|
|
|
char *propname = g_strdup_printf("%s[%d]",
|
|
|
|
name ? name : "unnamed-gpio-out", n);
|
2020-05-05 23:29:21 +08:00
|
|
|
if (pin && !OBJECT(pin)->parent) {
|
|
|
|
/* We need a name for object_property_set_link to work */
|
2015-03-12 23:09:34 +08:00
|
|
|
object_property_add_child(container_get(qdev_get_machine(),
|
|
|
|
"/unattached"),
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
"non-qdev-gpio[*]", OBJECT(pin));
|
2014-09-26 13:20:25 +08:00
|
|
|
}
|
qom: Put name parameter before value / visitor parameter
The object_property_set_FOO() setters take property name and value in
an unusual order:
void object_property_set_FOO(Object *obj, FOO_TYPE value,
const char *name, Error **errp)
Having to pass value before name feels grating. Swap them.
Same for object_property_set(), object_property_get(), and
object_property_parse().
Convert callers with this Coccinelle script:
@@
identifier fun = {
object_property_get, object_property_parse, object_property_set_str,
object_property_set_link, object_property_set_bool,
object_property_set_int, object_property_set_uint, object_property_set,
object_property_set_qobject
};
expression obj, v, name, errp;
@@
- fun(obj, v, name, errp)
+ fun(obj, name, v, errp)
Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
message "no position information". Convert that one manually.
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Fails to convert hw/rx/rx-gdbsim.c, because Coccinelle gets confused
by RXCPU being used both as typedef and function-like macro there.
Convert manually. The other files using RXCPU that way don't need
conversion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-27-armbru@redhat.com>
[Straightforwad conflict with commit 2336172d9b "audio: set default
value for pcspk.iobase property" resolved]
2020-07-08 00:05:54 +08:00
|
|
|
object_property_set_link(OBJECT(dev), propname, OBJECT(pin), &error_abort);
|
2014-09-26 13:20:25 +08:00
|
|
|
g_free(propname);
|
2009-05-15 05:35:06 +08:00
|
|
|
}
|
|
|
|
|
2014-09-24 18:32:17 +08:00
|
|
|
qemu_irq qdev_get_gpio_out_connector(DeviceState *dev, const char *name, int n)
|
|
|
|
{
|
2020-03-07 11:07:56 +08:00
|
|
|
g_autofree char *propname = g_strdup_printf("%s[%d]",
|
2014-09-24 18:32:17 +08:00
|
|
|
name ? name : "unnamed-gpio-out", n);
|
|
|
|
|
|
|
|
qemu_irq ret = (qemu_irq)object_property_get_link(OBJECT(dev), propname,
|
|
|
|
NULL);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2015-09-09 05:45:14 +08:00
|
|
|
/* disconnect a GPIO output, returning the disconnected input (if any) */
|
2014-09-26 13:20:58 +08:00
|
|
|
|
|
|
|
static qemu_irq qdev_disconnect_gpio_out_named(DeviceState *dev,
|
|
|
|
const char *name, int n)
|
|
|
|
{
|
|
|
|
char *propname = g_strdup_printf("%s[%d]",
|
|
|
|
name ? name : "unnamed-gpio-out", n);
|
|
|
|
|
|
|
|
qemu_irq ret = (qemu_irq)object_property_get_link(OBJECT(dev), propname,
|
|
|
|
NULL);
|
|
|
|
if (ret) {
|
qom: Put name parameter before value / visitor parameter
The object_property_set_FOO() setters take property name and value in
an unusual order:
void object_property_set_FOO(Object *obj, FOO_TYPE value,
const char *name, Error **errp)
Having to pass value before name feels grating. Swap them.
Same for object_property_set(), object_property_get(), and
object_property_parse().
Convert callers with this Coccinelle script:
@@
identifier fun = {
object_property_get, object_property_parse, object_property_set_str,
object_property_set_link, object_property_set_bool,
object_property_set_int, object_property_set_uint, object_property_set,
object_property_set_qobject
};
expression obj, v, name, errp;
@@
- fun(obj, v, name, errp)
+ fun(obj, name, v, errp)
Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
message "no position information". Convert that one manually.
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Fails to convert hw/rx/rx-gdbsim.c, because Coccinelle gets confused
by RXCPU being used both as typedef and function-like macro there.
Convert manually. The other files using RXCPU that way don't need
conversion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-27-armbru@redhat.com>
[Straightforwad conflict with commit 2336172d9b "audio: set default
value for pcspk.iobase property" resolved]
2020-07-08 00:05:54 +08:00
|
|
|
object_property_set_link(OBJECT(dev), propname, NULL, NULL);
|
2014-09-26 13:20:58 +08:00
|
|
|
}
|
|
|
|
g_free(propname);
|
|
|
|
return ret;
|
|
|
|
}
|
2014-05-20 14:30:58 +08:00
|
|
|
|
2014-09-26 13:20:58 +08:00
|
|
|
qemu_irq qdev_intercept_gpio_out(DeviceState *dev, qemu_irq icpt,
|
|
|
|
const char *name, int n)
|
|
|
|
{
|
|
|
|
qemu_irq disconnected = qdev_disconnect_gpio_out_named(dev, name, n);
|
|
|
|
qdev_connect_gpio_out_named(dev, name, n, icpt);
|
|
|
|
return disconnected;
|
2009-05-15 05:35:06 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void qdev_connect_gpio_out(DeviceState * dev, int n, qemu_irq pin)
|
|
|
|
{
|
2014-05-20 14:30:58 +08:00
|
|
|
qdev_connect_gpio_out_named(dev, NULL, n, pin);
|
2009-05-15 05:35:06 +08:00
|
|
|
}
|
|
|
|
|
2014-09-26 13:23:42 +08:00
|
|
|
void qdev_pass_gpios(DeviceState *dev, DeviceState *container,
|
|
|
|
const char *name)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
NamedGPIOList *ngl = qdev_get_named_gpio_list(dev, name);
|
|
|
|
|
|
|
|
for (i = 0; i < ngl->num_in; i++) {
|
|
|
|
const char *nm = ngl->name ? ngl->name : "unnamed-gpio-in";
|
|
|
|
char *propname = g_strdup_printf("%s[%d]", nm, i);
|
|
|
|
|
|
|
|
object_property_add_alias(OBJECT(container), propname,
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
OBJECT(dev), propname);
|
2015-04-10 03:57:30 +08:00
|
|
|
g_free(propname);
|
2014-09-26 13:23:42 +08:00
|
|
|
}
|
|
|
|
for (i = 0; i < ngl->num_out; i++) {
|
|
|
|
const char *nm = ngl->name ? ngl->name : "unnamed-gpio-out";
|
|
|
|
char *propname = g_strdup_printf("%s[%d]", nm, i);
|
|
|
|
|
|
|
|
object_property_add_alias(OBJECT(container), propname,
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
OBJECT(dev), propname);
|
2015-04-10 03:57:30 +08:00
|
|
|
g_free(propname);
|
2014-09-26 13:23:42 +08:00
|
|
|
}
|
|
|
|
QLIST_REMOVE(ngl, node);
|
|
|
|
QLIST_INSERT_HEAD(&container->gpios, ngl, node);
|
|
|
|
}
|
|
|
|
|
2009-05-23 07:05:19 +08:00
|
|
|
BusState *qdev_get_child_bus(DeviceState *dev, const char *name)
|
2009-05-15 05:35:06 +08:00
|
|
|
{
|
2009-05-23 07:05:19 +08:00
|
|
|
BusState *bus;
|
2016-01-21 22:15:03 +08:00
|
|
|
Object *child = object_resolve_path_component(OBJECT(dev), name);
|
|
|
|
|
|
|
|
bus = (BusState *)object_dynamic_cast(child, TYPE_BUS);
|
|
|
|
if (bus) {
|
|
|
|
return bus;
|
|
|
|
}
|
2009-05-15 05:35:06 +08:00
|
|
|
|
2009-09-12 15:36:22 +08:00
|
|
|
QLIST_FOREACH(bus, &dev->child_bus, sibling) {
|
2009-05-15 05:35:06 +08:00
|
|
|
if (strcmp(name, bus->name) == 0) {
|
2009-05-23 07:05:19 +08:00
|
|
|
return bus;
|
2009-05-15 05:35:06 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2013-12-07 00:54:26 +08:00
|
|
|
int qdev_walk_children(DeviceState *dev,
|
|
|
|
qdev_walkerfn *pre_devfn, qbus_walkerfn *pre_busfn,
|
|
|
|
qdev_walkerfn *post_devfn, qbus_walkerfn *post_busfn,
|
|
|
|
void *opaque)
|
2010-11-19 17:55:58 +08:00
|
|
|
{
|
|
|
|
BusState *bus;
|
|
|
|
int err;
|
|
|
|
|
2013-12-07 00:54:26 +08:00
|
|
|
if (pre_devfn) {
|
|
|
|
err = pre_devfn(dev, opaque);
|
2010-11-19 17:55:58 +08:00
|
|
|
if (err) {
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
QLIST_FOREACH(bus, &dev->child_bus, sibling) {
|
2013-12-07 00:54:26 +08:00
|
|
|
err = qbus_walk_children(bus, pre_devfn, pre_busfn,
|
|
|
|
post_devfn, post_busfn, opaque);
|
2010-11-19 17:55:58 +08:00
|
|
|
if (err < 0) {
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-12-07 00:54:26 +08:00
|
|
|
if (post_devfn) {
|
|
|
|
err = post_devfn(dev, opaque);
|
|
|
|
if (err) {
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-11-19 17:55:58 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-12-24 11:14:12 +08:00
|
|
|
DeviceState *qdev_find_recursive(BusState *bus, const char *id)
|
2009-09-26 03:42:41 +08:00
|
|
|
{
|
2011-12-24 05:34:39 +08:00
|
|
|
BusChild *kid;
|
|
|
|
DeviceState *ret;
|
2009-09-26 03:42:41 +08:00
|
|
|
BusState *child;
|
|
|
|
|
2011-12-24 05:34:39 +08:00
|
|
|
QTAILQ_FOREACH(kid, &bus->children, sibling) {
|
|
|
|
DeviceState *dev = kid->child;
|
|
|
|
|
|
|
|
if (dev->id && strcmp(dev->id, id) == 0) {
|
2009-09-26 03:42:41 +08:00
|
|
|
return dev;
|
2011-12-24 05:34:39 +08:00
|
|
|
}
|
|
|
|
|
2009-09-26 03:42:41 +08:00
|
|
|
QLIST_FOREACH(child, &dev->child_bus, sibling) {
|
|
|
|
ret = qdev_find_recursive(child, id);
|
|
|
|
if (ret) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2012-02-04 02:28:43 +08:00
|
|
|
char *qdev_get_dev_path(DeviceState *dev)
|
2011-12-13 04:29:25 +08:00
|
|
|
{
|
2012-05-02 15:00:20 +08:00
|
|
|
BusClass *bc;
|
2012-02-04 02:28:43 +08:00
|
|
|
|
|
|
|
if (!dev || !dev->parent_bus) {
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2012-05-02 15:00:20 +08:00
|
|
|
bc = BUS_GET_CLASS(dev->parent_bus);
|
|
|
|
if (bc->get_dev_path) {
|
|
|
|
return bc->get_dev_path(dev);
|
2012-02-04 02:28:43 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
2011-12-13 04:29:26 +08:00
|
|
|
}
|
2011-12-13 04:29:27 +08:00
|
|
|
|
|
|
|
/**
|
|
|
|
* Legacy property handling
|
|
|
|
*/
|
|
|
|
|
qom: Swap 'name' next to visitor in ObjectPropertyAccessor
Similar to the previous patch, it's nice to have all functions
in the tree that involve a visitor and a name for conversion to
or from QAPI to consistently stick the 'name' parameter next
to the Visitor parameter.
Done by manually changing include/qom/object.h and qom/object.c,
then running this Coccinelle script and touching up the fallout
(Coccinelle insisted on adding some trailing whitespace).
@ rule1 @
identifier fn;
typedef Object, Visitor, Error;
identifier obj, v, opaque, name, errp;
@@
void fn
- (Object *obj, Visitor *v, void *opaque, const char *name,
+ (Object *obj, Visitor *v, const char *name, void *opaque,
Error **errp) { ... }
@@
identifier rule1.fn;
expression obj, v, opaque, name, errp;
@@
fn(obj, v,
- opaque, name,
+ name, opaque,
errp)
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <1454075341-13658-20-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
2016-01-29 21:48:55 +08:00
|
|
|
static void qdev_get_legacy_property(Object *obj, Visitor *v,
|
|
|
|
const char *name, void *opaque,
|
|
|
|
Error **errp)
|
2011-12-13 04:29:27 +08:00
|
|
|
{
|
2012-01-30 22:55:55 +08:00
|
|
|
DeviceState *dev = DEVICE(obj);
|
2011-12-13 04:29:27 +08:00
|
|
|
Property *prop = opaque;
|
|
|
|
|
2011-12-19 00:05:06 +08:00
|
|
|
char buffer[1024];
|
|
|
|
char *ptr = buffer;
|
2011-12-13 04:29:27 +08:00
|
|
|
|
2011-12-19 00:05:06 +08:00
|
|
|
prop->info->print(dev, prop, buffer, sizeof(buffer));
|
qapi: Swap visit_* arguments for consistent 'name' placement
JSON uses "name":value, but many of our visitor interfaces were
called with visit_type_FOO(v, &value, name, errp). This can be
a bit confusing to have to mentally swap the parameter order to
match JSON order. It's particularly bad for visit_start_struct(),
where the 'name' parameter is smack in the middle of the
otherwise-related group of 'obj, kind, size' parameters! It's
time to do a global swap of the parameter ordering, so that the
'name' parameter is always immediately after the Visitor argument.
Additional reason in favor of the swap: the existing include/qjson.h
prefers listing 'name' first in json_prop_*(), and I have plans to
unify that file with the qapi visitors; listing 'name' first in
qapi will minimize churn to the (admittedly few) qjson.h clients.
Later patches will then fix docs, object.h, visitor-impl.h, and
those clients to match.
Done by first patching scripts/qapi*.py by hand to make generated
files do what I want, then by running the following Coccinelle
script to affect the rest of the code base:
$ spatch --sp-file script `git grep -l '\bvisit_' -- '**/*.[ch]'`
I then had to apply some touchups (Coccinelle insisted on TAB
indentation in visitor.h, and botched the signature of
visit_type_enum() by rewriting 'const char *const strings[]' to
the syntactically invalid 'const char*const[] strings'). The
movement of parameters is sufficient to provoke compiler errors
if any callers were missed.
// Part 1: Swap declaration order
@@
type TV, TErr, TObj, T1, T2;
identifier OBJ, ARG1, ARG2;
@@
void visit_start_struct
-(TV v, TObj OBJ, T1 ARG1, const char *name, T2 ARG2, TErr errp)
+(TV v, const char *name, TObj OBJ, T1 ARG1, T2 ARG2, TErr errp)
{ ... }
@@
type bool, TV, T1;
identifier ARG1;
@@
bool visit_optional
-(TV v, T1 ARG1, const char *name)
+(TV v, const char *name, T1 ARG1)
{ ... }
@@
type TV, TErr, TObj, T1;
identifier OBJ, ARG1;
@@
void visit_get_next_type
-(TV v, TObj OBJ, T1 ARG1, const char *name, TErr errp)
+(TV v, const char *name, TObj OBJ, T1 ARG1, TErr errp)
{ ... }
@@
type TV, TErr, TObj, T1, T2;
identifier OBJ, ARG1, ARG2;
@@
void visit_type_enum
-(TV v, TObj OBJ, T1 ARG1, T2 ARG2, const char *name, TErr errp)
+(TV v, const char *name, TObj OBJ, T1 ARG1, T2 ARG2, TErr errp)
{ ... }
@@
type TV, TErr, TObj;
identifier OBJ;
identifier VISIT_TYPE =~ "^visit_type_";
@@
void VISIT_TYPE
-(TV v, TObj OBJ, const char *name, TErr errp)
+(TV v, const char *name, TObj OBJ, TErr errp)
{ ... }
// Part 2: swap caller order
@@
expression V, NAME, OBJ, ARG1, ARG2, ERR;
identifier VISIT_TYPE =~ "^visit_type_";
@@
(
-visit_start_struct(V, OBJ, ARG1, NAME, ARG2, ERR)
+visit_start_struct(V, NAME, OBJ, ARG1, ARG2, ERR)
|
-visit_optional(V, ARG1, NAME)
+visit_optional(V, NAME, ARG1)
|
-visit_get_next_type(V, OBJ, ARG1, NAME, ERR)
+visit_get_next_type(V, NAME, OBJ, ARG1, ERR)
|
-visit_type_enum(V, OBJ, ARG1, ARG2, NAME, ERR)
+visit_type_enum(V, NAME, OBJ, ARG1, ARG2, ERR)
|
-VISIT_TYPE(V, OBJ, NAME, ERR)
+VISIT_TYPE(V, NAME, OBJ, ERR)
)
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <1454075341-13658-19-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
2016-01-29 21:48:54 +08:00
|
|
|
visit_type_str(v, name, &ptr, errp);
|
2011-12-13 04:29:27 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2020-01-10 23:30:34 +08:00
|
|
|
* qdev_class_add_legacy_property:
|
2016-04-17 15:45:54 +08:00
|
|
|
* @dev: Device to add the property to.
|
|
|
|
* @prop: The qdev property definition.
|
|
|
|
*
|
|
|
|
* Add a legacy QOM property to @dev for qdev property @prop.
|
2011-12-13 04:29:27 +08:00
|
|
|
*
|
2016-04-17 15:45:54 +08:00
|
|
|
* Legacy properties are string versions of QOM properties. The format of
|
|
|
|
* the string depends on the property type. Legacy properties are only
|
|
|
|
* needed for "info qtree".
|
2011-12-13 04:29:27 +08:00
|
|
|
*
|
2018-09-05 14:49:01 +08:00
|
|
|
* Do not use this in new code! QOM Properties added through this interface
|
2016-04-17 15:45:54 +08:00
|
|
|
* will be given names in the "legacy" namespace.
|
2011-12-13 04:29:27 +08:00
|
|
|
*/
|
2020-01-10 23:30:34 +08:00
|
|
|
static void qdev_class_add_legacy_property(DeviceClass *dc, Property *prop)
|
2011-12-13 04:29:27 +08:00
|
|
|
{
|
2020-01-10 23:30:34 +08:00
|
|
|
g_autofree char *name = NULL;
|
2011-12-13 04:29:27 +08:00
|
|
|
|
2012-05-02 19:31:07 +08:00
|
|
|
/* Register pointer properties as legacy properties */
|
2014-02-08 18:01:47 +08:00
|
|
|
if (!prop->info->print && prop->info->get) {
|
2012-02-02 17:17:19 +08:00
|
|
|
return;
|
|
|
|
}
|
2012-05-02 19:31:07 +08:00
|
|
|
|
2011-12-19 00:05:11 +08:00
|
|
|
name = g_strdup_printf("legacy-%s", prop->name);
|
2020-01-10 23:30:34 +08:00
|
|
|
object_class_property_add(OBJECT_CLASS(dc), name, "str",
|
|
|
|
prop->info->print ? qdev_get_legacy_property : prop->info->get,
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
NULL, NULL, prop);
|
2011-12-19 00:05:11 +08:00
|
|
|
}
|
|
|
|
|
2020-01-10 23:30:16 +08:00
|
|
|
void qdev_property_add_static(DeviceState *dev, Property *prop)
|
2011-12-19 00:05:11 +08:00
|
|
|
{
|
2012-04-03 04:40:26 +08:00
|
|
|
Object *obj = OBJECT(dev);
|
2020-01-10 23:30:34 +08:00
|
|
|
ObjectProperty *op;
|
2012-04-03 04:40:26 +08:00
|
|
|
|
2020-01-10 23:30:34 +08:00
|
|
|
assert(!prop->info->create);
|
|
|
|
|
|
|
|
op = object_property_add(obj, prop->name, prop->info->name,
|
|
|
|
prop->info->get, prop->info->set,
|
|
|
|
prop->info->release,
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
prop);
|
2014-10-07 14:33:22 +08:00
|
|
|
|
|
|
|
object_property_set_description(obj, prop->name,
|
2020-05-05 23:29:15 +08:00
|
|
|
prop->info->description);
|
2014-10-07 14:33:22 +08:00
|
|
|
|
2017-07-17 20:36:06 +08:00
|
|
|
if (prop->set_default) {
|
2020-01-10 23:30:34 +08:00
|
|
|
prop->info->set_default_value(op, prop);
|
|
|
|
if (op->init) {
|
|
|
|
op->init(obj, op);
|
|
|
|
}
|
2012-04-03 04:40:26 +08:00
|
|
|
}
|
2011-12-13 04:29:42 +08:00
|
|
|
}
|
2011-12-20 06:37:46 +08:00
|
|
|
|
2020-01-10 23:30:34 +08:00
|
|
|
static void qdev_class_add_property(DeviceClass *klass, Property *prop)
|
|
|
|
{
|
|
|
|
ObjectClass *oc = OBJECT_CLASS(klass);
|
|
|
|
|
|
|
|
if (prop->info->create) {
|
2020-05-05 23:29:23 +08:00
|
|
|
prop->info->create(oc, prop);
|
2020-01-10 23:30:34 +08:00
|
|
|
} else {
|
|
|
|
ObjectProperty *op;
|
|
|
|
|
|
|
|
op = object_class_property_add(oc,
|
|
|
|
prop->name, prop->info->name,
|
|
|
|
prop->info->get, prop->info->set,
|
|
|
|
prop->info->release,
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
prop);
|
2020-01-10 23:30:34 +08:00
|
|
|
if (prop->set_default) {
|
|
|
|
prop->info->set_default_value(op, prop);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
object_class_property_set_description(oc, prop->name,
|
2020-05-05 23:29:15 +08:00
|
|
|
prop->info->description);
|
2020-01-10 23:30:34 +08:00
|
|
|
}
|
|
|
|
|
2014-06-18 17:58:32 +08:00
|
|
|
void qdev_alias_all_properties(DeviceState *target, Object *source)
|
|
|
|
{
|
|
|
|
ObjectClass *class;
|
|
|
|
Property *prop;
|
|
|
|
|
|
|
|
class = object_get_class(OBJECT(target));
|
|
|
|
do {
|
|
|
|
DeviceClass *dc = DEVICE_CLASS(class);
|
|
|
|
|
2020-01-23 19:11:38 +08:00
|
|
|
for (prop = dc->props_; prop && prop->name; prop++) {
|
2014-06-18 17:58:32 +08:00
|
|
|
object_property_add_alias(source, prop->name,
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
OBJECT(target), prop->name);
|
2014-06-18 17:58:32 +08:00
|
|
|
}
|
|
|
|
class = object_class_get_parent(class);
|
|
|
|
} while (class != object_class_by_name(TYPE_DEVICE));
|
|
|
|
}
|
|
|
|
|
2014-04-25 18:44:21 +08:00
|
|
|
static bool device_get_realized(Object *obj, Error **errp)
|
2013-01-09 10:58:11 +08:00
|
|
|
{
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
|
|
|
return dev->realized;
|
|
|
|
}
|
|
|
|
|
2019-12-06 01:46:23 +08:00
|
|
|
static bool check_only_migratable(Object *obj, Error **errp)
|
2017-04-17 20:57:54 +08:00
|
|
|
{
|
|
|
|
DeviceClass *dc = DEVICE_GET_CLASS(obj);
|
|
|
|
|
|
|
|
if (!vmstate_check_only_migratable(dc->vmsd)) {
|
2019-12-06 01:46:23 +08:00
|
|
|
error_setg(errp, "Device %s is not migratable, but "
|
2017-04-17 20:57:54 +08:00
|
|
|
"--only-migratable was specified",
|
|
|
|
object_get_typename(obj));
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2014-04-25 18:44:21 +08:00
|
|
|
static void device_set_realized(Object *obj, bool value, Error **errp)
|
2013-01-09 10:58:11 +08:00
|
|
|
{
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
|
|
|
DeviceClass *dc = DEVICE_GET_CLASS(dev);
|
2014-09-26 17:28:41 +08:00
|
|
|
HotplugHandler *hotplug_ctrl;
|
2014-03-13 04:02:12 +08:00
|
|
|
BusState *bus;
|
2020-04-06 21:52:45 +08:00
|
|
|
NamedClockList *ncl;
|
2013-01-09 10:58:11 +08:00
|
|
|
Error *local_err = NULL;
|
2016-07-25 17:59:22 +08:00
|
|
|
bool unattached_parent = false;
|
|
|
|
static int unattached_count;
|
2013-01-09 10:58:11 +08:00
|
|
|
|
2014-02-05 23:36:46 +08:00
|
|
|
if (dev->hotplugged && !dc->hotpluggable) {
|
2015-03-17 18:54:50 +08:00
|
|
|
error_setg(errp, QERR_DEVICE_NO_HOTPLUG, object_get_typename(obj));
|
2014-02-05 23:36:46 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2013-01-09 10:58:11 +08:00
|
|
|
if (value && !dev->realized) {
|
2020-07-08 00:06:05 +08:00
|
|
|
if (!check_only_migratable(obj, errp)) {
|
2017-02-14 02:04:48 +08:00
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
2014-09-02 20:03:05 +08:00
|
|
|
if (!obj->parent) {
|
2013-01-09 10:58:11 +08:00
|
|
|
gchar *name = g_strdup_printf("device[%d]", unattached_count++);
|
|
|
|
|
|
|
|
object_property_add_child(container_get(qdev_get_machine(),
|
|
|
|
"/unattached"),
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
name, obj);
|
2016-07-25 17:59:22 +08:00
|
|
|
unattached_parent = true;
|
2013-01-09 10:58:11 +08:00
|
|
|
g_free(name);
|
|
|
|
}
|
|
|
|
|
2016-05-12 11:48:15 +08:00
|
|
|
hotplug_ctrl = qdev_get_hotplug_handler(dev);
|
|
|
|
if (hotplug_ctrl) {
|
|
|
|
hotplug_handler_pre_plug(hotplug_ctrl, dev, &local_err);
|
|
|
|
if (local_err != NULL) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-04-11 22:51:56 +08:00
|
|
|
if (dc->realize) {
|
|
|
|
dc->realize(dev, &local_err);
|
2019-12-06 01:46:23 +08:00
|
|
|
if (local_err != NULL) {
|
|
|
|
goto fail;
|
|
|
|
}
|
2014-09-04 10:18:26 +08:00
|
|
|
}
|
|
|
|
|
2015-01-20 19:05:07 +08:00
|
|
|
DEVICE_LISTENER_CALL(realize, Forward, dev);
|
|
|
|
|
qdev: store DeviceState's canonical path to use when unparenting
device_unparent(dev, ...) is called when a device is unparented,
either directly, or as a result of a parent device being
finalized, and handles some final cleanup for the device. Part
of this includes emiting a DEVICE_DELETED QMP event to notify
management, which includes the device's path in the composition
tree as provided by object_get_canonical_path().
object_get_canonical_path() assumes the device is still connected
to the machine/root container, and will assert otherwise, but
in some situations this isn't the case:
If the parent is finalized as a result of object_unparent(), it
will still be attached to the composition tree at the time any
children are unparented as a result of that same call to
object_unparent(). However, in some cases, object_unparent()
will complete without finalizing the parent device, due to
lingering references that won't be released till some time later.
One such example is if the parent has MemoryRegion children (which
take a ref on their parent), who in turn have AddressSpace's (which
take a ref on their regions), since those AddressSpaces get cleaned
up asynchronously by the RCU thread.
In this case qdev:device_unparent() may be called for a child Device
that no longer has a path to the root/machine container, causing
object_get_canonical_path() to assert.
Fix this by storing the canonical path during realize() so the
information will still be available for device_unparent() in such
cases.
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Tested-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <20171016222315.407-2-mdroth@linux.vnet.ibm.com>
[Clear dev->canonical_path at the post_realize_fail label, which is
cleaner. Suggested by David Gibson. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2017-10-17 06:23:13 +08:00
|
|
|
/*
|
|
|
|
* always free/re-initialize here since the value cannot be cleaned up
|
|
|
|
* in device_unrealize due to its usage later on in the unplug path
|
|
|
|
*/
|
|
|
|
g_free(dev->canonical_path);
|
|
|
|
dev->canonical_path = object_get_canonical_path(OBJECT(dev));
|
2020-04-06 21:52:45 +08:00
|
|
|
QLIST_FOREACH(ncl, &dev->clocks, node) {
|
|
|
|
if (ncl->alias) {
|
|
|
|
continue;
|
|
|
|
} else {
|
|
|
|
clock_setup_canonical_path(ncl->clock);
|
|
|
|
}
|
|
|
|
}
|
qdev: store DeviceState's canonical path to use when unparenting
device_unparent(dev, ...) is called when a device is unparented,
either directly, or as a result of a parent device being
finalized, and handles some final cleanup for the device. Part
of this includes emiting a DEVICE_DELETED QMP event to notify
management, which includes the device's path in the composition
tree as provided by object_get_canonical_path().
object_get_canonical_path() assumes the device is still connected
to the machine/root container, and will assert otherwise, but
in some situations this isn't the case:
If the parent is finalized as a result of object_unparent(), it
will still be attached to the composition tree at the time any
children are unparented as a result of that same call to
object_unparent(). However, in some cases, object_unparent()
will complete without finalizing the parent device, due to
lingering references that won't be released till some time later.
One such example is if the parent has MemoryRegion children (which
take a ref on their parent), who in turn have AddressSpace's (which
take a ref on their regions), since those AddressSpaces get cleaned
up asynchronously by the RCU thread.
In this case qdev:device_unparent() may be called for a child Device
that no longer has a path to the root/machine container, causing
object_get_canonical_path() to assert.
Fix this by storing the canonical path during realize() so the
information will still be available for device_unparent() in such
cases.
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Tested-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <20171016222315.407-2-mdroth@linux.vnet.ibm.com>
[Clear dev->canonical_path at the post_realize_fail label, which is
cleaner. Suggested by David Gibson. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2017-10-17 06:23:13 +08:00
|
|
|
|
2014-09-04 10:18:26 +08:00
|
|
|
if (qdev_get_vmsd(dev)) {
|
2019-08-28 20:02:32 +08:00
|
|
|
if (vmstate_register_with_alias_id(VMSTATE_IF(dev),
|
2019-10-16 10:29:30 +08:00
|
|
|
VMSTATE_INSTANCE_ID_ANY,
|
|
|
|
qdev_get_vmsd(dev), dev,
|
2017-02-02 20:59:56 +08:00
|
|
|
dev->instance_id_alias,
|
|
|
|
dev->alias_required_for_version,
|
|
|
|
&local_err) < 0) {
|
|
|
|
goto post_realize_fail;
|
|
|
|
}
|
2013-01-09 10:58:11 +08:00
|
|
|
}
|
2014-09-04 10:18:26 +08:00
|
|
|
|
2020-01-31 00:02:04 +08:00
|
|
|
/*
|
|
|
|
* Clear the reset state, in case the object was previously unrealized
|
|
|
|
* with a dirty state.
|
|
|
|
*/
|
|
|
|
resettable_state_clear(&dev->reset);
|
|
|
|
|
2014-09-04 10:18:26 +08:00
|
|
|
QLIST_FOREACH(bus, &dev->child_bus, sibling) {
|
2020-06-10 13:31:55 +08:00
|
|
|
if (!qbus_realize(bus, errp)) {
|
2014-09-04 10:18:26 +08:00
|
|
|
goto child_realize_fail;
|
2014-03-13 04:02:12 +08:00
|
|
|
}
|
|
|
|
}
|
2014-09-04 10:18:26 +08:00
|
|
|
if (dev->hotplugged) {
|
2020-01-31 00:02:04 +08:00
|
|
|
/*
|
|
|
|
* Reset the device, as well as its subtree which, at this point,
|
|
|
|
* should be realized too.
|
|
|
|
*/
|
|
|
|
resettable_assert_reset(OBJECT(dev), RESET_TYPE_COLD);
|
|
|
|
resettable_change_parent(OBJECT(dev), OBJECT(dev->parent_bus),
|
|
|
|
NULL);
|
|
|
|
resettable_release_reset(OBJECT(dev), RESET_TYPE_COLD);
|
2013-01-09 10:58:11 +08:00
|
|
|
}
|
2014-06-26 21:10:03 +08:00
|
|
|
dev->pending_deleted_event = false;
|
2018-07-16 16:37:31 +08:00
|
|
|
|
|
|
|
if (hotplug_ctrl) {
|
2018-10-16 21:33:40 +08:00
|
|
|
hotplug_handler_plug(hotplug_ctrl, dev, &local_err);
|
|
|
|
if (local_err != NULL) {
|
|
|
|
goto child_realize_fail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-01-09 10:58:11 +08:00
|
|
|
} else if (!value && dev->realized) {
|
2014-03-13 04:02:12 +08:00
|
|
|
QLIST_FOREACH(bus, &dev->child_bus, sibling) {
|
2020-06-10 13:31:55 +08:00
|
|
|
qbus_unrealize(bus);
|
2014-03-13 04:02:12 +08:00
|
|
|
}
|
2014-09-04 10:18:25 +08:00
|
|
|
if (qdev_get_vmsd(dev)) {
|
2019-08-28 20:02:32 +08:00
|
|
|
vmstate_unregister(VMSTATE_IF(dev), qdev_get_vmsd(dev), dev);
|
2013-04-16 00:34:10 +08:00
|
|
|
}
|
2014-09-04 10:18:25 +08:00
|
|
|
if (dc->unrealize) {
|
qdev: Unrealize must not fail
Devices may have component devices and buses.
Device realization may fail. Realization is recursive: a device's
realize() method realizes its components, and device_set_realized()
realizes its buses (which should in turn realize the devices on that
bus, except bus_set_realized() doesn't implement that, yet).
When realization of a component or bus fails, we need to roll back:
unrealize everything we realized so far. If any of these unrealizes
failed, the device would be left in an inconsistent state. Must not
happen.
device_set_realized() lets it happen: it ignores errors in the roll
back code starting at label child_realize_fail.
Since realization is recursive, unrealization must be recursive, too.
But how could a partly failed unrealize be rolled back? We'd have to
re-realize, which can fail. This design is fundamentally broken.
device_set_realized() does not roll back at all. Instead, it keeps
unrealizing, ignoring further errors.
It can screw up even for a device with no buses: if the lone
dc->unrealize() fails, it still unregisters vmstate, and calls
listeners' unrealize() callback.
bus_set_realized() does not roll back either. Instead, it stops
unrealizing.
Fortunately, no unrealize method can fail, as we'll see below.
To fix the design error, drop parameter @errp from all the unrealize
methods.
Any unrealize method that uses @errp now needs an update. This leads
us to unrealize() methods that can fail. Merely passing it to another
unrealize method cannot cause failure, though. Here are the ones that
do other things with @errp:
* virtio_serial_device_unrealize()
Fails when qbus_set_hotplug_handler() fails, but still does all the
other work. On failure, the device would stay realized with its
resources completely gone. Oops. Can't happen, because
qbus_set_hotplug_handler() can't actually fail here. Pass
&error_abort to qbus_set_hotplug_handler() instead.
* hw/ppc/spapr_drc.c's unrealize()
Fails when object_property_del() fails, but all the other work is
already done. On failure, the device would stay realized with its
vmstate registration gone. Oops. Can't happen, because
object_property_del() can't actually fail here. Pass &error_abort
to object_property_del() instead.
* spapr_phb_unrealize()
Fails and bails out when remove_drcs() fails, but other work is
already done. On failure, the device would stay realized with some
of its resources gone. Oops. remove_drcs() fails only when
chassis_from_bus()'s object_property_get_uint() fails, and it can't
here. Pass &error_abort to remove_drcs() instead.
Therefore, no unrealize method can fail before this patch.
device_set_realized()'s recursive unrealization via bus uses
object_property_set_bool(). Can't drop @errp there, so pass
&error_abort.
We similarly unrealize with object_property_set_bool() elsewhere,
always ignoring errors. Pass &error_abort instead.
Several unrealize methods no longer handle errors from other unrealize
methods: virtio_9p_device_unrealize(),
virtio_input_device_unrealize(), scsi_qdev_unrealize(), ...
Much of the deleted error handling looks wrong anyway.
One unrealize methods no longer ignore such errors:
usb_ehci_pci_exit().
Several realize methods no longer ignore errors when rolling back:
v9fs_device_realize_common(), pci_qdev_unrealize(),
spapr_phb_realize(), usb_qdev_realize(), vfio_ccw_realize(),
virtio_device_realize().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-17-armbru@redhat.com>
2020-05-05 23:29:24 +08:00
|
|
|
dc->unrealize(dev);
|
2013-01-09 10:58:11 +08:00
|
|
|
}
|
2014-06-26 21:10:03 +08:00
|
|
|
dev->pending_deleted_event = true;
|
2015-01-20 19:05:07 +08:00
|
|
|
DEVICE_LISTENER_CALL(unrealize, Reverse, dev);
|
2013-01-09 10:58:11 +08:00
|
|
|
}
|
|
|
|
|
2019-12-06 01:46:23 +08:00
|
|
|
assert(local_err == NULL);
|
2016-11-07 19:13:36 +08:00
|
|
|
dev->realized = value;
|
2014-09-04 10:18:26 +08:00
|
|
|
return;
|
|
|
|
|
|
|
|
child_realize_fail:
|
|
|
|
QLIST_FOREACH(bus, &dev->child_bus, sibling) {
|
2020-06-10 13:31:55 +08:00
|
|
|
qbus_unrealize(bus);
|
2014-09-04 10:18:26 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (qdev_get_vmsd(dev)) {
|
2019-08-28 20:02:32 +08:00
|
|
|
vmstate_unregister(VMSTATE_IF(dev), qdev_get_vmsd(dev), dev);
|
2014-09-04 10:18:26 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
post_realize_fail:
|
qdev: store DeviceState's canonical path to use when unparenting
device_unparent(dev, ...) is called when a device is unparented,
either directly, or as a result of a parent device being
finalized, and handles some final cleanup for the device. Part
of this includes emiting a DEVICE_DELETED QMP event to notify
management, which includes the device's path in the composition
tree as provided by object_get_canonical_path().
object_get_canonical_path() assumes the device is still connected
to the machine/root container, and will assert otherwise, but
in some situations this isn't the case:
If the parent is finalized as a result of object_unparent(), it
will still be attached to the composition tree at the time any
children are unparented as a result of that same call to
object_unparent(). However, in some cases, object_unparent()
will complete without finalizing the parent device, due to
lingering references that won't be released till some time later.
One such example is if the parent has MemoryRegion children (which
take a ref on their parent), who in turn have AddressSpace's (which
take a ref on their regions), since those AddressSpaces get cleaned
up asynchronously by the RCU thread.
In this case qdev:device_unparent() may be called for a child Device
that no longer has a path to the root/machine container, causing
object_get_canonical_path() to assert.
Fix this by storing the canonical path during realize() so the
information will still be available for device_unparent() in such
cases.
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Tested-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <20171016222315.407-2-mdroth@linux.vnet.ibm.com>
[Clear dev->canonical_path at the post_realize_fail label, which is
cleaner. Suggested by David Gibson. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2017-10-17 06:23:13 +08:00
|
|
|
g_free(dev->canonical_path);
|
|
|
|
dev->canonical_path = NULL;
|
2014-09-04 10:18:26 +08:00
|
|
|
if (dc->unrealize) {
|
qdev: Unrealize must not fail
Devices may have component devices and buses.
Device realization may fail. Realization is recursive: a device's
realize() method realizes its components, and device_set_realized()
realizes its buses (which should in turn realize the devices on that
bus, except bus_set_realized() doesn't implement that, yet).
When realization of a component or bus fails, we need to roll back:
unrealize everything we realized so far. If any of these unrealizes
failed, the device would be left in an inconsistent state. Must not
happen.
device_set_realized() lets it happen: it ignores errors in the roll
back code starting at label child_realize_fail.
Since realization is recursive, unrealization must be recursive, too.
But how could a partly failed unrealize be rolled back? We'd have to
re-realize, which can fail. This design is fundamentally broken.
device_set_realized() does not roll back at all. Instead, it keeps
unrealizing, ignoring further errors.
It can screw up even for a device with no buses: if the lone
dc->unrealize() fails, it still unregisters vmstate, and calls
listeners' unrealize() callback.
bus_set_realized() does not roll back either. Instead, it stops
unrealizing.
Fortunately, no unrealize method can fail, as we'll see below.
To fix the design error, drop parameter @errp from all the unrealize
methods.
Any unrealize method that uses @errp now needs an update. This leads
us to unrealize() methods that can fail. Merely passing it to another
unrealize method cannot cause failure, though. Here are the ones that
do other things with @errp:
* virtio_serial_device_unrealize()
Fails when qbus_set_hotplug_handler() fails, but still does all the
other work. On failure, the device would stay realized with its
resources completely gone. Oops. Can't happen, because
qbus_set_hotplug_handler() can't actually fail here. Pass
&error_abort to qbus_set_hotplug_handler() instead.
* hw/ppc/spapr_drc.c's unrealize()
Fails when object_property_del() fails, but all the other work is
already done. On failure, the device would stay realized with its
vmstate registration gone. Oops. Can't happen, because
object_property_del() can't actually fail here. Pass &error_abort
to object_property_del() instead.
* spapr_phb_unrealize()
Fails and bails out when remove_drcs() fails, but other work is
already done. On failure, the device would stay realized with some
of its resources gone. Oops. remove_drcs() fails only when
chassis_from_bus()'s object_property_get_uint() fails, and it can't
here. Pass &error_abort to remove_drcs() instead.
Therefore, no unrealize method can fail before this patch.
device_set_realized()'s recursive unrealization via bus uses
object_property_set_bool(). Can't drop @errp there, so pass
&error_abort.
We similarly unrealize with object_property_set_bool() elsewhere,
always ignoring errors. Pass &error_abort instead.
Several unrealize methods no longer handle errors from other unrealize
methods: virtio_9p_device_unrealize(),
virtio_input_device_unrealize(), scsi_qdev_unrealize(), ...
Much of the deleted error handling looks wrong anyway.
One unrealize methods no longer ignore such errors:
usb_ehci_pci_exit().
Several realize methods no longer ignore errors when rolling back:
v9fs_device_realize_common(), pci_qdev_unrealize(),
spapr_phb_realize(), usb_qdev_realize(), vfio_ccw_realize(),
virtio_device_realize().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-17-armbru@redhat.com>
2020-05-05 23:29:24 +08:00
|
|
|
dc->unrealize(dev);
|
2014-09-04 10:18:26 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
fail:
|
|
|
|
error_propagate(errp, local_err);
|
2016-07-25 17:59:22 +08:00
|
|
|
if (unattached_parent) {
|
qdev: New qdev_new(), qdev_realize(), etc.
We commonly plug devices into their bus right when we create them,
like this:
dev = qdev_create(bus, type_name);
Note that @dev is a weak reference. The reference from @bus to @dev
is the only strong one.
We realize at some later time, either with
object_property_set_bool(OBJECT(dev), true, "realized", errp);
or its convenience wrapper
qdev_init_nofail(dev);
If @dev still has no QOM parent then, realizing makes the
/machine/unattached/ orphanage its QOM parent.
Note that the device returned by qdev_create() is plugged into a bus,
but doesn't have a QOM parent, yet. Until it acquires one,
unrealizing the bus will hang in bus_unparent():
while ((kid = QTAILQ_FIRST(&bus->children)) != NULL) {
DeviceState *dev = kid->child;
object_unparent(OBJECT(dev));
}
object_unparent() does nothing when its argument has no QOM parent,
and the loop spins forever.
Device state "no QOM parent, but plugged into bus" is dangerous.
Paolo suggested to delay plugging into the bus until realize. We need
to plug into the parent bus before we call the device's realize
method, in case it uses the parent bus. So the dangerous state still
exists, but only within realization, where we can manage it safely.
This commit creates infrastructure to do this:
dev = qdev_new(type_name);
...
qdev_realize_and_unref(dev, bus, errp)
Note that @dev becomes a strong reference here.
qdev_realize_and_unref() drops it. There is also plain
qdev_realize(), which doesn't drop it.
The remainder of this series will convert all users to this new
interface.
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: Alistair Francis <alistair@alistair23.me>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-5-armbru@redhat.com>
2020-06-10 13:31:53 +08:00
|
|
|
/*
|
|
|
|
* Beware, this doesn't just revert
|
|
|
|
* object_property_add_child(), it also runs bus_remove()!
|
|
|
|
*/
|
2016-07-25 17:59:22 +08:00
|
|
|
object_unparent(OBJECT(dev));
|
|
|
|
unattached_count--;
|
|
|
|
}
|
2013-01-09 10:58:11 +08:00
|
|
|
}
|
|
|
|
|
2014-04-25 18:44:21 +08:00
|
|
|
static bool device_get_hotpluggable(Object *obj, Error **errp)
|
2014-02-05 23:36:46 +08:00
|
|
|
{
|
|
|
|
DeviceClass *dc = DEVICE_GET_CLASS(obj);
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
|
|
|
|
2014-03-08 02:04:13 +08:00
|
|
|
return dc->hotpluggable && (dev->parent_bus == NULL ||
|
2014-09-26 17:28:17 +08:00
|
|
|
qbus_is_hotpluggable(dev->parent_bus));
|
2014-02-05 23:36:46 +08:00
|
|
|
}
|
|
|
|
|
2019-12-06 01:46:23 +08:00
|
|
|
static bool device_get_hotplugged(Object *obj, Error **errp)
|
2014-06-02 21:25:04 +08:00
|
|
|
{
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
|
|
|
|
|
|
|
return dev->hotplugged;
|
|
|
|
}
|
|
|
|
|
2011-12-23 05:06:37 +08:00
|
|
|
static void device_initfn(Object *obj)
|
|
|
|
{
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
|
|
|
|
|
|
|
if (qdev_hotplug) {
|
|
|
|
dev->hotplugged = 1;
|
|
|
|
qdev_hot_added = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
dev->instance_id_alias = -1;
|
2013-01-09 10:58:10 +08:00
|
|
|
dev->realized = false;
|
2019-10-29 19:49:01 +08:00
|
|
|
dev->allow_unplug_during_migration = false;
|
2011-12-23 05:06:37 +08:00
|
|
|
|
2014-05-20 14:30:58 +08:00
|
|
|
QLIST_INIT(&dev->gpios);
|
2020-04-06 21:52:45 +08:00
|
|
|
QLIST_INIT(&dev->clocks);
|
2011-12-23 05:06:37 +08:00
|
|
|
}
|
|
|
|
|
2018-12-02 05:23:27 +08:00
|
|
|
static void device_post_init(Object *obj)
|
|
|
|
{
|
qdev: Fix latent bug with compat_props and onboard devices
Compatibility properties started life as a qdev property thing: we
supported them only for qdev properties, and implemented them with the
machinery backing command line option -global.
Recent commit fa0cb34d221 put them to use (tacitly) with memory
backend objects (subtypes of TYPE_MEMORY_BACKEND). To make that
possible, we first moved the work of applying them from the -global
machinery into TYPE_DEVICE's .instance_post_init() method
device_post_init(), in commits ea9ce8934c5 and b66bbee39f6, then made
it available to TYPE_MEMORY_BACKEND's .instance_post_init() method
host_memory_backend_post_init() as object_apply_compat_props(), in
commit 1c3994f6d2a.
Note the code smell: we now have function name starting with object_
in hw/core/qdev.c. It has to be there rather than in qom/, because it
calls qdev_get_machine() to find the current accelerator's and
machine's compat_props.
Turns out calling qdev_get_machine() there is problematic. If we
qdev_create() from a machine's .instance_init() method, we call
device_post_init() and thus qdev_get_machine() before main() can
create "/machine" in QOM. qdev_get_machine() tries to get it with
container_get(), which "helpfully" creates it as "container" object,
and returns that. object_apply_compat_props() tries to paper over the
problem by doing nothing when the value of qdev_get_machine() isn't a
TYPE_MACHINE. But the damage is done already: when main() later
attempts to create the real "/machine", it fails with "attempt to add
duplicate property 'machine' to object (type 'container')", and
aborts.
Since no machine .instance_init() calls qdev_create() so far, the bug
is latent. But since I want to do that, I get to fix the bug first.
Observe that object_apply_compat_props() doesn't actually need the
MachineState, only its the compat_props member of its MachineClass and
AccelClass. This permits a simple fix: register MachineClass and
AccelClass compat_props with the object_apply_compat_props() machinery
right after these classes get selected.
This is actually similar to how things worked before commits
ea9ce8934c5 and b66bbee39f6, except we now register much earlier. The
old code registered them only after the machine's .instance_init()
ran, which would've broken compatibility properties for any devices
created there.
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20190308131445.17502-2-armbru@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
2019-03-08 21:14:34 +08:00
|
|
|
/*
|
|
|
|
* Note: ordered so that the user's global properties take
|
|
|
|
* precedence.
|
|
|
|
*/
|
2018-12-02 05:23:27 +08:00
|
|
|
object_apply_compat_props(obj);
|
2015-01-20 17:04:07 +08:00
|
|
|
qdev_prop_set_globals(DEVICE(obj));
|
2013-07-11 04:08:42 +08:00
|
|
|
}
|
|
|
|
|
2011-12-23 22:38:56 +08:00
|
|
|
/* Unlink device from bus and free the structure. */
|
|
|
|
static void device_finalize(Object *obj)
|
|
|
|
{
|
2014-05-20 14:30:58 +08:00
|
|
|
NamedGPIOList *ngl, *next;
|
|
|
|
|
2011-12-23 22:38:56 +08:00
|
|
|
DeviceState *dev = DEVICE(obj);
|
2014-05-20 14:30:58 +08:00
|
|
|
|
|
|
|
QLIST_FOREACH_SAFE(ngl, &dev->gpios, node, next) {
|
|
|
|
QLIST_REMOVE(ngl, node);
|
2014-06-18 15:56:31 +08:00
|
|
|
qemu_free_irqs(ngl->in, ngl->num_in);
|
2014-05-20 14:30:58 +08:00
|
|
|
g_free(ngl->name);
|
|
|
|
g_free(ngl);
|
|
|
|
/* ngl->out irqs are owned by the other end and should not be freed
|
|
|
|
* here
|
|
|
|
*/
|
|
|
|
}
|
qdev: defer DEVICE_DEL event until instance_finalize()
DEVICE_DEL is currently emitted when a Device is unparented, as
opposed to when it is finalized. The main design motivation for this
seems to be that after unparent()/unrealize(), the Device is no
longer visible to the guest, and thus the operation is complete
from the perspective of management.
However, there are cases where remaining host-side cleanup is also
pertinent to management. The is generally handled by treating these
resources as aspects of the "backend", which can be managed via
separate interfaces/events, such as blockdev_add/del, netdev_add/del,
object_add/del, etc, but some devices do not have this level of
compartmentalization, namely vfio-pci, and possibly to lend themselves
well to it.
In the case of vfio-pci, the "backend" cleanup happens as part of
the finalization of the vfio-pci device itself, in particular the
cleanup of the VFIO group FD. Failing to wait for this cleanup can
result in tools like libvirt attempting to rebind the device to
the host while it's still being used by VFIO, which can result in
host crashes or other misbehavior depending on the host driver.
Deferring DEVICE_DEL still affords us the ability to manage backends
explicitly, while also addressing cases like vfio-pci's, so we
implement that approach here.
An alternative proposal involving having VFIO emit a separate event
to denote completion of host-side cleanup was discussed, but the
prevailing opinion seems to be that it is not worth the added
complexity, and leaves the issue open for other Device implementations
to solve in the future.
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Tested-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <20171016222315.407-4-mdroth@linux.vnet.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2017-10-17 06:23:15 +08:00
|
|
|
|
2020-04-06 21:52:45 +08:00
|
|
|
qdev_finalize_clocklist(dev);
|
|
|
|
|
qdev: defer DEVICE_DEL event until instance_finalize()
DEVICE_DEL is currently emitted when a Device is unparented, as
opposed to when it is finalized. The main design motivation for this
seems to be that after unparent()/unrealize(), the Device is no
longer visible to the guest, and thus the operation is complete
from the perspective of management.
However, there are cases where remaining host-side cleanup is also
pertinent to management. The is generally handled by treating these
resources as aspects of the "backend", which can be managed via
separate interfaces/events, such as blockdev_add/del, netdev_add/del,
object_add/del, etc, but some devices do not have this level of
compartmentalization, namely vfio-pci, and possibly to lend themselves
well to it.
In the case of vfio-pci, the "backend" cleanup happens as part of
the finalization of the vfio-pci device itself, in particular the
cleanup of the VFIO group FD. Failing to wait for this cleanup can
result in tools like libvirt attempting to rebind the device to
the host while it's still being used by VFIO, which can result in
host crashes or other misbehavior depending on the host driver.
Deferring DEVICE_DEL still affords us the ability to manage backends
explicitly, while also addressing cases like vfio-pci's, so we
implement that approach here.
An alternative proposal involving having VFIO emit a separate event
to denote completion of host-side cleanup was discussed, but the
prevailing opinion seems to be that it is not worth the added
complexity, and leaves the issue open for other Device implementations
to solve in the future.
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Tested-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <20171016222315.407-4-mdroth@linux.vnet.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2017-10-17 06:23:15 +08:00
|
|
|
/* Only send event if the device had been completely realized */
|
|
|
|
if (dev->pending_deleted_event) {
|
|
|
|
g_assert(dev->canonical_path);
|
|
|
|
|
2018-08-15 21:37:37 +08:00
|
|
|
qapi_event_send_device_deleted(!!dev->id, dev->id, dev->canonical_path);
|
qdev: defer DEVICE_DEL event until instance_finalize()
DEVICE_DEL is currently emitted when a Device is unparented, as
opposed to when it is finalized. The main design motivation for this
seems to be that after unparent()/unrealize(), the Device is no
longer visible to the guest, and thus the operation is complete
from the perspective of management.
However, there are cases where remaining host-side cleanup is also
pertinent to management. The is generally handled by treating these
resources as aspects of the "backend", which can be managed via
separate interfaces/events, such as blockdev_add/del, netdev_add/del,
object_add/del, etc, but some devices do not have this level of
compartmentalization, namely vfio-pci, and possibly to lend themselves
well to it.
In the case of vfio-pci, the "backend" cleanup happens as part of
the finalization of the vfio-pci device itself, in particular the
cleanup of the VFIO group FD. Failing to wait for this cleanup can
result in tools like libvirt attempting to rebind the device to
the host while it's still being used by VFIO, which can result in
host crashes or other misbehavior depending on the host driver.
Deferring DEVICE_DEL still affords us the ability to manage backends
explicitly, while also addressing cases like vfio-pci's, so we
implement that approach here.
An alternative proposal involving having VFIO emit a separate event
to denote completion of host-side cleanup was discussed, but the
prevailing opinion seems to be that it is not worth the added
complexity, and leaves the issue open for other Device implementations
to solve in the future.
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Tested-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <20171016222315.407-4-mdroth@linux.vnet.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2017-10-17 06:23:15 +08:00
|
|
|
g_free(dev->canonical_path);
|
|
|
|
dev->canonical_path = NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
qemu_opts_del(dev->opts);
|
2011-12-23 22:38:56 +08:00
|
|
|
}
|
|
|
|
|
2012-03-29 00:12:47 +08:00
|
|
|
static void device_class_base_init(ObjectClass *class, void *data)
|
|
|
|
{
|
|
|
|
DeviceClass *klass = DEVICE_CLASS(class);
|
|
|
|
|
|
|
|
/* We explicitly look up properties in the superclasses,
|
|
|
|
* so do not propagate them to the subclasses.
|
|
|
|
*/
|
2020-01-23 19:11:38 +08:00
|
|
|
klass->props_ = NULL;
|
2011-12-23 22:38:56 +08:00
|
|
|
}
|
|
|
|
|
2013-01-05 01:13:00 +08:00
|
|
|
static void device_unparent(Object *obj)
|
2012-11-23 16:47:13 +08:00
|
|
|
{
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
2013-01-25 21:12:34 +08:00
|
|
|
BusState *bus;
|
2012-11-23 16:47:13 +08:00
|
|
|
|
2014-03-13 04:02:12 +08:00
|
|
|
if (dev->realized) {
|
2020-06-10 13:31:57 +08:00
|
|
|
qdev_unrealize(dev);
|
2014-03-13 04:02:12 +08:00
|
|
|
}
|
2013-01-25 21:12:34 +08:00
|
|
|
while (dev->num_child_bus) {
|
|
|
|
bus = QLIST_FIRST(&dev->child_bus);
|
2013-12-19 00:15:51 +08:00
|
|
|
object_unparent(OBJECT(bus));
|
2013-01-25 21:12:34 +08:00
|
|
|
}
|
|
|
|
if (dev->parent_bus) {
|
2013-01-05 01:13:00 +08:00
|
|
|
bus_remove_child(dev->parent_bus, dev);
|
2013-01-25 21:12:35 +08:00
|
|
|
object_unref(OBJECT(dev->parent_bus));
|
|
|
|
dev->parent_bus = NULL;
|
2013-01-05 01:13:00 +08:00
|
|
|
}
|
2012-11-23 16:47:13 +08:00
|
|
|
}
|
|
|
|
|
2019-08-28 20:00:19 +08:00
|
|
|
static char *
|
|
|
|
device_vmstate_if_get_id(VMStateIf *obj)
|
|
|
|
{
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
|
|
|
|
|
|
|
return qdev_get_dev_path(dev);
|
|
|
|
}
|
|
|
|
|
2020-01-31 00:02:04 +08:00
|
|
|
/**
|
|
|
|
* device_phases_reset:
|
|
|
|
* Transition reset method for devices to allow moving
|
|
|
|
* smoothly from legacy reset method to multi-phases
|
|
|
|
*/
|
|
|
|
static void device_phases_reset(DeviceState *dev)
|
|
|
|
{
|
|
|
|
ResettableClass *rc = RESETTABLE_GET_CLASS(dev);
|
|
|
|
|
|
|
|
if (rc->phases.enter) {
|
|
|
|
rc->phases.enter(OBJECT(dev), RESET_TYPE_COLD);
|
|
|
|
}
|
|
|
|
if (rc->phases.hold) {
|
|
|
|
rc->phases.hold(OBJECT(dev));
|
|
|
|
}
|
|
|
|
if (rc->phases.exit) {
|
|
|
|
rc->phases.exit(OBJECT(dev));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void device_transitional_reset(Object *obj)
|
|
|
|
{
|
|
|
|
DeviceClass *dc = DEVICE_GET_CLASS(obj);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This will call either @device_phases_reset (for multi-phases transitioned
|
|
|
|
* devices) or a device's specific method for not-yet transitioned devices.
|
|
|
|
* In both case, it does not reset children.
|
|
|
|
*/
|
|
|
|
if (dc->reset) {
|
|
|
|
dc->reset(DEVICE(obj));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* device_get_transitional_reset:
|
|
|
|
* check if the device's class is ready for multi-phase
|
|
|
|
*/
|
|
|
|
static ResettableTrFunction device_get_transitional_reset(Object *obj)
|
|
|
|
{
|
|
|
|
DeviceClass *dc = DEVICE_GET_CLASS(obj);
|
|
|
|
if (dc->reset != device_phases_reset) {
|
|
|
|
/*
|
|
|
|
* dc->reset has been overridden by a subclass,
|
|
|
|
* the device is not ready for multi phase yet.
|
|
|
|
*/
|
|
|
|
return device_transitional_reset;
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2012-11-23 16:47:13 +08:00
|
|
|
static void device_class_init(ObjectClass *class, void *data)
|
|
|
|
{
|
2013-01-09 10:58:11 +08:00
|
|
|
DeviceClass *dc = DEVICE_CLASS(class);
|
2019-08-28 20:00:19 +08:00
|
|
|
VMStateIfClass *vc = VMSTATE_IF_CLASS(class);
|
2020-01-31 00:02:04 +08:00
|
|
|
ResettableClass *rc = RESETTABLE_CLASS(class);
|
2013-01-09 10:58:11 +08:00
|
|
|
|
2013-01-05 01:13:00 +08:00
|
|
|
class->unparent = device_unparent;
|
2014-02-19 00:56:53 +08:00
|
|
|
|
|
|
|
/* by default all devices were considered as hotpluggable,
|
|
|
|
* so with intent to check it in generic qdev_unplug() /
|
|
|
|
* device_set_realized() functions make every device
|
|
|
|
* hotpluggable. Devices that shouldn't be hotpluggable,
|
|
|
|
* should override it in their class_init()
|
|
|
|
*/
|
|
|
|
dc->hotpluggable = true;
|
2017-05-04 04:35:44 +08:00
|
|
|
dc->user_creatable = true;
|
2019-08-28 20:00:19 +08:00
|
|
|
vc->get_id = device_vmstate_if_get_id;
|
2020-01-31 00:02:04 +08:00
|
|
|
rc->get_state = device_get_reset_state;
|
|
|
|
rc->child_foreach = device_reset_child_foreach;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* @device_phases_reset is put as the default reset method below, allowing
|
|
|
|
* to do the multi-phase transition from base classes to leaf classes. It
|
|
|
|
* allows a legacy-reset Device class to extend a multi-phases-reset
|
|
|
|
* Device class for the following reason:
|
|
|
|
* + If a base class B has been moved to multi-phase, then it does not
|
|
|
|
* override this default reset method and may have defined phase methods.
|
|
|
|
* + A child class C (extending class B) which uses
|
|
|
|
* device_class_set_parent_reset() (or similar means) to override the
|
|
|
|
* reset method will still work as expected. @device_phases_reset function
|
|
|
|
* will be registered as the parent reset method and effectively call
|
|
|
|
* parent reset phases.
|
|
|
|
*/
|
|
|
|
dc->reset = device_phases_reset;
|
|
|
|
rc->get_transitional_function = device_get_transitional_reset;
|
2020-01-10 23:30:33 +08:00
|
|
|
|
|
|
|
object_class_property_add_bool(class, "realized",
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
device_get_realized, device_set_realized);
|
2020-01-10 23:30:33 +08:00
|
|
|
object_class_property_add_bool(class, "hotpluggable",
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
device_get_hotpluggable, NULL);
|
2020-01-10 23:30:33 +08:00
|
|
|
object_class_property_add_bool(class, "hotplugged",
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
device_get_hotplugged, NULL);
|
2020-01-10 23:30:33 +08:00
|
|
|
object_class_property_add_link(class, "parent_bus", TYPE_BUS,
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
offsetof(DeviceState, parent_bus), NULL, 0);
|
2012-11-23 16:47:13 +08:00
|
|
|
}
|
|
|
|
|
2020-01-10 23:30:32 +08:00
|
|
|
void device_class_set_props(DeviceClass *dc, Property *props)
|
|
|
|
{
|
2020-01-10 23:30:34 +08:00
|
|
|
Property *prop;
|
|
|
|
|
2020-01-23 19:11:38 +08:00
|
|
|
dc->props_ = props;
|
2020-01-10 23:30:34 +08:00
|
|
|
for (prop = props; prop && prop->name; prop++) {
|
|
|
|
qdev_class_add_legacy_property(dc, prop);
|
|
|
|
qdev_class_add_property(dc, prop);
|
|
|
|
}
|
2020-01-10 23:30:32 +08:00
|
|
|
}
|
|
|
|
|
2018-01-14 10:04:11 +08:00
|
|
|
void device_class_set_parent_reset(DeviceClass *dc,
|
|
|
|
DeviceReset dev_reset,
|
|
|
|
DeviceReset *parent_reset)
|
|
|
|
{
|
|
|
|
*parent_reset = dc->reset;
|
|
|
|
dc->reset = dev_reset;
|
|
|
|
}
|
|
|
|
|
|
|
|
void device_class_set_parent_realize(DeviceClass *dc,
|
|
|
|
DeviceRealize dev_realize,
|
|
|
|
DeviceRealize *parent_realize)
|
|
|
|
{
|
|
|
|
*parent_realize = dc->realize;
|
|
|
|
dc->realize = dev_realize;
|
|
|
|
}
|
|
|
|
|
|
|
|
void device_class_set_parent_unrealize(DeviceClass *dc,
|
|
|
|
DeviceUnrealize dev_unrealize,
|
|
|
|
DeviceUnrealize *parent_unrealize)
|
|
|
|
{
|
|
|
|
*parent_unrealize = dc->unrealize;
|
|
|
|
dc->unrealize = dev_unrealize;
|
|
|
|
}
|
|
|
|
|
2020-01-31 00:02:03 +08:00
|
|
|
void device_legacy_reset(DeviceState *dev)
|
2011-12-05 01:36:01 +08:00
|
|
|
{
|
|
|
|
DeviceClass *klass = DEVICE_GET_CLASS(dev);
|
|
|
|
|
2020-01-31 00:02:03 +08:00
|
|
|
trace_qdev_reset(dev, object_get_typename(OBJECT(dev)));
|
2011-12-05 01:36:01 +08:00
|
|
|
if (klass->reset) {
|
|
|
|
klass->reset(dev);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-03-28 22:34:12 +08:00
|
|
|
Object *qdev_get_machine(void)
|
|
|
|
{
|
|
|
|
static Object *dev;
|
|
|
|
|
|
|
|
if (dev == NULL) {
|
2012-04-05 19:21:46 +08:00
|
|
|
dev = container_get(object_get_root(), "/machine");
|
2012-03-28 22:34:12 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return dev;
|
|
|
|
}
|
|
|
|
|
2013-01-10 23:19:07 +08:00
|
|
|
static const TypeInfo device_type_info = {
|
2011-12-17 04:34:46 +08:00
|
|
|
.name = TYPE_DEVICE,
|
|
|
|
.parent = TYPE_OBJECT,
|
|
|
|
.instance_size = sizeof(DeviceState),
|
2011-12-23 05:06:37 +08:00
|
|
|
.instance_init = device_initfn,
|
2013-07-11 04:08:42 +08:00
|
|
|
.instance_post_init = device_post_init,
|
2011-12-23 22:38:56 +08:00
|
|
|
.instance_finalize = device_finalize,
|
2012-03-29 00:12:47 +08:00
|
|
|
.class_base_init = device_class_base_init,
|
2012-11-23 16:47:13 +08:00
|
|
|
.class_init = device_class_init,
|
2011-12-17 04:34:46 +08:00
|
|
|
.abstract = true,
|
|
|
|
.class_size = sizeof(DeviceClass),
|
2019-08-28 20:00:19 +08:00
|
|
|
.interfaces = (InterfaceInfo[]) {
|
|
|
|
{ TYPE_VMSTATE_IF },
|
2020-01-31 00:02:04 +08:00
|
|
|
{ TYPE_RESETTABLE_INTERFACE },
|
2019-08-28 20:00:19 +08:00
|
|
|
{ }
|
|
|
|
}
|
2011-12-17 04:34:46 +08:00
|
|
|
};
|
|
|
|
|
2012-02-09 22:20:55 +08:00
|
|
|
static void qdev_register_types(void)
|
2011-12-17 04:34:46 +08:00
|
|
|
{
|
|
|
|
type_register_static(&device_type_info);
|
|
|
|
}
|
|
|
|
|
2012-02-09 22:20:55 +08:00
|
|
|
type_init(qdev_register_types)
|