2010-06-03 00:48:27 +08:00
|
|
|
/*
|
|
|
|
* QEMU host block devices
|
|
|
|
*
|
|
|
|
* Copyright (c) 2003-2008 Fabrice Bellard
|
|
|
|
*
|
|
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or
|
|
|
|
* later. See the COPYING file in the top-level directory.
|
2013-03-14 20:59:53 +08:00
|
|
|
*
|
|
|
|
* This file incorporates work covered by the following copyright and
|
|
|
|
* permission notice:
|
|
|
|
*
|
|
|
|
* Copyright (c) 2003-2008 Fabrice Bellard
|
|
|
|
*
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
|
|
* in the Software without restriction, including without limitation the rights
|
|
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
|
|
* furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice shall be included in
|
|
|
|
* all copies or substantial portions of the Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
|
|
* THE SOFTWARE.
|
2010-06-03 00:48:27 +08:00
|
|
|
*/
|
|
|
|
|
block: New BlockBackend
A block device consists of a frontend device model and a backend.
A block backend has a tree of block drivers doing the actual work.
The tree is managed by the block layer.
We currently use a single abstraction BlockDriverState both for tree
nodes and the backend as a whole. Drawbacks:
* Its API includes both stuff that makes sense only at the block
backend level (root of the tree) and stuff that's only for use
within the block layer. This makes the API bigger and more complex
than necessary. Moreover, it's not obvious which interfaces are
meant for device models, and which really aren't.
* Since device models keep a reference to their backend, the backend
object can't just be destroyed. But for media change, we need to
replace the tree. Our solution is to make the BlockDriverState
generic, with actual driver state in a separate object, pointed to
by member opaque. That lets us replace the tree by deinitializing
and reinitializing its root. This special need of the root makes
the data structure awkward everywhere in the tree.
The general plan is to separate the APIs into "block backend", for use
by device models, monitor and whatever other code dealing with block
backends, and "block driver", for use by the block layer and whatever
other code (if any) dealing with trees and tree nodes.
Code dealing with block backends, device models in particular, should
become completely oblivious of BlockDriverState. This should let us
clean up both APIs, and the tree data structures.
This commit is a first step. It creates a minimal "block backend"
API: type BlockBackend and functions to create, destroy and find them.
BlockBackend objects are created and destroyed exactly when root
BlockDriverState objects are created and destroyed. "Root" in the
sense of "in bdrv_states". They're not yet used for anything; that'll
come shortly.
A root BlockDriverState is created with bdrv_new_root(), so where to
create a BlockBackend is obvious. Where these roots get destroyed
isn't always as obvious.
It is obvious in qemu-img.c, qemu-io.c and qemu-nbd.c, and in error
paths of blockdev_init(), blk_connect(). That leaves destruction of
objects successfully created by blockdev_init() and blk_connect().
blockdev_init() is used only by drive_new() and qmp_blockdev_add().
Objects created by the latter are currently indestructible (see commit
48f364d "blockdev: Refuse to drive_del something added with
blockdev-add" and commit 2d246f0 "blockdev: Introduce
DriveInfo.enable_auto_del"). Objects created by the former get
destroyed by drive_del().
Objects created by blk_connect() get destroyed by blk_disconnect().
BlockBackend is reference-counted. Its reference count never exceeds
one so far, but that's going to change.
In drive_del(), the BB's reference count is surely one now. The BDS's
reference count is greater than one when something else is holding a
reference, such as a block job. In this case, the BB is destroyed
right away, but the BDS lives on until all extra references get
dropped.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-10-07 19:59:04 +08:00
|
|
|
#include "sysemu/block-backend.h"
|
2012-12-18 01:20:04 +08:00
|
|
|
#include "sysemu/blockdev.h"
|
2013-02-06 00:06:20 +08:00
|
|
|
#include "hw/block/block.h"
|
2012-12-18 01:19:44 +08:00
|
|
|
#include "block/blockjob.h"
|
2012-12-18 01:19:49 +08:00
|
|
|
#include "monitor/monitor.h"
|
2012-12-18 01:20:00 +08:00
|
|
|
#include "qemu/option.h"
|
|
|
|
#include "qemu/config-file.h"
|
2012-12-18 01:19:43 +08:00
|
|
|
#include "qapi/qmp/types.h"
|
2013-09-23 21:26:03 +08:00
|
|
|
#include "qapi-visit.h"
|
|
|
|
#include "qapi/qmp-output-visitor.h"
|
2014-08-14 01:20:17 +08:00
|
|
|
#include "qapi/util.h"
|
2012-12-18 01:20:04 +08:00
|
|
|
#include "sysemu/sysemu.h"
|
2012-12-18 01:19:44 +08:00
|
|
|
#include "block/block_int.h"
|
2011-11-23 23:28:21 +08:00
|
|
|
#include "qmp-commands.h"
|
2012-01-18 22:40:46 +08:00
|
|
|
#include "trace.h"
|
2012-12-18 01:20:04 +08:00
|
|
|
#include "sysemu/arch_init.h"
|
2010-06-03 00:48:27 +08:00
|
|
|
|
2011-01-28 18:21:39 +08:00
|
|
|
static const char *const if_name[IF_COUNT] = {
|
|
|
|
[IF_NONE] = "none",
|
|
|
|
[IF_IDE] = "ide",
|
|
|
|
[IF_SCSI] = "scsi",
|
|
|
|
[IF_FLOPPY] = "floppy",
|
|
|
|
[IF_PFLASH] = "pflash",
|
|
|
|
[IF_MTD] = "mtd",
|
|
|
|
[IF_SD] = "sd",
|
|
|
|
[IF_VIRTIO] = "virtio",
|
|
|
|
[IF_XEN] = "xen",
|
|
|
|
};
|
|
|
|
|
2014-10-02 02:19:25 +08:00
|
|
|
static int if_max_devs[IF_COUNT] = {
|
2011-01-28 18:21:40 +08:00
|
|
|
/*
|
|
|
|
* Do not change these numbers! They govern how drive option
|
|
|
|
* index maps to unit and bus. That mapping is ABI.
|
|
|
|
*
|
|
|
|
* All controllers used to imlement if=T drives need to support
|
|
|
|
* if_max_devs[T] units, for any T with if_max_devs[T] != 0.
|
|
|
|
* Otherwise, some index values map to "impossible" bus, unit
|
|
|
|
* values.
|
|
|
|
*
|
|
|
|
* For instance, if you change [IF_SCSI] to 255, -drive
|
|
|
|
* if=scsi,index=12 no longer means bus=1,unit=5, but
|
|
|
|
* bus=0,unit=12. With an lsi53c895a controller (7 units max),
|
|
|
|
* the drive can't be set up. Regression.
|
|
|
|
*/
|
|
|
|
[IF_IDE] = 2,
|
|
|
|
[IF_SCSI] = 7,
|
2011-01-28 18:21:39 +08:00
|
|
|
};
|
|
|
|
|
2014-10-02 02:19:25 +08:00
|
|
|
/**
|
|
|
|
* Boards may call this to offer board-by-board overrides
|
|
|
|
* of the default, global values.
|
|
|
|
*/
|
|
|
|
void override_max_devs(BlockInterfaceType type, int max_devs)
|
|
|
|
{
|
2014-10-07 19:59:06 +08:00
|
|
|
BlockBackend *blk;
|
2014-10-02 02:19:25 +08:00
|
|
|
DriveInfo *dinfo;
|
|
|
|
|
|
|
|
if (max_devs <= 0) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2014-10-07 19:59:06 +08:00
|
|
|
for (blk = blk_next(NULL); blk; blk = blk_next(blk)) {
|
|
|
|
dinfo = blk_legacy_dinfo(blk);
|
2014-10-02 02:19:25 +08:00
|
|
|
if (dinfo->type == type) {
|
|
|
|
fprintf(stderr, "Cannot override units-per-bus property of"
|
|
|
|
" the %s interface, because a drive of that type has"
|
|
|
|
" already been added.\n", if_name[type]);
|
|
|
|
g_assert_not_reached();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if_max_devs[type] = max_devs;
|
|
|
|
}
|
|
|
|
|
2010-06-25 14:09:10 +08:00
|
|
|
/*
|
|
|
|
* We automatically delete the drive when a device using it gets
|
|
|
|
* unplugged. Questionable feature, but we can't just drop it.
|
|
|
|
* Device models call blockdev_mark_auto_del() to schedule the
|
|
|
|
* automatic deletion, and generic qdev code calls blockdev_auto_del()
|
|
|
|
* when deletion is actually safe.
|
|
|
|
*/
|
2014-10-07 19:59:18 +08:00
|
|
|
void blockdev_mark_auto_del(BlockBackend *blk)
|
2010-06-25 14:09:10 +08:00
|
|
|
{
|
2014-10-07 19:59:06 +08:00
|
|
|
DriveInfo *dinfo = blk_legacy_dinfo(blk);
|
2014-10-07 19:59:18 +08:00
|
|
|
BlockDriverState *bs = blk_bs(blk);
|
2014-10-21 19:03:52 +08:00
|
|
|
AioContext *aio_context;
|
2010-06-25 14:09:10 +08:00
|
|
|
|
2014-10-07 19:59:22 +08:00
|
|
|
if (!dinfo) {
|
2013-09-18 21:14:47 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2014-10-21 19:03:52 +08:00
|
|
|
aio_context = bdrv_get_aio_context(bs);
|
|
|
|
aio_context_acquire(aio_context);
|
|
|
|
|
2012-03-30 19:17:10 +08:00
|
|
|
if (bs->job) {
|
|
|
|
block_job_cancel(bs->job);
|
|
|
|
}
|
2014-10-21 19:03:52 +08:00
|
|
|
|
|
|
|
aio_context_release(aio_context);
|
|
|
|
|
2014-10-07 19:59:22 +08:00
|
|
|
dinfo->auto_del = 1;
|
2010-06-25 14:09:10 +08:00
|
|
|
}
|
|
|
|
|
2014-10-07 19:59:18 +08:00
|
|
|
void blockdev_auto_del(BlockBackend *blk)
|
2010-06-25 14:09:10 +08:00
|
|
|
{
|
2014-10-07 19:59:06 +08:00
|
|
|
DriveInfo *dinfo = blk_legacy_dinfo(blk);
|
2010-06-25 14:09:10 +08:00
|
|
|
|
2010-12-09 00:05:00 +08:00
|
|
|
if (dinfo && dinfo->auto_del) {
|
2014-10-07 19:59:09 +08:00
|
|
|
blk_unref(blk);
|
2010-06-25 14:09:10 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-10-02 02:19:27 +08:00
|
|
|
/**
|
|
|
|
* Returns the current mapping of how many units per bus
|
|
|
|
* a particular interface can support.
|
|
|
|
*
|
|
|
|
* A positive integer indicates n units per bus.
|
|
|
|
* 0 implies the mapping has not been established.
|
|
|
|
* -1 indicates an invalid BlockInterfaceType was given.
|
|
|
|
*/
|
|
|
|
int drive_get_max_devs(BlockInterfaceType type)
|
|
|
|
{
|
|
|
|
if (type >= IF_IDE && type < IF_COUNT) {
|
|
|
|
return if_max_devs[type];
|
|
|
|
}
|
|
|
|
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2011-01-28 18:21:43 +08:00
|
|
|
static int drive_index_to_bus_id(BlockInterfaceType type, int index)
|
|
|
|
{
|
|
|
|
int max_devs = if_max_devs[type];
|
|
|
|
return max_devs ? index / max_devs : 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int drive_index_to_unit_id(BlockInterfaceType type, int index)
|
|
|
|
{
|
|
|
|
int max_devs = if_max_devs[type];
|
|
|
|
return max_devs ? index % max_devs : index;
|
|
|
|
}
|
|
|
|
|
2011-01-28 18:21:41 +08:00
|
|
|
QemuOpts *drive_def(const char *optstr)
|
|
|
|
{
|
|
|
|
return qemu_opts_parse(qemu_find_opts("drive"), optstr, 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
QemuOpts *drive_add(BlockInterfaceType type, int index, const char *file,
|
2011-01-31 18:50:09 +08:00
|
|
|
const char *optstr)
|
2010-06-03 00:48:27 +08:00
|
|
|
{
|
|
|
|
QemuOpts *opts;
|
2011-01-28 18:21:41 +08:00
|
|
|
char buf[32];
|
2010-06-03 00:48:27 +08:00
|
|
|
|
2011-01-28 18:21:41 +08:00
|
|
|
opts = drive_def(optstr);
|
2010-06-03 00:48:27 +08:00
|
|
|
if (!opts) {
|
|
|
|
return NULL;
|
|
|
|
}
|
2011-01-28 18:21:41 +08:00
|
|
|
if (type != IF_DEFAULT) {
|
|
|
|
qemu_opt_set(opts, "if", if_name[type]);
|
|
|
|
}
|
|
|
|
if (index >= 0) {
|
|
|
|
snprintf(buf, sizeof(buf), "%d", index);
|
|
|
|
qemu_opt_set(opts, "index", buf);
|
|
|
|
}
|
2010-06-03 00:48:27 +08:00
|
|
|
if (file)
|
|
|
|
qemu_opt_set(opts, "file", file);
|
|
|
|
return opts;
|
|
|
|
}
|
|
|
|
|
|
|
|
DriveInfo *drive_get(BlockInterfaceType type, int bus, int unit)
|
|
|
|
{
|
2014-10-07 19:59:06 +08:00
|
|
|
BlockBackend *blk;
|
2010-06-03 00:48:27 +08:00
|
|
|
DriveInfo *dinfo;
|
|
|
|
|
2014-10-07 19:59:06 +08:00
|
|
|
for (blk = blk_next(NULL); blk; blk = blk_next(blk)) {
|
|
|
|
dinfo = blk_legacy_dinfo(blk);
|
|
|
|
if (dinfo && dinfo->type == type
|
|
|
|
&& dinfo->bus == bus && dinfo->unit == unit) {
|
2010-06-03 00:48:27 +08:00
|
|
|
return dinfo;
|
2014-10-07 19:59:06 +08:00
|
|
|
}
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2014-10-02 02:19:24 +08:00
|
|
|
bool drive_check_orphaned(void)
|
|
|
|
{
|
2014-10-07 19:59:06 +08:00
|
|
|
BlockBackend *blk;
|
2014-10-02 02:19:24 +08:00
|
|
|
DriveInfo *dinfo;
|
|
|
|
bool rs = false;
|
|
|
|
|
2014-10-07 19:59:06 +08:00
|
|
|
for (blk = blk_next(NULL); blk; blk = blk_next(blk)) {
|
|
|
|
dinfo = blk_legacy_dinfo(blk);
|
2014-10-02 02:19:24 +08:00
|
|
|
/* If dinfo->bdrv->dev is NULL, it has no device attached. */
|
|
|
|
/* Unless this is a default drive, this may be an oversight. */
|
2014-10-07 19:59:25 +08:00
|
|
|
if (!blk_get_attached_dev(blk) && !dinfo->is_default &&
|
2014-10-02 02:19:24 +08:00
|
|
|
dinfo->type != IF_NONE) {
|
|
|
|
fprintf(stderr, "Warning: Orphaned drive without device: "
|
|
|
|
"id=%s,file=%s,if=%s,bus=%d,unit=%d\n",
|
2014-10-07 19:59:21 +08:00
|
|
|
blk_name(blk), blk_bs(blk)->filename, if_name[dinfo->type],
|
2014-10-02 02:19:24 +08:00
|
|
|
dinfo->bus, dinfo->unit);
|
|
|
|
rs = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return rs;
|
|
|
|
}
|
|
|
|
|
2011-01-28 18:21:44 +08:00
|
|
|
DriveInfo *drive_get_by_index(BlockInterfaceType type, int index)
|
|
|
|
{
|
|
|
|
return drive_get(type,
|
|
|
|
drive_index_to_bus_id(type, index),
|
|
|
|
drive_index_to_unit_id(type, index));
|
|
|
|
}
|
|
|
|
|
2010-06-03 00:48:27 +08:00
|
|
|
int drive_get_max_bus(BlockInterfaceType type)
|
|
|
|
{
|
|
|
|
int max_bus;
|
2014-10-07 19:59:06 +08:00
|
|
|
BlockBackend *blk;
|
2010-06-03 00:48:27 +08:00
|
|
|
DriveInfo *dinfo;
|
|
|
|
|
|
|
|
max_bus = -1;
|
2014-10-07 19:59:06 +08:00
|
|
|
for (blk = blk_next(NULL); blk; blk = blk_next(blk)) {
|
|
|
|
dinfo = blk_legacy_dinfo(blk);
|
|
|
|
if (dinfo && dinfo->type == type && dinfo->bus > max_bus) {
|
2010-06-03 00:48:27 +08:00
|
|
|
max_bus = dinfo->bus;
|
2014-10-07 19:59:06 +08:00
|
|
|
}
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
|
|
|
return max_bus;
|
|
|
|
}
|
|
|
|
|
2011-01-28 18:21:37 +08:00
|
|
|
/* Get a block device. This should only be used for single-drive devices
|
|
|
|
(e.g. SD/Floppy/MTD). Multi-disk devices (scsi/ide) should use the
|
|
|
|
appropriate bus. */
|
|
|
|
DriveInfo *drive_get_next(BlockInterfaceType type)
|
|
|
|
{
|
|
|
|
static int next_block_unit[IF_COUNT];
|
|
|
|
|
|
|
|
return drive_get(type, 0, next_block_unit[type]++);
|
|
|
|
}
|
|
|
|
|
2010-06-03 00:48:27 +08:00
|
|
|
static void bdrv_format_print(void *opaque, const char *name)
|
|
|
|
{
|
2011-01-18 02:31:27 +08:00
|
|
|
error_printf(" %s", name);
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
|
|
|
|
2012-01-18 22:40:50 +08:00
|
|
|
typedef struct {
|
|
|
|
QEMUBH *bh;
|
2013-08-23 09:14:51 +08:00
|
|
|
BlockDriverState *bs;
|
|
|
|
} BDRVPutRefBH;
|
2012-01-18 22:40:50 +08:00
|
|
|
|
2013-08-23 09:14:51 +08:00
|
|
|
static void bdrv_put_ref_bh(void *opaque)
|
2012-01-18 22:40:50 +08:00
|
|
|
{
|
2013-08-23 09:14:51 +08:00
|
|
|
BDRVPutRefBH *s = opaque;
|
2012-01-18 22:40:50 +08:00
|
|
|
|
2013-08-23 09:14:51 +08:00
|
|
|
bdrv_unref(s->bs);
|
2012-01-18 22:40:50 +08:00
|
|
|
qemu_bh_delete(s->bh);
|
|
|
|
g_free(s);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2013-08-23 09:14:51 +08:00
|
|
|
* Release a BDS reference in a BH
|
2012-01-18 22:40:50 +08:00
|
|
|
*
|
2013-08-23 09:14:51 +08:00
|
|
|
* It is not safe to use bdrv_unref() from a callback function when the callers
|
|
|
|
* still need the BlockDriverState. In such cases we schedule a BH to release
|
|
|
|
* the reference.
|
2012-01-18 22:40:50 +08:00
|
|
|
*/
|
2013-08-23 09:14:51 +08:00
|
|
|
static void bdrv_put_ref_bh_schedule(BlockDriverState *bs)
|
2012-01-18 22:40:50 +08:00
|
|
|
{
|
2013-08-23 09:14:51 +08:00
|
|
|
BDRVPutRefBH *s;
|
2012-01-18 22:40:50 +08:00
|
|
|
|
2013-08-23 09:14:51 +08:00
|
|
|
s = g_new(BDRVPutRefBH, 1);
|
|
|
|
s->bh = qemu_bh_new(bdrv_put_ref_bh, s);
|
|
|
|
s->bs = bs;
|
2012-01-18 22:40:50 +08:00
|
|
|
qemu_bh_schedule(s->bh);
|
|
|
|
}
|
|
|
|
|
2013-09-20 17:33:11 +08:00
|
|
|
static int parse_block_error_action(const char *buf, bool is_read, Error **errp)
|
2010-06-03 00:48:27 +08:00
|
|
|
{
|
|
|
|
if (!strcmp(buf, "ignore")) {
|
2012-09-28 23:22:55 +08:00
|
|
|
return BLOCKDEV_ON_ERROR_IGNORE;
|
2010-06-03 00:48:27 +08:00
|
|
|
} else if (!is_read && !strcmp(buf, "enospc")) {
|
2012-09-28 23:22:55 +08:00
|
|
|
return BLOCKDEV_ON_ERROR_ENOSPC;
|
2010-06-03 00:48:27 +08:00
|
|
|
} else if (!strcmp(buf, "stop")) {
|
2012-09-28 23:22:55 +08:00
|
|
|
return BLOCKDEV_ON_ERROR_STOP;
|
2010-06-03 00:48:27 +08:00
|
|
|
} else if (!strcmp(buf, "report")) {
|
2012-09-28 23:22:55 +08:00
|
|
|
return BLOCKDEV_ON_ERROR_REPORT;
|
2010-06-03 00:48:27 +08:00
|
|
|
} else {
|
2013-09-20 17:33:11 +08:00
|
|
|
error_setg(errp, "'%s' invalid %s error action",
|
|
|
|
buf, is_read ? "read" : "write");
|
2010-06-03 00:48:27 +08:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-09-02 20:14:39 +08:00
|
|
|
static bool check_throttle_config(ThrottleConfig *cfg, Error **errp)
|
2011-11-03 16:57:25 +08:00
|
|
|
{
|
2013-09-02 20:14:39 +08:00
|
|
|
if (throttle_conflicting(cfg)) {
|
|
|
|
error_setg(errp, "bps/iops/max total values and read/write values"
|
|
|
|
" cannot be used at the same time");
|
2011-11-03 16:57:25 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2013-09-02 20:14:39 +08:00
|
|
|
if (!throttle_is_valid(cfg)) {
|
|
|
|
error_setg(errp, "bps/iops/maxs values must be 0 or greater");
|
2013-02-13 23:53:43 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2011-11-03 16:57:25 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2013-08-28 23:00:13 +08:00
|
|
|
typedef enum { MEDIA_DISK, MEDIA_CDROM } DriveMediaType;
|
|
|
|
|
2013-09-10 18:01:20 +08:00
|
|
|
/* Takes the ownership of bs_opts */
|
2014-10-07 19:59:06 +08:00
|
|
|
static BlockBackend *blockdev_init(const char *file, QDict *bs_opts,
|
|
|
|
Error **errp)
|
2010-06-03 00:48:27 +08:00
|
|
|
{
|
|
|
|
const char *buf;
|
|
|
|
int ro = 0;
|
|
|
|
int bdrv_flags = 0;
|
|
|
|
int on_read_error, on_write_error;
|
block: New BlockBackend
A block device consists of a frontend device model and a backend.
A block backend has a tree of block drivers doing the actual work.
The tree is managed by the block layer.
We currently use a single abstraction BlockDriverState both for tree
nodes and the backend as a whole. Drawbacks:
* Its API includes both stuff that makes sense only at the block
backend level (root of the tree) and stuff that's only for use
within the block layer. This makes the API bigger and more complex
than necessary. Moreover, it's not obvious which interfaces are
meant for device models, and which really aren't.
* Since device models keep a reference to their backend, the backend
object can't just be destroyed. But for media change, we need to
replace the tree. Our solution is to make the BlockDriverState
generic, with actual driver state in a separate object, pointed to
by member opaque. That lets us replace the tree by deinitializing
and reinitializing its root. This special need of the root makes
the data structure awkward everywhere in the tree.
The general plan is to separate the APIs into "block backend", for use
by device models, monitor and whatever other code dealing with block
backends, and "block driver", for use by the block layer and whatever
other code (if any) dealing with trees and tree nodes.
Code dealing with block backends, device models in particular, should
become completely oblivious of BlockDriverState. This should let us
clean up both APIs, and the tree data structures.
This commit is a first step. It creates a minimal "block backend"
API: type BlockBackend and functions to create, destroy and find them.
BlockBackend objects are created and destroyed exactly when root
BlockDriverState objects are created and destroyed. "Root" in the
sense of "in bdrv_states". They're not yet used for anything; that'll
come shortly.
A root BlockDriverState is created with bdrv_new_root(), so where to
create a BlockBackend is obvious. Where these roots get destroyed
isn't always as obvious.
It is obvious in qemu-img.c, qemu-io.c and qemu-nbd.c, and in error
paths of blockdev_init(), blk_connect(). That leaves destruction of
objects successfully created by blockdev_init() and blk_connect().
blockdev_init() is used only by drive_new() and qmp_blockdev_add().
Objects created by the latter are currently indestructible (see commit
48f364d "blockdev: Refuse to drive_del something added with
blockdev-add" and commit 2d246f0 "blockdev: Introduce
DriveInfo.enable_auto_del"). Objects created by the former get
destroyed by drive_del().
Objects created by blk_connect() get destroyed by blk_disconnect().
BlockBackend is reference-counted. Its reference count never exceeds
one so far, but that's going to change.
In drive_del(), the BB's reference count is surely one now. The BDS's
reference count is greater than one when something else is holding a
reference, such as a block job. In this case, the BB is destroyed
right away, but the BDS lives on until all extra references get
dropped.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-10-07 19:59:04 +08:00
|
|
|
BlockBackend *blk;
|
2014-09-13 03:26:21 +08:00
|
|
|
BlockDriverState *bs;
|
2013-09-02 20:14:39 +08:00
|
|
|
ThrottleConfig cfg;
|
2010-06-03 00:48:27 +08:00
|
|
|
int snapshot = 0;
|
2011-11-17 21:40:32 +08:00
|
|
|
bool copy_on_read;
|
2010-06-03 00:48:27 +08:00
|
|
|
int ret;
|
2013-02-13 23:53:42 +08:00
|
|
|
Error *error = NULL;
|
2013-03-15 17:35:07 +08:00
|
|
|
QemuOpts *opts;
|
|
|
|
const char *id;
|
2013-07-09 17:09:02 +08:00
|
|
|
bool has_driver_specific_opts;
|
2014-05-18 06:58:19 +08:00
|
|
|
BlockdevDetectZeroesOptions detect_zeroes;
|
2013-08-08 22:45:16 +08:00
|
|
|
BlockDriver *drv = NULL;
|
2010-06-03 00:48:27 +08:00
|
|
|
|
2013-09-10 18:01:20 +08:00
|
|
|
/* Check common options by copying from bs_opts to opts, all other options
|
|
|
|
* stay in bs_opts for processing by bdrv_open(). */
|
|
|
|
id = qdict_get_try_str(bs_opts, "id");
|
2013-03-15 17:35:07 +08:00
|
|
|
opts = qemu_opts_create(&qemu_common_drive_opts, id, 1, &error);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (error) {
|
2013-09-20 17:33:11 +08:00
|
|
|
error_propagate(errp, error);
|
2014-05-28 17:17:01 +08:00
|
|
|
goto err_no_opts;
|
2013-03-15 17:35:07 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
qemu_opts_absorb_qdict(opts, bs_opts, &error);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (error) {
|
2013-09-20 17:33:11 +08:00
|
|
|
error_propagate(errp, error);
|
2013-10-30 21:54:30 +08:00
|
|
|
goto early_err;
|
2013-03-15 17:35:07 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (id) {
|
|
|
|
qdict_del(bs_opts, "id");
|
|
|
|
}
|
|
|
|
|
2013-07-09 17:09:02 +08:00
|
|
|
has_driver_specific_opts = !!qdict_size(bs_opts);
|
|
|
|
|
2010-06-03 00:48:27 +08:00
|
|
|
/* extract parameters */
|
|
|
|
snapshot = qemu_opt_get_bool(opts, "snapshot", 0);
|
2013-07-20 02:07:29 +08:00
|
|
|
ro = qemu_opt_get_bool(opts, "read-only", 0);
|
2011-11-17 21:40:32 +08:00
|
|
|
copy_on_read = qemu_opt_get_bool(opts, "copy-on-read", false);
|
2010-06-03 00:48:27 +08:00
|
|
|
|
2013-02-08 21:06:12 +08:00
|
|
|
if ((buf = qemu_opt_get(opts, "discard")) != NULL) {
|
|
|
|
if (bdrv_parse_discard_flags(buf, &bdrv_flags) != 0) {
|
2013-09-20 17:33:11 +08:00
|
|
|
error_setg(errp, "invalid discard option");
|
2013-10-30 21:54:30 +08:00
|
|
|
goto early_err;
|
2013-02-08 21:06:12 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-07-18 22:31:25 +08:00
|
|
|
if (qemu_opt_get_bool(opts, "cache.writeback", true)) {
|
|
|
|
bdrv_flags |= BDRV_O_CACHE_WB;
|
|
|
|
}
|
|
|
|
if (qemu_opt_get_bool(opts, "cache.direct", false)) {
|
|
|
|
bdrv_flags |= BDRV_O_NOCACHE;
|
|
|
|
}
|
2013-09-20 00:48:53 +08:00
|
|
|
if (qemu_opt_get_bool(opts, "cache.no-flush", false)) {
|
2013-07-18 22:31:25 +08:00
|
|
|
bdrv_flags |= BDRV_O_NO_FLUSH;
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
#ifdef CONFIG_LINUX_AIO
|
|
|
|
if ((buf = qemu_opt_get(opts, "aio")) != NULL) {
|
|
|
|
if (!strcmp(buf, "native")) {
|
|
|
|
bdrv_flags |= BDRV_O_NATIVE_AIO;
|
|
|
|
} else if (!strcmp(buf, "threads")) {
|
|
|
|
/* this is the default */
|
|
|
|
} else {
|
2013-09-20 17:33:11 +08:00
|
|
|
error_setg(errp, "invalid aio option");
|
2013-10-30 21:54:30 +08:00
|
|
|
goto early_err;
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
if ((buf = qemu_opt_get(opts, "format")) != NULL) {
|
2012-08-02 20:45:54 +08:00
|
|
|
if (is_help_option(buf)) {
|
|
|
|
error_printf("Supported formats:");
|
|
|
|
bdrv_iterate_format(bdrv_format_print, NULL);
|
|
|
|
error_printf("\n");
|
2013-10-30 21:54:30 +08:00
|
|
|
goto early_err;
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
2013-07-09 17:09:02 +08:00
|
|
|
|
2013-10-10 17:45:55 +08:00
|
|
|
drv = bdrv_find_format(buf);
|
2013-08-08 22:45:16 +08:00
|
|
|
if (!drv) {
|
2013-09-20 17:33:11 +08:00
|
|
|
error_setg(errp, "'%s' invalid format", buf);
|
2013-10-30 21:54:30 +08:00
|
|
|
goto early_err;
|
2013-08-08 22:45:16 +08:00
|
|
|
}
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
|
|
|
|
2011-11-03 16:57:25 +08:00
|
|
|
/* disk I/O throttling */
|
2013-09-02 20:14:39 +08:00
|
|
|
memset(&cfg, 0, sizeof(cfg));
|
|
|
|
cfg.buckets[THROTTLE_BPS_TOTAL].avg =
|
2013-07-17 20:41:54 +08:00
|
|
|
qemu_opt_get_number(opts, "throttling.bps-total", 0);
|
2013-09-02 20:14:39 +08:00
|
|
|
cfg.buckets[THROTTLE_BPS_READ].avg =
|
2013-07-17 20:41:54 +08:00
|
|
|
qemu_opt_get_number(opts, "throttling.bps-read", 0);
|
2013-09-02 20:14:39 +08:00
|
|
|
cfg.buckets[THROTTLE_BPS_WRITE].avg =
|
2013-07-17 20:41:54 +08:00
|
|
|
qemu_opt_get_number(opts, "throttling.bps-write", 0);
|
2013-09-02 20:14:39 +08:00
|
|
|
cfg.buckets[THROTTLE_OPS_TOTAL].avg =
|
2013-07-17 20:41:54 +08:00
|
|
|
qemu_opt_get_number(opts, "throttling.iops-total", 0);
|
2013-09-02 20:14:39 +08:00
|
|
|
cfg.buckets[THROTTLE_OPS_READ].avg =
|
2013-07-17 20:41:54 +08:00
|
|
|
qemu_opt_get_number(opts, "throttling.iops-read", 0);
|
2013-09-02 20:14:39 +08:00
|
|
|
cfg.buckets[THROTTLE_OPS_WRITE].avg =
|
2013-07-17 20:41:54 +08:00
|
|
|
qemu_opt_get_number(opts, "throttling.iops-write", 0);
|
2011-11-03 16:57:25 +08:00
|
|
|
|
2013-09-02 20:14:40 +08:00
|
|
|
cfg.buckets[THROTTLE_BPS_TOTAL].max =
|
|
|
|
qemu_opt_get_number(opts, "throttling.bps-total-max", 0);
|
|
|
|
cfg.buckets[THROTTLE_BPS_READ].max =
|
|
|
|
qemu_opt_get_number(opts, "throttling.bps-read-max", 0);
|
|
|
|
cfg.buckets[THROTTLE_BPS_WRITE].max =
|
|
|
|
qemu_opt_get_number(opts, "throttling.bps-write-max", 0);
|
|
|
|
cfg.buckets[THROTTLE_OPS_TOTAL].max =
|
|
|
|
qemu_opt_get_number(opts, "throttling.iops-total-max", 0);
|
|
|
|
cfg.buckets[THROTTLE_OPS_READ].max =
|
|
|
|
qemu_opt_get_number(opts, "throttling.iops-read-max", 0);
|
|
|
|
cfg.buckets[THROTTLE_OPS_WRITE].max =
|
|
|
|
qemu_opt_get_number(opts, "throttling.iops-write-max", 0);
|
2013-09-02 20:14:39 +08:00
|
|
|
|
2013-09-02 20:14:41 +08:00
|
|
|
cfg.op_size = qemu_opt_get_number(opts, "throttling.iops-size", 0);
|
2013-09-02 20:14:39 +08:00
|
|
|
|
|
|
|
if (!check_throttle_config(&cfg, &error)) {
|
2013-09-20 17:33:11 +08:00
|
|
|
error_propagate(errp, error);
|
2013-10-30 21:54:30 +08:00
|
|
|
goto early_err;
|
2011-11-03 16:57:25 +08:00
|
|
|
}
|
|
|
|
|
2012-09-28 23:22:55 +08:00
|
|
|
on_write_error = BLOCKDEV_ON_ERROR_ENOSPC;
|
2010-06-03 00:48:27 +08:00
|
|
|
if ((buf = qemu_opt_get(opts, "werror")) != NULL) {
|
2013-09-20 17:33:11 +08:00
|
|
|
on_write_error = parse_block_error_action(buf, 0, &error);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (error) {
|
2013-09-20 17:33:11 +08:00
|
|
|
error_propagate(errp, error);
|
2013-10-30 21:54:30 +08:00
|
|
|
goto early_err;
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-09-28 23:22:55 +08:00
|
|
|
on_read_error = BLOCKDEV_ON_ERROR_REPORT;
|
2010-06-03 00:48:27 +08:00
|
|
|
if ((buf = qemu_opt_get(opts, "rerror")) != NULL) {
|
2013-09-20 17:33:11 +08:00
|
|
|
on_read_error = parse_block_error_action(buf, 1, &error);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (error) {
|
2013-09-20 17:33:11 +08:00
|
|
|
error_propagate(errp, error);
|
2013-10-30 21:54:30 +08:00
|
|
|
goto early_err;
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-05-18 06:58:19 +08:00
|
|
|
detect_zeroes =
|
2014-08-14 01:20:17 +08:00
|
|
|
qapi_enum_parse(BlockdevDetectZeroesOptions_lookup,
|
|
|
|
qemu_opt_get(opts, "detect-zeroes"),
|
|
|
|
BLOCKDEV_DETECT_ZEROES_OPTIONS_MAX,
|
|
|
|
BLOCKDEV_DETECT_ZEROES_OPTIONS_OFF,
|
|
|
|
&error);
|
2014-05-18 06:58:19 +08:00
|
|
|
if (error) {
|
|
|
|
error_propagate(errp, error);
|
|
|
|
goto early_err;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (detect_zeroes == BLOCKDEV_DETECT_ZEROES_OPTIONS_UNMAP &&
|
|
|
|
!(bdrv_flags & BDRV_O_UNMAP)) {
|
|
|
|
error_setg(errp, "setting detect-zeroes to unmap is not allowed "
|
|
|
|
"without setting discard operation to unmap");
|
|
|
|
goto early_err;
|
|
|
|
}
|
|
|
|
|
2013-07-11 18:52:34 +08:00
|
|
|
/* init */
|
2014-10-07 19:59:05 +08:00
|
|
|
blk = blk_new_with_bs(qemu_opts_id(opts), errp);
|
block: New BlockBackend
A block device consists of a frontend device model and a backend.
A block backend has a tree of block drivers doing the actual work.
The tree is managed by the block layer.
We currently use a single abstraction BlockDriverState both for tree
nodes and the backend as a whole. Drawbacks:
* Its API includes both stuff that makes sense only at the block
backend level (root of the tree) and stuff that's only for use
within the block layer. This makes the API bigger and more complex
than necessary. Moreover, it's not obvious which interfaces are
meant for device models, and which really aren't.
* Since device models keep a reference to their backend, the backend
object can't just be destroyed. But for media change, we need to
replace the tree. Our solution is to make the BlockDriverState
generic, with actual driver state in a separate object, pointed to
by member opaque. That lets us replace the tree by deinitializing
and reinitializing its root. This special need of the root makes
the data structure awkward everywhere in the tree.
The general plan is to separate the APIs into "block backend", for use
by device models, monitor and whatever other code dealing with block
backends, and "block driver", for use by the block layer and whatever
other code (if any) dealing with trees and tree nodes.
Code dealing with block backends, device models in particular, should
become completely oblivious of BlockDriverState. This should let us
clean up both APIs, and the tree data structures.
This commit is a first step. It creates a minimal "block backend"
API: type BlockBackend and functions to create, destroy and find them.
BlockBackend objects are created and destroyed exactly when root
BlockDriverState objects are created and destroyed. "Root" in the
sense of "in bdrv_states". They're not yet used for anything; that'll
come shortly.
A root BlockDriverState is created with bdrv_new_root(), so where to
create a BlockBackend is obvious. Where these roots get destroyed
isn't always as obvious.
It is obvious in qemu-img.c, qemu-io.c and qemu-nbd.c, and in error
paths of blockdev_init(), blk_connect(). That leaves destruction of
objects successfully created by blockdev_init() and blk_connect().
blockdev_init() is used only by drive_new() and qmp_blockdev_add().
Objects created by the latter are currently indestructible (see commit
48f364d "blockdev: Refuse to drive_del something added with
blockdev-add" and commit 2d246f0 "blockdev: Introduce
DriveInfo.enable_auto_del"). Objects created by the former get
destroyed by drive_del().
Objects created by blk_connect() get destroyed by blk_disconnect().
BlockBackend is reference-counted. Its reference count never exceeds
one so far, but that's going to change.
In drive_del(), the BB's reference count is surely one now. The BDS's
reference count is greater than one when something else is holding a
reference, such as a block job. In this case, the BB is destroyed
right away, but the BDS lives on until all extra references get
dropped.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-10-07 19:59:04 +08:00
|
|
|
if (!blk) {
|
|
|
|
goto early_err;
|
|
|
|
}
|
2014-10-07 19:59:05 +08:00
|
|
|
bs = blk_bs(blk);
|
2014-09-13 03:26:21 +08:00
|
|
|
bs->open_flags = snapshot ? BDRV_O_SNAPSHOT : 0;
|
|
|
|
bs->read_only = ro;
|
|
|
|
bs->detect_zeroes = detect_zeroes;
|
2010-06-03 00:48:27 +08:00
|
|
|
|
2014-09-13 03:26:21 +08:00
|
|
|
bdrv_set_on_error(bs, on_read_error, on_write_error);
|
2010-06-03 00:55:17 +08:00
|
|
|
|
2011-11-03 16:57:25 +08:00
|
|
|
/* disk I/O throttling */
|
2013-09-02 20:14:39 +08:00
|
|
|
if (throttle_enabled(&cfg)) {
|
2014-09-13 03:26:21 +08:00
|
|
|
bdrv_io_limits_enable(bs);
|
|
|
|
bdrv_set_io_limits(bs, &cfg);
|
2013-09-02 20:14:39 +08:00
|
|
|
}
|
2011-11-03 16:57:25 +08:00
|
|
|
|
2010-05-11 21:36:46 +08:00
|
|
|
if (!file || !*file) {
|
2013-07-09 17:09:02 +08:00
|
|
|
if (has_driver_specific_opts) {
|
2013-03-18 23:40:51 +08:00
|
|
|
file = NULL;
|
|
|
|
} else {
|
2013-10-30 21:54:30 +08:00
|
|
|
QDECREF(bs_opts);
|
|
|
|
qemu_opts_del(opts);
|
2014-10-07 19:59:06 +08:00
|
|
|
return blk;
|
2013-03-18 23:40:51 +08:00
|
|
|
}
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
|
|
|
if (snapshot) {
|
|
|
|
/* always use cache=unsafe with snapshot */
|
|
|
|
bdrv_flags &= ~BDRV_O_CACHE_MASK;
|
|
|
|
bdrv_flags |= (BDRV_O_SNAPSHOT|BDRV_O_CACHE_WB|BDRV_O_NO_FLUSH);
|
|
|
|
}
|
|
|
|
|
2011-11-17 21:40:32 +08:00
|
|
|
if (copy_on_read) {
|
|
|
|
bdrv_flags |= BDRV_O_COPY_ON_READ;
|
|
|
|
}
|
|
|
|
|
2012-03-23 15:36:50 +08:00
|
|
|
if (runstate_check(RUN_STATE_INMIGRATE)) {
|
|
|
|
bdrv_flags |= BDRV_O_INCOMING;
|
|
|
|
}
|
|
|
|
|
2010-06-03 00:48:27 +08:00
|
|
|
bdrv_flags |= ro ? 0 : BDRV_O_RDWR;
|
|
|
|
|
2013-07-09 17:09:02 +08:00
|
|
|
QINCREF(bs_opts);
|
2014-09-13 03:26:21 +08:00
|
|
|
ret = bdrv_open(&bs, file, NULL, bs_opts, bdrv_flags, drv, &error);
|
2014-10-07 19:59:13 +08:00
|
|
|
assert(bs == blk_bs(blk));
|
2013-03-15 17:35:07 +08:00
|
|
|
|
2010-06-03 00:48:27 +08:00
|
|
|
if (ret < 0) {
|
2013-09-20 17:33:11 +08:00
|
|
|
error_setg(errp, "could not open disk image %s: %s",
|
2014-10-07 19:59:21 +08:00
|
|
|
file ?: blk_name(blk), error_get_pretty(error));
|
2013-09-20 17:33:11 +08:00
|
|
|
error_free(error);
|
2011-02-08 22:12:39 +08:00
|
|
|
goto err;
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
|
|
|
|
2014-09-13 03:26:21 +08:00
|
|
|
if (bdrv_key_required(bs)) {
|
2010-06-03 00:48:27 +08:00
|
|
|
autostart = 0;
|
2014-09-13 03:26:21 +08:00
|
|
|
}
|
2013-03-15 17:35:07 +08:00
|
|
|
|
2013-07-09 17:09:02 +08:00
|
|
|
QDECREF(bs_opts);
|
2013-03-15 17:35:07 +08:00
|
|
|
qemu_opts_del(opts);
|
|
|
|
|
2014-10-07 19:59:06 +08:00
|
|
|
return blk;
|
2011-02-08 22:12:39 +08:00
|
|
|
|
|
|
|
err:
|
block: New BlockBackend
A block device consists of a frontend device model and a backend.
A block backend has a tree of block drivers doing the actual work.
The tree is managed by the block layer.
We currently use a single abstraction BlockDriverState both for tree
nodes and the backend as a whole. Drawbacks:
* Its API includes both stuff that makes sense only at the block
backend level (root of the tree) and stuff that's only for use
within the block layer. This makes the API bigger and more complex
than necessary. Moreover, it's not obvious which interfaces are
meant for device models, and which really aren't.
* Since device models keep a reference to their backend, the backend
object can't just be destroyed. But for media change, we need to
replace the tree. Our solution is to make the BlockDriverState
generic, with actual driver state in a separate object, pointed to
by member opaque. That lets us replace the tree by deinitializing
and reinitializing its root. This special need of the root makes
the data structure awkward everywhere in the tree.
The general plan is to separate the APIs into "block backend", for use
by device models, monitor and whatever other code dealing with block
backends, and "block driver", for use by the block layer and whatever
other code (if any) dealing with trees and tree nodes.
Code dealing with block backends, device models in particular, should
become completely oblivious of BlockDriverState. This should let us
clean up both APIs, and the tree data structures.
This commit is a first step. It creates a minimal "block backend"
API: type BlockBackend and functions to create, destroy and find them.
BlockBackend objects are created and destroyed exactly when root
BlockDriverState objects are created and destroyed. "Root" in the
sense of "in bdrv_states". They're not yet used for anything; that'll
come shortly.
A root BlockDriverState is created with bdrv_new_root(), so where to
create a BlockBackend is obvious. Where these roots get destroyed
isn't always as obvious.
It is obvious in qemu-img.c, qemu-io.c and qemu-nbd.c, and in error
paths of blockdev_init(), blk_connect(). That leaves destruction of
objects successfully created by blockdev_init() and blk_connect().
blockdev_init() is used only by drive_new() and qmp_blockdev_add().
Objects created by the latter are currently indestructible (see commit
48f364d "blockdev: Refuse to drive_del something added with
blockdev-add" and commit 2d246f0 "blockdev: Introduce
DriveInfo.enable_auto_del"). Objects created by the former get
destroyed by drive_del().
Objects created by blk_connect() get destroyed by blk_disconnect().
BlockBackend is reference-counted. Its reference count never exceeds
one so far, but that's going to change.
In drive_del(), the BB's reference count is surely one now. The BDS's
reference count is greater than one when something else is holding a
reference, such as a block job. In this case, the BB is destroyed
right away, but the BDS lives on until all extra references get
dropped.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-10-07 19:59:04 +08:00
|
|
|
blk_unref(blk);
|
2013-10-30 21:54:30 +08:00
|
|
|
early_err:
|
|
|
|
qemu_opts_del(opts);
|
2014-05-28 17:17:01 +08:00
|
|
|
err_no_opts:
|
|
|
|
QDECREF(bs_opts);
|
2011-02-08 22:12:39 +08:00
|
|
|
return NULL;
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
|
|
|
|
2014-09-18 17:48:34 +08:00
|
|
|
static void qemu_opt_rename(QemuOpts *opts, const char *from, const char *to,
|
|
|
|
Error **errp)
|
2013-07-17 20:41:54 +08:00
|
|
|
{
|
|
|
|
const char *value;
|
|
|
|
|
|
|
|
value = qemu_opt_get(opts, from);
|
|
|
|
if (value) {
|
2014-09-18 17:48:34 +08:00
|
|
|
if (qemu_opt_find(opts, to)) {
|
|
|
|
error_setg(errp, "'%s' and its alias '%s' can't be used at the "
|
|
|
|
"same time", to, from);
|
|
|
|
return;
|
|
|
|
}
|
2014-09-24 13:45:27 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* rename all items in opts */
|
|
|
|
while ((value = qemu_opt_get(opts, from))) {
|
2013-07-17 20:41:54 +08:00
|
|
|
qemu_opt_set(opts, to, value);
|
|
|
|
qemu_opt_unset(opts, from);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-08-28 23:00:13 +08:00
|
|
|
QemuOptsList qemu_legacy_drive_opts = {
|
|
|
|
.name = "drive",
|
|
|
|
.head = QTAILQ_HEAD_INITIALIZER(qemu_legacy_drive_opts.head),
|
|
|
|
.desc = {
|
|
|
|
{
|
2013-09-10 21:48:13 +08:00
|
|
|
.name = "bus",
|
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "bus number",
|
|
|
|
},{
|
|
|
|
.name = "unit",
|
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "unit number (i.e. lun for scsi)",
|
|
|
|
},{
|
|
|
|
.name = "index",
|
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "index number",
|
|
|
|
},{
|
2013-08-28 23:00:13 +08:00
|
|
|
.name = "media",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "media type (disk, cdrom)",
|
2013-08-28 23:24:51 +08:00
|
|
|
},{
|
|
|
|
.name = "if",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "interface (ide, scsi, sd, mtd, floppy, pflash, virtio)",
|
2013-09-09 22:49:49 +08:00
|
|
|
},{
|
|
|
|
.name = "cyls",
|
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "number of cylinders (ide disk geometry)",
|
|
|
|
},{
|
|
|
|
.name = "heads",
|
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "number of heads (ide disk geometry)",
|
|
|
|
},{
|
|
|
|
.name = "secs",
|
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "number of sectors (ide disk geometry)",
|
|
|
|
},{
|
|
|
|
.name = "trans",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "chs translation (auto, lba, none)",
|
2013-09-09 23:01:03 +08:00
|
|
|
},{
|
|
|
|
.name = "boot",
|
|
|
|
.type = QEMU_OPT_BOOL,
|
|
|
|
.help = "(deprecated, ignored)",
|
2013-09-13 20:09:17 +08:00
|
|
|
},{
|
|
|
|
.name = "addr",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "pci address (virtio only)",
|
2014-06-06 21:21:48 +08:00
|
|
|
},{
|
|
|
|
.name = "serial",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "disk serial number",
|
2013-12-21 02:28:14 +08:00
|
|
|
},{
|
|
|
|
.name = "file",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "file name",
|
2013-08-28 23:00:13 +08:00
|
|
|
},
|
2013-09-19 21:12:18 +08:00
|
|
|
|
|
|
|
/* Options that are passed on, but have special semantics with -drive */
|
|
|
|
{
|
|
|
|
.name = "read-only",
|
|
|
|
.type = QEMU_OPT_BOOL,
|
|
|
|
.help = "open drive file as read-only",
|
2014-02-09 16:52:32 +08:00
|
|
|
},{
|
|
|
|
.name = "rerror",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "read error action",
|
|
|
|
},{
|
|
|
|
.name = "werror",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "write error action",
|
2013-09-19 21:12:18 +08:00
|
|
|
},{
|
|
|
|
.name = "copy-on-read",
|
|
|
|
.type = QEMU_OPT_BOOL,
|
|
|
|
.help = "copy read data from backing file into image file",
|
|
|
|
},
|
|
|
|
|
2013-08-28 23:00:13 +08:00
|
|
|
{ /* end of list */ }
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
2014-06-06 20:50:58 +08:00
|
|
|
DriveInfo *drive_new(QemuOpts *all_opts, BlockInterfaceType block_default_type)
|
2013-07-17 20:41:54 +08:00
|
|
|
{
|
2013-07-18 22:31:25 +08:00
|
|
|
const char *value;
|
2014-10-07 19:59:06 +08:00
|
|
|
BlockBackend *blk;
|
2013-08-28 23:00:13 +08:00
|
|
|
DriveInfo *dinfo = NULL;
|
2013-09-10 18:01:20 +08:00
|
|
|
QDict *bs_opts;
|
2013-08-28 23:00:13 +08:00
|
|
|
QemuOpts *legacy_opts;
|
|
|
|
DriveMediaType media = MEDIA_DISK;
|
2013-08-28 23:24:51 +08:00
|
|
|
BlockInterfaceType type;
|
2013-09-09 22:49:49 +08:00
|
|
|
int cyls, heads, secs, translation;
|
2013-09-10 21:48:13 +08:00
|
|
|
int max_devs, bus_id, unit_id, index;
|
2013-09-13 20:09:17 +08:00
|
|
|
const char *devaddr;
|
2014-02-09 16:52:32 +08:00
|
|
|
const char *werror, *rerror;
|
2013-10-15 17:45:50 +08:00
|
|
|
bool read_only = false;
|
|
|
|
bool copy_on_read;
|
2014-06-06 21:21:48 +08:00
|
|
|
const char *serial;
|
2013-12-21 02:28:14 +08:00
|
|
|
const char *filename;
|
2013-08-28 23:00:13 +08:00
|
|
|
Error *local_err = NULL;
|
2014-09-24 22:37:14 +08:00
|
|
|
int i;
|
2013-07-18 22:31:25 +08:00
|
|
|
|
2013-07-17 20:41:54 +08:00
|
|
|
/* Change legacy command line options into QMP ones */
|
2014-09-24 22:37:14 +08:00
|
|
|
static const struct {
|
|
|
|
const char *from;
|
|
|
|
const char *to;
|
|
|
|
} opt_renames[] = {
|
|
|
|
{ "iops", "throttling.iops-total" },
|
|
|
|
{ "iops_rd", "throttling.iops-read" },
|
|
|
|
{ "iops_wr", "throttling.iops-write" },
|
2013-07-17 20:41:54 +08:00
|
|
|
|
2014-09-24 22:37:14 +08:00
|
|
|
{ "bps", "throttling.bps-total" },
|
|
|
|
{ "bps_rd", "throttling.bps-read" },
|
|
|
|
{ "bps_wr", "throttling.bps-write" },
|
2013-07-17 20:41:54 +08:00
|
|
|
|
2014-09-24 22:37:14 +08:00
|
|
|
{ "iops_max", "throttling.iops-total-max" },
|
|
|
|
{ "iops_rd_max", "throttling.iops-read-max" },
|
|
|
|
{ "iops_wr_max", "throttling.iops-write-max" },
|
2013-09-02 20:14:40 +08:00
|
|
|
|
2014-09-24 22:37:14 +08:00
|
|
|
{ "bps_max", "throttling.bps-total-max" },
|
|
|
|
{ "bps_rd_max", "throttling.bps-read-max" },
|
|
|
|
{ "bps_wr_max", "throttling.bps-write-max" },
|
2013-09-02 20:14:40 +08:00
|
|
|
|
2014-09-24 22:37:14 +08:00
|
|
|
{ "iops_size", "throttling.iops-size" },
|
2013-09-02 20:14:41 +08:00
|
|
|
|
2014-09-24 22:37:14 +08:00
|
|
|
{ "readonly", "read-only" },
|
|
|
|
};
|
|
|
|
|
|
|
|
for (i = 0; i < ARRAY_SIZE(opt_renames); i++) {
|
2014-09-18 17:48:34 +08:00
|
|
|
qemu_opt_rename(all_opts, opt_renames[i].from, opt_renames[i].to,
|
|
|
|
&local_err);
|
|
|
|
if (local_err) {
|
|
|
|
error_report("%s", error_get_pretty(local_err));
|
|
|
|
error_free(local_err);
|
|
|
|
return NULL;
|
|
|
|
}
|
2014-09-24 22:37:14 +08:00
|
|
|
}
|
2013-07-20 02:07:29 +08:00
|
|
|
|
2013-07-18 22:31:25 +08:00
|
|
|
value = qemu_opt_get(all_opts, "cache");
|
|
|
|
if (value) {
|
|
|
|
int flags = 0;
|
|
|
|
|
|
|
|
if (bdrv_parse_cache_flags(value, &flags) != 0) {
|
|
|
|
error_report("invalid cache option");
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Specific options take precedence */
|
|
|
|
if (!qemu_opt_get(all_opts, "cache.writeback")) {
|
|
|
|
qemu_opt_set_bool(all_opts, "cache.writeback",
|
|
|
|
!!(flags & BDRV_O_CACHE_WB));
|
|
|
|
}
|
|
|
|
if (!qemu_opt_get(all_opts, "cache.direct")) {
|
|
|
|
qemu_opt_set_bool(all_opts, "cache.direct",
|
|
|
|
!!(flags & BDRV_O_NOCACHE));
|
|
|
|
}
|
|
|
|
if (!qemu_opt_get(all_opts, "cache.no-flush")) {
|
|
|
|
qemu_opt_set_bool(all_opts, "cache.no-flush",
|
|
|
|
!!(flags & BDRV_O_NO_FLUSH));
|
|
|
|
}
|
|
|
|
qemu_opt_unset(all_opts, "cache");
|
|
|
|
}
|
|
|
|
|
2013-09-10 18:01:20 +08:00
|
|
|
/* Get a QDict for processing the options */
|
|
|
|
bs_opts = qdict_new();
|
|
|
|
qemu_opts_to_qdict(all_opts, bs_opts);
|
|
|
|
|
2014-01-02 10:49:17 +08:00
|
|
|
legacy_opts = qemu_opts_create(&qemu_legacy_drive_opts, NULL, 0,
|
|
|
|
&error_abort);
|
2013-08-28 23:00:13 +08:00
|
|
|
qemu_opts_absorb_qdict(legacy_opts, bs_opts, &local_err);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2014-05-16 17:00:08 +08:00
|
|
|
error_report("%s", error_get_pretty(local_err));
|
2013-08-28 23:00:13 +08:00
|
|
|
error_free(local_err);
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
2013-09-09 23:01:03 +08:00
|
|
|
/* Deprecated option boot=[on|off] */
|
|
|
|
if (qemu_opt_get(legacy_opts, "boot") != NULL) {
|
|
|
|
fprintf(stderr, "qemu-kvm: boot=on|off is deprecated and will be "
|
|
|
|
"ignored. Future versions will reject this parameter. Please "
|
|
|
|
"update your scripts.\n");
|
|
|
|
}
|
|
|
|
|
2013-08-28 23:00:13 +08:00
|
|
|
/* Media type */
|
|
|
|
value = qemu_opt_get(legacy_opts, "media");
|
|
|
|
if (value) {
|
|
|
|
if (!strcmp(value, "disk")) {
|
|
|
|
media = MEDIA_DISK;
|
|
|
|
} else if (!strcmp(value, "cdrom")) {
|
|
|
|
media = MEDIA_CDROM;
|
2013-10-15 17:45:50 +08:00
|
|
|
read_only = true;
|
2013-08-28 23:00:13 +08:00
|
|
|
} else {
|
|
|
|
error_report("'%s' invalid media", value);
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-09-19 21:12:18 +08:00
|
|
|
/* copy-on-read is disabled with a warning for read-only devices */
|
2013-10-15 17:45:50 +08:00
|
|
|
read_only |= qemu_opt_get_bool(legacy_opts, "read-only", false);
|
2013-09-19 21:12:18 +08:00
|
|
|
copy_on_read = qemu_opt_get_bool(legacy_opts, "copy-on-read", false);
|
|
|
|
|
|
|
|
if (read_only && copy_on_read) {
|
|
|
|
error_report("warning: disabling copy-on-read on read-only drive");
|
|
|
|
copy_on_read = false;
|
|
|
|
}
|
|
|
|
|
|
|
|
qdict_put(bs_opts, "read-only",
|
|
|
|
qstring_from_str(read_only ? "on" : "off"));
|
|
|
|
qdict_put(bs_opts, "copy-on-read",
|
|
|
|
qstring_from_str(copy_on_read ? "on" :"off"));
|
|
|
|
|
2013-08-28 23:24:51 +08:00
|
|
|
/* Controller type */
|
|
|
|
value = qemu_opt_get(legacy_opts, "if");
|
|
|
|
if (value) {
|
|
|
|
for (type = 0;
|
|
|
|
type < IF_COUNT && strcmp(value, if_name[type]);
|
|
|
|
type++) {
|
|
|
|
}
|
|
|
|
if (type == IF_COUNT) {
|
|
|
|
error_report("unsupported bus type '%s'", value);
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
type = block_default_type;
|
|
|
|
}
|
|
|
|
|
2013-09-09 22:49:49 +08:00
|
|
|
/* Geometry */
|
|
|
|
cyls = qemu_opt_get_number(legacy_opts, "cyls", 0);
|
|
|
|
heads = qemu_opt_get_number(legacy_opts, "heads", 0);
|
|
|
|
secs = qemu_opt_get_number(legacy_opts, "secs", 0);
|
|
|
|
|
|
|
|
if (cyls || heads || secs) {
|
|
|
|
if (cyls < 1) {
|
|
|
|
error_report("invalid physical cyls number");
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
if (heads < 1) {
|
|
|
|
error_report("invalid physical heads number");
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
if (secs < 1) {
|
|
|
|
error_report("invalid physical secs number");
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
translation = BIOS_ATA_TRANSLATION_AUTO;
|
|
|
|
value = qemu_opt_get(legacy_opts, "trans");
|
|
|
|
if (value != NULL) {
|
|
|
|
if (!cyls) {
|
|
|
|
error_report("'%s' trans must be used with cyls, heads and secs",
|
|
|
|
value);
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
if (!strcmp(value, "none")) {
|
|
|
|
translation = BIOS_ATA_TRANSLATION_NONE;
|
|
|
|
} else if (!strcmp(value, "lba")) {
|
|
|
|
translation = BIOS_ATA_TRANSLATION_LBA;
|
2014-02-08 18:01:54 +08:00
|
|
|
} else if (!strcmp(value, "large")) {
|
|
|
|
translation = BIOS_ATA_TRANSLATION_LARGE;
|
|
|
|
} else if (!strcmp(value, "rechs")) {
|
|
|
|
translation = BIOS_ATA_TRANSLATION_RECHS;
|
2013-09-09 22:49:49 +08:00
|
|
|
} else if (!strcmp(value, "auto")) {
|
|
|
|
translation = BIOS_ATA_TRANSLATION_AUTO;
|
|
|
|
} else {
|
|
|
|
error_report("'%s' invalid translation type", value);
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (media == MEDIA_CDROM) {
|
|
|
|
if (cyls || secs || heads) {
|
|
|
|
error_report("CHS can't be set with media=cdrom");
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-09-10 21:48:13 +08:00
|
|
|
/* Device address specified by bus/unit or index.
|
|
|
|
* If none was specified, try to find the first free one. */
|
|
|
|
bus_id = qemu_opt_get_number(legacy_opts, "bus", 0);
|
|
|
|
unit_id = qemu_opt_get_number(legacy_opts, "unit", -1);
|
|
|
|
index = qemu_opt_get_number(legacy_opts, "index", -1);
|
|
|
|
|
|
|
|
max_devs = if_max_devs[type];
|
|
|
|
|
|
|
|
if (index != -1) {
|
|
|
|
if (bus_id != 0 || unit_id != -1) {
|
|
|
|
error_report("index cannot be used with bus and unit");
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
bus_id = drive_index_to_bus_id(type, index);
|
|
|
|
unit_id = drive_index_to_unit_id(type, index);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (unit_id == -1) {
|
|
|
|
unit_id = 0;
|
|
|
|
while (drive_get(type, bus_id, unit_id) != NULL) {
|
|
|
|
unit_id++;
|
|
|
|
if (max_devs && unit_id >= max_devs) {
|
|
|
|
unit_id -= max_devs;
|
|
|
|
bus_id++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (max_devs && unit_id >= max_devs) {
|
|
|
|
error_report("unit %d too big (max is %d)", unit_id, max_devs - 1);
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (drive_get(type, bus_id, unit_id) != NULL) {
|
|
|
|
error_report("drive with bus=%d, unit=%d (index=%d) exists",
|
|
|
|
bus_id, unit_id, index);
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
2014-06-06 21:21:48 +08:00
|
|
|
/* Serial number */
|
|
|
|
serial = qemu_opt_get(legacy_opts, "serial");
|
|
|
|
|
2013-09-10 21:48:13 +08:00
|
|
|
/* no id supplied -> create one */
|
|
|
|
if (qemu_opts_id(all_opts) == NULL) {
|
|
|
|
char *new_id;
|
|
|
|
const char *mediastr = "";
|
|
|
|
if (type == IF_IDE || type == IF_SCSI) {
|
|
|
|
mediastr = (media == MEDIA_CDROM) ? "-cd" : "-hd";
|
|
|
|
}
|
|
|
|
if (max_devs) {
|
|
|
|
new_id = g_strdup_printf("%s%i%s%i", if_name[type], bus_id,
|
|
|
|
mediastr, unit_id);
|
|
|
|
} else {
|
|
|
|
new_id = g_strdup_printf("%s%s%i", if_name[type],
|
|
|
|
mediastr, unit_id);
|
|
|
|
}
|
|
|
|
qdict_put(bs_opts, "id", qstring_from_str(new_id));
|
|
|
|
g_free(new_id);
|
|
|
|
}
|
|
|
|
|
2013-09-13 20:09:17 +08:00
|
|
|
/* Add virtio block device */
|
|
|
|
devaddr = qemu_opt_get(legacy_opts, "addr");
|
|
|
|
if (devaddr && type != IF_VIRTIO) {
|
|
|
|
error_report("addr is not supported by this bus type");
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (type == IF_VIRTIO) {
|
|
|
|
QemuOpts *devopts;
|
2014-01-02 10:49:17 +08:00
|
|
|
devopts = qemu_opts_create(qemu_find_opts("device"), NULL, 0,
|
|
|
|
&error_abort);
|
2013-09-13 20:09:17 +08:00
|
|
|
if (arch_type == QEMU_ARCH_S390X) {
|
|
|
|
qemu_opt_set(devopts, "driver", "virtio-blk-s390");
|
|
|
|
} else {
|
|
|
|
qemu_opt_set(devopts, "driver", "virtio-blk-pci");
|
|
|
|
}
|
|
|
|
qemu_opt_set(devopts, "drive", qdict_get_str(bs_opts, "id"));
|
|
|
|
if (devaddr) {
|
|
|
|
qemu_opt_set(devopts, "addr", devaddr);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-12-21 02:28:14 +08:00
|
|
|
filename = qemu_opt_get(legacy_opts, "file");
|
|
|
|
|
2014-02-09 16:52:32 +08:00
|
|
|
/* Check werror/rerror compatibility with if=... */
|
|
|
|
werror = qemu_opt_get(legacy_opts, "werror");
|
|
|
|
if (werror != NULL) {
|
|
|
|
if (type != IF_IDE && type != IF_SCSI && type != IF_VIRTIO &&
|
|
|
|
type != IF_NONE) {
|
|
|
|
error_report("werror is not supported by this bus type");
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
qdict_put(bs_opts, "werror", qstring_from_str(werror));
|
|
|
|
}
|
|
|
|
|
|
|
|
rerror = qemu_opt_get(legacy_opts, "rerror");
|
|
|
|
if (rerror != NULL) {
|
|
|
|
if (type != IF_IDE && type != IF_VIRTIO && type != IF_SCSI &&
|
|
|
|
type != IF_NONE) {
|
|
|
|
error_report("rerror is not supported by this bus type");
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
qdict_put(bs_opts, "rerror", qstring_from_str(rerror));
|
|
|
|
}
|
|
|
|
|
2013-09-18 21:14:47 +08:00
|
|
|
/* Actual block device init: Functionality shared with blockdev-add */
|
2014-10-07 19:59:06 +08:00
|
|
|
blk = blockdev_init(filename, bs_opts, &local_err);
|
2014-05-28 17:17:02 +08:00
|
|
|
bs_opts = NULL;
|
2014-10-07 19:59:06 +08:00
|
|
|
if (!blk) {
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2014-05-16 17:00:08 +08:00
|
|
|
error_report("%s", error_get_pretty(local_err));
|
2013-09-20 17:33:11 +08:00
|
|
|
error_free(local_err);
|
|
|
|
}
|
2013-09-18 21:14:47 +08:00
|
|
|
goto fail;
|
2013-09-20 17:33:11 +08:00
|
|
|
} else {
|
2014-01-30 22:07:28 +08:00
|
|
|
assert(!local_err);
|
2013-09-18 21:14:47 +08:00
|
|
|
}
|
|
|
|
|
2014-10-07 19:59:22 +08:00
|
|
|
/* Create legacy DriveInfo */
|
|
|
|
dinfo = g_malloc0(sizeof(*dinfo));
|
2013-09-10 18:01:20 +08:00
|
|
|
dinfo->opts = all_opts;
|
2013-09-18 21:14:47 +08:00
|
|
|
|
2013-09-09 22:49:49 +08:00
|
|
|
dinfo->cyls = cyls;
|
|
|
|
dinfo->heads = heads;
|
|
|
|
dinfo->secs = secs;
|
|
|
|
dinfo->trans = translation;
|
|
|
|
|
2014-02-09 16:52:32 +08:00
|
|
|
dinfo->type = type;
|
2013-09-10 21:48:13 +08:00
|
|
|
dinfo->bus = bus_id;
|
|
|
|
dinfo->unit = unit_id;
|
2013-09-13 20:09:17 +08:00
|
|
|
dinfo->devaddr = devaddr;
|
2014-06-06 21:21:48 +08:00
|
|
|
dinfo->serial = g_strdup(serial);
|
|
|
|
|
2014-10-07 19:59:22 +08:00
|
|
|
blk_set_legacy_dinfo(blk, dinfo);
|
|
|
|
|
2013-09-19 20:24:10 +08:00
|
|
|
switch(type) {
|
|
|
|
case IF_IDE:
|
|
|
|
case IF_SCSI:
|
|
|
|
case IF_XEN:
|
|
|
|
case IF_NONE:
|
|
|
|
dinfo->media_cd = media == MEDIA_CDROM;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2013-09-18 21:14:47 +08:00
|
|
|
fail:
|
2013-08-28 23:00:13 +08:00
|
|
|
qemu_opts_del(legacy_opts);
|
2014-05-28 17:17:02 +08:00
|
|
|
QDECREF(bs_opts);
|
2013-09-18 21:14:47 +08:00
|
|
|
return dinfo;
|
2013-07-17 20:41:54 +08:00
|
|
|
}
|
|
|
|
|
2010-06-03 00:48:27 +08:00
|
|
|
void do_commit(Monitor *mon, const QDict *qdict)
|
|
|
|
{
|
|
|
|
const char *device = qdict_get_str(qdict, "device");
|
2010-06-03 00:55:18 +08:00
|
|
|
BlockDriverState *bs;
|
2012-03-06 02:10:11 +08:00
|
|
|
int ret;
|
2010-06-03 00:48:27 +08:00
|
|
|
|
2010-06-03 00:55:18 +08:00
|
|
|
if (!strcmp(device, "all")) {
|
2012-03-06 02:10:11 +08:00
|
|
|
ret = bdrv_commit_all();
|
2010-06-03 00:55:18 +08:00
|
|
|
} else {
|
|
|
|
bs = bdrv_find(device);
|
2010-06-03 00:55:19 +08:00
|
|
|
if (!bs) {
|
2013-01-19 01:45:35 +08:00
|
|
|
monitor_printf(mon, "Device '%s' not found\n", device);
|
2010-06-03 00:55:19 +08:00
|
|
|
return;
|
2010-06-03 00:55:18 +08:00
|
|
|
}
|
2012-01-18 22:40:41 +08:00
|
|
|
ret = bdrv_commit(bs);
|
2013-01-19 01:45:35 +08:00
|
|
|
}
|
|
|
|
if (ret < 0) {
|
|
|
|
monitor_printf(mon, "'commit' error for '%s': %s\n", device,
|
|
|
|
strerror(-ret));
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-03-07 01:55:59 +08:00
|
|
|
static void blockdev_do_action(int kind, void *data, Error **errp)
|
|
|
|
{
|
2013-05-13 16:43:43 +08:00
|
|
|
TransactionAction action;
|
|
|
|
TransactionActionList list;
|
2012-03-07 01:55:59 +08:00
|
|
|
|
|
|
|
action.kind = kind;
|
|
|
|
action.data = data;
|
|
|
|
list.value = &action;
|
|
|
|
list.next = NULL;
|
|
|
|
qmp_transaction(&list, errp);
|
|
|
|
}
|
|
|
|
|
2014-01-24 04:31:38 +08:00
|
|
|
void qmp_blockdev_snapshot_sync(bool has_device, const char *device,
|
|
|
|
bool has_node_name, const char *node_name,
|
|
|
|
const char *snapshot_file,
|
|
|
|
bool has_snapshot_node_name,
|
|
|
|
const char *snapshot_node_name,
|
2011-11-26 02:15:19 +08:00
|
|
|
bool has_format, const char *format,
|
2014-01-24 04:31:38 +08:00
|
|
|
bool has_mode, NewImageMode mode, Error **errp)
|
2010-12-16 20:52:16 +08:00
|
|
|
{
|
2012-03-07 01:55:59 +08:00
|
|
|
BlockdevSnapshot snapshot = {
|
2014-01-24 04:31:38 +08:00
|
|
|
.has_device = has_device,
|
2012-03-07 01:55:59 +08:00
|
|
|
.device = (char *) device,
|
2014-01-24 04:31:38 +08:00
|
|
|
.has_node_name = has_node_name,
|
|
|
|
.node_name = (char *) node_name,
|
2012-03-07 01:55:59 +08:00
|
|
|
.snapshot_file = (char *) snapshot_file,
|
2014-01-24 04:31:38 +08:00
|
|
|
.has_snapshot_node_name = has_snapshot_node_name,
|
|
|
|
.snapshot_node_name = (char *) snapshot_node_name,
|
2012-03-07 01:55:59 +08:00
|
|
|
.has_format = has_format,
|
|
|
|
.format = (char *) format,
|
|
|
|
.has_mode = has_mode,
|
|
|
|
.mode = mode,
|
|
|
|
};
|
2013-05-13 16:43:43 +08:00
|
|
|
blockdev_do_action(TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC,
|
|
|
|
&snapshot, errp);
|
2010-12-16 20:52:16 +08:00
|
|
|
}
|
|
|
|
|
2013-09-11 14:04:35 +08:00
|
|
|
void qmp_blockdev_snapshot_internal_sync(const char *device,
|
|
|
|
const char *name,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
BlockdevSnapshotInternal snapshot = {
|
|
|
|
.device = (char *) device,
|
|
|
|
.name = (char *) name
|
|
|
|
};
|
|
|
|
|
|
|
|
blockdev_do_action(TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_INTERNAL_SYNC,
|
|
|
|
&snapshot, errp);
|
|
|
|
}
|
|
|
|
|
2013-09-11 14:04:36 +08:00
|
|
|
SnapshotInfo *qmp_blockdev_snapshot_delete_internal_sync(const char *device,
|
|
|
|
bool has_id,
|
|
|
|
const char *id,
|
|
|
|
bool has_name,
|
|
|
|
const char *name,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
BlockDriverState *bs = bdrv_find(device);
|
2014-11-19 22:19:42 +08:00
|
|
|
AioContext *aio_context;
|
2013-09-11 14:04:36 +08:00
|
|
|
QEMUSnapshotInfo sn;
|
|
|
|
Error *local_err = NULL;
|
|
|
|
SnapshotInfo *info = NULL;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (!bs) {
|
|
|
|
error_set(errp, QERR_DEVICE_NOT_FOUND, device);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!has_id) {
|
|
|
|
id = NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!has_name) {
|
|
|
|
name = NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!id && !name) {
|
|
|
|
error_setg(errp, "Name or id must be provided");
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2014-11-19 22:19:42 +08:00
|
|
|
aio_context = bdrv_get_aio_context(bs);
|
|
|
|
aio_context_acquire(aio_context);
|
|
|
|
|
2014-11-19 22:19:43 +08:00
|
|
|
if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_INTERNAL_SNAPSHOT_DELETE, errp)) {
|
|
|
|
goto out_aio_context;
|
|
|
|
}
|
|
|
|
|
2013-09-11 14:04:36 +08:00
|
|
|
ret = bdrv_snapshot_find_by_id_and_name(bs, id, name, &sn, &local_err);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2013-09-11 14:04:36 +08:00
|
|
|
error_propagate(errp, local_err);
|
2014-11-19 22:19:42 +08:00
|
|
|
goto out_aio_context;
|
2013-09-11 14:04:36 +08:00
|
|
|
}
|
|
|
|
if (!ret) {
|
|
|
|
error_setg(errp,
|
|
|
|
"Snapshot with id '%s' and name '%s' does not exist on "
|
|
|
|
"device '%s'",
|
|
|
|
STR_OR_NULL(id), STR_OR_NULL(name), device);
|
2014-11-19 22:19:42 +08:00
|
|
|
goto out_aio_context;
|
2013-09-11 14:04:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
bdrv_snapshot_delete(bs, id, name, &local_err);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2013-09-11 14:04:36 +08:00
|
|
|
error_propagate(errp, local_err);
|
2014-11-19 22:19:42 +08:00
|
|
|
goto out_aio_context;
|
2013-09-11 14:04:36 +08:00
|
|
|
}
|
|
|
|
|
2014-11-19 22:19:42 +08:00
|
|
|
aio_context_release(aio_context);
|
|
|
|
|
block: Use g_new() & friends where that makes obvious sense
g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
for two reasons. One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.
Patch created with Coccinelle, with two manual changes on top:
* Add const to bdrv_iterate_format() to keep the types straight
* Convert the allocation in bdrv_drop_intermediate(), which Coccinelle
inexplicably misses
Coccinelle semantic patch:
@@
type T;
@@
-g_malloc(sizeof(T))
+g_new(T, 1)
@@
type T;
@@
-g_try_malloc(sizeof(T))
+g_try_new(T, 1)
@@
type T;
@@
-g_malloc0(sizeof(T))
+g_new0(T, 1)
@@
type T;
@@
-g_try_malloc0(sizeof(T))
+g_try_new0(T, 1)
@@
type T;
expression n;
@@
-g_malloc(sizeof(T) * (n))
+g_new(T, n)
@@
type T;
expression n;
@@
-g_try_malloc(sizeof(T) * (n))
+g_try_new(T, n)
@@
type T;
expression n;
@@
-g_malloc0(sizeof(T) * (n))
+g_new0(T, n)
@@
type T;
expression n;
@@
-g_try_malloc0(sizeof(T) * (n))
+g_try_new0(T, n)
@@
type T;
expression p, n;
@@
-g_realloc(p, sizeof(T) * (n))
+g_renew(T, p, n)
@@
type T;
expression p, n;
@@
-g_try_realloc(p, sizeof(T) * (n))
+g_try_renew(T, p, n)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-08-19 16:31:08 +08:00
|
|
|
info = g_new0(SnapshotInfo, 1);
|
2013-09-11 14:04:36 +08:00
|
|
|
info->id = g_strdup(sn.id_str);
|
|
|
|
info->name = g_strdup(sn.name);
|
|
|
|
info->date_nsec = sn.date_nsec;
|
|
|
|
info->date_sec = sn.date_sec;
|
|
|
|
info->vm_state_size = sn.vm_state_size;
|
|
|
|
info->vm_clock_nsec = sn.vm_clock_nsec % 1000000000;
|
|
|
|
info->vm_clock_sec = sn.vm_clock_nsec / 1000000000;
|
|
|
|
|
|
|
|
return info;
|
2014-11-19 22:19:42 +08:00
|
|
|
|
|
|
|
out_aio_context:
|
|
|
|
aio_context_release(aio_context);
|
|
|
|
return NULL;
|
2013-09-11 14:04:36 +08:00
|
|
|
}
|
2012-02-29 04:54:06 +08:00
|
|
|
|
|
|
|
/* New and old BlockDriverState structs for group snapshots */
|
2013-05-08 18:25:16 +08:00
|
|
|
|
2013-06-24 23:13:15 +08:00
|
|
|
typedef struct BlkTransactionState BlkTransactionState;
|
2013-05-08 18:25:16 +08:00
|
|
|
|
|
|
|
/* Only prepare() may fail. In a single transaction, only one of commit() or
|
|
|
|
abort() will be called, clean() will always be called if it present. */
|
|
|
|
typedef struct BdrvActionOps {
|
|
|
|
/* Size of state struct, in bytes. */
|
|
|
|
size_t instance_size;
|
|
|
|
/* Prepare the work, must NOT be NULL. */
|
2013-06-24 23:13:15 +08:00
|
|
|
void (*prepare)(BlkTransactionState *common, Error **errp);
|
2013-06-24 23:13:16 +08:00
|
|
|
/* Commit the changes, can be NULL. */
|
2013-06-24 23:13:15 +08:00
|
|
|
void (*commit)(BlkTransactionState *common);
|
2013-05-08 18:25:16 +08:00
|
|
|
/* Abort the changes on fail, can be NULL. */
|
2013-06-24 23:13:15 +08:00
|
|
|
void (*abort)(BlkTransactionState *common);
|
2013-05-08 18:25:16 +08:00
|
|
|
/* Clean up resource in the end, can be NULL. */
|
2013-06-24 23:13:15 +08:00
|
|
|
void (*clean)(BlkTransactionState *common);
|
2013-05-08 18:25:16 +08:00
|
|
|
} BdrvActionOps;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This structure must be arranged as first member in child type, assuming
|
|
|
|
* that compiler will also arrange it to the same address with parent instance.
|
|
|
|
* Later it will be used in free().
|
|
|
|
*/
|
2013-06-24 23:13:15 +08:00
|
|
|
struct BlkTransactionState {
|
2013-05-13 16:43:43 +08:00
|
|
|
TransactionAction *action;
|
2013-05-08 18:25:16 +08:00
|
|
|
const BdrvActionOps *ops;
|
2013-06-24 23:13:15 +08:00
|
|
|
QSIMPLEQ_ENTRY(BlkTransactionState) entry;
|
2013-05-08 18:25:16 +08:00
|
|
|
};
|
|
|
|
|
2013-09-11 14:04:34 +08:00
|
|
|
/* internal snapshot private data */
|
|
|
|
typedef struct InternalSnapshotState {
|
|
|
|
BlkTransactionState common;
|
|
|
|
BlockDriverState *bs;
|
|
|
|
QEMUSnapshotInfo sn;
|
|
|
|
} InternalSnapshotState;
|
|
|
|
|
|
|
|
static void internal_snapshot_prepare(BlkTransactionState *common,
|
|
|
|
Error **errp)
|
|
|
|
{
|
2014-04-25 22:50:34 +08:00
|
|
|
Error *local_err = NULL;
|
2013-09-11 14:04:34 +08:00
|
|
|
const char *device;
|
|
|
|
const char *name;
|
|
|
|
BlockDriverState *bs;
|
|
|
|
QEMUSnapshotInfo old_sn, *sn;
|
|
|
|
bool ret;
|
|
|
|
qemu_timeval tv;
|
|
|
|
BlockdevSnapshotInternal *internal;
|
|
|
|
InternalSnapshotState *state;
|
|
|
|
int ret1;
|
|
|
|
|
|
|
|
g_assert(common->action->kind ==
|
|
|
|
TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_INTERNAL_SYNC);
|
|
|
|
internal = common->action->blockdev_snapshot_internal_sync;
|
|
|
|
state = DO_UPCAST(InternalSnapshotState, common, common);
|
|
|
|
|
|
|
|
/* 1. parse input */
|
|
|
|
device = internal->device;
|
|
|
|
name = internal->name;
|
|
|
|
|
|
|
|
/* 2. check for validation */
|
|
|
|
bs = bdrv_find(device);
|
|
|
|
if (!bs) {
|
|
|
|
error_set(errp, QERR_DEVICE_NOT_FOUND, device);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!bdrv_is_inserted(bs)) {
|
|
|
|
error_set(errp, QERR_DEVICE_HAS_NO_MEDIUM, device);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (bdrv_is_read_only(bs)) {
|
|
|
|
error_set(errp, QERR_DEVICE_IS_READ_ONLY, device);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!bdrv_can_snapshot(bs)) {
|
|
|
|
error_set(errp, QERR_BLOCK_FORMAT_FEATURE_NOT_SUPPORTED,
|
|
|
|
bs->drv->format_name, device, "internal snapshot");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!strlen(name)) {
|
|
|
|
error_setg(errp, "Name is empty");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* check whether a snapshot with name exist */
|
2014-04-25 22:50:34 +08:00
|
|
|
ret = bdrv_snapshot_find_by_id_and_name(bs, NULL, name, &old_sn,
|
|
|
|
&local_err);
|
|
|
|
if (local_err) {
|
|
|
|
error_propagate(errp, local_err);
|
2013-09-11 14:04:34 +08:00
|
|
|
return;
|
|
|
|
} else if (ret) {
|
|
|
|
error_setg(errp,
|
|
|
|
"Snapshot with name '%s' already exists on device '%s'",
|
|
|
|
name, device);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* 3. take the snapshot */
|
|
|
|
sn = &state->sn;
|
|
|
|
pstrcpy(sn->name, sizeof(sn->name), name);
|
|
|
|
qemu_gettimeofday(&tv);
|
|
|
|
sn->date_sec = tv.tv_sec;
|
|
|
|
sn->date_nsec = tv.tv_usec * 1000;
|
|
|
|
sn->vm_clock_nsec = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
|
|
|
|
|
|
|
|
ret1 = bdrv_snapshot_create(bs, sn);
|
|
|
|
if (ret1 < 0) {
|
|
|
|
error_setg_errno(errp, -ret1,
|
|
|
|
"Failed to create snapshot '%s' on device '%s'",
|
|
|
|
name, device);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* 4. succeed, mark a snapshot is created */
|
|
|
|
state->bs = bs;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void internal_snapshot_abort(BlkTransactionState *common)
|
|
|
|
{
|
|
|
|
InternalSnapshotState *state =
|
|
|
|
DO_UPCAST(InternalSnapshotState, common, common);
|
|
|
|
BlockDriverState *bs = state->bs;
|
|
|
|
QEMUSnapshotInfo *sn = &state->sn;
|
|
|
|
Error *local_error = NULL;
|
|
|
|
|
|
|
|
if (!bs) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (bdrv_snapshot_delete(bs, sn->id_str, sn->name, &local_error) < 0) {
|
|
|
|
error_report("Failed to delete snapshot with id '%s' and name '%s' on "
|
|
|
|
"device '%s' in abort: %s",
|
|
|
|
sn->id_str,
|
|
|
|
sn->name,
|
|
|
|
bdrv_get_device_name(bs),
|
|
|
|
error_get_pretty(local_error));
|
|
|
|
error_free(local_error);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-05-08 18:25:16 +08:00
|
|
|
/* external snapshot private data */
|
2013-06-24 23:13:15 +08:00
|
|
|
typedef struct ExternalSnapshotState {
|
|
|
|
BlkTransactionState common;
|
2012-02-29 04:54:06 +08:00
|
|
|
BlockDriverState *old_bs;
|
|
|
|
BlockDriverState *new_bs;
|
2013-06-24 23:13:15 +08:00
|
|
|
} ExternalSnapshotState;
|
2012-02-29 04:54:06 +08:00
|
|
|
|
2013-06-24 23:13:15 +08:00
|
|
|
static void external_snapshot_prepare(BlkTransactionState *common,
|
2013-05-08 18:25:12 +08:00
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
BlockDriver *drv;
|
|
|
|
int flags, ret;
|
2014-01-24 04:31:38 +08:00
|
|
|
QDict *options = NULL;
|
2013-05-08 18:25:12 +08:00
|
|
|
Error *local_err = NULL;
|
2014-01-24 04:31:38 +08:00
|
|
|
bool has_device = false;
|
2013-05-08 18:25:13 +08:00
|
|
|
const char *device;
|
2014-01-24 04:31:38 +08:00
|
|
|
bool has_node_name = false;
|
|
|
|
const char *node_name;
|
|
|
|
bool has_snapshot_node_name = false;
|
|
|
|
const char *snapshot_node_name;
|
2013-05-08 18:25:13 +08:00
|
|
|
const char *new_image_file;
|
|
|
|
const char *format = "qcow2";
|
|
|
|
enum NewImageMode mode = NEW_IMAGE_MODE_ABSOLUTE_PATHS;
|
2013-06-24 23:13:15 +08:00
|
|
|
ExternalSnapshotState *state =
|
|
|
|
DO_UPCAST(ExternalSnapshotState, common, common);
|
2013-05-13 16:43:43 +08:00
|
|
|
TransactionAction *action = common->action;
|
2013-05-08 18:25:12 +08:00
|
|
|
|
2013-05-08 18:25:13 +08:00
|
|
|
/* get parameters */
|
2013-05-13 16:43:43 +08:00
|
|
|
g_assert(action->kind == TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC);
|
2013-05-08 18:25:13 +08:00
|
|
|
|
2014-01-24 04:31:38 +08:00
|
|
|
has_device = action->blockdev_snapshot_sync->has_device;
|
2013-05-08 18:25:13 +08:00
|
|
|
device = action->blockdev_snapshot_sync->device;
|
2014-01-24 04:31:38 +08:00
|
|
|
has_node_name = action->blockdev_snapshot_sync->has_node_name;
|
|
|
|
node_name = action->blockdev_snapshot_sync->node_name;
|
|
|
|
has_snapshot_node_name =
|
|
|
|
action->blockdev_snapshot_sync->has_snapshot_node_name;
|
|
|
|
snapshot_node_name = action->blockdev_snapshot_sync->snapshot_node_name;
|
|
|
|
|
2013-05-08 18:25:13 +08:00
|
|
|
new_image_file = action->blockdev_snapshot_sync->snapshot_file;
|
|
|
|
if (action->blockdev_snapshot_sync->has_format) {
|
|
|
|
format = action->blockdev_snapshot_sync->format;
|
|
|
|
}
|
|
|
|
if (action->blockdev_snapshot_sync->has_mode) {
|
|
|
|
mode = action->blockdev_snapshot_sync->mode;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* start processing */
|
2013-05-08 18:25:12 +08:00
|
|
|
drv = bdrv_find_format(format);
|
|
|
|
if (!drv) {
|
|
|
|
error_set(errp, QERR_INVALID_BLOCK_FORMAT, format);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2014-01-24 04:31:38 +08:00
|
|
|
state->old_bs = bdrv_lookup_bs(has_device ? device : NULL,
|
|
|
|
has_node_name ? node_name : NULL,
|
|
|
|
&local_err);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2014-01-24 04:31:38 +08:00
|
|
|
error_propagate(errp, local_err);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (has_node_name && !has_snapshot_node_name) {
|
|
|
|
error_setg(errp, "New snapshot node name missing");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (has_snapshot_node_name && bdrv_find_node(snapshot_node_name)) {
|
|
|
|
error_setg(errp, "New snapshot node name already existing");
|
2013-05-08 18:25:12 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2013-06-24 23:13:15 +08:00
|
|
|
if (!bdrv_is_inserted(state->old_bs)) {
|
2013-05-08 18:25:12 +08:00
|
|
|
error_set(errp, QERR_DEVICE_HAS_NO_MEDIUM, device);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2014-05-23 21:29:43 +08:00
|
|
|
if (bdrv_op_is_blocked(state->old_bs,
|
|
|
|
BLOCK_OP_TYPE_EXTERNAL_SNAPSHOT, errp)) {
|
2013-05-08 18:25:12 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2013-06-24 23:13:15 +08:00
|
|
|
if (!bdrv_is_read_only(state->old_bs)) {
|
|
|
|
if (bdrv_flush(state->old_bs)) {
|
2013-05-08 18:25:12 +08:00
|
|
|
error_set(errp, QERR_IO_ERROR);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-01-24 04:31:36 +08:00
|
|
|
if (!bdrv_is_first_non_filter(state->old_bs)) {
|
2013-10-02 20:33:48 +08:00
|
|
|
error_set(errp, QERR_FEATURE_DISABLED, "snapshot");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2013-06-24 23:13:15 +08:00
|
|
|
flags = state->old_bs->open_flags;
|
2013-05-08 18:25:12 +08:00
|
|
|
|
|
|
|
/* create new image w/backing file */
|
|
|
|
if (mode != NEW_IMAGE_MODE_EXISTING) {
|
|
|
|
bdrv_img_create(new_image_file, format,
|
2013-06-24 23:13:15 +08:00
|
|
|
state->old_bs->filename,
|
|
|
|
state->old_bs->drv->format_name,
|
2013-05-08 18:25:12 +08:00
|
|
|
NULL, -1, flags, &local_err, false);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2013-05-08 18:25:12 +08:00
|
|
|
error_propagate(errp, local_err);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-01-24 04:31:38 +08:00
|
|
|
if (has_snapshot_node_name) {
|
|
|
|
options = qdict_new();
|
|
|
|
qdict_put(options, "node-name",
|
|
|
|
qstring_from_str(snapshot_node_name));
|
|
|
|
}
|
|
|
|
|
2013-05-08 18:25:12 +08:00
|
|
|
/* TODO Inherit bs->options or only take explicit options with an
|
|
|
|
* extended QMP command? */
|
2014-02-19 01:33:05 +08:00
|
|
|
assert(state->new_bs == NULL);
|
2014-02-19 01:33:06 +08:00
|
|
|
ret = bdrv_open(&state->new_bs, new_image_file, NULL, options,
|
2013-09-05 20:45:29 +08:00
|
|
|
flags | BDRV_O_NO_BACKING, drv, &local_err);
|
2014-02-19 01:33:05 +08:00
|
|
|
/* We will manually add the backing_hd field to the bs later */
|
2013-05-08 18:25:12 +08:00
|
|
|
if (ret != 0) {
|
2013-09-05 20:45:29 +08:00
|
|
|
error_propagate(errp, local_err);
|
2013-05-08 18:25:12 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-06-24 23:13:15 +08:00
|
|
|
static void external_snapshot_commit(BlkTransactionState *common)
|
2013-05-08 18:25:14 +08:00
|
|
|
{
|
2013-06-24 23:13:15 +08:00
|
|
|
ExternalSnapshotState *state =
|
|
|
|
DO_UPCAST(ExternalSnapshotState, common, common);
|
2013-05-08 18:25:16 +08:00
|
|
|
|
2013-06-24 23:13:15 +08:00
|
|
|
/* This removes our old bs and adds the new bs */
|
|
|
|
bdrv_append(state->new_bs, state->old_bs);
|
2013-05-08 18:25:14 +08:00
|
|
|
/* We don't need (or want) to use the transactional
|
|
|
|
* bdrv_reopen_multiple() across all the entries at once, because we
|
|
|
|
* don't want to abort all of them if one of them fails the reopen */
|
2013-06-24 23:13:15 +08:00
|
|
|
bdrv_reopen(state->new_bs, state->new_bs->open_flags & ~BDRV_O_RDWR,
|
2013-05-08 18:25:14 +08:00
|
|
|
NULL);
|
|
|
|
}
|
|
|
|
|
2013-06-24 23:13:15 +08:00
|
|
|
static void external_snapshot_abort(BlkTransactionState *common)
|
2013-05-08 18:25:15 +08:00
|
|
|
{
|
2013-06-24 23:13:15 +08:00
|
|
|
ExternalSnapshotState *state =
|
|
|
|
DO_UPCAST(ExternalSnapshotState, common, common);
|
|
|
|
if (state->new_bs) {
|
2013-08-23 09:14:47 +08:00
|
|
|
bdrv_unref(state->new_bs);
|
2013-05-08 18:25:15 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
blockdev: add DriveBackup transaction
This patch adds a transactional version of the drive-backup QMP command.
It allows atomic snapshots of multiple drives along with automatic
cleanup if there is a failure to start one of the backup jobs.
Note that QMP events are emitted for block job completion/cancellation
and the block job will be listed by query-block-jobs.
@device: the name of the device whose writes should be mirrored.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:17 +08:00
|
|
|
typedef struct DriveBackupState {
|
|
|
|
BlkTransactionState common;
|
|
|
|
BlockDriverState *bs;
|
|
|
|
BlockJob *job;
|
|
|
|
} DriveBackupState;
|
|
|
|
|
|
|
|
static void drive_backup_prepare(BlkTransactionState *common, Error **errp)
|
|
|
|
{
|
|
|
|
DriveBackupState *state = DO_UPCAST(DriveBackupState, common, common);
|
|
|
|
DriveBackup *backup;
|
|
|
|
Error *local_err = NULL;
|
|
|
|
|
|
|
|
assert(common->action->kind == TRANSACTION_ACTION_KIND_DRIVE_BACKUP);
|
|
|
|
backup = common->action->drive_backup;
|
|
|
|
|
|
|
|
qmp_drive_backup(backup->device, backup->target,
|
|
|
|
backup->has_format, backup->format,
|
2013-06-26 20:11:57 +08:00
|
|
|
backup->sync,
|
blockdev: add DriveBackup transaction
This patch adds a transactional version of the drive-backup QMP command.
It allows atomic snapshots of multiple drives along with automatic
cleanup if there is a failure to start one of the backup jobs.
Note that QMP events are emitted for block job completion/cancellation
and the block job will be listed by query-block-jobs.
@device: the name of the device whose writes should be mirrored.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:17 +08:00
|
|
|
backup->has_mode, backup->mode,
|
|
|
|
backup->has_speed, backup->speed,
|
|
|
|
backup->has_on_source_error, backup->on_source_error,
|
|
|
|
backup->has_on_target_error, backup->on_target_error,
|
|
|
|
&local_err);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
blockdev: add DriveBackup transaction
This patch adds a transactional version of the drive-backup QMP command.
It allows atomic snapshots of multiple drives along with automatic
cleanup if there is a failure to start one of the backup jobs.
Note that QMP events are emitted for block job completion/cancellation
and the block job will be listed by query-block-jobs.
@device: the name of the device whose writes should be mirrored.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:17 +08:00
|
|
|
error_propagate(errp, local_err);
|
|
|
|
state->bs = NULL;
|
|
|
|
state->job = NULL;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
state->bs = bdrv_find(backup->device);
|
|
|
|
state->job = state->bs->job;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void drive_backup_abort(BlkTransactionState *common)
|
|
|
|
{
|
|
|
|
DriveBackupState *state = DO_UPCAST(DriveBackupState, common, common);
|
|
|
|
BlockDriverState *bs = state->bs;
|
|
|
|
|
|
|
|
/* Only cancel if it's the job we started */
|
|
|
|
if (bs && bs->job && bs->job == state->job) {
|
|
|
|
block_job_cancel_sync(bs->job);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-06-24 23:13:18 +08:00
|
|
|
static void abort_prepare(BlkTransactionState *common, Error **errp)
|
|
|
|
{
|
|
|
|
error_setg(errp, "Transaction aborted using Abort action");
|
|
|
|
}
|
|
|
|
|
|
|
|
static void abort_commit(BlkTransactionState *common)
|
|
|
|
{
|
2013-07-26 00:21:28 +08:00
|
|
|
g_assert_not_reached(); /* this action never succeeds */
|
2013-06-24 23:13:18 +08:00
|
|
|
}
|
|
|
|
|
2013-05-08 18:25:16 +08:00
|
|
|
static const BdrvActionOps actions[] = {
|
2013-05-13 16:43:43 +08:00
|
|
|
[TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC] = {
|
2013-06-24 23:13:15 +08:00
|
|
|
.instance_size = sizeof(ExternalSnapshotState),
|
2013-05-08 18:25:16 +08:00
|
|
|
.prepare = external_snapshot_prepare,
|
|
|
|
.commit = external_snapshot_commit,
|
|
|
|
.abort = external_snapshot_abort,
|
|
|
|
},
|
blockdev: add DriveBackup transaction
This patch adds a transactional version of the drive-backup QMP command.
It allows atomic snapshots of multiple drives along with automatic
cleanup if there is a failure to start one of the backup jobs.
Note that QMP events are emitted for block job completion/cancellation
and the block job will be listed by query-block-jobs.
@device: the name of the device whose writes should be mirrored.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:17 +08:00
|
|
|
[TRANSACTION_ACTION_KIND_DRIVE_BACKUP] = {
|
|
|
|
.instance_size = sizeof(DriveBackupState),
|
|
|
|
.prepare = drive_backup_prepare,
|
|
|
|
.abort = drive_backup_abort,
|
|
|
|
},
|
2013-06-24 23:13:18 +08:00
|
|
|
[TRANSACTION_ACTION_KIND_ABORT] = {
|
|
|
|
.instance_size = sizeof(BlkTransactionState),
|
|
|
|
.prepare = abort_prepare,
|
|
|
|
.commit = abort_commit,
|
|
|
|
},
|
2013-09-11 14:04:34 +08:00
|
|
|
[TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_INTERNAL_SYNC] = {
|
|
|
|
.instance_size = sizeof(InternalSnapshotState),
|
|
|
|
.prepare = internal_snapshot_prepare,
|
|
|
|
.abort = internal_snapshot_abort,
|
|
|
|
},
|
2013-05-08 18:25:16 +08:00
|
|
|
};
|
|
|
|
|
2012-02-29 04:54:06 +08:00
|
|
|
/*
|
|
|
|
* 'Atomic' group snapshots. The snapshots are taken as a set, and if any fail
|
|
|
|
* then we do not pivot any of the devices in the group, and abandon the
|
|
|
|
* snapshots
|
|
|
|
*/
|
2013-05-13 16:43:43 +08:00
|
|
|
void qmp_transaction(TransactionActionList *dev_list, Error **errp)
|
2012-02-29 04:54:06 +08:00
|
|
|
{
|
2013-05-13 16:43:43 +08:00
|
|
|
TransactionActionList *dev_entry = dev_list;
|
2013-06-24 23:13:15 +08:00
|
|
|
BlkTransactionState *state, *next;
|
2012-11-30 20:52:07 +08:00
|
|
|
Error *local_err = NULL;
|
2012-02-29 04:54:06 +08:00
|
|
|
|
2013-06-24 23:13:15 +08:00
|
|
|
QSIMPLEQ_HEAD(snap_bdrv_states, BlkTransactionState) snap_bdrv_states;
|
2012-02-29 04:54:06 +08:00
|
|
|
QSIMPLEQ_INIT(&snap_bdrv_states);
|
|
|
|
|
|
|
|
/* drain all i/o before any snapshots */
|
|
|
|
bdrv_drain_all();
|
|
|
|
|
|
|
|
/* We don't do anything in this loop that commits us to the snapshot */
|
|
|
|
while (NULL != dev_entry) {
|
2013-05-13 16:43:43 +08:00
|
|
|
TransactionAction *dev_info = NULL;
|
2013-05-08 18:25:16 +08:00
|
|
|
const BdrvActionOps *ops;
|
2012-03-07 01:55:57 +08:00
|
|
|
|
2012-02-29 04:54:06 +08:00
|
|
|
dev_info = dev_entry->value;
|
|
|
|
dev_entry = dev_entry->next;
|
|
|
|
|
2013-05-08 18:25:16 +08:00
|
|
|
assert(dev_info->kind < ARRAY_SIZE(actions));
|
|
|
|
|
|
|
|
ops = &actions[dev_info->kind];
|
2013-09-12 20:57:27 +08:00
|
|
|
assert(ops->instance_size > 0);
|
|
|
|
|
2013-06-24 23:13:15 +08:00
|
|
|
state = g_malloc0(ops->instance_size);
|
|
|
|
state->ops = ops;
|
|
|
|
state->action = dev_info;
|
|
|
|
QSIMPLEQ_INSERT_TAIL(&snap_bdrv_states, state, entry);
|
2012-02-29 04:54:06 +08:00
|
|
|
|
2013-06-24 23:13:15 +08:00
|
|
|
state->ops->prepare(state, &local_err);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2013-05-08 18:25:16 +08:00
|
|
|
error_propagate(errp, local_err);
|
|
|
|
goto delete_and_fail;
|
2012-02-29 04:54:06 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-06-24 23:13:15 +08:00
|
|
|
QSIMPLEQ_FOREACH(state, &snap_bdrv_states, entry) {
|
2013-06-24 23:13:16 +08:00
|
|
|
if (state->ops->commit) {
|
|
|
|
state->ops->commit(state);
|
|
|
|
}
|
2012-02-29 04:54:06 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* success */
|
|
|
|
goto exit;
|
|
|
|
|
|
|
|
delete_and_fail:
|
|
|
|
/*
|
|
|
|
* failure, and it is all-or-none; abandon each new bs, and keep using
|
|
|
|
* the original bs for all images
|
|
|
|
*/
|
2013-06-24 23:13:15 +08:00
|
|
|
QSIMPLEQ_FOREACH(state, &snap_bdrv_states, entry) {
|
|
|
|
if (state->ops->abort) {
|
|
|
|
state->ops->abort(state);
|
2013-05-08 18:25:16 +08:00
|
|
|
}
|
2012-02-29 04:54:06 +08:00
|
|
|
}
|
|
|
|
exit:
|
2013-06-24 23:13:15 +08:00
|
|
|
QSIMPLEQ_FOREACH_SAFE(state, &snap_bdrv_states, entry, next) {
|
|
|
|
if (state->ops->clean) {
|
|
|
|
state->ops->clean(state);
|
2013-05-08 18:25:16 +08:00
|
|
|
}
|
2013-06-24 23:13:15 +08:00
|
|
|
g_free(state);
|
2012-02-29 04:54:06 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-10-07 19:59:24 +08:00
|
|
|
static void eject_device(BlockBackend *blk, int force, Error **errp)
|
2010-06-03 00:48:27 +08:00
|
|
|
{
|
2014-10-07 19:59:24 +08:00
|
|
|
BlockDriverState *bs = blk_bs(blk);
|
|
|
|
|
2014-05-23 21:29:43 +08:00
|
|
|
if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_EJECT, errp)) {
|
2012-01-18 22:40:41 +08:00
|
|
|
return;
|
|
|
|
}
|
2014-10-07 19:59:25 +08:00
|
|
|
if (!blk_dev_has_removable_media(blk)) {
|
2014-03-22 07:42:26 +08:00
|
|
|
error_setg(errp, "Device '%s' is not removable",
|
|
|
|
bdrv_get_device_name(bs));
|
2011-12-08 01:47:23 +08:00
|
|
|
return;
|
2011-07-21 00:23:35 +08:00
|
|
|
}
|
2011-12-08 01:47:23 +08:00
|
|
|
|
2014-10-07 19:59:25 +08:00
|
|
|
if (blk_dev_is_medium_locked(blk) && !blk_dev_is_tray_open(blk)) {
|
|
|
|
blk_dev_eject_request(blk, force);
|
2011-11-08 00:50:13 +08:00
|
|
|
if (!force) {
|
2014-03-22 07:42:26 +08:00
|
|
|
error_setg(errp, "Device '%s' is locked",
|
|
|
|
bdrv_get_device_name(bs));
|
2011-12-08 01:47:23 +08:00
|
|
|
return;
|
2011-11-08 00:50:13 +08:00
|
|
|
}
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
2011-12-08 01:47:23 +08:00
|
|
|
|
2010-06-02 06:12:19 +08:00
|
|
|
bdrv_close(bs);
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
|
|
|
|
2011-12-08 02:02:36 +08:00
|
|
|
void qmp_eject(const char *device, bool has_force, bool force, Error **errp)
|
2010-06-03 00:48:27 +08:00
|
|
|
{
|
2014-10-07 19:59:24 +08:00
|
|
|
BlockBackend *blk;
|
2010-06-03 00:48:27 +08:00
|
|
|
|
2014-10-07 19:59:24 +08:00
|
|
|
blk = blk_by_name(device);
|
|
|
|
if (!blk) {
|
2011-12-08 02:02:36 +08:00
|
|
|
error_set(errp, QERR_DEVICE_NOT_FOUND, device);
|
|
|
|
return;
|
2011-12-08 01:47:23 +08:00
|
|
|
}
|
|
|
|
|
2014-10-07 19:59:24 +08:00
|
|
|
eject_device(blk, force, errp);
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
|
|
|
|
2014-01-24 04:31:35 +08:00
|
|
|
void qmp_block_passwd(bool has_device, const char *device,
|
|
|
|
bool has_node_name, const char *node_name,
|
|
|
|
const char *password, Error **errp)
|
2010-06-03 00:48:27 +08:00
|
|
|
{
|
2014-01-24 04:31:35 +08:00
|
|
|
Error *local_err = NULL;
|
2010-06-03 00:48:27 +08:00
|
|
|
BlockDriverState *bs;
|
|
|
|
int err;
|
|
|
|
|
2014-01-24 04:31:35 +08:00
|
|
|
bs = bdrv_lookup_bs(has_device ? device : NULL,
|
|
|
|
has_node_name ? node_name : NULL,
|
|
|
|
&local_err);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2014-01-24 04:31:35 +08:00
|
|
|
error_propagate(errp, local_err);
|
2011-11-23 23:28:21 +08:00
|
|
|
return;
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
|
|
|
|
2011-11-23 23:28:21 +08:00
|
|
|
err = bdrv_set_key(bs, password);
|
2010-06-03 00:48:27 +08:00
|
|
|
if (err == -EINVAL) {
|
2011-11-23 23:28:21 +08:00
|
|
|
error_set(errp, QERR_DEVICE_NOT_ENCRYPTED, bdrv_get_device_name(bs));
|
|
|
|
return;
|
2010-06-03 00:48:27 +08:00
|
|
|
} else if (err < 0) {
|
2011-11-23 23:28:21 +08:00
|
|
|
error_set(errp, QERR_INVALID_PASSWORD);
|
|
|
|
return;
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-12-08 21:13:50 +08:00
|
|
|
static void qmp_bdrv_open_encrypted(BlockDriverState *bs, const char *filename,
|
|
|
|
int bdrv_flags, BlockDriver *drv,
|
|
|
|
const char *password, Error **errp)
|
|
|
|
{
|
2013-09-05 20:45:29 +08:00
|
|
|
Error *local_err = NULL;
|
2013-06-08 02:33:48 +08:00
|
|
|
int ret;
|
|
|
|
|
2014-02-19 01:33:06 +08:00
|
|
|
ret = bdrv_open(&bs, filename, NULL, NULL, bdrv_flags, drv, &local_err);
|
2013-06-08 02:33:48 +08:00
|
|
|
if (ret < 0) {
|
2013-09-05 20:45:29 +08:00
|
|
|
error_propagate(errp, local_err);
|
2011-12-08 21:13:50 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (bdrv_key_required(bs)) {
|
|
|
|
if (password) {
|
|
|
|
if (bdrv_set_key(bs, password) < 0) {
|
|
|
|
error_set(errp, QERR_INVALID_PASSWORD);
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
error_set(errp, QERR_DEVICE_ENCRYPTED, bdrv_get_device_name(bs),
|
|
|
|
bdrv_get_encrypted_filename(bs));
|
|
|
|
}
|
|
|
|
} else if (password) {
|
|
|
|
error_set(errp, QERR_DEVICE_NOT_ENCRYPTED, bdrv_get_device_name(bs));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void qmp_change_blockdev(const char *device, const char *filename,
|
2013-12-02 05:23:37 +08:00
|
|
|
const char *format, Error **errp)
|
2010-06-03 00:48:27 +08:00
|
|
|
{
|
2014-10-07 19:59:24 +08:00
|
|
|
BlockBackend *blk;
|
2010-06-03 00:48:27 +08:00
|
|
|
BlockDriverState *bs;
|
|
|
|
BlockDriver *drv = NULL;
|
|
|
|
int bdrv_flags;
|
2011-12-08 01:47:23 +08:00
|
|
|
Error *err = NULL;
|
2010-06-03 00:48:27 +08:00
|
|
|
|
2014-10-07 19:59:24 +08:00
|
|
|
blk = blk_by_name(device);
|
|
|
|
if (!blk) {
|
2011-12-08 21:13:50 +08:00
|
|
|
error_set(errp, QERR_DEVICE_NOT_FOUND, device);
|
|
|
|
return;
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
2014-10-07 19:59:24 +08:00
|
|
|
bs = blk_bs(blk);
|
2011-12-08 21:13:50 +08:00
|
|
|
|
|
|
|
if (format) {
|
2013-05-29 19:35:40 +08:00
|
|
|
drv = bdrv_find_whitelisted_format(format, bs->read_only);
|
2010-06-03 00:48:27 +08:00
|
|
|
if (!drv) {
|
2011-12-08 21:13:50 +08:00
|
|
|
error_set(errp, QERR_INVALID_BLOCK_FORMAT, format);
|
|
|
|
return;
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
|
|
|
}
|
2011-12-08 21:13:50 +08:00
|
|
|
|
2014-10-07 19:59:24 +08:00
|
|
|
eject_device(blk, 0, &err);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (err) {
|
2011-12-08 21:13:50 +08:00
|
|
|
error_propagate(errp, err);
|
|
|
|
return;
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
2011-12-08 21:13:50 +08:00
|
|
|
|
2010-06-25 21:26:48 +08:00
|
|
|
bdrv_flags = bdrv_is_read_only(bs) ? 0 : BDRV_O_RDWR;
|
2010-07-26 04:49:34 +08:00
|
|
|
bdrv_flags |= bdrv_is_snapshot(bs) ? BDRV_O_SNAPSHOT : 0;
|
2011-12-08 21:13:50 +08:00
|
|
|
|
|
|
|
qmp_bdrv_open_encrypted(bs, filename, bdrv_flags, drv, NULL, errp);
|
2010-06-03 00:48:27 +08:00
|
|
|
}
|
2010-11-13 01:07:13 +08:00
|
|
|
|
2011-11-08 13:00:31 +08:00
|
|
|
/* throttling disk I/O limits */
|
2011-12-15 02:49:14 +08:00
|
|
|
void qmp_block_set_io_throttle(const char *device, int64_t bps, int64_t bps_rd,
|
2013-09-02 20:14:40 +08:00
|
|
|
int64_t bps_wr,
|
|
|
|
int64_t iops,
|
|
|
|
int64_t iops_rd,
|
|
|
|
int64_t iops_wr,
|
|
|
|
bool has_bps_max,
|
|
|
|
int64_t bps_max,
|
|
|
|
bool has_bps_rd_max,
|
|
|
|
int64_t bps_rd_max,
|
|
|
|
bool has_bps_wr_max,
|
|
|
|
int64_t bps_wr_max,
|
|
|
|
bool has_iops_max,
|
|
|
|
int64_t iops_max,
|
|
|
|
bool has_iops_rd_max,
|
|
|
|
int64_t iops_rd_max,
|
|
|
|
bool has_iops_wr_max,
|
2013-09-02 20:14:41 +08:00
|
|
|
int64_t iops_wr_max,
|
|
|
|
bool has_iops_size,
|
|
|
|
int64_t iops_size, Error **errp)
|
2011-11-08 13:00:31 +08:00
|
|
|
{
|
2013-09-02 20:14:39 +08:00
|
|
|
ThrottleConfig cfg;
|
2011-11-08 13:00:31 +08:00
|
|
|
BlockDriverState *bs;
|
2014-05-14 22:22:47 +08:00
|
|
|
AioContext *aio_context;
|
2011-11-08 13:00:31 +08:00
|
|
|
|
2011-12-15 02:49:14 +08:00
|
|
|
bs = bdrv_find(device);
|
2011-11-08 13:00:31 +08:00
|
|
|
if (!bs) {
|
2011-12-15 02:49:14 +08:00
|
|
|
error_set(errp, QERR_DEVICE_NOT_FOUND, device);
|
|
|
|
return;
|
2011-11-08 13:00:31 +08:00
|
|
|
}
|
|
|
|
|
2013-09-02 20:14:39 +08:00
|
|
|
memset(&cfg, 0, sizeof(cfg));
|
|
|
|
cfg.buckets[THROTTLE_BPS_TOTAL].avg = bps;
|
|
|
|
cfg.buckets[THROTTLE_BPS_READ].avg = bps_rd;
|
|
|
|
cfg.buckets[THROTTLE_BPS_WRITE].avg = bps_wr;
|
|
|
|
|
|
|
|
cfg.buckets[THROTTLE_OPS_TOTAL].avg = iops;
|
|
|
|
cfg.buckets[THROTTLE_OPS_READ].avg = iops_rd;
|
|
|
|
cfg.buckets[THROTTLE_OPS_WRITE].avg = iops_wr;
|
|
|
|
|
2013-09-02 20:14:40 +08:00
|
|
|
if (has_bps_max) {
|
|
|
|
cfg.buckets[THROTTLE_BPS_TOTAL].max = bps_max;
|
|
|
|
}
|
|
|
|
if (has_bps_rd_max) {
|
|
|
|
cfg.buckets[THROTTLE_BPS_READ].max = bps_rd_max;
|
|
|
|
}
|
|
|
|
if (has_bps_wr_max) {
|
|
|
|
cfg.buckets[THROTTLE_BPS_WRITE].max = bps_wr_max;
|
|
|
|
}
|
|
|
|
if (has_iops_max) {
|
|
|
|
cfg.buckets[THROTTLE_OPS_TOTAL].max = iops_max;
|
|
|
|
}
|
|
|
|
if (has_iops_rd_max) {
|
|
|
|
cfg.buckets[THROTTLE_OPS_READ].max = iops_rd_max;
|
|
|
|
}
|
|
|
|
if (has_iops_wr_max) {
|
|
|
|
cfg.buckets[THROTTLE_OPS_WRITE].max = iops_wr_max;
|
|
|
|
}
|
2011-11-08 13:00:31 +08:00
|
|
|
|
2013-09-02 20:14:41 +08:00
|
|
|
if (has_iops_size) {
|
|
|
|
cfg.op_size = iops_size;
|
|
|
|
}
|
2013-09-02 20:14:39 +08:00
|
|
|
|
|
|
|
if (!check_throttle_config(&cfg, errp)) {
|
2011-12-15 02:49:14 +08:00
|
|
|
return;
|
2011-11-08 13:00:31 +08:00
|
|
|
}
|
|
|
|
|
2014-05-14 22:22:47 +08:00
|
|
|
aio_context = bdrv_get_aio_context(bs);
|
|
|
|
aio_context_acquire(aio_context);
|
|
|
|
|
2013-09-02 20:14:39 +08:00
|
|
|
if (!bs->io_limits_enabled && throttle_enabled(&cfg)) {
|
2011-11-08 13:00:31 +08:00
|
|
|
bdrv_io_limits_enable(bs);
|
2013-09-02 20:14:39 +08:00
|
|
|
} else if (bs->io_limits_enabled && !throttle_enabled(&cfg)) {
|
2011-11-08 13:00:31 +08:00
|
|
|
bdrv_io_limits_disable(bs);
|
2013-09-02 20:14:39 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (bs->io_limits_enabled) {
|
|
|
|
bdrv_set_io_limits(bs, &cfg);
|
2011-11-08 13:00:31 +08:00
|
|
|
}
|
2014-05-14 22:22:47 +08:00
|
|
|
|
|
|
|
aio_context_release(aio_context);
|
2011-11-08 13:00:31 +08:00
|
|
|
}
|
|
|
|
|
2010-11-13 01:07:13 +08:00
|
|
|
int do_drive_del(Monitor *mon, const QDict *qdict, QObject **ret_data)
|
|
|
|
{
|
|
|
|
const char *id = qdict_get_str(qdict, "id");
|
2014-10-07 19:59:05 +08:00
|
|
|
BlockBackend *blk;
|
2010-11-13 01:07:13 +08:00
|
|
|
BlockDriverState *bs;
|
2014-08-18 23:07:12 +08:00
|
|
|
AioContext *aio_context;
|
2014-05-23 21:29:43 +08:00
|
|
|
Error *local_err = NULL;
|
2010-11-13 01:07:13 +08:00
|
|
|
|
2014-10-07 19:59:05 +08:00
|
|
|
blk = blk_by_name(id);
|
|
|
|
if (!blk) {
|
2014-05-16 17:00:09 +08:00
|
|
|
error_report("Device '%s' not found", id);
|
2010-11-13 01:07:13 +08:00
|
|
|
return -1;
|
|
|
|
}
|
2014-10-07 19:59:05 +08:00
|
|
|
bs = blk_bs(blk);
|
2014-08-18 23:07:12 +08:00
|
|
|
|
2014-10-07 19:59:22 +08:00
|
|
|
if (!blk_legacy_dinfo(blk)) {
|
2014-09-11 22:45:39 +08:00
|
|
|
error_report("Deleting device added with blockdev-add"
|
|
|
|
" is not supported");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2014-08-18 23:07:12 +08:00
|
|
|
aio_context = bdrv_get_aio_context(bs);
|
|
|
|
aio_context_acquire(aio_context);
|
|
|
|
|
2014-05-23 21:29:43 +08:00
|
|
|
if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_DRIVE_DEL, &local_err)) {
|
|
|
|
error_report("%s", error_get_pretty(local_err));
|
|
|
|
error_free(local_err);
|
2014-08-18 23:07:12 +08:00
|
|
|
aio_context_release(aio_context);
|
2011-01-26 22:12:35 +08:00
|
|
|
return -1;
|
|
|
|
}
|
2010-11-13 01:07:13 +08:00
|
|
|
|
|
|
|
/* quiesce block driver; prevent further io */
|
2011-11-30 20:23:43 +08:00
|
|
|
bdrv_drain_all();
|
2010-11-13 01:07:13 +08:00
|
|
|
bdrv_flush(bs);
|
|
|
|
bdrv_close(bs);
|
|
|
|
|
2011-08-03 21:07:40 +08:00
|
|
|
/* if we have a device attached to this BlockDriverState
|
Do not delete BlockDriverState when deleting the drive
When removing a drive from the host-side via drive_del we currently have
the following path:
drive_del
qemu_aio_flush()
bdrv_close() // zaps bs->drv, which makes any subsequent I/O get
// dropped. Works as designed
drive_uninit()
bdrv_delete() // frees the bs. Since the device is still connected to
// bs, any subsequent I/O is a use-after-free.
The value of bs->drv becomes unpredictable on free. As long as it
remains null, I/O still gets dropped, however it could become non-null
at any point after the free resulting SEGVs or other QEMU state
corruption.
To resolve this issue as simply as possible, we can chose to not
actually delete the BlockDriverState pointer. Since bdrv_close()
handles setting the drv pointer to NULL, we just need to remove the
BlockDriverState from the QLIST that is used to enumerate the block
devices. This is currently handled within bdrv_delete, so move this
into its own function, bdrv_make_anon().
The result is that we can now invoke drive_del, this closes the file
descriptors and sets BlockDriverState->drv to NULL which prevents futher
IO to the device, and since we do not free BlockDriverState, we don't
have to worry about the copy retained in the block devices.
We also don't attempt to remove the qdev property since we are no longer
deleting the BlockDriverState on drives with associated drives. This
also allows for removing Drives with no devices associated either.
Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
Acked-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2011-03-30 09:51:47 +08:00
|
|
|
* then we need to make the drive anonymous until the device
|
|
|
|
* can be removed. If this is a drive with no device backing
|
|
|
|
* then we can just get rid of the block driver state right here.
|
|
|
|
*/
|
2014-10-07 19:59:25 +08:00
|
|
|
if (blk_get_attached_dev(blk)) {
|
2014-10-07 19:59:05 +08:00
|
|
|
blk_hide_on_behalf_of_do_drive_del(blk);
|
2013-06-05 16:33:14 +08:00
|
|
|
/* Further I/O must not pause the guest */
|
|
|
|
bdrv_set_on_error(bs, BLOCKDEV_ON_ERROR_REPORT,
|
|
|
|
BLOCKDEV_ON_ERROR_REPORT);
|
Do not delete BlockDriverState when deleting the drive
When removing a drive from the host-side via drive_del we currently have
the following path:
drive_del
qemu_aio_flush()
bdrv_close() // zaps bs->drv, which makes any subsequent I/O get
// dropped. Works as designed
drive_uninit()
bdrv_delete() // frees the bs. Since the device is still connected to
// bs, any subsequent I/O is a use-after-free.
The value of bs->drv becomes unpredictable on free. As long as it
remains null, I/O still gets dropped, however it could become non-null
at any point after the free resulting SEGVs or other QEMU state
corruption.
To resolve this issue as simply as possible, we can chose to not
actually delete the BlockDriverState pointer. Since bdrv_close()
handles setting the drv pointer to NULL, we just need to remove the
BlockDriverState from the QLIST that is used to enumerate the block
devices. This is currently handled within bdrv_delete, so move this
into its own function, bdrv_make_anon().
The result is that we can now invoke drive_del, this closes the file
descriptors and sets BlockDriverState->drv to NULL which prevents futher
IO to the device, and since we do not free BlockDriverState, we don't
have to worry about the copy retained in the block devices.
We also don't attempt to remove the qdev property since we are no longer
deleting the BlockDriverState on drives with associated drives. This
also allows for removing Drives with no devices associated either.
Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
Acked-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2011-03-30 09:51:47 +08:00
|
|
|
} else {
|
2014-10-07 19:59:09 +08:00
|
|
|
blk_unref(blk);
|
2010-11-13 01:07:13 +08:00
|
|
|
}
|
|
|
|
|
2014-08-18 23:07:12 +08:00
|
|
|
aio_context_release(aio_context);
|
2010-11-13 01:07:13 +08:00
|
|
|
return 0;
|
|
|
|
}
|
2011-01-24 20:32:33 +08:00
|
|
|
|
2014-01-24 04:31:37 +08:00
|
|
|
void qmp_block_resize(bool has_device, const char *device,
|
|
|
|
bool has_node_name, const char *node_name,
|
|
|
|
int64_t size, Error **errp)
|
2011-01-24 20:32:33 +08:00
|
|
|
{
|
2014-01-24 04:31:37 +08:00
|
|
|
Error *local_err = NULL;
|
2011-01-24 20:32:33 +08:00
|
|
|
BlockDriverState *bs;
|
2014-08-18 21:52:28 +08:00
|
|
|
AioContext *aio_context;
|
2013-05-02 21:32:55 +08:00
|
|
|
int ret;
|
2011-01-24 20:32:33 +08:00
|
|
|
|
2014-01-24 04:31:37 +08:00
|
|
|
bs = bdrv_lookup_bs(has_device ? device : NULL,
|
|
|
|
has_node_name ? node_name : NULL,
|
|
|
|
&local_err);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2014-01-24 04:31:37 +08:00
|
|
|
error_propagate(errp, local_err);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2014-08-18 21:52:28 +08:00
|
|
|
aio_context = bdrv_get_aio_context(bs);
|
|
|
|
aio_context_acquire(aio_context);
|
|
|
|
|
2014-01-24 04:31:37 +08:00
|
|
|
if (!bdrv_is_first_non_filter(bs)) {
|
|
|
|
error_set(errp, QERR_FEATURE_DISABLED, "resize");
|
2014-08-18 21:52:28 +08:00
|
|
|
goto out;
|
2011-01-24 20:32:33 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (size < 0) {
|
2012-01-05 06:23:34 +08:00
|
|
|
error_set(errp, QERR_INVALID_PARAMETER_VALUE, "size", "a >0 size");
|
2014-08-18 21:52:28 +08:00
|
|
|
goto out;
|
2011-01-24 20:32:33 +08:00
|
|
|
}
|
|
|
|
|
2014-06-26 04:55:30 +08:00
|
|
|
if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_RESIZE, NULL)) {
|
|
|
|
error_set(errp, QERR_DEVICE_IN_USE, device);
|
2014-08-18 21:52:28 +08:00
|
|
|
goto out;
|
2014-06-26 04:55:30 +08:00
|
|
|
}
|
|
|
|
|
2013-03-11 18:04:24 +08:00
|
|
|
/* complete all in-flight operations before resizing the device */
|
|
|
|
bdrv_drain_all();
|
|
|
|
|
2013-05-02 21:32:55 +08:00
|
|
|
ret = bdrv_truncate(bs, size);
|
|
|
|
switch (ret) {
|
2012-01-05 06:23:34 +08:00
|
|
|
case 0:
|
|
|
|
break;
|
|
|
|
case -ENOMEDIUM:
|
|
|
|
error_set(errp, QERR_DEVICE_HAS_NO_MEDIUM, device);
|
|
|
|
break;
|
|
|
|
case -ENOTSUP:
|
|
|
|
error_set(errp, QERR_UNSUPPORTED);
|
|
|
|
break;
|
|
|
|
case -EACCES:
|
|
|
|
error_set(errp, QERR_DEVICE_IS_READ_ONLY, device);
|
|
|
|
break;
|
|
|
|
case -EBUSY:
|
|
|
|
error_set(errp, QERR_DEVICE_IN_USE, device);
|
|
|
|
break;
|
|
|
|
default:
|
2013-05-02 21:32:55 +08:00
|
|
|
error_setg_errno(errp, -ret, "Could not resize");
|
2012-01-05 06:23:34 +08:00
|
|
|
break;
|
2011-01-24 20:32:33 +08:00
|
|
|
}
|
2014-08-18 21:52:28 +08:00
|
|
|
|
|
|
|
out:
|
|
|
|
aio_context_release(aio_context);
|
2011-01-24 20:32:33 +08:00
|
|
|
}
|
2012-01-18 22:40:46 +08:00
|
|
|
|
2012-09-28 01:29:14 +08:00
|
|
|
static void block_job_cb(void *opaque, int ret)
|
2012-01-18 22:40:46 +08:00
|
|
|
{
|
2014-10-21 19:03:53 +08:00
|
|
|
/* Note that this function may be executed from another AioContext besides
|
|
|
|
* the QEMU main loop. If you need to access anything that assumes the
|
|
|
|
* QEMU global mutex, use a BH or introduce a mutex.
|
|
|
|
*/
|
|
|
|
|
2012-01-18 22:40:46 +08:00
|
|
|
BlockDriverState *bs = opaque;
|
2014-06-18 14:43:47 +08:00
|
|
|
const char *msg = NULL;
|
2012-01-18 22:40:46 +08:00
|
|
|
|
2012-09-28 01:29:14 +08:00
|
|
|
trace_block_job_cb(bs, bs->job, ret);
|
2012-01-18 22:40:46 +08:00
|
|
|
|
|
|
|
assert(bs->job);
|
2014-06-18 14:43:47 +08:00
|
|
|
|
2012-01-18 22:40:46 +08:00
|
|
|
if (ret < 0) {
|
2014-06-18 14:43:47 +08:00
|
|
|
msg = strerror(-ret);
|
2012-01-18 22:40:46 +08:00
|
|
|
}
|
|
|
|
|
2012-01-18 22:40:48 +08:00
|
|
|
if (block_job_is_cancelled(bs->job)) {
|
2014-06-18 14:43:47 +08:00
|
|
|
block_job_event_cancelled(bs->job);
|
2012-01-18 22:40:48 +08:00
|
|
|
} else {
|
2014-06-18 14:43:47 +08:00
|
|
|
block_job_event_completed(bs->job, msg);
|
2012-01-18 22:40:48 +08:00
|
|
|
}
|
2012-01-18 22:40:50 +08:00
|
|
|
|
2013-08-23 09:14:51 +08:00
|
|
|
bdrv_put_ref_bh_schedule(bs);
|
2012-01-18 22:40:46 +08:00
|
|
|
}
|
|
|
|
|
block: add backing-file option to block-stream
On some image chains, QEMU may not always be able to resolve the
filenames properly, when updating the backing file of an image
after a block job.
For instance, certain relative pathnames may fail, or drives may
have been specified originally by file descriptor (e.g. /dev/fd/???),
or a relative protocol pathname may have been used.
In these instances, QEMU may lack the information to be able to make
the correct choice, but the user or management layer most likely does
have that knowledge.
With this extension to the block-stream api, the user is able to change
the backing file of the active layer as part of the block-stream
operation.
This allows the change to be 'safe', in the sense that if the attempt
to write the active image metadata fails, then the block-stream
operation returns failure, without disrupting the guest.
If a backing file string is not specified in the command, the backing
file string to use is determined in the same manner as it was
previously.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-26 03:40:11 +08:00
|
|
|
void qmp_block_stream(const char *device,
|
|
|
|
bool has_base, const char *base,
|
|
|
|
bool has_backing_file, const char *backing_file,
|
|
|
|
bool has_speed, int64_t speed,
|
2012-09-28 23:22:59 +08:00
|
|
|
bool has_on_error, BlockdevOnError on_error,
|
|
|
|
Error **errp)
|
2012-01-18 22:40:46 +08:00
|
|
|
{
|
|
|
|
BlockDriverState *bs;
|
2012-01-18 22:40:53 +08:00
|
|
|
BlockDriverState *base_bs = NULL;
|
2014-10-21 19:03:57 +08:00
|
|
|
AioContext *aio_context;
|
2012-04-25 23:51:00 +08:00
|
|
|
Error *local_err = NULL;
|
block: add backing-file option to block-stream
On some image chains, QEMU may not always be able to resolve the
filenames properly, when updating the backing file of an image
after a block job.
For instance, certain relative pathnames may fail, or drives may
have been specified originally by file descriptor (e.g. /dev/fd/???),
or a relative protocol pathname may have been used.
In these instances, QEMU may lack the information to be able to make
the correct choice, but the user or management layer most likely does
have that knowledge.
With this extension to the block-stream api, the user is able to change
the backing file of the active layer as part of the block-stream
operation.
This allows the change to be 'safe', in the sense that if the attempt
to write the active image metadata fails, then the block-stream
operation returns failure, without disrupting the guest.
If a backing file string is not specified in the command, the backing
file string to use is determined in the same manner as it was
previously.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-26 03:40:11 +08:00
|
|
|
const char *base_name = NULL;
|
2012-01-18 22:40:46 +08:00
|
|
|
|
2012-09-28 23:22:59 +08:00
|
|
|
if (!has_on_error) {
|
|
|
|
on_error = BLOCKDEV_ON_ERROR_REPORT;
|
|
|
|
}
|
|
|
|
|
2012-01-18 22:40:46 +08:00
|
|
|
bs = bdrv_find(device);
|
|
|
|
if (!bs) {
|
|
|
|
error_set(errp, QERR_DEVICE_NOT_FOUND, device);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2014-10-21 19:03:57 +08:00
|
|
|
aio_context = bdrv_get_aio_context(bs);
|
|
|
|
aio_context_acquire(aio_context);
|
|
|
|
|
2014-05-23 21:29:44 +08:00
|
|
|
if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_STREAM, errp)) {
|
2014-10-21 19:03:57 +08:00
|
|
|
goto out;
|
2014-05-23 21:29:44 +08:00
|
|
|
}
|
|
|
|
|
block: add backing-file option to block-stream
On some image chains, QEMU may not always be able to resolve the
filenames properly, when updating the backing file of an image
after a block job.
For instance, certain relative pathnames may fail, or drives may
have been specified originally by file descriptor (e.g. /dev/fd/???),
or a relative protocol pathname may have been used.
In these instances, QEMU may lack the information to be able to make
the correct choice, but the user or management layer most likely does
have that knowledge.
With this extension to the block-stream api, the user is able to change
the backing file of the active layer as part of the block-stream
operation.
This allows the change to be 'safe', in the sense that if the attempt
to write the active image metadata fails, then the block-stream
operation returns failure, without disrupting the guest.
If a backing file string is not specified in the command, the backing
file string to use is determined in the same manner as it was
previously.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-26 03:40:11 +08:00
|
|
|
if (has_base) {
|
2012-01-18 22:40:53 +08:00
|
|
|
base_bs = bdrv_find_backing_image(bs, base);
|
|
|
|
if (base_bs == NULL) {
|
|
|
|
error_set(errp, QERR_BASE_NOT_FOUND, base);
|
2014-10-21 19:03:57 +08:00
|
|
|
goto out;
|
2012-01-18 22:40:53 +08:00
|
|
|
}
|
2014-10-21 19:03:57 +08:00
|
|
|
assert(bdrv_get_aio_context(base_bs) == aio_context);
|
block: add backing-file option to block-stream
On some image chains, QEMU may not always be able to resolve the
filenames properly, when updating the backing file of an image
after a block job.
For instance, certain relative pathnames may fail, or drives may
have been specified originally by file descriptor (e.g. /dev/fd/???),
or a relative protocol pathname may have been used.
In these instances, QEMU may lack the information to be able to make
the correct choice, but the user or management layer most likely does
have that knowledge.
With this extension to the block-stream api, the user is able to change
the backing file of the active layer as part of the block-stream
operation.
This allows the change to be 'safe', in the sense that if the attempt
to write the active image metadata fails, then the block-stream
operation returns failure, without disrupting the guest.
If a backing file string is not specified in the command, the backing
file string to use is determined in the same manner as it was
previously.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-26 03:40:11 +08:00
|
|
|
base_name = base;
|
2012-01-18 22:40:46 +08:00
|
|
|
}
|
|
|
|
|
block: add backing-file option to block-stream
On some image chains, QEMU may not always be able to resolve the
filenames properly, when updating the backing file of an image
after a block job.
For instance, certain relative pathnames may fail, or drives may
have been specified originally by file descriptor (e.g. /dev/fd/???),
or a relative protocol pathname may have been used.
In these instances, QEMU may lack the information to be able to make
the correct choice, but the user or management layer most likely does
have that knowledge.
With this extension to the block-stream api, the user is able to change
the backing file of the active layer as part of the block-stream
operation.
This allows the change to be 'safe', in the sense that if the attempt
to write the active image metadata fails, then the block-stream
operation returns failure, without disrupting the guest.
If a backing file string is not specified in the command, the backing
file string to use is determined in the same manner as it was
previously.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-26 03:40:11 +08:00
|
|
|
/* if we are streaming the entire chain, the result will have no backing
|
|
|
|
* file, and specifying one is therefore an error */
|
|
|
|
if (base_bs == NULL && has_backing_file) {
|
|
|
|
error_setg(errp, "backing file specified, but streaming the "
|
|
|
|
"entire chain");
|
2014-10-21 19:03:57 +08:00
|
|
|
goto out;
|
block: add backing-file option to block-stream
On some image chains, QEMU may not always be able to resolve the
filenames properly, when updating the backing file of an image
after a block job.
For instance, certain relative pathnames may fail, or drives may
have been specified originally by file descriptor (e.g. /dev/fd/???),
or a relative protocol pathname may have been used.
In these instances, QEMU may lack the information to be able to make
the correct choice, but the user or management layer most likely does
have that knowledge.
With this extension to the block-stream api, the user is able to change
the backing file of the active layer as part of the block-stream
operation.
This allows the change to be 'safe', in the sense that if the attempt
to write the active image metadata fails, then the block-stream
operation returns failure, without disrupting the guest.
If a backing file string is not specified in the command, the backing
file string to use is determined in the same manner as it was
previously.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-26 03:40:11 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* backing_file string overrides base bs filename */
|
|
|
|
base_name = has_backing_file ? backing_file : base_name;
|
|
|
|
|
|
|
|
stream_start(bs, base_bs, base_name, has_speed ? speed : 0,
|
2012-09-28 23:22:59 +08:00
|
|
|
on_error, block_job_cb, bs, &local_err);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2012-04-25 23:51:00 +08:00
|
|
|
error_propagate(errp, local_err);
|
2014-10-21 19:03:57 +08:00
|
|
|
goto out;
|
2012-01-18 22:40:46 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
trace_qmp_block_stream(bs, bs->job);
|
2014-10-21 19:03:57 +08:00
|
|
|
|
|
|
|
out:
|
|
|
|
aio_context_release(aio_context);
|
2012-01-18 22:40:46 +08:00
|
|
|
}
|
2012-01-18 22:40:47 +08:00
|
|
|
|
QAPI: add command for live block commit, 'block-commit'
The command for live block commit is added, which has the following
arguments:
device: the block device to perform the commit on (mandatory)
base: the base image to commit into; optional (if not specified,
it is the underlying original image)
top: the top image of the commit - all data from inside top down
to base will be committed into base (mandatory for now; see
note, below)
speed: maximum speed, in bytes/sec
Note: Eventually this command will support merging down the active layer,
but that code is not yet complete. If the active layer is passed
in as top, then an error will be returned. Once merging down the
active layer is supported, the 'top' argument may become optional,
and default to the active layer.
The is done as a block job, so upon completion a BLOCK_JOB_COMPLETED will
be emitted.
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 01:29:16 +08:00
|
|
|
void qmp_block_commit(const char *device,
|
2014-06-30 21:14:15 +08:00
|
|
|
bool has_base, const char *base,
|
|
|
|
bool has_top, const char *top,
|
block: extend block-commit to accept a string for the backing file
On some image chains, QEMU may not always be able to resolve the
filenames properly, when updating the backing file of an image
after a block commit.
For instance, certain relative pathnames may fail, or drives may
have been specified originally by file descriptor (e.g. /dev/fd/???),
or a relative protocol pathname may have been used.
In these instances, QEMU may lack the information to be able to make
the correct choice, but the user or management layer most likely does
have that knowledge.
With this extension to the block-commit api, the user is able to change
the backing file of the overlay image as part of the block-commit
operation.
This allows the change to be 'safe', in the sense that if the attempt
to write the overlay image metadata fails, then the block-commit
operation returns failure, without disrupting the guest.
If the commit top is the active layer, then specifying the backing
file string will be treated as an error (there is no overlay image
to modify in that case).
If a backing file string is not specified in the command, the backing
file string to use is determined in the same manner as it was
previously.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-26 03:40:10 +08:00
|
|
|
bool has_backing_file, const char *backing_file,
|
QAPI: add command for live block commit, 'block-commit'
The command for live block commit is added, which has the following
arguments:
device: the block device to perform the commit on (mandatory)
base: the base image to commit into; optional (if not specified,
it is the underlying original image)
top: the top image of the commit - all data from inside top down
to base will be committed into base (mandatory for now; see
note, below)
speed: maximum speed, in bytes/sec
Note: Eventually this command will support merging down the active layer,
but that code is not yet complete. If the active layer is passed
in as top, then an error will be returned. Once merging down the
active layer is supported, the 'top' argument may become optional,
and default to the active layer.
The is done as a block job, so upon completion a BLOCK_JOB_COMPLETED will
be emitted.
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 01:29:16 +08:00
|
|
|
bool has_speed, int64_t speed,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
BlockDriverState *bs;
|
|
|
|
BlockDriverState *base_bs, *top_bs;
|
2014-10-21 19:03:59 +08:00
|
|
|
AioContext *aio_context;
|
QAPI: add command for live block commit, 'block-commit'
The command for live block commit is added, which has the following
arguments:
device: the block device to perform the commit on (mandatory)
base: the base image to commit into; optional (if not specified,
it is the underlying original image)
top: the top image of the commit - all data from inside top down
to base will be committed into base (mandatory for now; see
note, below)
speed: maximum speed, in bytes/sec
Note: Eventually this command will support merging down the active layer,
but that code is not yet complete. If the active layer is passed
in as top, then an error will be returned. Once merging down the
active layer is supported, the 'top' argument may become optional,
and default to the active layer.
The is done as a block job, so upon completion a BLOCK_JOB_COMPLETED will
be emitted.
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 01:29:16 +08:00
|
|
|
Error *local_err = NULL;
|
|
|
|
/* This will be part of the QMP command, if/when the
|
|
|
|
* BlockdevOnError change for blkmirror makes it in
|
|
|
|
*/
|
2012-09-28 23:22:55 +08:00
|
|
|
BlockdevOnError on_error = BLOCKDEV_ON_ERROR_REPORT;
|
QAPI: add command for live block commit, 'block-commit'
The command for live block commit is added, which has the following
arguments:
device: the block device to perform the commit on (mandatory)
base: the base image to commit into; optional (if not specified,
it is the underlying original image)
top: the top image of the commit - all data from inside top down
to base will be committed into base (mandatory for now; see
note, below)
speed: maximum speed, in bytes/sec
Note: Eventually this command will support merging down the active layer,
but that code is not yet complete. If the active layer is passed
in as top, then an error will be returned. Once merging down the
active layer is supported, the 'top' argument may become optional,
and default to the active layer.
The is done as a block job, so upon completion a BLOCK_JOB_COMPLETED will
be emitted.
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 01:29:16 +08:00
|
|
|
|
2014-04-11 01:36:25 +08:00
|
|
|
if (!has_speed) {
|
|
|
|
speed = 0;
|
|
|
|
}
|
|
|
|
|
2014-06-30 21:14:15 +08:00
|
|
|
/* Important Note:
|
|
|
|
* libvirt relies on the DeviceNotFound error class in order to probe for
|
|
|
|
* live commit feature versions; for this to work, we must make sure to
|
|
|
|
* perform the device lookup before any generic errors that may occur in a
|
|
|
|
* scenario in which all optional arguments are omitted. */
|
QAPI: add command for live block commit, 'block-commit'
The command for live block commit is added, which has the following
arguments:
device: the block device to perform the commit on (mandatory)
base: the base image to commit into; optional (if not specified,
it is the underlying original image)
top: the top image of the commit - all data from inside top down
to base will be committed into base (mandatory for now; see
note, below)
speed: maximum speed, in bytes/sec
Note: Eventually this command will support merging down the active layer,
but that code is not yet complete. If the active layer is passed
in as top, then an error will be returned. Once merging down the
active layer is supported, the 'top' argument may become optional,
and default to the active layer.
The is done as a block job, so upon completion a BLOCK_JOB_COMPLETED will
be emitted.
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 01:29:16 +08:00
|
|
|
bs = bdrv_find(device);
|
|
|
|
if (!bs) {
|
|
|
|
error_set(errp, QERR_DEVICE_NOT_FOUND, device);
|
|
|
|
return;
|
2014-05-23 21:29:44 +08:00
|
|
|
}
|
|
|
|
|
2014-10-21 19:03:59 +08:00
|
|
|
aio_context = bdrv_get_aio_context(bs);
|
|
|
|
aio_context_acquire(aio_context);
|
|
|
|
|
|
|
|
/* drain all i/o before commits */
|
|
|
|
bdrv_drain_all();
|
|
|
|
|
2014-05-23 21:29:44 +08:00
|
|
|
if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_COMMIT, errp)) {
|
2014-10-21 19:03:59 +08:00
|
|
|
goto out;
|
QAPI: add command for live block commit, 'block-commit'
The command for live block commit is added, which has the following
arguments:
device: the block device to perform the commit on (mandatory)
base: the base image to commit into; optional (if not specified,
it is the underlying original image)
top: the top image of the commit - all data from inside top down
to base will be committed into base (mandatory for now; see
note, below)
speed: maximum speed, in bytes/sec
Note: Eventually this command will support merging down the active layer,
but that code is not yet complete. If the active layer is passed
in as top, then an error will be returned. Once merging down the
active layer is supported, the 'top' argument may become optional,
and default to the active layer.
The is done as a block job, so upon completion a BLOCK_JOB_COMPLETED will
be emitted.
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 01:29:16 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* default top_bs is the active layer */
|
|
|
|
top_bs = bs;
|
|
|
|
|
2014-06-30 21:14:15 +08:00
|
|
|
if (has_top && top) {
|
QAPI: add command for live block commit, 'block-commit'
The command for live block commit is added, which has the following
arguments:
device: the block device to perform the commit on (mandatory)
base: the base image to commit into; optional (if not specified,
it is the underlying original image)
top: the top image of the commit - all data from inside top down
to base will be committed into base (mandatory for now; see
note, below)
speed: maximum speed, in bytes/sec
Note: Eventually this command will support merging down the active layer,
but that code is not yet complete. If the active layer is passed
in as top, then an error will be returned. Once merging down the
active layer is supported, the 'top' argument may become optional,
and default to the active layer.
The is done as a block job, so upon completion a BLOCK_JOB_COMPLETED will
be emitted.
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 01:29:16 +08:00
|
|
|
if (strcmp(bs->filename, top) != 0) {
|
|
|
|
top_bs = bdrv_find_backing_image(bs, top);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (top_bs == NULL) {
|
|
|
|
error_setg(errp, "Top image file %s not found", top ? top : "NULL");
|
2014-10-21 19:03:59 +08:00
|
|
|
goto out;
|
QAPI: add command for live block commit, 'block-commit'
The command for live block commit is added, which has the following
arguments:
device: the block device to perform the commit on (mandatory)
base: the base image to commit into; optional (if not specified,
it is the underlying original image)
top: the top image of the commit - all data from inside top down
to base will be committed into base (mandatory for now; see
note, below)
speed: maximum speed, in bytes/sec
Note: Eventually this command will support merging down the active layer,
but that code is not yet complete. If the active layer is passed
in as top, then an error will be returned. Once merging down the
active layer is supported, the 'top' argument may become optional,
and default to the active layer.
The is done as a block job, so upon completion a BLOCK_JOB_COMPLETED will
be emitted.
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 01:29:16 +08:00
|
|
|
}
|
|
|
|
|
2014-10-21 19:03:59 +08:00
|
|
|
assert(bdrv_get_aio_context(top_bs) == aio_context);
|
|
|
|
|
2012-10-17 03:49:10 +08:00
|
|
|
if (has_base && base) {
|
|
|
|
base_bs = bdrv_find_backing_image(top_bs, base);
|
|
|
|
} else {
|
|
|
|
base_bs = bdrv_find_base(top_bs);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (base_bs == NULL) {
|
|
|
|
error_set(errp, QERR_BASE_NOT_FOUND, base ? base : "NULL");
|
2014-10-21 19:03:59 +08:00
|
|
|
goto out;
|
2012-10-17 03:49:10 +08:00
|
|
|
}
|
|
|
|
|
2014-10-21 19:03:59 +08:00
|
|
|
assert(bdrv_get_aio_context(base_bs) == aio_context);
|
|
|
|
|
2014-06-30 21:14:15 +08:00
|
|
|
/* Do not allow attempts to commit an image into itself */
|
|
|
|
if (top_bs == base_bs) {
|
|
|
|
error_setg(errp, "cannot commit an image into itself");
|
2014-10-21 19:03:59 +08:00
|
|
|
goto out;
|
2014-06-30 21:14:15 +08:00
|
|
|
}
|
|
|
|
|
2013-12-16 14:45:31 +08:00
|
|
|
if (top_bs == bs) {
|
block: extend block-commit to accept a string for the backing file
On some image chains, QEMU may not always be able to resolve the
filenames properly, when updating the backing file of an image
after a block commit.
For instance, certain relative pathnames may fail, or drives may
have been specified originally by file descriptor (e.g. /dev/fd/???),
or a relative protocol pathname may have been used.
In these instances, QEMU may lack the information to be able to make
the correct choice, but the user or management layer most likely does
have that knowledge.
With this extension to the block-commit api, the user is able to change
the backing file of the overlay image as part of the block-commit
operation.
This allows the change to be 'safe', in the sense that if the attempt
to write the overlay image metadata fails, then the block-commit
operation returns failure, without disrupting the guest.
If the commit top is the active layer, then specifying the backing
file string will be treated as an error (there is no overlay image
to modify in that case).
If a backing file string is not specified in the command, the backing
file string to use is determined in the same manner as it was
previously.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-26 03:40:10 +08:00
|
|
|
if (has_backing_file) {
|
|
|
|
error_setg(errp, "'backing-file' specified,"
|
|
|
|
" but 'top' is the active layer");
|
2014-10-21 19:03:59 +08:00
|
|
|
goto out;
|
block: extend block-commit to accept a string for the backing file
On some image chains, QEMU may not always be able to resolve the
filenames properly, when updating the backing file of an image
after a block commit.
For instance, certain relative pathnames may fail, or drives may
have been specified originally by file descriptor (e.g. /dev/fd/???),
or a relative protocol pathname may have been used.
In these instances, QEMU may lack the information to be able to make
the correct choice, but the user or management layer most likely does
have that knowledge.
With this extension to the block-commit api, the user is able to change
the backing file of the overlay image as part of the block-commit
operation.
This allows the change to be 'safe', in the sense that if the attempt
to write the overlay image metadata fails, then the block-commit
operation returns failure, without disrupting the guest.
If the commit top is the active layer, then specifying the backing
file string will be treated as an error (there is no overlay image
to modify in that case).
If a backing file string is not specified in the command, the backing
file string to use is determined in the same manner as it was
previously.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-26 03:40:10 +08:00
|
|
|
}
|
2013-12-16 14:45:31 +08:00
|
|
|
commit_active_start(bs, base_bs, speed, on_error, block_job_cb,
|
|
|
|
bs, &local_err);
|
|
|
|
} else {
|
|
|
|
commit_start(bs, base_bs, top_bs, speed, on_error, block_job_cb, bs,
|
block: extend block-commit to accept a string for the backing file
On some image chains, QEMU may not always be able to resolve the
filenames properly, when updating the backing file of an image
after a block commit.
For instance, certain relative pathnames may fail, or drives may
have been specified originally by file descriptor (e.g. /dev/fd/???),
or a relative protocol pathname may have been used.
In these instances, QEMU may lack the information to be able to make
the correct choice, but the user or management layer most likely does
have that knowledge.
With this extension to the block-commit api, the user is able to change
the backing file of the overlay image as part of the block-commit
operation.
This allows the change to be 'safe', in the sense that if the attempt
to write the overlay image metadata fails, then the block-commit
operation returns failure, without disrupting the guest.
If the commit top is the active layer, then specifying the backing
file string will be treated as an error (there is no overlay image
to modify in that case).
If a backing file string is not specified in the command, the backing
file string to use is determined in the same manner as it was
previously.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2014-06-26 03:40:10 +08:00
|
|
|
has_backing_file ? backing_file : NULL, &local_err);
|
2013-12-16 14:45:31 +08:00
|
|
|
}
|
QAPI: add command for live block commit, 'block-commit'
The command for live block commit is added, which has the following
arguments:
device: the block device to perform the commit on (mandatory)
base: the base image to commit into; optional (if not specified,
it is the underlying original image)
top: the top image of the commit - all data from inside top down
to base will be committed into base (mandatory for now; see
note, below)
speed: maximum speed, in bytes/sec
Note: Eventually this command will support merging down the active layer,
but that code is not yet complete. If the active layer is passed
in as top, then an error will be returned. Once merging down the
active layer is supported, the 'top' argument may become optional,
and default to the active layer.
The is done as a block job, so upon completion a BLOCK_JOB_COMPLETED will
be emitted.
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 01:29:16 +08:00
|
|
|
if (local_err != NULL) {
|
|
|
|
error_propagate(errp, local_err);
|
2014-10-21 19:03:59 +08:00
|
|
|
goto out;
|
QAPI: add command for live block commit, 'block-commit'
The command for live block commit is added, which has the following
arguments:
device: the block device to perform the commit on (mandatory)
base: the base image to commit into; optional (if not specified,
it is the underlying original image)
top: the top image of the commit - all data from inside top down
to base will be committed into base (mandatory for now; see
note, below)
speed: maximum speed, in bytes/sec
Note: Eventually this command will support merging down the active layer,
but that code is not yet complete. If the active layer is passed
in as top, then an error will be returned. Once merging down the
active layer is supported, the 'top' argument may become optional,
and default to the active layer.
The is done as a block job, so upon completion a BLOCK_JOB_COMPLETED will
be emitted.
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 01:29:16 +08:00
|
|
|
}
|
2014-10-21 19:03:59 +08:00
|
|
|
|
|
|
|
out:
|
|
|
|
aio_context_release(aio_context);
|
QAPI: add command for live block commit, 'block-commit'
The command for live block commit is added, which has the following
arguments:
device: the block device to perform the commit on (mandatory)
base: the base image to commit into; optional (if not specified,
it is the underlying original image)
top: the top image of the commit - all data from inside top down
to base will be committed into base (mandatory for now; see
note, below)
speed: maximum speed, in bytes/sec
Note: Eventually this command will support merging down the active layer,
but that code is not yet complete. If the active layer is passed
in as top, then an error will be returned. Once merging down the
active layer is supported, the 'top' argument may become optional,
and default to the active layer.
The is done as a block job, so upon completion a BLOCK_JOB_COMPLETED will
be emitted.
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 01:29:16 +08:00
|
|
|
}
|
|
|
|
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
void qmp_drive_backup(const char *device, const char *target,
|
|
|
|
bool has_format, const char *format,
|
2013-06-26 20:11:57 +08:00
|
|
|
enum MirrorSyncMode sync,
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
bool has_mode, enum NewImageMode mode,
|
|
|
|
bool has_speed, int64_t speed,
|
|
|
|
bool has_on_source_error, BlockdevOnError on_source_error,
|
|
|
|
bool has_on_target_error, BlockdevOnError on_target_error,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
BlockDriverState *bs;
|
|
|
|
BlockDriverState *target_bs;
|
2013-07-27 02:39:04 +08:00
|
|
|
BlockDriverState *source = NULL;
|
2014-10-21 19:03:56 +08:00
|
|
|
AioContext *aio_context;
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
BlockDriver *drv = NULL;
|
|
|
|
Error *local_err = NULL;
|
|
|
|
int flags;
|
|
|
|
int64_t size;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (!has_speed) {
|
|
|
|
speed = 0;
|
|
|
|
}
|
|
|
|
if (!has_on_source_error) {
|
|
|
|
on_source_error = BLOCKDEV_ON_ERROR_REPORT;
|
|
|
|
}
|
|
|
|
if (!has_on_target_error) {
|
|
|
|
on_target_error = BLOCKDEV_ON_ERROR_REPORT;
|
|
|
|
}
|
|
|
|
if (!has_mode) {
|
|
|
|
mode = NEW_IMAGE_MODE_ABSOLUTE_PATHS;
|
|
|
|
}
|
|
|
|
|
|
|
|
bs = bdrv_find(device);
|
|
|
|
if (!bs) {
|
|
|
|
error_set(errp, QERR_DEVICE_NOT_FOUND, device);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2014-10-21 19:03:56 +08:00
|
|
|
aio_context = bdrv_get_aio_context(bs);
|
|
|
|
aio_context_acquire(aio_context);
|
|
|
|
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
if (!bdrv_is_inserted(bs)) {
|
|
|
|
error_set(errp, QERR_DEVICE_HAS_NO_MEDIUM, device);
|
2014-10-21 19:03:56 +08:00
|
|
|
goto out;
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (!has_format) {
|
|
|
|
format = mode == NEW_IMAGE_MODE_EXISTING ? NULL : bs->drv->format_name;
|
|
|
|
}
|
|
|
|
if (format) {
|
|
|
|
drv = bdrv_find_format(format);
|
|
|
|
if (!drv) {
|
|
|
|
error_set(errp, QERR_INVALID_BLOCK_FORMAT, format);
|
2014-10-21 19:03:56 +08:00
|
|
|
goto out;
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-05-23 21:29:43 +08:00
|
|
|
if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_BACKUP_SOURCE, errp)) {
|
2014-10-21 19:03:56 +08:00
|
|
|
goto out;
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
flags = bs->open_flags | BDRV_O_RDWR;
|
|
|
|
|
2013-07-27 02:39:04 +08:00
|
|
|
/* See if we have a backing HD we can use to create our new image
|
|
|
|
* on top of. */
|
|
|
|
if (sync == MIRROR_SYNC_MODE_TOP) {
|
|
|
|
source = bs->backing_hd;
|
|
|
|
if (!source) {
|
|
|
|
sync = MIRROR_SYNC_MODE_FULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (sync == MIRROR_SYNC_MODE_NONE) {
|
|
|
|
source = bs;
|
|
|
|
}
|
|
|
|
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
size = bdrv_getlength(bs);
|
|
|
|
if (size < 0) {
|
|
|
|
error_setg_errno(errp, -size, "bdrv_getlength failed");
|
2014-10-21 19:03:56 +08:00
|
|
|
goto out;
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (mode != NEW_IMAGE_MODE_EXISTING) {
|
|
|
|
assert(format && drv);
|
2013-07-27 02:39:04 +08:00
|
|
|
if (source) {
|
|
|
|
bdrv_img_create(target, format, source->filename,
|
|
|
|
source->drv->format_name, NULL,
|
|
|
|
size, flags, &local_err, false);
|
|
|
|
} else {
|
|
|
|
bdrv_img_create(target, format, NULL, NULL, NULL,
|
|
|
|
size, flags, &local_err, false);
|
|
|
|
}
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
}
|
|
|
|
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
error_propagate(errp, local_err);
|
2014-10-21 19:03:56 +08:00
|
|
|
goto out;
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
}
|
|
|
|
|
2014-02-19 01:33:05 +08:00
|
|
|
target_bs = NULL;
|
2014-02-19 01:33:06 +08:00
|
|
|
ret = bdrv_open(&target_bs, target, NULL, NULL, flags, drv, &local_err);
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
if (ret < 0) {
|
2013-09-05 20:45:29 +08:00
|
|
|
error_propagate(errp, local_err);
|
2014-10-21 19:03:56 +08:00
|
|
|
goto out;
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
}
|
|
|
|
|
2014-10-21 19:03:56 +08:00
|
|
|
bdrv_set_aio_context(target_bs, aio_context);
|
|
|
|
|
2013-07-27 02:39:04 +08:00
|
|
|
backup_start(bs, target_bs, speed, sync, on_source_error, on_target_error,
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
block_job_cb, bs, &local_err);
|
|
|
|
if (local_err != NULL) {
|
2013-08-23 09:14:47 +08:00
|
|
|
bdrv_unref(target_bs);
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
error_propagate(errp, local_err);
|
2014-10-21 19:03:56 +08:00
|
|
|
goto out;
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
}
|
2014-10-21 19:03:56 +08:00
|
|
|
|
|
|
|
out:
|
|
|
|
aio_context_release(aio_context);
|
block: add drive-backup QMP command
@drive-backup
Start a point-in-time copy of a block device to a new destination. The
status of ongoing drive-backup operations can be checked with
query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
The operation can be stopped before it has completed using the
block-job-cancel command.
@device: the name of the device which should be copied.
@target: the target of the new image. If the file exists, or if it
is a device, the existing file/device will be used as the new
destination. If it does not exist, a new file will be created.
@format: #optional the format of the new destination, default is to
probe if @mode is 'existing', else the format of the source
@mode: #optional whether and how QEMU should create a new image, default is
'absolute-paths'.
@speed: #optional the maximum speed, in bytes per second
@on-source-error: #optional the action to take on an error on the source,
default 'report'. 'stop' and 'enospc' can only be used
if the block device supports io-status (see BlockInfo).
@on-target-error: #optional the action to take on an error on the target,
default 'report' (no limitations, since this applies to
a different block device than @device).
Note that @on-source-error and @on-target-error only affect background I/O.
If an error occurs during a guest write request, the device's rerror/werror
actions will be used.
Returns: nothing on success
If @device is not a valid block device, DeviceNotFound
Since 1.6
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2013-06-24 23:13:14 +08:00
|
|
|
}
|
|
|
|
|
2014-01-24 04:31:34 +08:00
|
|
|
BlockDeviceInfoList *qmp_query_named_block_nodes(Error **errp)
|
|
|
|
{
|
|
|
|
return bdrv_named_nodes_list();
|
|
|
|
}
|
|
|
|
|
2013-01-22 16:03:13 +08:00
|
|
|
#define DEFAULT_MIRROR_BUF_SIZE (10 << 20)
|
|
|
|
|
2012-10-18 22:49:24 +08:00
|
|
|
void qmp_drive_mirror(const char *device, const char *target,
|
|
|
|
bool has_format, const char *format,
|
2014-06-16 18:00:55 +08:00
|
|
|
bool has_node_name, const char *node_name,
|
2014-06-28 00:25:25 +08:00
|
|
|
bool has_replaces, const char *replaces,
|
2012-10-18 22:49:24 +08:00
|
|
|
enum MirrorSyncMode sync,
|
|
|
|
bool has_mode, enum NewImageMode mode,
|
2012-10-18 22:49:28 +08:00
|
|
|
bool has_speed, int64_t speed,
|
2013-01-22 00:09:46 +08:00
|
|
|
bool has_granularity, uint32_t granularity,
|
2013-01-22 16:03:13 +08:00
|
|
|
bool has_buf_size, int64_t buf_size,
|
2012-10-18 22:49:28 +08:00
|
|
|
bool has_on_source_error, BlockdevOnError on_source_error,
|
|
|
|
bool has_on_target_error, BlockdevOnError on_target_error,
|
|
|
|
Error **errp)
|
2012-10-18 22:49:24 +08:00
|
|
|
{
|
|
|
|
BlockDriverState *bs;
|
|
|
|
BlockDriverState *source, *target_bs;
|
2014-10-21 19:03:58 +08:00
|
|
|
AioContext *aio_context;
|
2012-10-18 22:49:24 +08:00
|
|
|
BlockDriver *drv = NULL;
|
|
|
|
Error *local_err = NULL;
|
2014-06-16 18:00:55 +08:00
|
|
|
QDict *options = NULL;
|
2012-10-18 22:49:24 +08:00
|
|
|
int flags;
|
2013-06-24 23:13:13 +08:00
|
|
|
int64_t size;
|
2012-10-18 22:49:24 +08:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (!has_speed) {
|
|
|
|
speed = 0;
|
|
|
|
}
|
2012-10-18 22:49:28 +08:00
|
|
|
if (!has_on_source_error) {
|
|
|
|
on_source_error = BLOCKDEV_ON_ERROR_REPORT;
|
|
|
|
}
|
|
|
|
if (!has_on_target_error) {
|
|
|
|
on_target_error = BLOCKDEV_ON_ERROR_REPORT;
|
|
|
|
}
|
2012-10-18 22:49:24 +08:00
|
|
|
if (!has_mode) {
|
|
|
|
mode = NEW_IMAGE_MODE_ABSOLUTE_PATHS;
|
|
|
|
}
|
2013-01-22 00:09:46 +08:00
|
|
|
if (!has_granularity) {
|
|
|
|
granularity = 0;
|
|
|
|
}
|
2013-01-22 16:03:13 +08:00
|
|
|
if (!has_buf_size) {
|
|
|
|
buf_size = DEFAULT_MIRROR_BUF_SIZE;
|
|
|
|
}
|
|
|
|
|
2013-01-22 00:09:46 +08:00
|
|
|
if (granularity != 0 && (granularity < 512 || granularity > 1048576 * 64)) {
|
2014-08-27 21:29:59 +08:00
|
|
|
error_set(errp, QERR_INVALID_PARAMETER_VALUE, "granularity",
|
|
|
|
"a value in range [512B, 64MB]");
|
2013-01-22 00:09:46 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
if (granularity & (granularity - 1)) {
|
2014-08-27 21:29:59 +08:00
|
|
|
error_set(errp, QERR_INVALID_PARAMETER_VALUE, "granularity", "power of 2");
|
2013-01-22 00:09:46 +08:00
|
|
|
return;
|
|
|
|
}
|
2012-10-18 22:49:24 +08:00
|
|
|
|
|
|
|
bs = bdrv_find(device);
|
|
|
|
if (!bs) {
|
|
|
|
error_set(errp, QERR_DEVICE_NOT_FOUND, device);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2014-10-21 19:03:58 +08:00
|
|
|
aio_context = bdrv_get_aio_context(bs);
|
|
|
|
aio_context_acquire(aio_context);
|
|
|
|
|
2012-10-18 22:49:24 +08:00
|
|
|
if (!bdrv_is_inserted(bs)) {
|
|
|
|
error_set(errp, QERR_DEVICE_HAS_NO_MEDIUM, device);
|
2014-10-21 19:03:58 +08:00
|
|
|
goto out;
|
2012-10-18 22:49:24 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (!has_format) {
|
|
|
|
format = mode == NEW_IMAGE_MODE_EXISTING ? NULL : bs->drv->format_name;
|
|
|
|
}
|
|
|
|
if (format) {
|
|
|
|
drv = bdrv_find_format(format);
|
|
|
|
if (!drv) {
|
|
|
|
error_set(errp, QERR_INVALID_BLOCK_FORMAT, format);
|
2014-10-21 19:03:58 +08:00
|
|
|
goto out;
|
2012-10-18 22:49:24 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-05-23 21:29:43 +08:00
|
|
|
if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_MIRROR, errp)) {
|
2014-10-21 19:03:58 +08:00
|
|
|
goto out;
|
2012-10-18 22:49:24 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
flags = bs->open_flags | BDRV_O_RDWR;
|
|
|
|
source = bs->backing_hd;
|
|
|
|
if (!source && sync == MIRROR_SYNC_MODE_TOP) {
|
|
|
|
sync = MIRROR_SYNC_MODE_FULL;
|
|
|
|
}
|
block/drive-mirror: Reuse backing HD for sync=none
For "none" sync mode in "absolute-paths" mode, the current image should
be used as the backing file for the newly created image.
The current behavior is:
a) If the image to be mirrored has a backing file, use that (which is
wrong, since the operations recorded by "none" are applied to the
image itself, not to its backing file).
b) If the image to be mirrored lacks a backing file, the target doesn't
have one either (which is not really wrong, but not really right,
either; "none" records a set of operations executed on the image
file, therefore having no backing file to apply these operations on
seems rather pointless).
For a, this is clearly a bugfix. For b, it is still a bugfix, although
it might break existing API - but since that case crashed qemu just
three weeks ago (before 1452686495922b81d6cf43edf025c1aef15965c0), we
can safely assume there is no such API relying on that case yet.
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 1385407736-13941-2-git-send-email-mreitz@redhat.com
Signed-off-by: Anthony Liguori <aliguori@amazon.com>
2013-11-26 03:28:55 +08:00
|
|
|
if (sync == MIRROR_SYNC_MODE_NONE) {
|
|
|
|
source = bs;
|
|
|
|
}
|
2012-10-18 22:49:24 +08:00
|
|
|
|
2013-06-24 23:13:13 +08:00
|
|
|
size = bdrv_getlength(bs);
|
|
|
|
if (size < 0) {
|
|
|
|
error_setg_errno(errp, -size, "bdrv_getlength failed");
|
2014-10-21 19:03:58 +08:00
|
|
|
goto out;
|
2013-06-24 23:13:13 +08:00
|
|
|
}
|
|
|
|
|
2014-06-28 00:25:25 +08:00
|
|
|
if (has_replaces) {
|
|
|
|
BlockDriverState *to_replace_bs;
|
2014-10-21 19:03:58 +08:00
|
|
|
AioContext *replace_aio_context;
|
|
|
|
int64_t replace_size;
|
2014-06-28 00:25:25 +08:00
|
|
|
|
|
|
|
if (!has_node_name) {
|
|
|
|
error_setg(errp, "a node-name must be provided when replacing a"
|
|
|
|
" named node of the graph");
|
2014-10-21 19:03:58 +08:00
|
|
|
goto out;
|
2014-06-28 00:25:25 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
to_replace_bs = check_to_replace_node(replaces, &local_err);
|
|
|
|
|
|
|
|
if (!to_replace_bs) {
|
|
|
|
error_propagate(errp, local_err);
|
2014-10-21 19:03:58 +08:00
|
|
|
goto out;
|
2014-06-28 00:25:25 +08:00
|
|
|
}
|
|
|
|
|
2014-10-21 19:03:58 +08:00
|
|
|
replace_aio_context = bdrv_get_aio_context(to_replace_bs);
|
|
|
|
aio_context_acquire(replace_aio_context);
|
|
|
|
replace_size = bdrv_getlength(to_replace_bs);
|
|
|
|
aio_context_release(replace_aio_context);
|
|
|
|
|
|
|
|
if (size != replace_size) {
|
2014-06-28 00:25:25 +08:00
|
|
|
error_setg(errp, "cannot replace image with a mirror image of "
|
|
|
|
"different size");
|
2014-10-21 19:03:58 +08:00
|
|
|
goto out;
|
2014-06-28 00:25:25 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-11-07 02:50:44 +08:00
|
|
|
if ((sync == MIRROR_SYNC_MODE_FULL || !source)
|
|
|
|
&& mode != NEW_IMAGE_MODE_EXISTING)
|
|
|
|
{
|
2012-10-18 22:49:24 +08:00
|
|
|
/* create new image w/o backing file */
|
|
|
|
assert(format && drv);
|
2012-11-30 20:52:08 +08:00
|
|
|
bdrv_img_create(target, format,
|
2013-02-13 16:09:40 +08:00
|
|
|
NULL, NULL, NULL, size, flags, &local_err, false);
|
2012-10-18 22:49:24 +08:00
|
|
|
} else {
|
|
|
|
switch (mode) {
|
|
|
|
case NEW_IMAGE_MODE_EXISTING:
|
|
|
|
break;
|
|
|
|
case NEW_IMAGE_MODE_ABSOLUTE_PATHS:
|
|
|
|
/* create new image with backing file */
|
2012-11-30 20:52:08 +08:00
|
|
|
bdrv_img_create(target, format,
|
|
|
|
source->filename,
|
|
|
|
source->drv->format_name,
|
2013-02-13 16:09:40 +08:00
|
|
|
NULL, size, flags, &local_err, false);
|
2012-10-18 22:49:24 +08:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2012-11-30 20:52:08 +08:00
|
|
|
error_propagate(errp, local_err);
|
2014-10-21 19:03:58 +08:00
|
|
|
goto out;
|
2012-10-18 22:49:24 +08:00
|
|
|
}
|
|
|
|
|
2014-06-16 18:00:55 +08:00
|
|
|
if (has_node_name) {
|
|
|
|
options = qdict_new();
|
|
|
|
qdict_put(options, "node-name", qstring_from_str(node_name));
|
|
|
|
}
|
|
|
|
|
2013-01-22 00:09:43 +08:00
|
|
|
/* Mirroring takes care of copy-on-write using the source's backing
|
|
|
|
* file.
|
|
|
|
*/
|
2014-02-19 01:33:05 +08:00
|
|
|
target_bs = NULL;
|
2014-06-16 18:00:55 +08:00
|
|
|
ret = bdrv_open(&target_bs, target, NULL, options,
|
|
|
|
flags | BDRV_O_NO_BACKING, drv, &local_err);
|
2012-10-18 22:49:24 +08:00
|
|
|
if (ret < 0) {
|
2013-09-05 20:45:29 +08:00
|
|
|
error_propagate(errp, local_err);
|
2014-10-21 19:03:58 +08:00
|
|
|
goto out;
|
2012-10-18 22:49:24 +08:00
|
|
|
}
|
|
|
|
|
2014-10-21 19:03:58 +08:00
|
|
|
bdrv_set_aio_context(target_bs, aio_context);
|
|
|
|
|
2014-06-28 00:25:25 +08:00
|
|
|
/* pass the node name to replace to mirror start since it's loose coupling
|
|
|
|
* and will allow to check whether the node still exist at mirror completion
|
|
|
|
*/
|
|
|
|
mirror_start(bs, target_bs,
|
|
|
|
has_replaces ? replaces : NULL,
|
|
|
|
speed, granularity, buf_size, sync,
|
2013-01-22 00:09:46 +08:00
|
|
|
on_source_error, on_target_error,
|
2012-10-18 22:49:28 +08:00
|
|
|
block_job_cb, bs, &local_err);
|
2012-10-18 22:49:24 +08:00
|
|
|
if (local_err != NULL) {
|
2013-08-23 09:14:47 +08:00
|
|
|
bdrv_unref(target_bs);
|
2012-10-18 22:49:24 +08:00
|
|
|
error_propagate(errp, local_err);
|
2014-10-21 19:03:58 +08:00
|
|
|
goto out;
|
2012-10-18 22:49:24 +08:00
|
|
|
}
|
2014-10-21 19:03:58 +08:00
|
|
|
|
|
|
|
out:
|
|
|
|
aio_context_release(aio_context);
|
2012-10-18 22:49:24 +08:00
|
|
|
}
|
|
|
|
|
2014-10-21 19:03:50 +08:00
|
|
|
/* Get the block job for a given device name and acquire its AioContext */
|
|
|
|
static BlockJob *find_block_job(const char *device, AioContext **aio_context)
|
2012-01-18 22:40:47 +08:00
|
|
|
{
|
|
|
|
BlockDriverState *bs;
|
|
|
|
|
|
|
|
bs = bdrv_find(device);
|
2014-10-21 19:03:50 +08:00
|
|
|
if (!bs) {
|
|
|
|
goto notfound;
|
|
|
|
}
|
|
|
|
|
|
|
|
*aio_context = bdrv_get_aio_context(bs);
|
|
|
|
aio_context_acquire(*aio_context);
|
|
|
|
|
|
|
|
if (!bs->job) {
|
|
|
|
aio_context_release(*aio_context);
|
|
|
|
goto notfound;
|
2012-01-18 22:40:47 +08:00
|
|
|
}
|
2014-10-21 19:03:50 +08:00
|
|
|
|
2012-01-18 22:40:47 +08:00
|
|
|
return bs->job;
|
2014-10-21 19:03:50 +08:00
|
|
|
|
|
|
|
notfound:
|
|
|
|
*aio_context = NULL;
|
|
|
|
return NULL;
|
2012-01-18 22:40:47 +08:00
|
|
|
}
|
|
|
|
|
2012-04-25 23:51:02 +08:00
|
|
|
void qmp_block_job_set_speed(const char *device, int64_t speed, Error **errp)
|
2012-01-18 22:40:47 +08:00
|
|
|
{
|
2014-10-21 19:03:50 +08:00
|
|
|
AioContext *aio_context;
|
|
|
|
BlockJob *job = find_block_job(device, &aio_context);
|
2012-01-18 22:40:47 +08:00
|
|
|
|
|
|
|
if (!job) {
|
2012-09-28 23:22:44 +08:00
|
|
|
error_set(errp, QERR_BLOCK_JOB_NOT_ACTIVE, device);
|
2012-01-18 22:40:47 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2012-04-25 23:51:02 +08:00
|
|
|
block_job_set_speed(job, speed, errp);
|
2014-10-21 19:03:50 +08:00
|
|
|
aio_context_release(aio_context);
|
2012-01-18 22:40:47 +08:00
|
|
|
}
|
2012-01-18 22:40:48 +08:00
|
|
|
|
2012-09-28 23:22:51 +08:00
|
|
|
void qmp_block_job_cancel(const char *device,
|
|
|
|
bool has_force, bool force, Error **errp)
|
2012-01-18 22:40:48 +08:00
|
|
|
{
|
2014-10-21 19:03:50 +08:00
|
|
|
AioContext *aio_context;
|
|
|
|
BlockJob *job = find_block_job(device, &aio_context);
|
2012-09-28 23:22:51 +08:00
|
|
|
|
2012-01-18 22:40:48 +08:00
|
|
|
if (!job) {
|
2012-09-28 23:22:44 +08:00
|
|
|
error_set(errp, QERR_BLOCK_JOB_NOT_ACTIVE, device);
|
2012-01-18 22:40:48 +08:00
|
|
|
return;
|
|
|
|
}
|
2014-10-21 19:03:50 +08:00
|
|
|
|
|
|
|
if (!has_force) {
|
|
|
|
force = false;
|
|
|
|
}
|
|
|
|
|
2012-09-28 23:22:51 +08:00
|
|
|
if (job->paused && !force) {
|
2014-03-22 07:42:26 +08:00
|
|
|
error_setg(errp, "The block job for device '%s' is currently paused",
|
|
|
|
device);
|
2014-10-21 19:03:50 +08:00
|
|
|
goto out;
|
2012-09-28 23:22:50 +08:00
|
|
|
}
|
2012-01-18 22:40:48 +08:00
|
|
|
|
|
|
|
trace_qmp_block_job_cancel(job);
|
|
|
|
block_job_cancel(job);
|
2014-10-21 19:03:50 +08:00
|
|
|
out:
|
|
|
|
aio_context_release(aio_context);
|
2012-01-18 22:40:48 +08:00
|
|
|
}
|
2012-01-18 22:40:49 +08:00
|
|
|
|
2012-09-28 23:22:51 +08:00
|
|
|
void qmp_block_job_pause(const char *device, Error **errp)
|
|
|
|
{
|
2014-10-21 19:03:50 +08:00
|
|
|
AioContext *aio_context;
|
|
|
|
BlockJob *job = find_block_job(device, &aio_context);
|
2012-09-28 23:22:51 +08:00
|
|
|
|
|
|
|
if (!job) {
|
|
|
|
error_set(errp, QERR_BLOCK_JOB_NOT_ACTIVE, device);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
trace_qmp_block_job_pause(job);
|
|
|
|
block_job_pause(job);
|
2014-10-21 19:03:50 +08:00
|
|
|
aio_context_release(aio_context);
|
2012-09-28 23:22:51 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void qmp_block_job_resume(const char *device, Error **errp)
|
|
|
|
{
|
2014-10-21 19:03:50 +08:00
|
|
|
AioContext *aio_context;
|
|
|
|
BlockJob *job = find_block_job(device, &aio_context);
|
2012-09-28 23:22:51 +08:00
|
|
|
|
|
|
|
if (!job) {
|
|
|
|
error_set(errp, QERR_BLOCK_JOB_NOT_ACTIVE, device);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
trace_qmp_block_job_resume(job);
|
|
|
|
block_job_resume(job);
|
2014-10-21 19:03:50 +08:00
|
|
|
aio_context_release(aio_context);
|
2012-09-28 23:22:51 +08:00
|
|
|
}
|
|
|
|
|
2012-10-18 22:49:21 +08:00
|
|
|
void qmp_block_job_complete(const char *device, Error **errp)
|
|
|
|
{
|
2014-10-21 19:03:50 +08:00
|
|
|
AioContext *aio_context;
|
|
|
|
BlockJob *job = find_block_job(device, &aio_context);
|
2012-10-18 22:49:21 +08:00
|
|
|
|
|
|
|
if (!job) {
|
|
|
|
error_set(errp, QERR_BLOCK_JOB_NOT_ACTIVE, device);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
trace_qmp_block_job_complete(job);
|
|
|
|
block_job_complete(job, errp);
|
2014-10-21 19:03:50 +08:00
|
|
|
aio_context_release(aio_context);
|
2012-10-18 22:49:21 +08:00
|
|
|
}
|
|
|
|
|
2014-07-01 15:52:16 +08:00
|
|
|
void qmp_change_backing_file(const char *device,
|
|
|
|
const char *image_node_name,
|
|
|
|
const char *backing_file,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
BlockDriverState *bs = NULL;
|
|
|
|
BlockDriverState *image_bs = NULL;
|
|
|
|
Error *local_err = NULL;
|
|
|
|
bool ro;
|
|
|
|
int open_flags;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
/* find the top layer BDS of the chain */
|
|
|
|
bs = bdrv_find(device);
|
|
|
|
if (!bs) {
|
|
|
|
error_set(errp, QERR_DEVICE_NOT_FOUND, device);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
image_bs = bdrv_lookup_bs(NULL, image_node_name, &local_err);
|
|
|
|
if (local_err) {
|
|
|
|
error_propagate(errp, local_err);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!image_bs) {
|
|
|
|
error_setg(errp, "image file not found");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (bdrv_find_base(image_bs) == image_bs) {
|
|
|
|
error_setg(errp, "not allowing backing file change on an image "
|
|
|
|
"without a backing file");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* even though we are not necessarily operating on bs, we need it to
|
|
|
|
* determine if block ops are currently prohibited on the chain */
|
|
|
|
if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_CHANGE, errp)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* final sanity check */
|
|
|
|
if (!bdrv_chain_contains(bs, image_bs)) {
|
|
|
|
error_setg(errp, "'%s' and image file are not in the same chain",
|
|
|
|
device);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* if not r/w, reopen to make r/w */
|
|
|
|
open_flags = image_bs->open_flags;
|
|
|
|
ro = bdrv_is_read_only(image_bs);
|
|
|
|
|
|
|
|
if (ro) {
|
|
|
|
bdrv_reopen(image_bs, open_flags | BDRV_O_RDWR, &local_err);
|
|
|
|
if (local_err) {
|
|
|
|
error_propagate(errp, local_err);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = bdrv_change_backing_file(image_bs, backing_file,
|
|
|
|
image_bs->drv ? image_bs->drv->format_name : "");
|
|
|
|
|
|
|
|
if (ret < 0) {
|
|
|
|
error_setg_errno(errp, -ret, "Could not change backing file to '%s'",
|
|
|
|
backing_file);
|
|
|
|
/* don't exit here, so we can try to restore open flags if
|
|
|
|
* appropriate */
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ro) {
|
|
|
|
bdrv_reopen(image_bs, open_flags, &local_err);
|
|
|
|
if (local_err) {
|
|
|
|
error_propagate(errp, local_err); /* will preserve prior errp */
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-09-23 21:26:03 +08:00
|
|
|
void qmp_blockdev_add(BlockdevOptions *options, Error **errp)
|
|
|
|
{
|
|
|
|
QmpOutputVisitor *ov = qmp_output_visitor_new();
|
2014-10-07 19:59:06 +08:00
|
|
|
BlockBackend *blk;
|
2013-09-23 21:26:03 +08:00
|
|
|
QObject *obj;
|
|
|
|
QDict *qdict;
|
|
|
|
Error *local_err = NULL;
|
|
|
|
|
|
|
|
/* Require an ID in the top level */
|
|
|
|
if (!options->has_id) {
|
|
|
|
error_setg(errp, "Block device needs an ID");
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
2014-06-06 20:50:58 +08:00
|
|
|
/* TODO Sort it out in raw-posix and drive_new(): Reject aio=native with
|
2013-09-23 21:26:03 +08:00
|
|
|
* cache.direct=false instead of silently switching to aio=threads, except
|
2014-06-06 20:50:58 +08:00
|
|
|
* when called from drive_new().
|
2013-09-23 21:26:03 +08:00
|
|
|
*
|
|
|
|
* For now, simply forbidding the combination for all drivers will do. */
|
|
|
|
if (options->has_aio && options->aio == BLOCKDEV_AIO_OPTIONS_NATIVE) {
|
2014-03-06 22:47:32 +08:00
|
|
|
bool direct = options->has_cache &&
|
|
|
|
options->cache->has_direct &&
|
|
|
|
options->cache->direct;
|
|
|
|
if (!direct) {
|
2013-09-23 21:26:03 +08:00
|
|
|
error_setg(errp, "aio=native requires cache.direct=true");
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
visit_type_BlockdevOptions(qmp_output_get_visitor(ov),
|
|
|
|
&options, NULL, &local_err);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2013-09-23 21:26:03 +08:00
|
|
|
error_propagate(errp, local_err);
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
obj = qmp_output_get_qobject(ov);
|
|
|
|
qdict = qobject_to_qdict(obj);
|
|
|
|
|
|
|
|
qdict_flatten(qdict);
|
|
|
|
|
2014-10-07 19:59:06 +08:00
|
|
|
blk = blockdev_init(NULL, qdict, &local_err);
|
2014-01-30 22:07:28 +08:00
|
|
|
if (local_err) {
|
2013-09-20 17:33:11 +08:00
|
|
|
error_propagate(errp, local_err);
|
2013-09-23 21:26:03 +08:00
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
2014-10-07 19:59:06 +08:00
|
|
|
if (bdrv_key_required(blk_bs(blk))) {
|
|
|
|
blk_unref(blk);
|
2014-03-06 22:43:42 +08:00
|
|
|
error_setg(errp, "blockdev-add doesn't support encrypted devices");
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
2013-09-23 21:26:03 +08:00
|
|
|
fail:
|
|
|
|
qmp_output_visitor_cleanup(ov);
|
|
|
|
}
|
|
|
|
|
2014-10-07 19:59:10 +08:00
|
|
|
BlockJobInfoList *qmp_query_block_jobs(Error **errp)
|
2012-01-18 22:40:49 +08:00
|
|
|
{
|
2014-10-07 19:59:10 +08:00
|
|
|
BlockJobInfoList *head = NULL, **p_next = &head;
|
|
|
|
BlockDriverState *bs;
|
2012-01-18 22:40:49 +08:00
|
|
|
|
2014-10-07 19:59:10 +08:00
|
|
|
for (bs = bdrv_next(NULL); bs; bs = bdrv_next(bs)) {
|
2014-10-21 19:03:51 +08:00
|
|
|
AioContext *aio_context = bdrv_get_aio_context(bs);
|
|
|
|
|
|
|
|
aio_context_acquire(aio_context);
|
|
|
|
|
2014-10-07 19:59:10 +08:00
|
|
|
if (bs->job) {
|
|
|
|
BlockJobInfoList *elem = g_new0(BlockJobInfoList, 1);
|
|
|
|
elem->value = block_job_query(bs->job);
|
|
|
|
*p_next = elem;
|
|
|
|
p_next = &elem->next;
|
|
|
|
}
|
2014-10-21 19:03:51 +08:00
|
|
|
|
|
|
|
aio_context_release(aio_context);
|
2012-01-18 22:40:49 +08:00
|
|
|
}
|
|
|
|
|
2014-10-07 19:59:10 +08:00
|
|
|
return head;
|
2012-01-18 22:40:49 +08:00
|
|
|
}
|
2012-11-26 23:03:42 +08:00
|
|
|
|
2013-03-15 17:35:07 +08:00
|
|
|
QemuOptsList qemu_common_drive_opts = {
|
2012-11-26 23:03:42 +08:00
|
|
|
.name = "drive",
|
2013-03-15 17:35:07 +08:00
|
|
|
.head = QTAILQ_HEAD_INITIALIZER(qemu_common_drive_opts.head),
|
2012-11-26 23:03:42 +08:00
|
|
|
.desc = {
|
|
|
|
{
|
|
|
|
.name = "snapshot",
|
|
|
|
.type = QEMU_OPT_BOOL,
|
|
|
|
.help = "enable/disable snapshot mode",
|
2013-02-08 21:06:12 +08:00
|
|
|
},{
|
|
|
|
.name = "discard",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "discard operation (ignore/off, unmap/on)",
|
2012-11-26 23:03:42 +08:00
|
|
|
},{
|
2013-07-18 22:31:25 +08:00
|
|
|
.name = "cache.writeback",
|
|
|
|
.type = QEMU_OPT_BOOL,
|
|
|
|
.help = "enables writeback mode for any caches",
|
|
|
|
},{
|
|
|
|
.name = "cache.direct",
|
|
|
|
.type = QEMU_OPT_BOOL,
|
|
|
|
.help = "enables use of O_DIRECT (bypass the host page cache)",
|
|
|
|
},{
|
|
|
|
.name = "cache.no-flush",
|
|
|
|
.type = QEMU_OPT_BOOL,
|
|
|
|
.help = "ignore any flush requests for the device",
|
2012-11-26 23:03:42 +08:00
|
|
|
},{
|
|
|
|
.name = "aio",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "host AIO implementation (threads, native)",
|
|
|
|
},{
|
|
|
|
.name = "format",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "disk format (raw, qcow2, ...)",
|
|
|
|
},{
|
|
|
|
.name = "rerror",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "read error action",
|
|
|
|
},{
|
|
|
|
.name = "werror",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "write error action",
|
|
|
|
},{
|
2013-07-20 02:07:29 +08:00
|
|
|
.name = "read-only",
|
2012-11-26 23:03:42 +08:00
|
|
|
.type = QEMU_OPT_BOOL,
|
|
|
|
.help = "open drive file as read-only",
|
|
|
|
},{
|
2013-07-17 20:41:54 +08:00
|
|
|
.name = "throttling.iops-total",
|
2012-11-26 23:03:42 +08:00
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "limit total I/O operations per second",
|
|
|
|
},{
|
2013-07-17 20:41:54 +08:00
|
|
|
.name = "throttling.iops-read",
|
2012-11-26 23:03:42 +08:00
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "limit read operations per second",
|
|
|
|
},{
|
2013-07-17 20:41:54 +08:00
|
|
|
.name = "throttling.iops-write",
|
2012-11-26 23:03:42 +08:00
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "limit write operations per second",
|
|
|
|
},{
|
2013-07-17 20:41:54 +08:00
|
|
|
.name = "throttling.bps-total",
|
2012-11-26 23:03:42 +08:00
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "limit total bytes per second",
|
|
|
|
},{
|
2013-07-17 20:41:54 +08:00
|
|
|
.name = "throttling.bps-read",
|
2012-11-26 23:03:42 +08:00
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "limit read bytes per second",
|
|
|
|
},{
|
2013-07-17 20:41:54 +08:00
|
|
|
.name = "throttling.bps-write",
|
2012-11-26 23:03:42 +08:00
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "limit write bytes per second",
|
2013-09-02 20:14:40 +08:00
|
|
|
},{
|
|
|
|
.name = "throttling.iops-total-max",
|
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "I/O operations burst",
|
|
|
|
},{
|
|
|
|
.name = "throttling.iops-read-max",
|
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "I/O operations read burst",
|
|
|
|
},{
|
|
|
|
.name = "throttling.iops-write-max",
|
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "I/O operations write burst",
|
|
|
|
},{
|
|
|
|
.name = "throttling.bps-total-max",
|
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "total bytes burst",
|
|
|
|
},{
|
|
|
|
.name = "throttling.bps-read-max",
|
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "total bytes read burst",
|
|
|
|
},{
|
|
|
|
.name = "throttling.bps-write-max",
|
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "total bytes write burst",
|
2013-09-02 20:14:41 +08:00
|
|
|
},{
|
|
|
|
.name = "throttling.iops-size",
|
|
|
|
.type = QEMU_OPT_NUMBER,
|
|
|
|
.help = "when limiting by iops max size of an I/O in bytes",
|
2012-11-26 23:03:42 +08:00
|
|
|
},{
|
|
|
|
.name = "copy-on-read",
|
|
|
|
.type = QEMU_OPT_BOOL,
|
|
|
|
.help = "copy read data from backing file into image file",
|
2014-05-18 06:58:19 +08:00
|
|
|
},{
|
|
|
|
.name = "detect-zeroes",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "try to optimize zero writes (off, on, unmap)",
|
2012-11-26 23:03:42 +08:00
|
|
|
},
|
|
|
|
{ /* end of list */ }
|
|
|
|
},
|
|
|
|
};
|
2013-03-15 17:35:07 +08:00
|
|
|
|
|
|
|
QemuOptsList qemu_drive_opts = {
|
|
|
|
.name = "drive",
|
|
|
|
.head = QTAILQ_HEAD_INITIALIZER(qemu_drive_opts.head),
|
|
|
|
.desc = {
|
2013-06-19 19:44:17 +08:00
|
|
|
/*
|
|
|
|
* no elements => accept any params
|
|
|
|
* validation will happen later
|
|
|
|
*/
|
2013-03-15 17:35:07 +08:00
|
|
|
{ /* end of list */ }
|
|
|
|
},
|
|
|
|
};
|