Commit Graph

1070 Commits

Author SHA1 Message Date
Nikita Popov
422d1665a2 Make convert_to_*_ex simple aliases of convert_to_*
Historically, the _ex variants separated the zval first, if a
conversion was necessary. This distinction no longer makes sense
since PHP 7.

The only difference that was still left is that _ex checked whether
the type is the same first, but the usage of these macros did not
actually distinguish on whether such an inlined check is valuable
or not in a given context.

Also drop the unused convert_to_explicit_type macros.
2021-01-14 12:11:11 +01:00
Christopher Jones
d6731d69bd Description typo 2020-12-21 15:46:26 +11:00
Christopher Jones
74959b47cd Bundle PECL OCI8 3.0.1 2020-12-21 15:15:16 +11:00
Christoph M. Becker
2e974c8c81 Add Windows support for OCI 19
As requested by Christopher Jones.
2020-12-14 23:11:04 +01:00
Christopher Jones
a9c44d1b5a Update PECL package release date 2020-11-27 10:17:37 +11:00
Christopher Jones
37f96d990c Fix test diff 2020-11-25 16:42:12 +11:00
Christopher Jones
68d5878097 Sync README with package.xml 2020-11-24 10:45:48 +11:00
Máté Kocsis
d6264b0966
Verify parameter names of function aliases
Closes GH-6335
2020-10-16 10:56:33 +02:00
Máté Kocsis
4173f2b3ab
Improve parameter names in ext/oci8
Closes GH-6267
2020-10-08 23:30:33 +02:00
Nikita Popov
c5401854fc Run tidy
This should fix most of the remaining issues with tabs and spaces
being mixed in tests.
2020-09-18 14:28:32 +02:00
Máté Kocsis
36fd95b524
Generate arginfos 2020-09-16 21:28:27 +02:00
Máté Kocsis
de912821e0
Display string default values in stubs more uniformly
Settling on using quoted string
2020-09-16 21:27:01 +02:00
Máté Kocsis
c76910cd96
Display types in stubs more uniformly
In preparation for generating method signatures for the manual.

This change gets rid of bogus false|null return types, a few unnecessary trailing backslashes, and settles on using ? when possible for nullable types.
2020-09-16 21:19:36 +02:00
George Peter Banyard
824a2bf149 Promote some warnings to ValueError in OCI8
Closes GH-6116

Co-authored-by: Christopher Jones <sixd@php.net>
2020-09-15 02:54:12 +02:00
Máté Kocsis
9975986b7e
Improve error messages mentioning parameters instead of arguments
Closes GH-5999
2020-09-09 10:47:43 +02:00
Christopher Jones
311fa34246 Fix 3b0fecd and resulting test fail lob_012.phpt 2020-09-09 11:28:00 +10:00
Máté Kocsis
3b0fecd508
Fix UNKNOWN default values in ext/oci8
Closes GH-6089
2020-09-08 15:38:23 +02:00
Christopher Jones
ec158c25c4 Catch type errors so test completes and doesn't diff 2020-09-08 16:49:54 +10:00
Christopher Jones
16d79d7acc Accept updated error number generated by the latest Oracle version 2020-09-08 16:06:33 +10:00
Christopher Jones
55afe4e7da Yes, and mask the dir path too. 2020-09-08 15:56:26 +10:00
Christopher Jones
6134bf9ab1 Fix parsing regression from PHP 7 2020-09-08 15:48:48 +10:00
Máté Kocsis
3e800e997b
Move custom type checks to ZPP
Closes GH-6034
2020-09-02 11:11:38 +02:00
Máté Kocsis
f7fbc6333f
Add more precise type info for stubs
Closes GH-6005
2020-09-01 16:35:56 +02:00
George Peter Banyard
1b2ec73c1d Drop various unused macros/APIs
Also convert_libmagic_pattern() to return a zend_string*

Closes GH-6029
2020-08-26 12:59:43 +02:00
Christopher Jones
47c787ff5b Squash a Linux compile warning 2020-08-22 11:37:23 +10:00
Christopher Jones
ff66e4945e OCI8 classes were already renamed in 8; this now follows the new-new standard 2020-08-21 17:46:16 +10:00
Máté Kocsis
7aacc705d0
Add many missing closing PHP tags to tests
Closes GH-5958
2020-08-09 22:03:36 +02:00
Christopher Jones
99d2b24b15 Make test decimal to binary conversion expectation more tolerant 2020-07-23 16:31:33 +10:00
Christopher Jones
b2d1736de8 Fix cut/paste error in expected test output 2020-07-23 16:29:51 +10:00
George Peter Banyard
7a3375a08c Use ZPP callable check for oci_register_taf_callback() 2020-07-22 17:29:30 +10:00
George Peter Banyard
0d146cb3eb Some cleanup in OCI8 extension for PHP 8 2020-07-22 17:29:30 +10:00
Christopher Jones
74ca2a39a7 Rename OCI8 classes to use standard names so arg stub parsing works 2020-07-20 18:06:20 +10:00
Christopher Jones
8058776295 Bump OCI8 version to 3.0 so a PHP 8 PECL release can be made 2020-07-20 18:06:19 +10:00
Jens de Nies
11f4a5e563
Removed the "oci_internal_debug" function and its alias. Also deprecated the "ocifetchinto" function.
Closes GH-5810
2020-07-11 19:57:30 +02:00
Max Semenik
2b5de6f839
Remove proto comments from C files
Closes GH-5758
2020-07-06 21:13:34 +02:00
Jens de Nies
58f51f8c75
Added stubs for ext/oci8
Closes GH-5701
2020-07-04 10:56:48 +02:00
Fabien Villepinte
0c6d06ecfa Replace EXPECTF when possible
Closes GH-5779
2020-06-29 21:31:44 +02:00
Jens de Nies
01be55fc00
Made sure zpp is always called and refactored some existing zpp calls.
Closes GH-5714
2020-06-16 10:45:14 +02:00
Jens de Nies
58a65c4b96
Fixed some oci8 tests.
Closes GH-5716
2020-06-16 10:38:06 +02:00
Máté Kocsis
793823655e
Fix ZPP of OCI_Lob::free 2020-06-13 10:53:49 +02:00
Jens de Nies
45475c2e21 Deprecate function aliases in oci8 extension.
Closes GH-5589
2020-06-08 00:23:38 +02:00
Nikita Popov
406c95758d Remove some uses of zend_inline_hash_func
There's no need to force-inline the hashing for all of these.
2020-05-15 10:14:22 +02:00
Máté Kocsis
36935e42ea
Improve undefined variable error messages
Closes GH-5312
2020-03-31 13:02:32 +02:00
Cameron Porter
a55b0abef3 oci8: Fix two tests that fail with stricter internal checks
Closes GH-5230
2020-03-03 12:13:44 +01:00
Máté Kocsis
960318ed95
Change argument error message format
Closes GH-5211
2020-02-26 15:00:08 +01:00
Máté Kocsis
ac0853eb26
Make type error messages more consistent
Closes GH-5092
2020-02-17 14:22:17 +01:00
Nikita Popov
f8d795820e Reindent phpt files 2020-02-03 22:52:20 +01:00
Nikita Popov
6811222422 Eliminate uses of ZVAL_ZVAL and friends
Instead add RETURN_COPY(_VALUE) macros will the expected behavior.

RETURN_ZVAL doesn't make any sense since PHP 7, but has stuck
around, probably because the alternative was to write directly to
the return_value variable.
2020-01-20 10:34:17 +01:00
Máté Kocsis
d1764ca330
Make error messages more consistent by fixing capitalization
Closes GH-5066 As a first step, let's capitalize their initial letter when it is applicable.
2020-01-17 14:52:46 +01:00
Máté Kocsis
afdaa91170
Fix #78880: Final spelling fixes 2020-01-16 19:14:31 +01:00