mirrors/php-src
0
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2024-11-30 13:25:43 +08:00
Code Issues Packages Projects Releases Wiki Activity
110,828 Commits 500 Branches 1,381 Tags 820 MiB
c348ed13ac
Commit Graph

50110 Commits

Author SHA1 Message Date
Peter Kokot
bebcdcc745 Remove legacy AC_CHECK_TYPE calls for uint and ulong 
The AC_CHECK_TYPE was refactored in more recent versions of Autoconf
and the call with two arguments is obsolete and not recommended anymore.

This patch also refactors some leftovers of using ulong and uint which
are not standard nor common usages of types in C.

The ulong can be used as zend_ulong and uint usage is actually
`unsigned int`.

The usage of HAVE_ULONG removed since it is not used in current code
base.

Legacy edgecase for some legacy HPUX systems removed:
- sys/stream.h header is not checked and the HAVE_SYS_STREAM_H is
  not defined with current build system.

- flags are unsigned int
- max_allowed_packet changed to unsigned int
 2019-03-06 22:49:16 +01:00
Nikita Popov
8c62c69265 More zpp error/variation test removals 
Some of these tests also check non-zpp conditions -- however, there is
always some other test that also checks those error conditions.
 2019-03-06 13:40:22 +01:00
Stanislav Malyshev
db777e9199 Fix shifting signed values too far 
Signed shift of 31 for int and 63 for long is flagged as undefined
behavior by UBSan (-fsanitize=undefined) and seems to be indeed so
according to the standard.

The patch converts such cases to use unsigned.
 2019-03-06 00:50:09 -08:00
Christoph M. Becker
f651397b1f Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Fix #77700: Writing truecolor images as GIF ignores interlace flag
 2019-03-06 00:38:12 +01:00
Christoph M. Becker
0d88388912 Merge branch 'PHP-7.2' into PHP-7.3 
* PHP-7.2:
  Fix #77700: Writing truecolor images as GIF ignores interlace flag
 2019-03-06 00:37:38 +01:00
Christoph M. Becker
41fb0eaa11 Fix #77700: Writing truecolor images as GIF ignores interlace flag 
We  revert the interlace flag related part of commit ff2822a[1], since
contrary to the transparent color, the interlace flag is not retained
by `gdImageCreatePaletteFromTrueColor()`.  This also matches upstream
libgd.

[1] <http://git.php.net/?p=php-src.git;a=commit;h=ff2822a82b740edb8ccf307f080bae188c200fb9>
 2019-03-06 00:34:40 +01:00
Nikita Popov
10b4113638 Remove more zpp error tests 2019-03-05 17:09:09 +01:00
Gabriel Caruso
e907fbaf7c Remove unnecessary check for always available extension 2019-03-05 12:54:24 -03:00
Nikita Popov
7e3f4a2390 Remove more zpp error/variation tests 2019-03-05 14:09:33 +01:00
Nikita Popov
4bd18db8cc Remove custom error handler in mbstring tests 
To make it more obvious what is tested and what the error messages
are.
 2019-03-05 11:41:53 +01:00
Nikita Popov
94d509363d Remove more zpp error tests 2019-03-05 11:02:31 +01:00
Nikita Popov
b26df0e395 Remove tests for zpp failure conditions 
These tests only check zpp error conditions, so drop them per
zpp testing policy.
 2019-03-05 10:22:23 +01:00
Dmitry Stogov
ff5fa0d631 Fixed support for callbacks with "void" return type 2019-03-05 01:03:47 +03:00
Anatol Belski
53c44a43dd Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Fix test portability
 2019-03-04 14:30:32 +01:00
Anatol Belski
a976283c34 Merge branch 'PHP-7.2' into PHP-7.3 
* PHP-7.2:
  Fix test portability
 2019-03-04 14:30:01 +01:00
Anatol Belski
040196972c Fix test portability 2019-03-04 14:28:47 +01:00
Nikita Popov
ade5474792 Merge branch 'PHP-7.3' into PHP-7.4 2019-03-04 13:16:25 +01:00
Nikita Popov
4c68aaabf1 Merge branch 'PHP-7.2' into PHP-7.3 2019-03-04 13:16:01 +01:00
Nikita Popov
3f00c9367d Fixed bug #77691 
We cannot replace an op1_def opcode with an ASSIGN, if it also has
a used res_def. Usually this doesn't happen because the res_def use
can be eliminated first. The example is a case where operand replacement
on the res_def use fails.
 2019-03-04 13:11:12 +01:00
Peter Kokot
a8c3e22d23 Replace PHP_TM_GMTOFF with AC_CHECK_MEMBERS 
Changes:
- PHP_TM_GMTOFF removed
- HAVE_TM_GMTOFF replaced with HAVE_STRUCT_TM_TM_GMTOFF
- HAVE_TM_ZONE replaced with HAVE_STRUCT_TM_TM_ZONE
- HAVE_TZNAME removed

The PHP_TM_GMTOFF macro can be replaced with Autoconf's AC_CHECK_MEMBERS
that defines the HAVE_STRUCT_TM_TM_GMTOFF symbol instead of the
HAVE_TM_ZONE.

The HAVE_TZNAME symbol is not used in current code. The obsolete
HAVE_TM_ZONE symbol has been replaced with more proper
HAVE_STRUCT_TM_TM_ZONE. These are defined by the AC_STRUCT_TIMEZONE
macro.
 2019-03-04 12:13:12 +01:00
Nikita Popov
6be93b29eb Don't generate script for proc_open_pipes tests 
Commit the generated script instead, which is much simpler than
the code generating it...
 2019-03-04 10:52:50 +01:00
Nikita Popov
e27ba75e0f Use separate output files in x2gd tests 2019-03-04 10:48:09 +01:00
Nikita Popov
15711a4db0 Use separate directories for win32 dir tests 
Also remove one redundant piece of cleanup code.
 2019-03-04 10:36:55 +01:00
Stanislav Malyshev
071e18c697 Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Fix bug #77586 - phar_tar_writeheaders_int() buffer overflow
 2019-03-03 23:33:54 -08:00
Stanislav Malyshev
6d60ed69a1 Merge branch 'PHP-7.2' into PHP-7.3 
* PHP-7.2:
  Fix bug #77586 - phar_tar_writeheaders_int() buffer overflow
 2019-03-03 23:33:48 -08:00
Stanislav Malyshev
3e8d8f7fb3 Merge branch 'PHP-7.1' into PHP-7.2 
* PHP-7.1:
  Fix bug #77586 - phar_tar_writeheaders_int() buffer overflow
 2019-03-03 23:33:43 -08:00
Stanislav Malyshev
e0f5d62bd6 Fix bug #77586 - phar_tar_writeheaders_int() buffer overflow 2019-03-03 23:05:32 -08:00
Stanislav Malyshev
534a18c08f Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Update NEWS
  Fix test error message
  Fix bug #77563 - Uninitialized read in exif_process_IFD_in_MAKERNOTE
  Fix bug #77540 - Invalid Read on exif_process_SOFn
  Fix integer overflows on 32-bits
  Fix #77431 SplFileInfo::__construct() accepts NUL bytes
  Fix bug #77396 - Null Pointer Dereference in phar_create_or_parse_filename
 2019-03-03 22:20:49 -08:00
Stanislav Malyshev
e3f7c352dc Merge branch 'PHP-7.2' into PHP-7.3 
* PHP-7.2:
  Update NEWS
  Fix test error message
  Fix bug #77563 - Uninitialized read in exif_process_IFD_in_MAKERNOTE
  Fix bug #77540 - Invalid Read on exif_process_SOFn
  Fix integer overflows on 32-bits
  Fix #77431 SplFileInfo::__construct() accepts NUL bytes
  Fix bug #77396 - Null Pointer Dereference in phar_create_or_parse_filename
 2019-03-03 22:20:42 -08:00
Stanislav Malyshev
8363df3703 Merge branch 'PHP-7.1' into PHP-7.2 
* PHP-7.1:
  Update NEWS
  Fix test error message
  Fix bug #77563 - Uninitialized read in exif_process_IFD_in_MAKERNOTE
  Fix bug #77540 - Invalid Read on exif_process_SOFn
  Fix integer overflows on 32-bits
  Fix #77431 SplFileInfo::__construct() accepts NUL bytes
  Fix bug #77396 - Null Pointer Dereference in phar_create_or_parse_filename
 2019-03-03 22:20:35 -08:00
Stanislav Malyshev
44f87fbf36 Fix test error message 2019-03-03 19:30:14 -08:00
Stanislav Malyshev
8ac6fee856 Fix bug #77563 - Uninitialized read in exif_process_IFD_in_MAKERNOTE 
Also fix for bug #77659
 2019-03-03 18:35:43 -08:00
Stanislav Malyshev
5f0e62a3e5 Fix bug #77540 - Invalid Read on exif_process_SOFn 2019-03-03 18:35:26 -08:00
Stanislav Malyshev
5e824a88d0 Fix integer overflows on 32-bits 2019-03-03 18:35:04 -08:00
Christoph M. Becker
254a5914ad Fix #77431 SplFileInfo::__construct() accepts NUL bytes 
`SplFileInfo::__construct()` has to expect a path instead of a string,
analogous to `SplFileObject::__construct()`.
 2019-03-03 18:23:46 -08:00
Stanislav Malyshev
7f0ab7c20c Fix bug #77396 - Null Pointer Dereference in phar_create_or_parse_filename 2019-03-03 18:22:32 -08:00
Anatol Belski
8cd345acb1 Heedlessly enable thread LS cache for ext/hash. 
It's always static now and as such always has access to the cached
TLS pointer.
 2019-03-02 21:25:35 +01:00
Peter Kokot
a700451706 Remove obsolescent AC_HEADER_STDC and memcpy check 
Autoconf 2.59d (released in 2006) [1] started promoting several macros
as not relevant for newer systems anymore, including the `AC_HEADER_STDC`.

This macro checks if given system has C89 compliant header files such
as `<string.h>`, `<stdlib.h>`, `<stdarg.h>`, `<float.h>`,... and defines
the `STDC_HEADERS` symbol [2]. Case is that current systems should be
well supported with at least C89 standard headers [3].

Given headers are still additionally checked with the `AC_PROG_CC`
macro, yet not needed anyway.

Additionally, the HAVE_MEMCPY check has been removed. The memcpy
function is standardized by C89 and later.

Refs:
[1] http://git.savannah.gnu.org/cgit/autoconf.git/tree/NEWS
[2] https://www.gnu.org/software/autoconf/manual/autoconf-2.69/autoconf.html
[3] https://port70.net/~nsz/c/c89/c89-draft.html#4.1.2
 2019-03-01 19:22:44 +01:00
Nikita Popov
51dacafc64 Use separate files for SplFileObject::setCsvControl() tests 2019-03-01 15:32:02 +01:00
Nikita Popov
6878d1026b Merge branch 'PHP-7.3' into PHP-7.4 2019-03-01 14:55:24 +01:00
Nikita Popov
8be12e770f Merge branch 'PHP-7.2' into PHP-7.3 2019-03-01 14:55:15 +01:00
Jay Satiro
5025eb05bd curl_error: return an empty string if no error occurred 
CURLOPT_ERRORBUFFER doc says "Do not rely on the contents of the
buffer unless an error code was returned." [1]

Prior to this change the error buffer was returned even if no error had
occurred, and that buffer may contain incorrect information in such a
case. [2]

[1]: https://curl.haxx.se/libcurl/c/CURLOPT_ERRORBUFFER.html
[2]: https://github.com/curl/curl/issues/3629
 2019-03-01 14:54:37 +01:00
Dmitry Stogov
7d5e2e532c Enable Posix Shared Memory on Linux 2019-03-01 12:15:56 +03:00
Rodrigo Prado
54ef8d13d8 Test for function posix_getpwnam() basic functionality 
The coverage for the function posix_getpwnam() that was not covered yet.
http://gcov.php.net/PHP_HEAD/lcov_html/ext/posix/posix.c.gcov.php#1182
Rodrigo Prado de Jesus <royopa [at] gmail [dot] com>
User Group: PHPSP #PHPTestFestBrasil
 2019-03-01 02:01:52 +01:00
Peter Kokot
e763cc7425 Fix file permissions 
Git can track executable (0755) and non-executable (0644) file modes.

This patch fixes file permissions in the php-src repository according to
the predefined executable files with 0755 permissions (shell scripts)
and all others with 0644 permissions.
 2019-02-28 22:07:16 +01:00
Nikita Popov
105a04aaac Don't remove CONST CAST in CONCAT operand 
CONCAT assumes that CONST operands are strings, so we cannot
blindly remove CAST operands.
 2019-02-28 16:42:30 +01:00
Nikita Popov
1b998bb9cb Remove unnecessary convert_to_string_safe macro 
I'm assuming that the reason this existed was to avoid modifying
an interned string. However, the current code handles this case
fine already.
 2019-02-28 16:30:05 +01:00
Nikita Popov
f4ded492c9 Don't return inside _DO_THROW macro 
Returning inside _DO_THROW() is kind of pointless if we are going
to comment most uses with "this is gonna return".
 2019-02-28 15:45:47 +01:00
Nikita Popov
248f9cf33f Remove more leftovers of mysqli embedded server 2019-02-28 15:43:29 +01:00
Derick Rethans
9624e87a8f Merge branch 'PHP-7.3' into PHP-7.4 2019-02-28 13:52:33 +00:00