Christoph M. Becker
6ec4056928
Fix #79008 : General performance regression with PHP 7.4 on Windows
...
We no longer try to retrieve the filename of a given stream when
fstat'ing, because this is very slow. Since we neither didn't do that
in PHP 7.3 and earlier, we regard this as sensible trade-off.
2019-12-20 16:28:11 +01:00
Nikita Popov
d5c55f81ec
Try to make proc_open_bug69900.phpt more robust
2019-12-20 13:51:31 +01:00
Nikita Popov
b0737fa35e
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #78982 : pdo_pgsql returns dead persistent connection
2019-12-20 12:06:05 +01:00
SATO Kentaro
37d11d123e
Fix #78982 : pdo_pgsql returns dead persistent connection
...
Call PQconsumeInput() before PQstatus() to update the status.
2019-12-20 12:05:17 +01:00
Nikita Popov
f974f252dd
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #78980 : pgsqlGetNotify() overlooks dead connection
2019-12-20 11:45:16 +01:00
SATO Kentaro
7e39e6934d
Fix #78980 : pgsqlGetNotify() overlooks dead connection
...
pgsqlGetNotify() didn't check result of PQconsumeInput().
2019-12-20 11:44:07 +01:00
Nikita Popov
10eb0b3110
Fixed bug #79000
...
Don't report EAGAIN/EWOULDBLOCK as errors for fwrite on
non-blocking socket streams. This matches behavior for fread,
as well as behavior for plain file streams.
Closes GH-5026.
2019-12-20 11:37:43 +01:00
Nikita Popov
d4ba1fd963
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #74170 : locale information change after mime_content_type
2019-12-20 11:24:03 +01:00
Sergei Turchanov
c62cd9a43a
Fix #74170 : locale information change after mime_content_type
...
Some functions in libmagic (distributed with fileinfo extension) perform this sequence of calls:
func() {
setlocale(LC_TYPE, "C")
.. do some work ..
setlocale(LC_TYPE, "")
}
It effectively resets LC_TYPE if it that was set before the function call.
To avoid manipulations with current locale at all, the problematic functions
were modified to use locale-independent functions.
2019-12-20 11:22:59 +01:00
Nikita Popov
5155097431
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #78402 : pcntl_signal() misleading error message
2019-12-20 11:02:57 +01:00
SATO Kentaro
cbb0efaeeb
Fix #78402 : pcntl_signal() misleading error message
...
An error message can be misleading when a handler
passed to pcntl_signal() is not callable.
2019-12-20 11:02:20 +01:00
Nikita Popov
885b3451f4
Fix early free of assign_obj op_data
...
We need to make sure that op_data is only freed after populating
result, as op_data may be the only thing holding the value in the
case of an overloaded assignment.
This reverts the code to how it looked like in 7.3.
2019-12-20 10:35:34 +01:00
Dmitry Stogov
66d5b0608a
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed bug #78999 (Cycle leak when using function result as temporary)
2019-12-19 23:17:39 +03:00
Dmitry Stogov
eb846939b1
Fixed bug #78999 (Cycle leak when using function result as temporary)
2019-12-19 23:11:08 +03:00
Christoph M. Becker
7e05f97fa6
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #78983 : pdo_pgsql config.w32 cannot find libpq-fe.h
2019-12-19 13:21:23 +01:00
SATO Kentaro
3e35b08980
Fix #78983 : pdo_pgsql config.w32 cannot find libpq-fe.h
...
When configured with a path specified.
2019-12-19 13:20:43 +01:00
Nikita Popov
527ad1d80c
Avoid signed integer overflow in string offset check
...
Cast to size_t before performing operations instead of afterwards.
2019-12-19 11:47:50 +01:00
Nikita Popov
e4b12fc62a
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Add destructor annotations in ini parser
2019-12-19 10:43:14 +01:00
Nikita Popov
0f078f6e78
Add destructor annotations in ini parser
...
It would be better to switch this to use %union and %type annotations,
but not going to do that change for 7.3.
2019-12-19 10:43:05 +01:00
Nikita Popov
df08d6bffe
Fix leak in assign_ref with function
...
As far as I can see, the retval copying is already done in all
callers of this function, so it should not be duplicated here.
2019-12-18 17:18:10 +01:00
Nikita Popov
4a61d842e7
Fixed bug #78776
...
By using the normal inheritance check if the parent is abstract
as well.
2019-12-18 15:55:45 +01:00
Remi Collet
76eb30ded3
fix release date
2019-12-18 14:18:03 +01:00
Remi Collet
e5e1425a05
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
fix release date
fix release date
2019-12-18 14:17:49 +01:00
Remi Collet
bacfae8baf
fix release date
2019-12-18 14:17:31 +01:00
Remi Collet
22dec2b323
Merge branch 'PHP-7.2' into PHP-7.3
...
* PHP-7.2:
fix release date
2019-12-18 14:17:21 +01:00
Remi Collet
864f5ef12f
fix release date
2019-12-18 14:16:19 +01:00
Nikita Popov
bd4fce4f6f
Fixed bug #78986
...
Don't assume that handlers live in the arena, they may also be in
SHM.
2019-12-18 11:40:58 +01:00
Fabien Villepinte
203308f6c3
Add CONFLICTS tag
...
These tests can be the reason file_get_contents_variation8.phpt fails times to times.
2019-12-18 11:08:24 +01:00
Nikita Popov
bfb38c3592
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Rethrow generator exception even without active stack frame
2019-12-18 11:04:46 +01:00
Nikita Popov
897d99c7a4
Rethrow generator exception even without active stack frame
...
Finally blocks in generators may be invoked during shutdown, in
which case we don't have a stack frame. Similar to what
zend_call_function does, we still need to rethrow these exceptions,
otherwise they will be hidden (and leak).
2019-12-18 11:04:15 +01:00
Nikita Popov
b965f158ac
Fix use-after-free when trying to write to closure property
2019-12-18 10:24:02 +01:00
Nikita Popov
ee89e73312
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix freeing of dynamic call name
2019-12-18 10:11:23 +01:00
Nikita Popov
189f625e2b
Fix freeing of dynamic call name
...
We need to free op2 if the call construction fails.
Also remove a redundant check for !call.
2019-12-18 10:11:09 +01:00
Nikita Popov
0301ab70b3
Fix const/cv freeing on failed reference assignment
2019-12-18 09:54:10 +01:00
Christoph M. Becker
9458f7e2d8
More updates to CONTRIBUTING.md
...
7.4 is stable.
2019-12-17 20:01:18 +01:00
Christoph M. Becker
250416ccb1
Update CONTRIBUTING.md
...
7.1 is EOL; 7.2 is security fixes only.
2019-12-17 19:57:49 +01:00
Christoph M. Becker
4cd6d384bd
Fix #78976 : SplFileObject::fputcsv returns -1 on failure
...
`php_stream_write()` returns `-1` on failure now, which has to be
catered to by `SplFileObject::fputcsv()` which still is supposed to
return `false` on failure.
2019-12-17 17:52:18 +01:00
Nikita Popov
e45b613950
Free buffer in php_verror even if it is empty
...
vspprintf allocates a buffer even if the resulting string is empty.
2019-12-17 16:46:52 +01:00
Nikita Popov
fcdc0a6db0
Fix resetting of internal_encoding and friends
...
We need to update the value even if new_value is NULL. In particular,
it should be reset back to NULL after each request if the setting was
not specified on startup. Otherwise we leave dangling pointers.
2019-12-17 16:27:56 +01:00
Nikita Popov
dd997a40d0
Avoid float to int cast UB in exif
2019-12-17 13:26:05 +01:00
Christoph M. Becker
ddd6e68ef9
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Update/fix NEWS [ci skip]
2019-12-17 10:05:18 +01:00
Christoph M. Becker
3d50131ef7
Update/fix NEWS [ci skip]
2019-12-17 10:04:42 +01:00
Christoph M. Becker
900283d25d
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
[ci skip] Update NEWS
[ci skip] Update NEWS
Fix test
2019-12-17 10:02:43 +01:00
Christoph M. Becker
b94c28b0e6
Merge branch 'PHP-7.2' into PHP-7.3
...
* PHP-7.2:
[ci skip] Update NEWS
2019-12-17 10:01:50 +01:00
Stanislav Malyshev
0e413241ec
[ci skip] Update NEWS
2019-12-16 23:45:11 -08:00
Stanislav Malyshev
9705e631a4
[ci skip] Update NEWS
2019-12-16 23:41:04 -08:00
Dmitry Stogov
d89cd0bb22
Property names of internal classes from temporary extensins, loaded by dl(), may be emalloc-ed strings.
2019-12-17 10:10:11 +03:00
Dmitry Stogov
abf05181b9
Fixed memory leak
2019-12-17 10:09:22 +03:00
Dmitry Stogov
0927af3d8d
Fixed memory leaks
2019-12-17 09:58:27 +03:00
Nikita Popov
77e131da91
Set opcache.optimization_level=0 in test
...
Otherwise opcache "inlines" the function, which causes a minor
difference in destruction behavior.
2019-12-16 20:23:17 +01:00