Commit Graph

1418 Commits

Author SHA1 Message Date
Greg Beaver
68c7403a13 stupid me - this was a circular reference, removing 2003-12-06 22:17:22 +00:00
Greg Beaver
d9f4fd0757 slightly clearer error messages 2003-12-06 22:14:11 +00:00
Greg Beaver
fc3cb93064 fix arg parsing to work with Console_Getopt 2.0 2003-12-06 22:07:49 +00:00
Greg Beaver
9e361c0278 remove unnecessary experimental code 2003-12-06 21:52:20 +00:00
Greg Beaver
107d75d86b getting ready for both packages to be released 2003-12-06 21:47:53 +00:00
Greg Beaver
8cd5e9ec6e fix for Console_GetOpt 2.0 (what was 1.1 - re-release being negotiated) 2003-12-06 21:35:02 +00:00
Greg Beaver
bb861773a9 forgot to have it delete the directory it creates 2003-12-06 06:56:55 +00:00
Greg Beaver
61bd893e0d update phpdoc comment 2003-12-06 06:08:56 +00:00
Greg Beaver
33aa36fb8d add todo for known issue that isn't yet critical but will be 2003-12-06 06:06:50 +00:00
Greg Beaver
c46abac9bd new test case - test invalid download conditions
TODO:
- tests for _processDependency
2003-12-06 06:05:04 +00:00
Greg Beaver
29df86f2d1 improve error message, it was both terrible grammar and unclear. 2003-12-06 05:59:25 +00:00
Greg Beaver
d1770cc57f fix error message - was printing an empty preferred state 2003-12-06 05:35:52 +00:00
Greg Beaver
49a2893adb simple fix for core bug #362 - raiseError() doesn't return a reference, why should throwError()? 2003-12-06 02:00:33 +00:00
Andrei Zmievski
a3d2fd336c MFB 2003-12-05 22:02:48 +00:00
Greg Beaver
5252f3faa9 merge downloader code into HEAD - it works
fix bug found in uninstall
2003-12-04 02:11:40 +00:00
Greg Beaver
d2ad2841bd unit test for new code - proves it works 2003-12-04 02:01:46 +00:00
Greg Beaver
07a0281d00 add helper methods needed - now it is 100% unit tested 2003-12-04 02:00:39 +00:00
Greg Beaver
e8468911ed fixed minor bug 2003-12-04 01:35:45 +00:00
Greg Beaver
ad9629d2bf finished unit test 2003-12-04 01:35:27 +00:00
Greg Beaver
1558f748e3 fix bugs found in unit-testing, one BC issue also 2003-12-04 01:22:50 +00:00
Greg Beaver
2ab2d8263c fix notice 2003-12-04 01:22:12 +00:00
Greg Beaver
dba21314ce another segment working 2003-12-04 01:22:00 +00:00
Greg Beaver
172bf25830 another test case, small fix for XML_RPC caching borking working tests 2003-12-03 23:46:10 +00:00
Greg Beaver
ed3167eada another tgz for test case comparison 2003-12-03 23:36:00 +00:00
Greg Beaver
604dcdd256 add part of a test case 2003-12-03 23:24:47 +00:00
Greg Beaver
577cf36f91 remove unnecessary notice generator in certain cases 2003-12-03 23:00:05 +00:00
Greg Beaver
4e5e628637 new unit test for downloader - incomplete.
WARNING: this test requires a fully functional pearweb server at address pear.Chiara, with several packages available for download.  This one will fail until Martin has time to set up test.pear.php.net as the server.
2003-12-03 22:53:58 +00:00
Greg Beaver
35bdc2f7eb duhhh... 2003-12-03 22:39:55 +00:00
Greg Beaver
036ac99eef new test case and supporting files - incomplete, but works as it is 2003-12-01 04:51:21 +00:00
Greg Beaver
cd4baaf654 potential major booboo in unit test, probably won't affect this one 2003-12-01 04:04:07 +00:00
Greg Beaver
cde3509868 2 bugs found here, added deprecation warning for those who have written their own PEAR application 2003-12-01 01:02:40 +00:00
Greg Beaver
3e60df640e 2 bugs found here 2003-12-01 01:00:57 +00:00
Greg Beaver
1b95c31c77 2 bugs found 2003-12-01 00:59:14 +00:00
Greg Beaver
b27f71ca58 fclose() might be needed 2003-12-01 00:43:34 +00:00
Greg Beaver
87365b0149 new unit test 2003-12-01 00:36:47 +00:00
Greg Beaver
2939c3539d fix bug found by unit testing in package ordering 2003-12-01 00:15:53 +00:00
Greg Beaver
21714261a6 fix unit test 2003-12-01 00:14:37 +00:00
Greg Beaver
3db2e9bdcc minor booboo 2003-12-01 00:14:16 +00:00
Greg Beaver
df5317e336 new unit test - test works, but there is a serious bug in sortPkgDeps to be fixed, as unearthed by this test 2003-11-30 23:43:19 +00:00
Greg Beaver
bfc02f7223 finish unit test with non-working download test with callback 2003-11-30 22:51:17 +00:00
Greg Beaver
398dec718a add in skip condition for internet offline, and callback test 2003-11-30 22:49:33 +00:00
Greg Beaver
685e7a365a first unsuccessful test works 2003-11-30 22:39:24 +00:00
Greg Beaver
2276704637 first successful download test works :) 2003-11-30 22:37:47 +00:00
Greg Beaver
a7d7f311f0 beginning framework for PEAR_Common::downloadHttp test - binary test file 2003-11-30 22:31:35 +00:00
Greg Beaver
5c60fe3a0e beginning framework for PEAR_Common::downloadHttp test 2003-11-30 22:31:00 +00:00
Greg Beaver
44e2b42692 tweak tests 2003-11-30 22:24:14 +00:00
Greg Beaver
0b24e0a404 remove old holdover code that has no purpose 2003-11-30 22:01:22 +00:00
Greg Beaver
76e83f576c ...and with these changes, 100% BC is maintained. 2003-11-30 22:00:59 +00:00
Greg Beaver
c7c5d7689d experimental code shuffling, moved download() into a new class, PEAR_Downloader.
Reasons:
- 7 parameters for a method with lots of pass by reference
  implies the need to save state, i.e. use an object
- cleaner code.  download() can be easily split into 4 separate but related methods
- Installer.php is now exclusively used for installation
- future extensibility: switching to channels or local package repositories from
  using PEAR_Remote is easy.  Simply extend the API for PEAR_Downloader:
  no changes needed to the installer at all

to install for testing purposes, use

pear upgrade --force package-PEAR-new-Downloader.xml

to uninstall, use

pear upgrade --force package-PEAR.xml
2003-11-30 05:39:02 +00:00
Greg Beaver
cc27a3f03d got it - the pattern ONLY needs addslashes for windows paths 2003-11-30 00:14:22 +00:00