Nikita Popov
bb54694f4f
Fix refcounting
2020-08-24 16:23:19 +02:00
Christoph M. Becker
6b6c2c003c
Fix #79979 : passing value to by-ref param via CUFA crashes
...
If a by-val send is not allowed, we must not do so. Instead we wrap
the value in a temporary reference.
Closes GH-6000
2020-08-24 14:08:32 +02:00
Nikita Popov
8819d247c6
Don't require rc=1 for function static variables
...
If file cache only is used, then static_variables_ptr may point
to an immutable static_variables HT, which we do not want to
destroy here.
2020-05-20 11:12:18 +02:00
Nikita Popov
98deece6f7
Reset trampoline on executor startup
...
Make sure the trampoline is usable, even if we had an unclean
shutdown on the last request.
2020-01-30 11:05:04 +01:00
Nikita Popov
7e9e0937f3
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed bug #78921
2019-12-13 16:38:24 +01:00
Nikita Popov
621598eaa8
Fixed bug #78921
...
By resetting fake_scope during autoloading. We already do the same
when executing destructors.
2019-12-13 16:37:20 +01:00
Nikita Popov
ed31e04133
Fix leak with cycle in static prop of internal class
...
More the cleanup of interned classes before the final GC run,
just like it is done for user classes.
2019-10-21 10:26:10 +02:00
Nikita Popov
f2e8851245
Remove func copy optimization for private method with static vars
...
Not NULLing the static_variables pointer for shadow methods during
static var shutdown would be a way to avoid this leak, but unless
there's evidence that inherited private methods with static vars are
actually a common use-case, I don't think we should keep this kind
of fragile edge-case optimization.
Fixes OSS-Fuzz #17875 .
2019-10-01 13:04:06 +02:00
Nikita Popov
4b9ebd837b
Allow throwing exception while loading parent class
...
This is a fix for symfony/symfony#32995 .
The behavior is:
* Throwing exception when loading parent/interface is allowed
(and we will also throw one if the class is simply not found).
* If this happens, the bucket key for the class is reset, so
it's possibly to try registering the same class again.
* However, if the class has already been used due to a variance
obligation, the exception is upgraded to a fatal error, as we
cannot safely unregister the class stub anymore.
2019-09-12 16:41:18 +02:00
Nikita Popov
270e5e3c5b
Only allow "nearly linked" classes for parent/interface
...
The requirements for parent/interface are difference than for the
variance checks in type declarations. The latter can work on fully
unlinked classes, but the former need inheritance to be essentially
finished, only variance checks may still be outstanding.
Adding a new flag for this because we have lots of space, but we
could also represent these "inheritance states" more compactly in
the future.
2019-09-11 16:27:28 +02:00
Nikita Popov
f912445eb2
Add missed mutability check
2019-08-28 17:35:25 +02:00
Nikita Popov
2709d6a250
Destroy error handlers before final GC run
2019-08-28 17:04:35 +02:00
Nikita Popov
ec9a96dc60
Fixed bug #78335
...
Destroy static properties and variables prior to the final GC run,
as they may hold GC roots.
2019-08-28 12:32:06 +02:00
Nikita Popov
a18ad194c4
Fixed bug #78396
2019-08-12 10:45:13 +02:00
Nikita Popov
825f47564a
Merge branch 'PHP-7.2' into PHP-7.3
2019-07-09 11:05:18 +02:00
Nikita Popov
22ed362810
Revert "Fixed bug #76980 "
...
This reverts commit 35353dc49ahttps://github.com/symfony/symfony/issues/32395 . I'm reverting it
from PHP 7.2 and PHP 7.3 and only leaving it in PHP 7.4.
2019-07-09 11:04:16 +02:00
Nikita Popov
2bf880db2c
Fixed bug #78239
2019-07-03 11:00:12 +02:00
Nikita Popov
01e1e1991d
Clarify #if indentation in time limit implemementation
2019-07-01 12:18:21 +02:00
Dmitry Stogov
ba8033feb0
Fixed use-after-free
2019-06-28 10:43:56 +03:00
Nikita Popov
eaafb69eea
Change indexing scheme for symtable_cache
...
symtable_cache_ptr now points to the first unused symtable_cache
entry, rahter than the last used one. This avoids taking a pointer
to the minus first element of the array, which is UB. Instead we
take a pointer to the end plus one, which is not UB.
2019-06-20 16:21:39 +02:00
Nikita Popov
8f8fcbbd39
Support full variance if autoloading is used
...
Keep track of delayed variance obligations and check them after
linking a class is otherwise finished. Obligations may either be
unresolved method compatibility (because the necessecary classes
aren't available yet) or open parent/interface dependencies. The
latter occur because we allow the use of not fully linked classes
as parents/interfaces now.
An important aspect of the implementation is we do not require
classes involved in variance checks to be fully linked in order for
the class to be fully linked. Because the involved types do have to
exist in the class table (as partially linked classes) and we do
check these for correct variance, we have the guarantee that either
those classes will successfully link lateron or generate an error,
but there is no way to actually use them until that point and as
such no possibility of violating the variance contract. This is
important because it ensures that a class declaration always either
errors or will produce an immediately usable class afterwards --
there are no cases where the finalization of the class declaration
has to be delayed until a later time, as earlier variants of this
patch did.
Because variance checks deal with classes in various stages of
linking, we need to use a special instanceof implementation that
supports this, and also introduce finer-grained flags that tell us
which parts have been linked already and which haven't.
Class autoloading for variance checks is delayed into a separate
stage after the class is otherwise linked and before delayed
variance obligations are processed. This separation is needed to
handle cases like A extends B extends C, where B is the autoload
root, but C is required to check variance. This could end up
loading C while the class structure of B is in an inconsistent
state.
2019-06-11 13:09:33 +02:00
Dmitry Stogov
1df9f238fe
Better hot/cold code splitting
2019-05-31 12:20:21 +03:00
Dmitry Stogov
e14d77335c
Mark "cold" functions
2019-05-29 11:48:41 +03:00
Nikita Popov
e6fac86dc3
Accept flags argument in zend_lookup_class_ex()
...
Instead of a single boolean, so we have space for extension here.
2019-05-27 09:36:25 +02:00
Nikita Popov
64918c7702
Forbid use of not fully linked classes
2019-05-23 10:41:10 +02:00
Nikita Popov
c666f6ec3b
Merge branch 'PHP-7.3' into PHP-7.4
2019-05-15 12:49:03 +02:00
Nikita Popov
5846119e50
Merge branch 'PHP-7.2' into PHP-7.3
2019-05-15 12:48:35 +02:00
Nikita Popov
35353dc49a
Fixed bug #76980
...
If we perform a class fetch that is not marked as exception safe,
convert exceptions thrown by autoloaders into a fatal error.
Ideally fetching the interfaces would be exception safe, but as it
isn't right now, we must abort at this point.
2019-05-15 12:46:23 +02:00
Dmitry Stogov
3f7bf35e16
execute_data->return_value is not used for internal functions
2019-04-16 00:08:16 +03:00
Dmitry Stogov
55cc280429
Backported call frame initialization improvement
2019-04-12 02:35:42 +03:00
Nikita Popov
d087a356fe
Suppress warnings using zend_quiet_write
2019-04-11 12:22:52 +02:00
Dmitry Stogov
f53240dbc4
Use fastcall calling convention
2019-04-02 23:49:13 +03:00
Joe Watkins
6529d7acd9
zend_weakrefs
2019-03-12 00:35:35 +01:00
Anatol Belski
4f4cf9874d
Change the way timer queue timer is deleted
...
As discussed in bug #77580 , passing INVALID_HANDLE_VALUE for the
completion event improves compatibility with Wine/ReactOS. The timer
callback itself is supposed to complete fast enough, no behavior change
is to expect.
2019-02-12 18:30:55 -08:00
Peter Kokot
92ac598aab
Remove local variables
...
This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly used by Vim and Emacs editors
yet with recent changes the once working definitions don't work
anymore in Vim without custom plugins or additional configuration.
Neither are these settings synced across the PHP code base.
A simpler and better approach is EditorConfig and fixing code
using some code style fixing tools in the future instead.
This patch also removes the so called modelines for Vim. Modelines
allow Vim editor specifically to set some editor configuration such as
syntax highlighting, indentation style and tab width to be set in the
first line or the last 5 lines per file basis. Since the php test
files have syntax highlighting already set in most editors properly and
EditorConfig takes care of the indentation settings, this patch removes
these as well for the Vim 6.0 and newer versions.
With the removal of local variables for certain editors such as
Emacs and Vim, the footer is also probably not needed anymore when
creating extensions using ext_skel.php script.
Additionally, Vim modelines for setting php syntax and some editor
settings has been removed from some *.phpt files. All these are
mostly not relevant for phpt files neither work properly in the
middle of the file.
2019-02-03 21:03:00 +01:00
Zeev Suraski
a81202ac49
Adios, yearly copyright ranges
2019-01-30 11:48:28 +01:00
Dmitry Stogov
f6d227ed4f
Implemented preloading RFC: https://wiki.php.net/rfc/preload .
...
Squashed commit of the following:
commit 106c815fffb8eb3efe00a27a5229cb1f8ffc9736
Author: Dmitry Stogov <dmitry@zend.com>
Date: Wed Nov 14 16:36:44 2018 +0300
Added NEWS entry
commit 1dacd5e20b7043368ef9e80db296d1781134b6fd
Merge: d516139abf ba99aa133c45fdd034ce8bda22592eFix #77141 : Signedness issue in SOAP when precision=-1
Support SQLite3 @name notation
Remove lexer files generated by RE2C
Update libmagic.patch [ci skip]
Update libmagic.patch [ci skip]
Fork test with pcre.jit=0
Rework magic data
Fix regex
Fix regex
Rework magic data
Sync one more upstream libmagic piece
Suppress already used warning
Ignore getaddrinfo failed message
...
commit 45fdd034ce34645aeb42cef0d67c3e08ffc9a5528d3429cda87ae3a47d209b0a53ed1c049f239cfcFix #76825 : Undefined symbols ___cpuid_count
NEWS
Fix : #77110 undefined symbol zend_string_equal_val in C++ build
Fix #77105 : Use position:sticky for <th> in `phpinfo()`
Implement handling for JIT recognition when cross compiling
Backport 7f5f4601Fix #76348 : WSDL_CACHE_MEMORY causes Segmentation fault
Rework places in libmagic regarding previous CVE-2014-3538 fixes
Change the way JIT availability is checked
Fix a test for ldap extension
Fixed bug #77092
Future-proof email addresses
commit 9b0a53ed1c0bd17bd438b6104670513a9d90f74a67e0138c0d3a9d90f74aaea85c65bd36b644fbb77a20781d2eb91690c892#77081 ftruncate() changes seek pointer in c mode
Fix and improve test case
commit 7a20781d2e4a57b5d56368c4f99e2338ab7ef4cfeb6e2c529fbf38e6c10aeb6e2c529f562049510f2fefa8c61e562049510fe806cb732a4828fb7b6b#77079
Add missing null initialization
Remove redundant mbfl_string_init calls
Use zend_string for mbstring last encoding cache
commit e806cb732a2f697ef8afc559f22b3e310631cc05ea2e67876a310631cc050a24d7ba8f17a3cb4a2a6d4b22c518386c9d3470d7fbb4d402359f19edc9Fix #71592 : External entity processing never fails
Add TIDY_TAG_* constants supported by libtidy 5
Add is_iterable to opcache Optimizer
commit d7fbb4d4020fe9ea1c073a2d1bcc1fe6b76ecb4b4531fbf93168694c99974531fbf931a594a618ceab9a40f63ce3c65db0994f57c1e02933e777acbf#77058
Improve "narrowing" error message
bump versions
commit 4f57c1e02926587a95c0d70cb10480aabe685dbbd9fc51bc3b40808ac41ed9fc51bc3bb5ffba0fafb6ef8998d5b5ffba0fafe4a7ef0c43a404383118e4a7ef0c43811f20aaa5d1e14e2cc0#50675
bump to 7.2.13-dev
[ci skip] Update NEWS wrt. php-7.3.0RC4 tagging
Inlining in the most frequently used code paths
Fixed test failurs introduced by 9c144e0d82Fix #75282 : xmlrpc_encode_request() crashes
Fix tests for ICU 63.1
...
commit 811f20aaa5093e8b1bbfa2ba970ce3b67e28367cb0139dc228a609520adb3fe698b904Fix #77035 : The phpize and ./configure create redundant .deps file
Remove outdated PEAR artefacts
Fix tests/output/bug74815.phpt generating errors.log
Revert "Use C++ symbols, when C++11 or upper is compiled"
Use C++ symbols, when C++11 or upper is compiled
Added new line
Remove stamp-h
Move all testing docs to qa.php.net
Fix a typo in UPGRADING.INTERNALS
Fix test when it's run on another drive
[ci skip] Update UPGRADING wrt. tidyp support
Fixed incorrect reallocation
Fix #77027 : tidy::getOptDoc() not available on Windows
Run CI tests under opcache.protect_memory=1
commit a609520adbac8f45f61bb6ac50f9e6ac8f45f61b632b30b545d57cd36e47632b30b545d33908a99acd0c36c3f9#77025
Add vtbls for EUC-TW encoding
commit cd0c36c3f94740dabb84ad6738e886#77025
Add vtbls for EUC-TW encoding
commit d33908a99a21e0bebca34740dabb844740dabb8421e0bebca3c78277ae84ad7a78b253ad7a78b2530276ea5187c63fc5d5f1b945548e93d5a41088408dadca88649ef07c88bda06f0f3d3a94099586ec3412345ffec78277ae84f76a955c020810ce0d8194099586ec
2018-11-14 16:46:05 +03:00
Zeev Suraski
9afce019e0
Future-proof email addresses
2018-11-01 18:35:32 +02:00
Zeev Suraski
54dc07f3dc
Update email addresses. We're still @Zend, but future proofing it...
2018-11-01 17:20:07 +02:00
Dmitry Stogov
d57cd36e47
Immutable clases and op_arrays.
...
Squashed commit of the following:
commit cd0c36c3f94740dabb84ad6738e886#77025
Add vtbls for EUC-TW encoding
commit 4740dabb84ad7a78b2530276ea5187c63fc5d5f1b945548e93d5a41088408dadca88649ef07c88bda06f0f3d3a94099586ec3412345ffe94099586ec
2018-10-17 15:52:50 +03:00
Peter Kokot
902d39a3a7
Trim trailing whitespace in source code files
2018-10-13 14:14:50 +02:00
Dmitry Stogov
a2e8334613
Allocate only necessary space for static properties of internal classes in ZTS mode.
2018-10-01 19:05:31 +03:00
Nikita Popov
a7b8131606
Drop unused variable
2018-09-18 12:12:36 +02:00
Dmitry Stogov
62338a2385
Use different loop terminating conditions
2018-09-17 20:39:28 +03:00
Nikita Popov
178dcd4749
Perform final GC before the object store is freed
...
free_object_storage intentionally does not free the object allocations
to make sure that they show up as leaks. However, if the object is in
the GC root buffer, the later GC run may end up freeing the allocation,
hiding the leak.
Avoid this by moving the final GC run before free_object_storage, the
way it was done before fast_shutdown was integrated into core.
2018-09-17 10:13:55 +02:00
Nikita Popov
dfa166e7ed
Remove unused ZEND_FILE_LINE in i_zval_ptr_dtor
2018-09-16 17:16:26 +02:00
Dmitry Stogov
ea9628936f
Move zend_verify_abstract_class() into zend_inheritance.c
2018-08-27 12:56:17 +03:00
Dmitry Stogov
92fdf9d629
Change zend_lookup_class_ex() and zend_fetch_class_by_name() prototypes to accept optional lower-case class name as zend_string*, instead of zval*.
2018-08-22 17:07:31 +03:00
Dmitry Stogov
ab8094c666
Pack zend_constant.flags and zend_constant.module_number into reserved space inside zend_constant.value.
2018-07-26 12:58:07 +03:00
Peter Kokot
8d3f8ca12a
Remove unused Git attributes ident
...
The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
user who changed it.
In Git this functionality is different and can be done with Git attribute
ident. These need to be defined manually for each file in the
.gitattributes file and are afterwards replaced with 40-character
hexadecimal blob object name which is based only on the particular file
contents.
This patch simplifies handling of $Id$ keywords by removing them since
they are not used anymore.
2018-07-25 00:53:25 +02:00
