mirrors/php-src
0
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2024-11-28 12:26:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

MFH: fix bug #41833 (addChild() on a non-existent node, no node created, getName() segfaults)

Browse Source
This commit is contained in:
Rob Richards 2007-07-31 15:40:49 +00:00
parent ce582024a5
commit e0a2d149f5
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ext/simplexml/simplexml.c
View File

@ -1563,6 +1563,11 @@ SXE_METHOD(addChild)
node = php_sxe_get_first_node(sxe, node TSRMLS_CC);
if (node == NULL) {
php_error_docref(NULL TSRMLS_CC, E_WARNING, "Cannot add child. Parent is not a permanent member of the XML tree");
return;
}
localname = xmlSplitQName2((xmlChar *)qname, &prefix);
if (localname == NULL) {
localname = xmlStrdup((xmlChar *)qname);
@ -1575,9 +1580,7 @@ SXE_METHOD(addChild)
newnode->ns = NULL;
nsptr = xmlNewNs(newnode, (xmlChar *)nsuri, prefix);
} else {
if (node) {
nsptr = xmlSearchNsByHref(node->doc, node, (xmlChar *)nsuri);
}
nsptr = xmlSearchNsByHref(node->doc, node, (xmlChar *)nsuri);
if (nsptr == NULL) {
nsptr = xmlNewNs(newnode, (xmlChar *)nsuri, prefix);
}