mirrors/php-src
0
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2024-11-27 20:03:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix of Bug #74383: Wrong reflection on Phar::running

Browse Source
This commit is contained in:
Mitch Hagstrand 2017-04-09 15:30:35 -07:00 committed by Joe Watkins
parent 9c7cb2cdcd
commit d9a05807d2
No known key found for this signature in database
GPG Key ID: F9BA0ADA31CBD89E
3 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
NEWS
View File

@ -18,6 +18,9 @@ PHP NEWS
. Fixed bug #74341 (openssl_x509_parse fails to parse ASN.1 UTCTime without
seconds). (Moritz Fain)
- phar:
. Fixed bug #74383 phar method parameters reflection correction. (mhagstrand)
13 Apr 2017 PHP 7.0.18
- Core:

2
ext/phar/phar_object.c
View File

@ -5191,7 +5191,7 @@ ZEND_BEGIN_ARG_INFO_EX(arginfo_phar_webPhar, 0, 0, 0)
ZEND_END_ARG_INFO()
PHAR_ARG_INFO
ZEND_BEGIN_ARG_INFO_EX(arginfo_phar_running, 0, 0, 1)
ZEND_BEGIN_ARG_INFO_EX(arginfo_phar_running, 0, 0, 0)
ZEND_ARG_INFO(0, retphar)
ZEND_END_ARG_INFO()

20
ext/phar/tests/bug74383.phpt Normal file
View File

@ -0,0 +1,20 @@
--TEST--
Phar: bug #74383: Wrong reflection on Phar::running
--SKIPIF--
<?php if (!extension_loaded("phar") || !extension_loaded('reflection')) die("skip"); ?>
--FILE--
<?php
$rc = new ReflectionClass(Phar::class);
$rm = $rc->getMethod("running");
echo $rm->getNumberOfParameters();
echo PHP_EOL;
echo $rm->getNumberOfRequiredParameters();
echo PHP_EOL;
echo (int) $rm->getParameters()[0]->isOptional();
?>
--EXPECT--
1
0
1