mirrors/php-src
0
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2024-11-23 18:04:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix English and improve by Stas. Thanks :)

Browse Source
This commit is contained in:
Yasuo Ohgaki 2014-01-27 06:50:11 +09:00 committed by Stanislav Malyshev
parent f496aac1f6
commit d65ddb633d
3 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
CODING_STANDARDS
View File

@ -166,9 +166,10 @@ User Functions/Methods Naming Conventions
Internal Function Naming Convensions
----------------------
1. Exposed module API must be named 'php_modulename_function()' to avoid
symbol collision. They should be in lowercase, with words underscore
delimited. Exposed API must be defined in 'php_modulename.h'.
1. Functions that are part of the external API should be named
'php_modulename_function()' to avoid symbol collision. They should be in
lowercase, with words underscore delimited. Exposed API must be defined
in 'php_modulename.h'.
PHPAPI char *php_session_create_id(PS_CREATE_SID_ARGS);
@ -179,7 +180,7 @@ Internal Function Naming Convensions
2. Main module source file must be named 'modulename.c'.
3. Header file that are used by other sources must be named 'php_modulename.h'.
3. Header file that is used by other sources must be named 'php_modulename.h'.
Syntax and indentation

2
README.EXT_SKEL
View File

@ -91,7 +91,7 @@ FORMAT OF FUNCTION DEFINITIONS FILE
module_name_function(int arg1, int arg2 [, int arg3 [, int arg4]])
Arguments arg1 and arg2 is required.
Arguments arg1 and arg2 are required.
Arguments arg3 and arg4 are optional.
If possible, the function definition should also contain it's return type

11
README.SUBMITTING_PATCH
View File

@ -50,13 +50,16 @@ Please make the mail subject prefix "[PATCH]". If attaching a patch,
ensure it has a file extension of ".txt". This is because only MIME
attachments of type 'text/*' are accepted.
Preferred way to propose PHP patch is sending pull request from github.
The preferred way to propose PHP patch is sending pull request from
github.
https://github.com/php/php-src
Fork official PHP repository and send pull request. It will be notified
to pull request mailing list. You can add pull requests to
http://bugs.php.net/ reports also.
Fork the official PHP repository and send a pull request. A
notification will be sent to the pull request mailing list. Sending a
note to PHP Internals list (internals@lists.php.net) may help getting
more feedback and quicker turnaround. You can also add pull requests
to bug reports at http://bugs.php.net/.
PHP Documentation Patches