mirrors/php-src
0
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2024-12-11 19:04:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

These naked strcpy()s scare me

Browse Source
This commit is contained in:
Rasmus Lerdorf 2011-08-07 00:18:38 +00:00
parent 71af9259e3
commit c70aa9436a
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ext/ereg/ereg.c
View File

@ -474,7 +474,7 @@ PHP_EREG_API char *php_ereg_replace(const char *pattern, const char *replace, co
if (new_l + 1 > buf_len) {
buf_len = 1 + buf_len + 2 * new_l;
nbuf = emalloc(buf_len);
strcpy(nbuf, buf);
strncpy(nbuf, buf, buf_len-1);
efree(buf);
buf = nbuf;
}
@ -511,7 +511,7 @@ PHP_EREG_API char *php_ereg_replace(const char *pattern, const char *replace, co
if (new_l + 1 > buf_len) {
buf_len = 1 + buf_len + 2 * new_l;
nbuf = safe_emalloc(buf_len, sizeof(char), 0);
strcpy(nbuf, buf);
strncpy(nbuf, buf, buf_len-1);
efree(buf);
buf = nbuf;
}
@ -526,7 +526,7 @@ PHP_EREG_API char *php_ereg_replace(const char *pattern, const char *replace, co
if (new_l + 1 > buf_len) {
buf_len = new_l + 1; /* now we know exactly how long it is */
nbuf = safe_emalloc(buf_len, sizeof(char), 0);
strcpy(nbuf, buf);
strncpy(nbuf, buf, buf_len-1);
efree(buf);
buf = nbuf;
}