From be4db6b5505fb32489a5bf2723ea85b7af8d4fac Mon Sep 17 00:00:00 2001
From: Ilija Tovilo <ilija.tovilo@me.com>
Date: Fri, 24 Mar 2023 10:13:25 +0100
Subject: [PATCH] Suppress snmp lib memory leak, xfail ASAN tests

I don't know enough about this library to fix those :(
---
 .github/lsan-suppressions.txt                | 1 +
 ext/snmp/tests/snmp-object-errno-errstr.phpt | 1 +
 ext/snmp/tests/snmp-object-error.phpt        | 1 +
 ext/snmp/tests/snmp2_get.phpt                | 1 +
 ext/snmp/tests/snmp2_set-nomib.phpt          | 1 +
 ext/snmp/tests/snmp2_walk.phpt               | 1 +
 ext/snmp/tests/snmp3-error.phpt              | 1 +
 ext/snmp/tests/snmp_getvalue.phpt            | 1 +
 ext/snmp/tests/snmpget.phpt                  | 1 +
 ext/snmp/tests/snmpset-nomib.phpt            | 1 +
 ext/snmp/tests/snmpwalk.phpt                 | 1 +
 11 files changed, 11 insertions(+)

diff --git a/.github/lsan-suppressions.txt b/.github/lsan-suppressions.txt
index 3ce5de80bd6..b8f863ce603 100644
--- a/.github/lsan-suppressions.txt
+++ b/.github/lsan-suppressions.txt
@@ -1,2 +1,3 @@
 leak:acommon::DictInfoList::elements
 leak:timer_create
+leak:netsnmp_init_mib_internals
diff --git a/ext/snmp/tests/snmp-object-errno-errstr.phpt b/ext/snmp/tests/snmp-object-errno-errstr.phpt
index 8304c6cb9f9..2f005071045 100644
--- a/ext/snmp/tests/snmp-object-errno-errstr.phpt
+++ b/ext/snmp/tests/snmp-object-errno-errstr.phpt
@@ -7,6 +7,7 @@ snmp
 --SKIPIF--
 <?php
 require_once(__DIR__.'/skipif.inc');
+if (getenv('SKIP_ASAN')) die('xfail Timeouts under ASAN');
 ?>
 --FILE--
 <?php
diff --git a/ext/snmp/tests/snmp-object-error.phpt b/ext/snmp/tests/snmp-object-error.phpt
index 1e5b505b50c..be7af86388d 100644
--- a/ext/snmp/tests/snmp-object-error.phpt
+++ b/ext/snmp/tests/snmp-object-error.phpt
@@ -7,6 +7,7 @@ snmp
 --SKIPIF--
 <?php
 require_once(__DIR__.'/skipif.inc');
+if (getenv('SKIP_ASAN')) die('xfail Timeouts under ASAN');
 ?>
 --FILE--
 <?php
diff --git a/ext/snmp/tests/snmp2_get.phpt b/ext/snmp/tests/snmp2_get.phpt
index 58f12d4c0e5..b6160469317 100644
--- a/ext/snmp/tests/snmp2_get.phpt
+++ b/ext/snmp/tests/snmp2_get.phpt
@@ -7,6 +7,7 @@ snmp
 --SKIPIF--
 <?php
 require_once(__DIR__.'/skipif.inc');
+if (getenv('SKIP_ASAN')) die('xfail Timeouts under ASAN');
 ?>
 --FILE--
 <?php
diff --git a/ext/snmp/tests/snmp2_set-nomib.phpt b/ext/snmp/tests/snmp2_set-nomib.phpt
index 2b9d26d09c7..5ea63062e86 100644
--- a/ext/snmp/tests/snmp2_set-nomib.phpt
+++ b/ext/snmp/tests/snmp2_set-nomib.phpt
@@ -7,6 +7,7 @@ snmp
 --SKIPIF--
 <?php
 require_once(__DIR__.'/skipif.inc');
+if (getenv('SKIP_ASAN')) die('xfail Timeouts under ASAN');
 ?>
 --ENV--
 MIBS=
diff --git a/ext/snmp/tests/snmp2_walk.phpt b/ext/snmp/tests/snmp2_walk.phpt
index 4cd9b3a85b6..6baae774e84 100644
--- a/ext/snmp/tests/snmp2_walk.phpt
+++ b/ext/snmp/tests/snmp2_walk.phpt
@@ -7,6 +7,7 @@ snmp
 --SKIPIF--
 <?php
 require_once(__DIR__.'/skipif.inc');
+if (getenv('SKIP_ASAN')) die('xfail Timeouts under ASAN');
 ?>
 --FILE--
 <?php
diff --git a/ext/snmp/tests/snmp3-error.phpt b/ext/snmp/tests/snmp3-error.phpt
index 389800dad6b..b0b50282c2b 100644
--- a/ext/snmp/tests/snmp3-error.phpt
+++ b/ext/snmp/tests/snmp3-error.phpt
@@ -7,6 +7,7 @@ snmp
 --SKIPIF--
 <?php
 require_once(__DIR__.'/skipif.inc');
+if (getenv('SKIP_ASAN')) die('xfail Timeouts under ASAN');
 ?>
 --FILE--
 <?php
diff --git a/ext/snmp/tests/snmp_getvalue.phpt b/ext/snmp/tests/snmp_getvalue.phpt
index f62482d90d3..232b9bc1254 100644
--- a/ext/snmp/tests/snmp_getvalue.phpt
+++ b/ext/snmp/tests/snmp_getvalue.phpt
@@ -8,6 +8,7 @@ snmp
 <?php
 require_once(__DIR__.'/skipif.inc');
 if (PHP_OS_FAMILY === "Windows") die("xfail fails on Windows for unknown reasons");
+if (getenv('SKIP_ASAN')) die('xfail Timeouts under ASAN');
 ?>
 --FILE--
 <?php
diff --git a/ext/snmp/tests/snmpget.phpt b/ext/snmp/tests/snmpget.phpt
index ed18e1f028b..9833bf3211d 100644
--- a/ext/snmp/tests/snmpget.phpt
+++ b/ext/snmp/tests/snmpget.phpt
@@ -7,6 +7,7 @@ snmp
 --SKIPIF--
 <?php
 require_once(__DIR__.'/skipif.inc');
+if (getenv('SKIP_ASAN')) die('xfail Timeouts under ASAN');
 ?>
 --FILE--
 <?php
diff --git a/ext/snmp/tests/snmpset-nomib.phpt b/ext/snmp/tests/snmpset-nomib.phpt
index 5252daa0ebd..6075b3a065f 100644
--- a/ext/snmp/tests/snmpset-nomib.phpt
+++ b/ext/snmp/tests/snmpset-nomib.phpt
@@ -7,6 +7,7 @@ snmp
 --SKIPIF--
 <?php
 require_once(__DIR__.'/skipif.inc');
+if (getenv('SKIP_ASAN')) die('xfail Timeouts under ASAN');
 ?>
 --ENV--
 MIBS=
diff --git a/ext/snmp/tests/snmpwalk.phpt b/ext/snmp/tests/snmpwalk.phpt
index b0e8a8a8afd..e8f4586e8ed 100644
--- a/ext/snmp/tests/snmpwalk.phpt
+++ b/ext/snmp/tests/snmpwalk.phpt
@@ -7,6 +7,7 @@ snmp
 --SKIPIF--
 <?php
 require_once(__DIR__.'/skipif.inc');
+if (getenv('SKIP_ASAN')) die('xfail Timeouts under ASAN');
 ?>
 --FILE--
 <?php